Darwin Liu
8ef4cfa070
Add in a sanity check for valid vnc ports
...
Check to make sure that the max and min VNC ports be below 65535 in
config.
2021-01-08 13:43:02 -07:00
Darwin Liu
2b698478a6
Adjusted QEMU step_run_tests.go to reflect previous changes
2021-01-07 22:23:51 -07:00
Darwin Liu
4f2e9117c3
QEMU: Minor fix to VNC mapping parameters and output
...
* Set the QEMU builder vnc_port_min to have a minimum value of 5900,
with updated documentation to explain why.
* Changed output messages so that the correct port is listed in packer's
messaging to the user.
LONGER DESCRIPTION
If vnc_min_port is set to anything above 5900, then packer will fail to
connect via VNC to the QEMU instance. This is due to how QEMU parses
the port for listening to VNC:
host:d
TCP connections will only be allowed from host on
display d. By convention the TCP port is 5900+d.
Previously the calculation for the port was vncPort - VNCPortMin,
however this will result in an incorrect port being displayed in
packer's messages and potentially packer being unable to connect via VNC
to the host.
For example if vnc_port_min=5990 nad vnc_port_max=5999:
```
Looking for available port between 5990 and 5999 on 0.0.0.0
Found available port: 5996 on IP: 0.0.0.0
Found available VNC port: 5996 on IP: 0.0.0.0
[....]
==> Starting VM, booting disk image
view the screen of the VM, connect via VNC without a password to
vnc://0.0.0.0:6
```
This will cause QEMU to set the listening port to 5906 while packer's
VNC client is attempting to connect to 5996.
I am a touch concerned as this commit undoes pull request #9905
(specfically commit 7335695c
), but I am also confused as to how he was
able to get QEMU to get a VNC listening port below 5900, as examining
QEMU's git history has shown that this behavior has been in since at
least 2017, probably older.
Hopefully the more explicit error messaging and documentation can make
it clear why this is being undone.
2021-01-07 22:23:43 -07:00
Wilken Rivera
04dbbe2d8e
Fix broken links detected by link checker
...
- Fix broken example links
- Fix broken provisioner links
- Ignore linode.com because of DDOS protection settings
2021-01-06 16:27:12 -05:00
Megan Marsh
28245ec143
Merge pull request #10134 from borancar/feat/azure_pfx_support
...
Add Azure PFX certificate support
2020-12-18 12:09:17 -08:00
Megan Marsh
d1d5706048
Merge pull request #10362 from nielspardon/master
...
OpenStack builder: Make external source image props configurable
2020-12-18 10:55:40 -08:00
Megan Marsh
ce99640fe2
fix test fixture path
2020-12-17 14:41:36 -08:00
Megan Marsh
88b7b0e14a
remove sdk
2020-12-17 13:29:25 -08:00
Megan Marsh
5f34bbd56e
add extra line before package declaration so this line does not become the synopsis of a package for godoc
2020-12-16 15:14:43 -08:00
Niels Pardon
0e56b83196
OpenStack builder: Make external source image props configurable
...
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
2020-12-16 17:19:52 +00:00
Megan Marsh
75803397cb
Document exception to encryption ( #10395 )
...
* Update docs on ebs encrypt_boot to clarify that packer will not override global account settings
* Update struct-markdown generator and regenerate partials with new website location. This overwrites some linting that got automatically applied when the files got moved
2020-12-16 10:35:34 +01:00
Megan Marsh
eecac40d77
Merge pull request #10394 from anssijun/aws-ebs-retry-spot-instance-tagging
...
Fix retry logic in AWS spot instance tagging
2020-12-15 11:07:48 -08:00
Megan Marsh
1113301c1b
fix conflicts
2020-12-15 10:53:51 -08:00
Dany Garcia
905d8401ea
removing unused import
2020-12-15 10:41:25 -08:00
Dany Garcia
0b13d44a23
exporting reusable validatekmskey function
2020-12-15 10:41:25 -08:00
Dany Garcia
3389fded48
merging latest master
2020-12-15 10:40:46 -08:00
Dany Garcia
39bb3a6c55
incorrect error message regarding parameter names
2020-12-15 10:40:12 -08:00
Dany Garcia
504c3807f7
adding support for root volume encryption for amazon-chroot
2020-12-15 10:40:08 -08:00
Anssi Junnola
82a25ec419
Fix retry logic in AWS spot instance tagging
2020-12-15 17:21:03 +00:00
Megan Marsh
4f419506fd
Merge pull request #10384 from Pyrrvs/vmware-dhcp-leases-bigsur
...
make packer compatible with MacOS BigSur by using Apple DHCP leases instead of VMWare leases
2020-12-14 16:30:50 -08:00
Pyrrvs
12a6fddbd8
handle apple dhcp lease with missing 'name' and 'lease' informations
2020-12-14 19:16:00 +01:00
Roman Mingazeev
354166350d
yandex: do not use cloud-config fileds due to possible collision
2020-12-14 13:04:27 +03:00
Pyrrvs
f0612e4688
improve parser by skipping all lines containing a '{' or a '}'. fix unecessary []byte cast (linter issue).
2020-12-14 01:00:24 +01:00
gla
7201ce9248
make packer compatible MacOS BigSur by making vmware fusion drivers able to lookup the VM IP address in apple dhcpd leases instead of vmware leases.
2020-12-13 23:26:53 +01:00
Roman Mingazeev
bbd9ee8589
fix export when using empty ubuntu image
2020-12-10 14:52:22 +03:00
Roman Mingazeev
aa0efcf73e
Yandex/ssh communicator in export ( #10352 )
...
* use ssh for communicate to export
* Update post-processor/yandex-export/step-create-s3-keys.go
Co-authored-by: GennadySpb <lipenkov@gmail.com>
2020-12-09 16:51:34 +01:00
Gareth Rees
355b93730b
Gcp oslogin issue 10170 ( #10360 )
2020-12-09 15:01:51 +01:00
Roman Mingazeev
f8e85f94fd
fix set user-agent ( #10361 )
2020-12-09 14:48:35 +01:00
Mike Tougeron
e0e82e2192
Support AWS gp3 volumes ( #10338 )
...
* Support AWS gp3 volumes
* docs
* tests
2020-12-09 13:06:57 +01:00
Megan Marsh
26946f1300
Merge pull request #10320 from seventieskid/gcp-wait-to-add-ssh-keys-10312
...
Gcp wait to add ssh keys 10312
2020-12-08 15:52:52 -08:00
Megan Marsh
1d2ee0bf81
Merge pull request #10337 from serverwentdown/serverwentdown/duplicate-output-file
...
Fix duplication of main disk in QEMU
2020-12-08 15:18:38 -08:00
Megan Marsh
3c346867f4
fix nil pointer dereference
2020-12-07 15:45:16 -08:00
Megan Marsh
76177b50ce
Refactor provisioner acceptance tests to shell directly out to Packer rather than import the core. Modify test case formatting to more closely reflect the builder test cases.
2020-12-07 15:45:16 -08:00
Roman Mingazeev
9fabad6f1d
rebase && some fixes
2020-12-07 18:27:22 +03:00
Roman Mingazeev
1c08463204
rebase
2020-12-07 18:13:12 +03:00
Roman Mingazeev
efe6d2f08f
add comment and remove overrides
2020-12-07 18:13:12 +03:00
Roman Mingazeev
23118c451c
fix delete
2020-12-07 18:13:12 +03:00
Roman Mingazeev
4eb3daec8e
lint
2020-12-07 18:13:12 +03:00
Roman Mingazeev
478fda12ba
reuse common configs
2020-12-07 18:13:06 +03:00
Roman Mingazeev
adb4a14471
do better mount image ( #10335 )
...
* do better mount image
* check error
2020-12-07 12:20:06 +01:00
Megan Marsh
cda3aa205a
linting
2020-12-03 16:11:36 -08:00
Megan Marsh
352f064b55
fix docker acceptance tests. Turns out they were broken on the main branch too; needed to move noop progress bar into the sdk to be used in the builder testui.
2020-12-03 16:04:49 -08:00
Megan Marsh
8f51a8bfae
move provisioner acceptance tests into sdk alongside builder acceptance tests. Reorganize slightly to make sure no import cycles of doom get formed
2020-12-03 14:22:18 -08:00
Megan Marsh
becf7723e6
move builder/testing to acctest inside sdk
2020-12-03 11:57:06 -08:00
Megan Marsh
f3f4fef44a
fix import
2020-12-03 11:43:06 -08:00
Megan Marsh
98f5fa453c
move aws specific acceptance test helper into amazon builder dir
2020-12-03 11:34:45 -08:00
Megan Marsh
2d04ef9b99
remove commented code
2020-12-03 11:32:05 -08:00
Megan Marsh
afc798c30a
Modify vmware_vmx acceptance tests to use builderT framework
...
Modify builderT framework to enable use of shell and file provisioners
2020-12-03 11:25:02 -08:00
Megan Marsh
3681e2a7ee
fix pathing
2020-12-03 10:39:21 -08:00
Megan Marsh
5576bb5caa
move packer config constants next to the packer config
2020-12-03 10:17:35 -08:00