fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
e5c4a4a6fb
create export directories for vmx and ovf file types, too.
2018-11-09 11:45:36 -08:00
68c9e34bfe
add new display_name template option
2018-11-09 10:54:31 -08:00
790d5661c5
escape username
2018-11-06 11:30:45 -08:00
96d628eef1
fix silliness with pointers
2018-11-06 09:50:28 -08:00
5c2ca450bd
fix tests
2018-11-02 15:44:27 -07:00
5815b376b4
remove unnecessary checks; we always default format to ovf if it is unset.
...
fix exportoutputdir
2018-11-02 14:22:01 -07:00
c3144c2d0a
add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.
2018-11-02 14:22:01 -07:00
c3d6d45696
modify test so that it accesses CommConfig the same way we really do within the driver
2018-11-02 14:22:01 -07:00
f18bb19f96
remove redundant config; CommConfig was already a part of the SSSHConfig struct
2018-11-02 14:22:01 -07:00
fa12113eaf
remove unused NewLocalArtifact
...
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
2ae235a28a
fix tests
2018-10-25 14:41:01 -07:00
290f4a7c4c
cleanup to make it actually build after that monstrous rebase
2018-10-25 14:17:35 -07:00
3193f50f17
Support export with the vmx builder.
2018-10-25 13:02:37 -07:00
a68a639a1a
Move step_export to common.
2018-10-25 12:55:10 -07:00
63054fb808
Fix the test.
2018-10-25 12:45:44 -07:00
da5f322484
Add quotes around all filenames to prevent issues with spaces
2018-10-25 12:45:44 -07:00
f42f5a8ad3
Remove some extra logging.
2018-10-25 12:44:29 -07:00
e7e6a80587
No need to make upload public.
2018-10-25 12:39:51 -07:00
c940f7e754
Conditional reload.
2018-10-25 12:37:47 -07:00
17845beadc
Fix the CommHost tests
2018-10-25 12:37:47 -07:00
5e74bcfb88
Fix tests, move remote_ default values to driver_config.
2018-10-25 12:30:57 -07:00
4d9cb19012
Refactor artifacts and output_dir implementations.
2018-10-25 12:21:24 -07:00
2d00dc6756
Add VMName to the vmx mods.
2018-10-25 11:17:09 -07:00
7b5943160b
Re-enable the CommHost() call. Use common's driver factory.
2018-10-25 11:17:09 -07:00
ba22090bc9
Move step_register and step_uload_vmx from iso to common.
2018-10-25 11:07:02 -07:00
b5298464c5
Move the remote_driver from iso to common.
2018-10-25 11:01:22 -07:00
91c7089455
Implement the first version of the remote Clone().
2018-10-25 10:37:45 -07:00
46cfb5a30c
Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver()
2018-10-25 10:33:37 -07:00
51d2aac9f6
SSHPrivateKey => SSHPrivateKeyFile
2018-08-29 14:40:32 +02:00
bf191d1ef6
Merge pull request #6204 from arizvisa/GH-6197
...
Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.
2018-08-24 15:46:31 -07:00
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
31d4f8af45
use a time.Duration instead of a hardcoded ms
2018-08-23 13:16:01 -07:00
918db58604
added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
2018-08-22 11:37:56 -07:00
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
a39c5887fb
Test we halt if a bad path is set in vmx_path
2018-07-06 10:58:25 +01:00
21117e5d38
Test we fail if displayName is not stored in the statebag as 'display_name'
2018-07-06 10:58:25 +01:00
88c43ec98d
Test we fail if the displayName key is not found in the VMX
2018-07-06 10:58:24 +01:00
d68d26a6e5
Fix tests: We now need to set `displayName` key/val pair in the test VMX
2018-07-06 10:58:24 +01:00
3eab3cc99b
ESXi builds require we store the value of displayName in the statebag
...
The value of displayName is needed by later steps:
* When determining the IP address of the build VM
* When exporting the VM using ovftool
By default Packer will configure the VMX so `displayName` is equal to
the value defined for `vm_name` in the build template. However, it is
possible (and sometimes desirable) to set a custom value for
`displayName`.
Users can set a custom `displayName` through use of the `vmx_data`
option in their template.
2018-07-06 01:58:09 +01:00
406f4eeb93
Merge pull request #6394 from conradjones/master
...
Add support to vmware-vmx for linked clones
2018-07-02 09:50:24 -07:00
d9b6924986
Add cloneType to fusion driver
2018-06-30 16:31:42 +01:00
04ff0761e6
Notify that we are skipping file, but retain error message
2018-06-25 08:28:32 -07:00
591bfe3dfa
Continue searching for leases even if one of the files cannot be read.
2018-06-22 18:09:27 -07:00
d05a601d00
Add support to vmware-vmx builder for linked clones.
2018-06-17 01:38:42 +01:00
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
2018-05-16 13:52:00 +01:00
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
2018-05-16 12:55:59 +01:00
25dd27a164
Remove tmp directories created by builder/vmware/common tests
2018-04-30 20:38:03 +01:00
c828015bc3
Follow variable varName <-> statebag var_name convention
2018-04-27 20:09:19 +01:00
f342975ff3
Fix test - reporting compaction results requires a tmp file
2018-04-27 16:40:44 +01:00
08f9d619a9
Report the result of the disk compaction step
2018-04-27 16:40:29 +01:00
10d93dffa4
Fix tests for vmware/common
2018-04-27 16:40:23 +01:00
c48a7889f9
Simplify handling of disks by collating requirements and unifying ops
2018-04-27 16:39:52 +01:00
5d8b476a7f
Fixed the regex in common/step_clean_vmx.go for the VMware builder to also support removal of sata-based cdrom devices. Also added a comment in iso/step_create_vmx.go that links both pieces of related code.
2018-04-26 14:01:58 -05:00
c6299972b9
s/boot_command/bootcommand/
2018-04-19 14:26:31 -07:00
408eba88ad
flatten boot command config and implement for vmware
2018-04-19 14:26:30 -07:00
cba4d3235f
cleanup
2018-04-19 14:26:29 -07:00
bf0a320125
Implement new parser for qemu boot command
2018-04-19 14:26:29 -07:00
1c0af28662
Some cleanup and comments.
2018-04-19 14:26:29 -07:00
4e2f14196a
Rely on context to cancel typing boot command.
2018-04-19 14:26:28 -07:00
673245afcf
Replace boot command parser with PEG parser.
2018-04-19 14:26:28 -07:00
2c2904c095
Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases..
2018-03-30 18:19:25 -05:00
7e9699675f
Modified device matching logs to look more consistent.
2018-03-30 18:15:46 -05:00
6e176f97a0
Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network.
2018-03-29 13:12:59 -05:00
646523c5f4
Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers.
2018-03-29 13:04:25 -05:00
ef4f3f143b
Merge pull request #5985 from AndiDog/f-5979-vmware-fusion-guestip-lookup-multiple-devices
...
Handle multiple devices per VMware network type
2018-03-21 17:12:36 -07:00
61030c0d85
spelling: output
2018-03-13 08:27:26 +00:00
d987fcefc3
spelling: multiples
2018-03-13 08:12:53 +00:00
ff92fb883d
Handle multiple devices per VMware network type
...
Fixes #5979
2018-03-07 10:59:55 +01:00
ac2e02b938
remove loglines that should not have made it onto master
2018-03-06 14:12:39 -08:00
9e8e376d6c
Merge pull request #5932 from hashicorp/add_configurable_snapshot_timeout
...
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:27:20 -08:00
597ddc2192
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:01:53 -08:00
27ed479b0a
Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux.
...
It was reported that on WS14 on Linux, that the path may be different than stated in the documentation. This modifies `workstationDhcpConfPath` and `workstationDhcpLeasesPath` functions to walk through every permutation while attempting to find the correct file.
This reinforces the fix for issue #5882 .
2018-02-14 00:11:17 -06:00
d6e5342ece
Fixed a type-o in the VMWare builder when locating the dhcp configuration file on Linux.
...
Closes issue #5882 .
2018-02-13 17:27:17 -06:00
fa2dddd26d
Fixed some things mucked up during rebase.
2018-02-02 19:45:18 -06:00
74946071d2
Added support for specifying the disk adapter type to the vmware builders. This was squashed from the vmware-diskAdapterType branch ( #2968 ) as submitted by Rami Abughazaleh <icnocop@users.noreply.github.com>. This closes #5671 and possibly #4885 .
...
arizvisa: Updated icnocop's documentation to include the possible disk adapter types that one can specify.
arizvisa: Tweaked icnocop's support for the `disk_adapter_type` option to the VMWare builder that caused conflicts due to version skew.
icnocop: Updated links to the Virtual Disk Manager User's Guide PDF to open in a new window and also added the Adobe PDF icon
icnocop: Added support for vmware to specify the disk adapter type, ide or scsi (lsilogic or buslogic)
2018-02-02 19:18:49 -06:00
594ed950c7
Fixed a race condition in builder/vmware/common/driver_parser.go due to a misunderstanding how channels work when you close them.
2018-02-02 19:18:49 -06:00
737e951685
Added missing root path to path-finders for the VMware Fusion implementation in the vmware builder as mentioned by @SwampDragons.
2018-02-02 19:18:49 -06:00
b2fec18b1e
Added parser for VMware Fusion's networking file. Replaced VmwareDriver's NetmapConfPath with a NetworkMapperInterface in order to handle the differences between VMware Fusion and the rest of the VMware suite.
2018-02-02 19:18:49 -06:00
069d00f70b
Added the paths suggested by @phekmat and @SwampDragons for VMware Fusion... Although parser for the new mapper format is likely to be needed still.
2018-02-02 19:18:49 -06:00
8cc0776f3a
Fixed oversight in VMware builder's mock-driver that neglected to initialize 'HostAddressResult'.
2018-02-02 19:18:49 -06:00
029c357d8c
Modified some tests to require the PACKER_ACC environment variable to be set before executing them. This turns them into acceptance tests as per CONTRIBUTING.md.
2018-02-02 19:18:49 -06:00
258804106b
Added missing GetVmwareDriver() method to VMware Builder's DriverMock.
2018-02-02 19:18:48 -06:00
75fbfa0763
Replaced a hacky type assertion in the VMware builder with a call to Driver.GetVmwareDriver() that returns the driver-specific structure for ip and addressing information. Also implemented the addressing functions for the ESXi driver interface.
...
This fixes an issue where a driver might not have defined a VmwareDriver by forcing a developer to implement it via the standard Driver interface.
2018-02-02 19:18:48 -06:00
884af69da1
go fmt on builder/vmware/*
2018-02-02 19:18:48 -06:00
0d6cf7fac4
Added support for auto-detection to the serial and parallel port types.
...
Included the yield option to all the serial port types.
Added the ability for the network type to fallback to a custom network if the
specified network name is not found in netmap.conf.
Promoted the scope for both Read{Dhcp,Netmap}Config inside vmwcommon.driver.
Updated the documentation for the VMware builder.
2018-02-02 19:14:29 -06:00
b52e2d3f45
Added the ability for the vmware-builder to fallback and determine the network device-name using the .vmx configuration in case of a guest using the "custom" connection type.
2018-02-02 19:13:02 -06:00
Ali Rizvi-Santiago
Megan Marsh
Rickard von Essen
Adrien Delorme
Alexander Laamanen
Stuart Miller
Adrien Delorme
DanHam
Conrad Jones
Bob Brumfield
Matthew Hooker
Josh Soref
Andreas Sommer