Commit Graph

29 Commits

Author SHA1 Message Date
Megan Marsh 8f51a8bfae move provisioner acceptance tests into sdk alongside builder acceptance tests. Reorganize slightly to make sure no import cycles of doom get formed 2020-12-03 14:22:18 -08:00
Megan Marsh 7d658149ea update tests and website and generated partials to reflect new package format 2020-11-17 10:36:01 -08:00
Megan Marsh 7ac09d0b7c add how to pull experimental binaries to CONTRIBUTING.md 2020-06-02 14:08:01 -07:00
Megan Marsh 5b8113ab0f
Merge pull request #9006 from hashicorp/provisioner_acc_contributing
Add how to write provisioner's acceptance tests to CONTRIBUTING docs
2020-04-07 16:02:16 -07:00
Jeff Escalante 2999934326
fix generation script, bugfixes in source comments, update website paths in primary codebase 2020-04-07 17:53:22 -04:00
Moss eac5526a28 Update prov test code 2020-04-07 11:41:03 +02:00
Moss 388997cd1c Fix some typos 2020-04-07 10:29:17 +02:00
Moss 25b91aa3cb Update CONTRIBUTING with ajustments 2020-04-06 18:22:34 +02:00
Moss 939b5ee22d Update CONTRIBUTING with provisioner acc tests 2020-04-06 18:06:46 +02:00
Wilken Rivera daffd9c318
CONTRIBUTING: Update documentation for linting on Travis (#8933) 2020-03-23 10:46:03 +01:00
Wilken Rivera 9ec8b67392
Add golangci-lint to project (#8686)
* Add golangci-lint as linting tool

* Disable failing staticchecks to start; GitHub issue to handle coming soon

* Run `goimports -w` to repair all source files that have improperly
formatted imports

* makefile: Add ci-lint target to run on travis

This change adds a new make target for running golangci-lint on newly
added Go files only. This target is expected to run during Packer ci builds.

* .github/contributing: Add code linting instructions

* travis: Update job configuration to run parallel builds
2020-02-14 11:42:29 -05:00
Megan Marsh f5c58c8e83
fix rcp --> rpc typo (#8665) 2020-01-29 10:49:50 +01:00
Adrien Delorme 06d29d279a Document how code generation works a little in .github/CONTRIBUTING.md 2019-10-29 15:29:29 +01:00
Khai Do b442c0ad45 add debugging info to debugging page as well 2019-09-03 09:01:00 -07:00
Khai Do ca61b443c5 Add doc about debugger setup
From discussion on packer mailing list about setting up a debugger
for packer:
https://groups.google.com/d/msg/packer-tool/sfmZootjHBU/OhtEh3YTBwAJ
2019-08-30 11:30:08 -07:00
BobSilent b08bb6038d
improve contributing.md for windows user
improving description for windows user
2019-05-21 00:10:58 +02:00
Amrita Dutta c3a1ab3816 Updating to suggested future-proof comment 2019-04-19 01:48:08 +00:00
Amrita Dutta ed785fddb2 update CONTRIBUTING.md with version of go to download 2019-04-18 17:43:24 +00:00
Adrien Delorme aa6d5e1d74 Update CONTRIBUTING.md
to explain go mod usages
2019-04-11 14:19:25 +02:00
Megan Marsh 7ba913c4f3 update contributing guidelines and make sure that the PR template links to them. 2019-01-23 11:35:50 -08:00
DanHam d75a580952
Fix link 2018-12-15 11:36:47 +00:00
Megan Marsh c29e25ae8a add some advice in contributor docs about how to make faster-merging prs 2018-11-27 09:53:03 -08:00
Josh Soref b68168807a Miscellaneous doc improvements
backticks, spaces, commas

In general, a list of items should have a space after each comma.
While there are editorial styles that suggest commas inside quotations,
they're horrible advice when the backticks are describing specific
character for a user to enter.

one off indent filters section

singular

backticks...

word wrap long lines...

spelling: macOS

contributing: clarify closing case
contributing: link to changelog
contributing: point to git remote...
contributing: split commands from descriptions
contributing: grammar
spelling: github
grammar: comma after etc.
spelling: macOS
grammar: i.e.
alicloud: use relative link
alicloud: use backticks
alicloud: bits
alicloud: such as
grammar: comma after etc.
avoid linking periods
grammar: period
amazon-chroot: IOPS
amazon-chroot: use backticks
amazon-chroot: link to section
amazon-chroot: whether-or-not; period
amazon-ebs: period
amazon-ebs: use relative link
amazon-ebs: use backticks
amazon-ebs: comma
amazon-ebs: bold
amazon-ebssurrogate: comma after etc.
amazon-ebssurrogate: this builder
amazon-instance: this builder
amazon-ebssurrogate: set this
amazon-ebssurrogate: whether-or-not
amazon-ebssurrogate: period
amazon-ebssurrogate: bold section reference
amazon-ebssurrogate: backticks...
amazon-ebssurrogate: commas around e.g.
spelling: precedence
spelling: i.e.
amazon-ebssurrogate: backticks...
2018-10-18 19:09:49 -04:00
Josh Soref 11075235ae
Grammar: anyway 2018-10-10 14:40:08 -04:00
Adrien Delorme 2e151f3cd0
Spelling & checks 2018-08-14 09:49:24 +02:00
Adrien Delorme bef5c842af
re add the go 1.7 min version warning 2018-08-13 12:53:41 +02:00
Adrien Delorme 1d025c005f
Link to godocs install steps 2018-08-13 12:50:55 +02:00
Adrien Delorme 51b9065497
split go and packer dev setups 2018-08-13 12:40:42 +02:00
Matthew Hooker 6f7044c0f6
move contributing doc out of root 2018-04-02 10:52:27 -07:00