0149f679de
Print instead of Printf with no dynamic first variable.
2017-03-28 20:36:20 -07:00
d1b20b3d9c
remove a bunch of dead code.
...
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
7548024720
More verbose error message when ansible-playbook fails
...
I've spent 1 hour today debugging why packer does not want to work with
ansible. It turns out `ansible-playbook` command was returning non-zero
exit status because of the file system permission problem.
Output before change:
% packer build rabbitmq.json
amazon-ebs output will be in this color.
1 error(s) occurred:
* exit status 1
Output after change:
amazon-ebs output will be in this color.
1 error(s) occurred:
* Error running "ansible-playbook --version": exit status 1
2017-03-21 20:26:41 -07:00
6894f93085
Merge pull request #4534 from mitchellh/chefclean
...
provisioner/chef-client: only upload knife config if we're cleaning
2017-02-26 18:46:15 -08:00
78ab21b42f
Test error messages for restart_command and restart_timeout seems to be erroneous
2017-02-12 18:17:31 +01:00
825f69c64d
provisioner/chef-client: only upload knife config if we're cleaning
2017-02-09 23:37:35 -08:00
a836268490
fix test on windows
2017-02-06 11:29:39 -08:00
0f445dff07
fix tests
2017-02-03 15:03:19 -08:00
45030e1919
provisioner/anisble: use randomized staging dir
2017-01-27 16:14:35 -08:00
370b67497e
provisioner/powershell: Don't over complicate removal of tmp output file
2017-01-26 11:21:45 +00:00
21be983855
provisioner/powershell: Use system context env var to set output file path
...
Fixes #4271
2017-01-26 00:17:46 +00:00
e350739ecb
post-processor/shell-local: expand tests to align with shell provisioner
2017-01-23 22:25:39 +00:00
28051a9218
provisioner/windows-shell: fix and compact env var test
2017-01-23 12:10:46 +00:00
e8db6b9b9a
provisioner/windows-shell: Remove env var check - again checked in prepare
2017-01-23 12:10:46 +00:00
c88fafdf38
provisioner/powershell: align, fix and compact env var test
2017-01-23 12:10:46 +00:00
4122f3a897
provisioner/powershell: Remove env var check - we already check in Prepare
2017-01-23 12:10:46 +00:00
4514b1b10f
provisioner/shell: expand tests to align with powershell/win-shell
2017-01-23 12:10:46 +00:00
0cbb4ff30c
provisioner/shell: Align gen of flattened env vars with powershell/win-shell
...
* Move code to generate quoted flattened env vars to separate function
* Fix: generate flattened env vars once per provisioner not once per script
2017-01-23 12:10:46 +00:00
80ebcea5e1
Mirror cleaner test code back from windows-shell to powershell
2017-01-19 13:33:59 +00:00
2bd9fa6c70
Use counter for index. Sort stray comments.
2017-01-19 12:12:00 +00:00
c33cef9c12
tests for equals in windows-shell
2017-01-18 12:51:14 -08:00
49bc2e353f
Fix to allow equals in value of environment variable. Mirrors #4328
2017-01-18 12:42:25 -08:00
4e6a44f5f1
append will resize
2017-01-17 17:21:14 -08:00
480398c3d2
only set PACKER_HTTP_ADDR if a server is listening
2017-01-17 17:17:36 -08:00
6563eb213c
Document. add to windows-shell and powershell
2017-01-17 17:07:36 -08:00
d2e59e4e92
set PACKER_HTTP_ADDR env var when available.
...
If using a builder that has an http server set up for file transfer,
expose the connection info to the shell provisioner through the environment
variable PACKER_HTTP_ADDR.
Closes #2869
2017-01-16 23:19:52 -08:00
5fc6a2ee70
Merge pull request #4326 from asteris-llc/feature/converge-provisioner
...
New Provisioner: Converge
2017-01-04 10:46:18 -08:00
6d6c7864b4
Merge pull request #4328 from DanHam/gh-3108
...
Allow equals sign in value of environment variable for Powershell provisioner
2017-01-03 12:38:17 -08:00
a617884a16
Add more tests for puppet-masterless provisioner
...
* Add tests for staging_directory config option
* Add tests for working_directory config option
2016-12-28 21:14:17 -06:00
feab6f096e
provisioner(converge): add prevent_bootstrap_sudo
2016-12-28 12:53:22 -06:00
fb6a5c5bbc
provisioner(converge): change skip_bootstrap back to bootstrap
2016-12-28 12:49:40 -06:00
64ebd3af8d
provisioner(converge): remove version validation
2016-12-28 08:49:08 -06:00
18425c45d0
provisioner(converge): change bootstrap to skip_bootstrap
2016-12-28 08:48:02 -06:00
5d935767f0
provisioner(converge): add bootstrap_command
2016-12-28 08:45:19 -06:00
843731d98d
provisioner(converge): add prevent_sudo
2016-12-28 08:19:03 -06:00
c226b19d08
Add additional unit tests for puppet-server provisioner
...
* Add puppet-server test for staging_dir config option
* Add puppet-server test for execute_command config option
2016-12-27 22:35:13 -06:00
0423f91037
Fix to allow equals sign in value of environment variable
2016-12-28 00:33:16 +00:00
be0196492f
Tests for env variables values starting with or containing an equals sign
2016-12-28 00:31:17 +00:00
3311d3a48d
provisioner(converge): interpolate execute_command
2016-12-27 16:48:11 -06:00
fe4b972d32
provisioner(converge): flatten execution fields
2016-12-27 16:32:19 -06:00
3658a0b6b5
provisioner(converge): remove log line
2016-12-27 16:31:12 -06:00
de918ac7a7
provisioner(converge): rename directory to working_directory
2016-12-27 16:07:16 -06:00
e6ba4c1929
provisioner(converge): remove version check
2016-12-27 16:03:35 -06:00
549ff50a3c
provisioner(converge): handle http error
2016-12-27 14:58:41 -06:00
b46a402a18
provisioner(converge): add tests for Prepare
2016-12-27 14:47:13 -06:00
73252b9a9b
provisioner(converge): reverse the meaning of bootstrap
2016-12-27 12:24:06 -06:00
b8849a9c2d
provisioner(converge): add version specification for bootstrapping
2016-12-27 12:22:17 -06:00
eca8690018
provisioner(converge): add actual provisioning step
2016-12-27 12:13:51 -06:00
73d5593242
provisioner(converge): add validate for source and destination
2016-12-27 11:41:52 -06:00
4f0034e574
provisioner(converge): transfer module directories
2016-12-27 11:29:36 -06:00
e2daefab71
provisioner(converge): improve error messages when Converge isn't found
2016-12-27 11:20:20 -06:00
03a8e309ba
provisioner(converge): add bootstrapping
2016-12-27 10:50:33 -06:00
ce43ade973
Add additional unit tests for puppet provisioners
...
* Add puppet-masterless test for packer_build_name default fact
* Add puppet-masterless test for packer_builder_type default fact
* Add puppet-server test for puppet bin directory
2016-12-26 23:11:27 -06:00
7feb8b993c
Add default facts for puppet-server provisioner
2016-12-22 15:53:59 -06:00
335615408a
Run go fmt on files
2016-12-12 22:45:19 +00:00
c88a2ef872
Remove trailing tabs
2016-12-12 22:45:10 +00:00
55353fae89
Fix spelling mistake
...
Fix code type for formatting
Remove empty space
2016-12-12 22:45:09 +00:00
f38d787b0e
Powershell uses UTF16Le for encodedCommand
2016-12-12 22:44:56 +00:00
e36051d394
Pattern for infrastructure changed to quote filename and execute file with ampersand as everything is run in powershell now
...
Handle powershell commands by specifying any extra infrastructure around running scripts inside of ExecuteCommand and ElevatedExecuteCommand
2016-12-12 22:44:55 +00:00
d61513bf77
Encode powershell using utf8
...
Fix a bug in the size of string that was returned when decoding a base64 string
Added tests around encoding and decoding powershell scripts. Used [System.Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes('powershell commands')) | clip to generate what base 64 strings should look like
2016-12-12 22:44:54 +00:00
17597b48e1
Base64 encode powershell to avoid any necessary escaping
2016-12-12 22:44:54 +00:00
5d5809b27e
Make hiding of progress backward compatible with old versions of powershell
2016-12-12 22:44:48 +00:00
e8c2b49be8
Use correct quotation of variables
2016-12-12 22:44:34 +00:00
4b394c8563
Write output will put ouput from function, so we don't want to be getting line from output of function
...
Fix unit tests for not showing progress stream when using powershell
Ensure that progress stream does not get leaked into stdout
Using Write-Output instead of Write-Host since PS v5 now leaks the host stream to stderr
2016-12-12 22:44:33 +00:00
c42cb88ddd
Using Write-Output instead of Write-Host since PS v5 now leaks the host stream to stderr
2016-12-12 22:44:32 +00:00
cd6213eb55
Seems like we do need to escape the double quote
2016-12-12 22:44:25 +00:00
15137310a7
Must escape string formatting for string fmt
2016-12-12 22:44:20 +00:00
5285a819dd
Quoting of powershell commands and associated tests
2016-12-12 22:44:19 +00:00
3051ea6633
Quote powershell so that it does not try to interpret command to be run
...
Get VName out of state. This allows template replacement to be run on vmname
2016-12-12 22:44:10 +00:00
6c3030c73a
Add a little safety around variables that are passed into provisioner.
2016-12-12 22:44:10 +00:00
b49be38d74
Merge pull request #4210 from yoctocloud/fixes
...
various fixes
2016-12-12 12:33:19 -08:00
c510988cbf
Merge pull request #4209 from bhcleek/ansible-winrm
...
provisioner/ansible: assume scp target is file (resolves winrm incompatibility)
2016-12-08 22:37:41 -08:00
5dd7fb11f4
Saltstack bootstrapping: fallback on wget if curl failed for any reason (such as not being installed)
2016-12-02 20:02:22 +01:00
00ebe9e1d3
various fixes
...
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-11-29 14:55:44 +03:00
f5ca0de225
provisioner/ansible: assume scp target is file
...
Assume the scp target is a file instead of a directory. Assuming the scp
target is a file instead of a directory allows uploading files to a node
being provisioned with the ssh communciator using sftp and with the
winrm communicator. It is fully compatible with ansible; ansible
communicators only allow for files (never directories) to be uploaded
(when the copy module is used to upload a directory, ansible walks the
directory and uploads files one at a time).
Update documentation to explain how to provision a Windows image.
Extend tests that use ssh to communicate with the node to include single
files, recursive copies, and content-only recursive copies.
Add test to verify support for the winrm communicator.
Remove the err argument from adapter.scpExec, because it was unused.
Fixes #3911
2016-11-26 14:40:39 -08:00
12176b6afc
provisioner/shell: treat disconnects as retryable.
2016-11-22 15:59:40 -08:00
200aa74e78
Added support for passing arguments to salt-call.
2016-11-11 15:15:16 +01:00
a616c3da3c
provisioner/ansible: Move info messages to log
...
Make the ansible provisioner less noisy by moving most messages to the
log instead of ui print outs.
Closes #4117
2016-11-05 14:25:45 +01:00
d920b3fbf4
run gofmt
2016-11-01 14:08:04 -07:00
f17bd30070
Revert "Removed escaped quotes in non-elevated powershell invocation"
...
This reverts commit 1b186f1613
2016-10-26 21:12:11 +02:00
3b42d28cce
Merge pull request #4014 from mexisme/feature/puppet-bin-dir
...
privisioner/puppet: Add `puppet_bin_dir` option.
2016-10-22 14:48:45 +02:00
3361da82d4
Added trailing slash after puppet_bin_dir.
2016-10-22 14:34:34 +02:00
892d5e82c9
expect_disconnect option
...
provisioner/shell: Adds option to fail if the remote server disconnects
us.
2016-10-21 11:39:03 -07:00
a1ef6398c3
Merge pull request #3371 from simonguest/powershell-envvars-fix
...
Removed escaped quotes in non-elevated powershell invocation
2016-10-19 18:50:39 -07:00
314a4f4bbf
Add Puppet Bin Dir to puppet-server provisioner
2016-10-16 02:50:37 +13:00
6f9294095f
Add Puppet Bin Dir to puppet-masterless provisioner
2016-10-15 22:39:50 +13:00
d8439b0034
Merge pull request #3971 from mitchellh/fix3486
...
change chef-solo provisioner staging directory
2016-10-14 15:51:26 -07:00
3c8dabba9e
Fixed formatting
2016-10-11 23:43:50 +02:00
83131db4b8
Merge pull request #3776 from curiositycasualty/master
...
Add custom_state config to salt provisioner
2016-10-07 17:59:52 -07:00
2ae1b83b15
change chef-solo provisioner staging directory
...
Have the staging directory be called `packer-chef-solo`, which is what
is given in docs. Closes #3486
2016-10-07 17:24:30 -07:00
51a9a51699
Update winrm and winrmcp dependencies
...
Updated winrm and winrmcp dependencies. Relevant unit and acceptance tests passed successfully.
shell.Execute didn't return a Command object.
See f1bcf36a69/winrmcp/cp.go (L167)54ea5d0147/winrm/shell.go (L10-L22)Closes #3763
Original patch by: Philipp Kosel <philipp.kosel@gmail.com>
2016-10-03 13:48:29 -07:00
a8e57d83d2
gofmt project.
...
noticed many unrelated changes being added to patches because of gofmt.
ran `find . -not -path "./vendor/*" -name "*.go" -exec gofmt -w {} \;`
2016-09-29 14:13:06 -07:00
efa594bebe
Merge pull request #3899 from pengkh/f-file-provisioner
...
continue add support for file-provisioner to allow directory downloa…
2016-09-22 18:32:57 -07:00
96a637684b
fix #3897
...
bug fix for file-provisioner download file, including unit-test code.
2016-09-19 10:36:18 +08:00
59dac451a5
provisioner/file: add "generated" key to allow files created on-the-fly.
2016-09-15 22:15:56 +02:00
f760ab2fd8
Make SCP the default for provisioner/ansible
...
Add a new option, `use_sftp` to the ansible provisioner. It's default
value is false; ansible provisioner will use SCP by default.
Refactor to consistently set all configure options for ansible
provisioner in the Prepare step.
Remove incorrect information about `ANSIBLE_HOST_KEY_CHECKING=False`
being set when `ansible_env_vars` is not set in the packer template.
Update BATS tests for the ansible provisioner to actually check that the
fetched directory contains the contents expected. This revealed a
problem with the all_options template that required adding a host to the
hosts list in the test playbook.
2016-09-11 23:58:31 -07:00
e6a0e523e2
refactor sftp subsystem request handling
...
Refactor the sftp subsystem request handling to make it more similar to
an exec request. This simplifies and improves the readability of the
code.
2016-09-11 23:58:31 -07:00
da223b9539
add scp support to ansible provisioner
...
Handle running `scp -t` and `scp -f` exec requests in the
ansible-provisioner's SSH
server to allow Ansible to use SCP so that SFTP doesn't have to be
installed on the node.
Update the BATS tests to test the ansible provisioner.
2016-09-11 23:58:31 -07:00
9963bfcd42
removes unneeded white space
2016-09-01 13:39:44 -06:00
7fdd303641
Installs 64bit chef on windows if available
...
Resolves #3847
- Changes linux install url to new omnitruck.chef.io url.
- Changes powershell install to use omnitruck url instead of hard coded to 32bit msi install.
2016-09-01 13:23:08 -06:00
d1e38052f7
Merge pull request #3350 from JoakimLofgren/add-support-for-ansible-galaxy
...
Add support for ansible-galaxy
2016-09-01 20:51:17 +02:00
023f2edde8
add better logging and error handling to ansible provisioner ( #3477 )
2016-08-24 19:53:39 +02:00
bb2dd6e2b2
add custom_state config to salt provisioner
2016-08-03 12:56:51 -07:00
32cbb515b5
Merge pull request #3692 from mohae/3474-file-mkdir-all
...
3474 file mkdir all
2016-07-07 16:44:15 -07:00
94d158b0b7
remove debug fmt.Print from test
2016-07-07 18:12:54 -05:00
049fb2d9c1
actually check for errors in functional tests
2016-07-07 20:01:23 +01:00
0c81e49f83
Adding a functional test with an Ansible message very long
2016-07-07 01:12:57 +01:00
664e640257
Merge pull request #3392 from msteinhoff/fix-ansible-provisioner-long-lines
...
Fix Scanner buffer too long error in ansible-remote provisioner
2016-07-06 15:27:57 -07:00
999b8b2ed0
file provisioner: download should create all dirs in the destination path
2016-07-06 15:42:26 -05:00
7b3224f3c7
rename KnifeChefTemplate to KnifeTemplate
2016-06-14 13:42:53 -05:00
4847e891b0
Fix knife clean-up run on windows
2016-06-14 13:34:25 -05:00
40aa2b9973
added support for specifying an execute command to the puppet-server provisioner.
2016-06-13 14:12:28 +01:00
49067e732a
append ANSIBLE_HOST_KEY_CHECKING correctly ( #3568 )
...
Append the ANSIBLE_HOST_KEY_CHECKING environment variable correctly
regardless of whether the template specifies some environment variables.
2016-05-24 15:34:51 -07:00
f2b0fabe66
Fixes #3466 - Remote path needs to be set prior to config interpolation ( #3468 )
2016-04-29 19:21:27 -07:00
7e653370b7
Seperate remote_path into remote_folder and remote_script. ( #3462 )
...
Commonly /tmp is set as noexec, as a result packer scripts
fail to run. In order to get around this one can set a
remote_path, whoever, remote path requires full filename
and path.
By making remote_path a combination of
remote_folder/remote_script we can change remote_folder
and keep the default script_nnn.sh
Signed-off-by: Ian Duffy <ian@ianduffy.ie>
2016-04-26 16:04:29 -07:00
b5f6e379f0
Fix Scanner buffer too long error in ansible-remote provisioner
...
Ansible may produce very long lines which Scanner can not handle. This
replaces the Scanner with a Reader and uses the ReadString method to
read an arbitrary large line from the ansible-playbook stdout pipe.
2016-03-28 21:27:42 +02:00
1b186f1613
Removed escaped quotes in non-elevated powershell invocation
2016-03-20 20:28:08 -07:00
1172e670c0
Add support for ansible-galaxy
...
This adds "galaxy_file" to the options
Implement #3301
2016-03-14 18:26:56 +01:00
f3811cb99d
Add ignore_exit_codes param for puppet-masterless provisioner
2016-03-13 23:39:18 -04:00
d59844f0d1
Determine current user without CGO.
2016-03-07 13:35:24 +01:00
7369841e63
Ansible: add the support for specifying ansible_user
...
Closes #3273
2016-03-07 13:35:24 +01:00
d6716f6ee1
Ansible: don't use deprecated ssh options when ver above 2.0
...
Ansible 2.0 deprecated ansible_ssh_user, ansible_ssh_port, ansible_ssh_host
instead use ansible_user, ansible_port, and ansible_host in the
inventory file.
Closes #3275
2016-03-07 13:26:22 +01:00
f823725e53
Ansible: os.Environ() should always be passed to the ansible command.
...
Fixes GH-3271
Regression introduced in GH-3203
2016-02-26 20:49:37 +01:00
4750da3457
Add empty_groups param to ansible provisioner
2016-02-19 23:46:50 +01:00
2791542171
Allow specifying environment variables for ansible provisioner
2016-02-15 13:07:02 +13:00
6dd02e7912
Update ansible test to use the new Downloader interface
2016-02-12 14:53:23 -08:00
feee19e4ed
file provisioner improvements
...
* allow specify source/destination as dir
* allow specify many files as source
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-02-12 11:48:28 -08:00
d8aaf6175f
Merge pull request #2470 from jsoriano/puppet-masterless-clean-staging
...
Puppet masterless provisioner optionally cleans staging directory
2016-02-11 17:39:35 -08:00
3ae867446d
Merge pull request #2660 from mafrosis/saltp
...
Salt provisioner updates
2016-02-11 16:37:06 -08:00
0cd54ed19e
add options to configure host alias and groups
2016-02-10 23:33:14 -08:00
a6552f7c75
Merge pull request #3166 from ephemeralsnow/master
...
Add chmod to chef-solo provisioner
2016-02-10 19:23:47 -08:00
a5ab53bf5e
update ansible tests
...
Update tests to account for changes made in #3149
2016-02-10 14:16:02 -08:00
a23610ef41
cleanup ansible provisioner key generation
...
* Clearly separate host signer and user key generation into separate
functions and data structures.
* Remove inaccurate comment about needing to specify both files if
either one is specified.
* Rename parameters for clarity according to their meaning to the
callee.
* Style the code with gofmt.
2016-02-10 14:16:02 -08:00
3de8561a75
Add chmod to chef-solo provisioner
2016-02-09 20:06:26 +09:00
569e6cc464
go fmt
2016-02-08 17:34:06 -08:00
c95b2b483f
Merge branch ansible-provisioner of https://github.com/dkhenry/packer
2016-02-05 15:40:17 +13:00
114bddfe36
Merge branch 'master' of https://github.com/mitchellh/packer
2016-02-01 13:28:56 -08:00
1f6749096a
Restore missing interpolation after merging ansible remote; fixes #3138
2016-02-01 13:28:49 -08:00
bf3c294326
listen on system chosen port
...
Change the default for LocalPort to "0", so that the listener will be a
system chosen port.
2016-01-28 22:22:12 -08:00
15f99a4aee
Merge branch 'ansible-provisioner' of https://github.com/bhcleek/packer into f-ansible
2016-01-28 15:16:54 -08:00
87532b1b00
Merge branch 'chef-provisioner-windows' of https://github.com/sneal/packer into f-chef-provisioner-windows
2016-01-28 14:55:17 -08:00
33071150c1
Salt provisioner: option to set logging level on Salt highstate run
2016-01-26 13:09:15 +00:00
9ccf298be9
Salt provisioner: option to ignore salt highstate failures fixes #2486
2016-01-26 13:09:15 +00:00
5cd15b52c5
Salt provisioner: dynamic command line args passed onto salt-call fixes #2652
2016-01-26 13:09:15 +00:00
7cb802f8a0
Salt provisioner: improved inputs validation
2016-01-26 13:09:15 +00:00
3eabc6253d
Merge pull request #2653 from evertrue/evertrue/eherot/add_data_bag_secret_to_chef_client
...
Chef-client provisioner: Add encrypted data bag secret path (Fixes #1945 )
2016-01-13 13:59:48 -08:00
77c48678d6
eliminate possible race conditions
...
Eliminate race-y use of the packer.Ui interface by wrapping it in a
concurrency-safe implementation.
2015-12-19 15:15:19 -08:00
d73e75a7cf
fix panic when connection is closed before packer send Shutdown
2015-12-19 12:15:04 -08:00
2668747c71
Rename noclean shell option to skip_clean, per pull feedback
2015-11-19 16:02:45 +13:00
3d23655f2f
Add "noclean" boolean to shell provisioner. This stops the provisioner from
...
attempting to remove helper scripts it creates. As noted on #2803 this can
be useful when deleting the build user from an AMI or other template.
2015-11-16 16:37:09 +13:00
f006a83c95
Fixing the bug found in the tests
2015-11-03 18:19:03 -05:00
6ca02286d4
Test for when the config parameter isn't passed
2015-11-03 18:18:24 -05:00
627a8fe819
Renaming the config parameter from "options"
...
to "extra_arguments"
2015-11-03 17:55:03 -05:00
4ea7e3473d
Testing the new options argument during the actual
...
call to `Provision()`
2015-11-03 15:01:16 -05:00
84e1b387c4
New test for preparing the new config parameter
2015-11-03 14:36:04 -05:00
ebed9e53fb
Adding new "Options" configuration parameter for
...
the puppet-masterless provisioner, to allow for specifying additional
options to pass to the execute command
2015-11-03 12:30:55 -05:00
2dc9e0af3f
fix `go vet` identified issues
2015-10-31 10:39:33 -07:00
5366393f9f
fix tests
2015-10-31 10:39:33 -07:00
cc8ca3098e
add ansible provisioner
2015-10-31 10:39:33 -07:00
43cb854b3e
Merge pull request #2568 from pecigonzalo/f-winrm-reboot
...
Add reboot checks before moving out of the reboot sequence for WinRM
2015-10-26 16:57:13 -07:00
c48548b3bb
go fmt
2015-10-18 11:13:09 -07:00
1aad5cf6d5
provisioner/windows-restart: remove race in test
2015-10-12 13:20:18 -07:00
d87b68efe8
Syncronize cancellation in windows-restart tests
...
Two windows-restart tests would timeout and fail due to the cancellation
thread firing before the cancel object was created. This change syncronizes
the start of the threads to prevent this from occurring.
2015-10-10 14:32:39 -07:00
357e494ee3
Fix failing Windows guest command tests
2015-10-01 10:04:59 -07:00
8014dac742
Add Windows support to Chef provisioners
...
- Add guest os type to change the default Chef-Solo and Chef-Client provisioner behavior. Paths, commands etc.
- Change Chef installation download location to chef.io domain
- Add encrypted data bag secret configuration
2015-10-01 10:04:59 -07:00
affebcda86
Windows Powershell commands need to specify shell
...
The WinRM communicator defaults to the regular Windows cmd shell so we need to tell Packer to use Powershell when running these guest commands.
2015-10-01 10:02:11 -07:00
67f6d6cdb5
Adds provisioner guest commands abstraction
...
Provisioners often needs to perform command line operations on guests that may have different syntax and shells. The GuestCommands type abstracts these away so provisioners can avoid littering branching logic all over the place.
2015-10-01 10:02:10 -07:00
f01f62dc88
Add specific exit codes listed on https://msdn.microsoft.com/en-us/library/windows/desktop/ms681383(v=vs.85).aspx
2015-08-28 09:55:14 +12:00
8bd3e62853
Because the new functionality makes the ```waitForRestart()``` function run commands it modifies the value of ```comm.StartCmd.Command``` that is being checked, we need to implement the same workaround that is being used for the ```waitForCommunicator()``` function. This should make the test work again and retain functionality.
2015-08-28 09:54:59 +12:00
08359e409a
Revert the shutdown command with new parameters as this will return proper exit codes. This will work in the same way as restart-computer -force when using ```shutdown /r /f /t 0```.
...
Note:The WinRM library does not return the exit code currently, this will be implemented on https://github.com/masterzen/winrm/pull/26
2015-08-28 09:54:39 +12:00
70083fc869
Add reboot checks before moving out of the reboot.
2015-08-28 09:54:24 +12:00
72e8119233
Download chef from chef.io
2015-08-25 21:53:50 -07:00
f625c985af
Chef-client provisioner: Add encrypted data bag secret support ( Fixes #1945 )
2015-08-21 16:05:47 -07:00
abb67fdd79
Fix govet issues
2015-08-05 19:41:29 -07:00
84abbc2fe2
Merge pull request #2519 from BayanGroup/salt-remote-dirs
...
Add options to specify salt remote dirs
2015-07-30 19:06:59 -07:00
c04feb77b1
Merge pull request #2520 from BayanGroup/salt-ensure-dir-exists
...
Ensure that `/etc/salt` exists
2015-07-30 19:03:34 -07:00
c04e442203
Merge pull request #2518 from BayanGroup/fix-error-messages
...
Fix semantic errors in messages
2015-07-28 18:36:21 -07:00
eba0e9eaf8
Ensure that `/etc/salt` exists
...
Make sure that directory `/etc/salt` exists before copying salt
minion file.
2015-07-28 10:40:09 +04:30
769c82b171
Support for setting salt remote directory
...
* It is possible to set remote salt tree through `remote_state_tree` argument.
* It is possible to set remote pillar root through `remote_pillar_roots` argument.
* Directories `remote_state_tree` and `remote_pillar_roots` are emptied before use.
2015-07-28 10:37:52 +04:30
f90f2f685d
Fix semantic errors in messages
2015-07-28 10:34:13 +04:30
21107b0027
Fix wrong command type being used when running elevated provisioner.
2015-07-28 16:14:32 +12:00
715662f60b
Reformat
2015-07-27 16:42:06 -07:00
be8c9dddf2
Puppet masterless provisioner optionally cleans staging directory
...
When puppet is executed in masterless mode it didn't remove
staging directory, this can be a problem because it leaves all
the modules and manifests in the built image.
This is specially problematic when building docker images as they
can be left in the layers unless an specific cleanup is done after
running puppet.
This change adds a flag `clean_staging_directory` to puppet
masterless provisioner so it takes care of this cleanup.
2015-07-17 22:24:23 +02:00
56745e14f5
manifest_file can now be a folder or file.pp and we will upload it correctly in either case
2015-07-16 19:15:16 -07:00
18438cf291
Add knife config by template
...
Since the chef-client provisioner is cleaning the node and client at the chef-server from the provisioned node
it needs to have a flexible configuration
This is replacing the used knife flags: -s '<chef-server-url>' -k '/tmp/packer-chef-client/client.pem' -u '<client-name>'
and puts their values into a generated knife.rb
Additionally the knife.rb may include the optional ssl_verify_mode attribute to enable the verify mode verify_none
Background:
When deleting node and client to a self-hosted chef-server using self signed cerfiticates the usage of
knife node delete <node-name> -y -s '<chef-server-url>' -k '/tmp/packer-chef-client/client.pem' -u '<client-name>'
will lead into a ssl verification failure.
The error output of the knife call is somthing like:
2015/06/24 12:29:17 ui: docker: WARNING: No knife configuration file found
docker: WARNING: No knife configuration file found
2015/06/24 12:29:17 ui: docker: ERROR: SSL Validation failure connecting to host: 172.16.117.63 - SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B:
certificate verify failed
docker: ERROR: SSL Validation failure connecting to host: 172.16.117.63 - SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed
2015/06/24 12:29:17 ui: docker: ERROR: Could not establish a secure connection to the server.
docker: ERROR: Could not establish a secure connection to the server.
2015/06/24 12:29:17 ui: docker: Use 'knife ssl check' to troubleshoot your SSL configuration.
docker: Use 'knife ssl check' to troubleshoot your SSL configuration.
2015/06/24 12:29:17 ui: docker: If your Chef Server uses a self-signed certificate, you can use
docker: If your Chef Server uses a self-signed certificate, you can use
2015/06/24 12:29:17 ui: docker: 'knife ssl fetch' to make knife trust the server's certificates.
docker: 'knife ssl fetch' to make knife trust the server's certificates.
2015/06/24 12:29:17 ui: docker:
docker:
2015/06/24 12:29:17 ui: docker: Original Exception: OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed
docker: Original Exception: OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed
2015/06/24 12:29:17 packer-builder-docker: 2015/06/24 12:29:17 Executed command exit status: 100
2015-06-24 15:22:59 +02:00
036c9ddf7c
fix file download provisioner
...
when file used with download direction we don't need
to check source on builder because it on machine.
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2015-06-23 12:27:27 +03:00
b77042dc85
provisioner/shell-local: fix vet
2015-06-22 15:01:22 -07:00
5db4d7c01f
fmt
2015-06-22 12:37:52 -07:00
288b9a70f6
Merge pull request #1657 from njhartwell/master
...
Adding disable sudo support to salt masterless
2015-06-22 12:37:30 -07:00
11e325738b
Merge branch 'ansible-inventory-groups' of https://github.com/lyrixx/packer into lyrixx-ansible-inventory-groups
2015-06-22 12:35:50 -07:00
7c8e86c9c5
provisioner/*: fix interpolation context
2015-06-22 12:26:54 -07:00
0e8036a023
Merge pull request #2283 from mitchellh/f-local-shell
...
Local shell provisioner
2015-06-22 12:18:48 -07:00
6ec428cc38
provisioner/shell: retry file delete [GH-2286]
2015-06-21 19:53:43 -07:00
2dc6155c30
provisioner/shell-local: tests
2015-06-19 15:27:44 -07:00
80fc1f032b
provisioner/shell-local: a first stab
2015-06-19 15:06:06 -07:00
59766067c0
provisioner/windows-restart: make test pass on slow machines
2015-06-19 06:13:51 +02:00
873bc7471f
Merge pull request #2280 from flopex/ignore_exit_codes
...
provisioner/puppet-server: Add ignore exit codes option
2015-06-19 06:08:29 +02:00
4463083a60
provisioner/shell: randomize default script name
2015-06-18 10:38:23 +02:00
b2609db395
provisioner/windows-restart: fix potential panic case
2015-06-17 18:22:27 +02:00
7711e07f05
provisioner/windows-restart: test fix
2015-06-17 17:56:31 +02:00
49769a17c2
Merge pull request #2243 from mitchellh/f-powershell
...
Windows provisioners: powershell, windows-shell, windows-restart
2015-06-17 17:51:42 +02:00
5ee02b09b2
Merge pull request #2258 from mitchellh/b-puppet-manifest-base
...
provisioner/puppet-masterless: only base if manifest is a file [GH-1933]
2015-06-17 17:51:07 +02:00
af4d8b99b4
Add quickfix to restart provisioner as existing one was not working.
...
For more information read https://github.com/mitchellh/packer/pull/2243
2015-06-17 12:29:10 +12:00
8990c38d5e
provisioner/puppet-masterless: deprecation warning
2015-06-16 09:38:24 -07:00
6cda4fa548
Merge branch 'default_facts' of https://github.com/danzilio/packer into danzilio-default_facts
2015-06-15 15:29:23 -07:00
65916514c0
Merge branch 'puppet_working_dir' of https://github.com/ColinHebert/packer into ColinHebert-puppet_working_dir
2015-06-15 15:17:45 -07:00
5d38ee939b
Merge pull request #2259 from mitchellh/b-shell-delete
...
provisioner/shell: remove file after exec [GH-1536]
2015-06-15 15:15:51 -07:00
6c80228661
provisioner/shell: missing error arg
2015-06-15 15:11:08 -07:00
500d83b673
add download support to file provisioner
2015-06-15 15:08:56 -07:00
a235419c7d
provisioner/shell: remove file after exec [GH-1536]
2015-06-15 15:02:59 -07:00
742e556836
provisioner/puppet-masterless: only base if manifest is a file [GH-1933]
2015-06-15 14:44:54 -07:00
711dfc9d0a
provisioner/chef: show command in output
2015-06-15 14:35:54 -07:00
14787fd4cc
provisioner/chef-client: run cleanup on node [GH-1295]
2015-06-15 14:29:12 -07:00
106c9403ed
provisioner/chef-client: chmod the directories
2015-06-15 13:41:07 -07:00
bee3b59c40
Merge branch 'chef-client-client_key' of https://github.com/ameir/packer into ameir-chef-client-client_key
2015-06-15 13:40:33 -07:00
ab6a330d86
provisioner/*: fix go vet
2015-06-14 12:39:39 -07:00
339a4ccdab
provisioner/windows-shell
2015-06-14 11:23:29 -07:00
840ddb4f20
provisioner/windows-restart
2015-06-14 11:14:47 -07:00
040ff0706d
provisioner/powershell
2015-06-14 11:01:28 -07:00
c549fce85e
provisioner/shell: escape single quotes [GH-2067]
2015-06-13 14:11:20 -04:00
7830d78d06
provisioner/shell: fix tests
2015-06-11 17:24:02 -04:00
b28f946be9
Merge pull request #2210 from mitchellh/b-set-e
...
provisioner/shell: set -e for inline [GH-2069]
2015-06-11 17:19:43 -04:00
3ed73852be
provisioner/shell: set -e on the shebang itself
2015-06-11 17:19:23 -04:00
a995df352e
provisioner/shell: uploaded script should be 0755 [GH-1708]
2015-06-10 21:18:46 -07:00
952077ccb0
provisioner/shell: set -e for inline [GH-2069]
2015-06-10 21:02:22 -07:00
2b4df93f2f
provisioner/*: interpolation
2015-05-27 14:50:20 -07:00
c2381be44f
provisioner/*: convert to interpolation
2015-05-27 14:41:47 -07:00
758618ecaa
Add ignore_exit_codes key for provisioner puppet-server
2015-05-14 15:05:44 -07:00
c4cee75b93
Adding tests for disable sudo
2015-05-13 08:32:09 -05:00
d0d3229f96
Merge branch 'master' of https://github.com/mitchellh/packer
...
Conflicts:
provisioner/salt-masterless/provisioner.go
2015-05-13 08:13:38 -05:00
cd14cb7012
[Provisioner][Ansible] Added support for inventory group
2015-04-30 18:43:00 +02:00
5c06af872d
Support chef-client 'client_key' and default to <staging
...
dir>/client.pem.
2015-04-09 02:15:16 -04:00
3165b0c936
provisioner/salt-masterless: fix incorrect printf verb types
...
Fixes the following vet reports:
provisioner/salt-masterless/provisioner.go:119: arg cmd for printf verb %s of wrong type: *github.com/mitchellh/packer/packer.RemoteCmd
provisioner/salt-masterless/provisioner.go:121: arg err for printf verb %d of wrong type: error
provisioner/salt-masterless/provisioner.go:142: arg err for printf verb %d of wrong type: error
provisioner/salt-masterless/provisioner.go:157: arg err for printf verb %d of wrong type: error
provisioner/salt-masterless/provisioner.go:172: arg err for printf verb %d of wrong type: error
provisioner/salt-masterless/provisioner.go:216: arg err for printf verb %d of wrong type: error
2015-02-25 05:43:18 +01:00
92704b693a
provisioner/puppet-masterless: fix missing format argument
...
Fixes the following vet report:
provisioner/puppet-masterless/provisioner.go:196: missing argument for Errorf(%d): format reads arg 1, have only 0 args
2015-02-25 05:43:18 +01:00
7e3d172581
Fixing spacing on line 162 and 164 of provisioner/puppet-masterless/provisioner_test.go
2015-02-24 22:56:37 -05:00
8404f6ce86
Taking a stab at a test for the facter facts
2015-02-24 22:52:09 -05:00
d1445bc6fe
Make PackerBuildName and PackerBuilderType available as Facts during a masterless run similar to the way we do with the Shell provisioner.
2015-02-24 21:44:00 -05:00
b7fccec91c
Set the working dir to staging dir
2015-01-11 10:29:01 +11:00
a100e9393b
Add support for custom working directory for puppet
2015-01-11 10:25:48 +11:00
034ed36d0e
Ask salt to return a proper exit code so we can fail the builder appropriately.
2014-12-30 10:34:43 -05:00
3a3a81b01c
Merge remote-tracking branch 'upstream/master'
2014-12-24 17:04:27 -05:00
eb72584415
fix passing bootstrap_args to bootstrap script
2014-12-22 14:08:32 -06:00
027b43ea05
Fixed info declared and not used
2014-12-16 09:49:57 -05:00
5a9e5df967
Allow manifest_file to be a directory
...
Puppet is removing support for imports and node inherits. This change will support directories as manifests
https://docs.puppetlabs.com/puppet/latest/reference/dirs_manifest.html
https://docs.puppetlabs.com/puppet/latest/reference/lang_import.html
2014-12-16 09:27:30 -05:00
e4c544b3e2
added ssl_verify_mode parameter to chef-client provisioner
2014-12-05 20:26:41 +03:00
1837c7189a
Added tests for prevent_sudo
2014-11-27 06:24:54 -08:00
a5ca2e5a27
Use sudo only if prevent_sudo is not set
2014-11-27 06:24:54 -08:00
0eb634ae6a
Merge pull request #1525 from scott2449/master
...
Add default nodename for chef-client
2014-11-26 16:29:22 -05:00
e5c6f1a753
Merge branch 'master' of https://github.com/mitchellh/packer
...
Conflicts:
provisioner/salt-masterless/provisioner.go
2014-11-05 10:58:25 -06:00
81d8cd0db4
Merge pull request #1394 from mafrosis/salt-masterless
...
Salt masterless tidy up
2014-10-28 08:35:10 -07:00
3eda0f33a0
provisioner/shell: quote PACKER env vars [GH-1565]
2014-10-28 08:23:18 -07:00
8cdb686505
Merge pull request #1562 from bhcleek/ansible-local-inventory-best-practice
...
provisioners/ansible-local: always use an inventory file
2014-10-27 17:01:12 -07:00
86fb46ab0a
Update SaltStack provision to https
...
This changes the SaltStack bootstrap URL to use the HTTPS link from the commercial site. Alternatives are the HTTPS link to the raw file on GitHub, but this, whilst more transparent, might break down the line.
2014-10-22 17:55:45 +01:00
afa499befd
always use an inventory file
...
Using "127.0.0.1," as the argument to `ansible-playbook -i` uses an
undocumented feature of Ansible. Michael DeHaan has indicated that
support for it may be pulled in the future
(https://groups.google.com/forum/#!topic/ansible-project/G_9JRGp5jGE ).
2014-10-14 15:36:29 -07:00
373cefa93c
Merge pull request #1585 from Tpbrown/ansible-color-and-unbuffered
...
provisioner/ansible: Colorize Ansible output, and don't buffer output.
2014-10-14 15:36:27 -07:00
5835ca42b4
Move quoting to else block only for valid vars. Add test case.
2014-10-14 14:20:36 -07:00
a667282e00
Single quote env var values.
2014-10-14 13:03:14 -07:00
baa8697f5d
Colorize Ansible output, and don't buffer output.
...
Setting environment variables for the ansible-playbook invocation.
ANSIBLE_FORCE_COLOR will ensure output is colorized. PYTHONUNBUFFERED will stream output as Ansible runs, vs getting a big dump of output at the end.
2014-10-13 15:31:11 -07:00
331003c809
Merge branch 'master' of https://github.com/mitchellh/packer
2014-10-06 15:19:11 -05:00
ed07fb63e4
salt provisioner: tidy up and refactor into functions
2014-10-01 12:31:58 +10:00
e7a46d97c0
salt provisioner: require local_state_tree
2014-10-01 12:31:58 +10:00
4383b435a4
adding default nodename
2014-09-24 19:40:34 -04:00
75395af12d
Merge branch '1064-fix-upload-file-permissions' of github.com:rasa/packer into rasa-1064-fix-upload-file-permissions
...
Conflicts:
builder/parallels/common/step_upload_parallels_tools.go
builder/vmware/common/step_upload_tools.go
provisioner/chef-client/provisioner.go
provisioner/chef-solo/provisioner.go
2014-09-08 13:20:46 -07:00
802168f4b5
Merge branch 'add-chef-environment' of github.com:cfortier2/packer into cfortier2-add-chef-environment
...
Conflicts:
provisioner/chef-client/provisioner.go
2014-09-05 16:13:32 -07:00
825864a9ea
Merge branch 'additional-user-variables' of github.com:nBerg/packer into nBerg-additional-user-variables
...
Conflicts:
builder/amazon/common/run_config.go
2014-09-02 09:57:52 -07:00
3bfeb54853
Fix Ansible inventory path on Windows
...
Convert the path to use a '/' separator.
2014-07-25 14:32:38 +01:00
c75a671c1e
Cleaned up Go formatting with gofmt.
2014-07-17 15:33:09 -04:00
18dddb516b
Fix remotePaths when provisioning Linux from Windows
2014-07-11 19:12:34 +09:00
bd1a0d07fb
Added some variables to amazon-ebs builder and chef-client provisioner
2014-07-08 13:15:17 -04:00
e908cc1733
add chef_environment test
2014-05-21 09:30:18 -04:00
25386f8e8e
add support for chef_environment
2014-05-21 09:24:34 -04:00
d92179847d
provisioner/file: set file/directory permissions
...
fixes #1064
2014-05-09 21:03:35 -07:00
0a8e4c7186
Uploading the whole ansible playbook directory
2014-05-10 01:59:05 +10:00
88ec874c32
Adding disable_sudo support to salt-masterless provisioner
...
This is already present in some other provisioners and is helpful when
using a builder that gives you root access.
2014-05-09 09:08:41 -05:00
5c5d62733f
fmt
2014-05-01 14:24:19 -07:00
9beac8d286
provisioner/chef-client: proper ordering of args [GH-1100]
2014-05-01 14:13:22 -07:00
b801713e83
Node DNA needs to handle multiple types
...
Makes chef-client provisioner consistent with chef-solo in its handling of nested JSON as well as strings.
Fixes #1096
2014-05-01 12:48:45 -03:00
bb8d0a5e7a
provisioner/chef-solo: convert []uint8 to string
2014-04-29 00:33:55 -07:00
379f3ae933
provisioner/chef-solo: be more lenient on json fix
2014-04-28 22:20:57 -07:00
4379997c2c
provisioner/chef-solo: better error for bad type in JSON
2014-04-28 22:18:21 -07:00
8fc46aaa82
provisioner/chef-solo: deeploy nested JSON works properly
2014-04-28 21:56:32 -07:00
6017f895f1
provisioners/chef-client: delete correct client
...
The server URL was being passed through rather than the client name.
2014-04-28 15:29:15 -07:00
9365b879c0
provisioner/shell: chmod uploaded file to 0777 [GH-994]
2014-04-26 20:20:47 -07:00
ec41edf558
provisioner/shell: Split on first equal for env vars [GH-1045]
2014-04-26 14:51:56 -07:00
5fac6c79c4
fmt
2014-04-26 11:12:43 -07:00
eb4ba76e1a
provisioner/chef-client: validation_client_name
...
Allows setting of validation_client_name from packer template json.
2014-04-24 00:09:30 -07:00
ec847acf80
Merge pull request #963 from rhburrows/ansible-local-paths-on-windows
...
Fix ansible paths when provisioning Linux from Windows
2014-04-21 08:21:08 -07:00
4f186fbd6e
Merge pull request #1006 from jgornick/add-ansible-inventory-file (manually)
2014-04-21 07:57:24 -07:00
d9fc06a170
Update Ansible provisioner to set cwd to staging directory.
2014-04-08 09:50:26 -05:00
6d56def162
Add inventory_file option to Ansible provisioner.
2014-04-04 14:58:48 -05:00
6420fbb469
Fix ansible paths when provisioning Linux from Windows
...
Since the paths are generated on the host machine but the commands are
executed on the VM being provisioned the paths generated will use path
separators from the host. In the case of provisioning a Linux VM from
Windows this path will not work.
Convert the path to use a '/' separator which should work for both
platforms in Go
2014-03-18 11:12:13 -07:00
3de16f20b9
privisioner/chef-client: don't chown with ubuntu [GH-939]
2014-03-12 21:05:25 -07:00
ab97545a52
provisioner/puppet-server: docs
2014-02-24 09:51:48 -08:00
2af91addf9
Merge pull request #796 from Jimdo/puppet-server
...
Add puppet server provisioner
2014-02-24 09:49:27 -08:00
000e5b67ff
provisioner/chef-client: docs and validation key path
2014-02-24 09:45:04 -08:00
d7e6409b9a
provisioner/chef-client: clean up
2014-02-24 08:53:56 -08:00
d0a08e83cf
Merge pull request #855 from Elachance/chef-client-provisioner
...
adding chef-client provisioner
2014-02-24 08:33:11 -08:00
4576093c17
fmt
2014-02-24 08:26:51 -08:00
8c1de9e712
provisioner/ansible-local: better error if missing [GH-836]
2014-02-21 20:30:04 -08:00
Matthew Hooker
Andrey Chernih
Marc Carmier
DanHam
Sean Malloy
Brian Hicks
Taliesin Sisson
Taliesin Sisson
Patrick Decat
Vasiliy Tolstov
Billie Cleek
Jasper Siepkes
Rickard von Essen
mexisme
开恒
nouney
Spencer Owen
Billie Cleek
Isa
Chris Bednarski
Joel Scoble
Ricard Clau
Jamie Snell
Tom Asquith
Justin Nauman
Ian Duffy
Mario Steinhoff
Simon Guest
Joakim Löfgren
Keyan Pishdadian
Vespian
Marat Bakeev
Billie H. Cleek
ephemeralsnow
Matt Black
David Zanetti
Trevor Suarez
Billie H. Cleek
Mark Peek
Shawn Neal
Gonzalo Peci
Tim Smith
Eric Herot
AmirAli Moinfar
Jaime Soriano Pastor
Schreiter, Wulf-Thilo
Mitchell Hashimoto
Mitchell Hashimoto
Alexander Golovko
Francisco Lopez
Nathan Hartwell
Grégoire Pineau
Ameir Abdeldayem
Emil Hessman
David Danzilio
Colin Hebert
Erik Simmler
Neeki Patel
Victor Trac
Timur Batyrshin
James Massara
Seth Vargo
Nathan Hartwell
Steve Daniels
Josh Frye
Tim Brown
Scott Rahner
yveslaroche
Misha Brukman
sawanoboly
Nina Berg
cfortier2
Ross Smith II
renat-sabitov-sirca
Ben Langfeld
James Cline
Joe Gornick
Ryan Burrows