ee7fa27ada
Fix up tests. Ensure export step stores the export path in state
2018-07-20 02:12:44 +01:00
232dd8f0a6
Remove code to preserve legacy export dir structure from the export step
...
Store the export path in the state bag in preparation for use in a later
step
2018-07-20 02:12:44 +01:00
c2437ba592
Remove the option to place the VHD files in a separate directory
...
The export process now exports the VM directly from the build directory
into the output directory. There are no intermediate steps or copying of
files involved. This means that there is no longer any benefit in having
a separate directory to house the VHD files - see #5206 for the
reasoning behind the introduction of this feature.
If a user wishes to house the build files on a separate disk from the
output directory (perhaps for performance reasons or due to disk space
limitations) they can still do so through the use of `temp_path`.
2018-07-20 02:12:43 +01:00
d5d82c32b2
Changes to the export process have made 'inline' build of disks redundant
...
PR #5631 introduced code to build/create disks directly in the output
directory if `skip_export` was set in an attempt to optimise the build
process. These are no longer required.
2018-07-20 02:12:43 +01:00
35b4e87c42
Add tests for export VM step
2018-07-20 02:12:43 +01:00
30a71da8e7
Add tests for disk compaction step
2018-07-20 02:12:43 +01:00
09028c14a3
Reintroduce the disk compaction process as a unique step
2018-07-20 02:12:43 +01:00
da2df69301
Remove disk compaction from the export step
2018-07-20 02:12:42 +01:00
c6b9d9ce90
Add checks/error reporting to compaction process
...
* Report compaction results
* Failure to find any disks under the supplied path is treated as a
'soft' error and a warning message will be printed in place of the
compaction result. Any other failure will cause the build to fail.
2018-07-20 02:12:42 +01:00
534fc4a473
Ensure the export directory structure matches that of previous versions
...
Commit 3fc2defb63fc2defb63fc2defb6
2018-07-20 02:09:57 +01:00
dc46848f89
Remove now redundant function to copy exported VM files
2018-07-20 02:09:57 +01:00
3fc2defb6d
Refactor the export step for Hyper-V ISO and VMCX builders
...
* Fixes a bug that caused the build to error if users did not
explicitly set `skip_compaction:true` when setting `skip_export:
true`. See #6392 .
* Improves the efficiency of the compaction and export process by
reordering the compaction and export steps.
* Further improves the efficiency of the compacting step through
compacting the vmd* file directly rather than creating and then
operating on a copy.
* The changes mean the export process now stores the exported machine
files and folders under a folder with name 'vm_name' in the output
directory. Previously the exported machine files and folders were
stored directly in the output directory.
2018-07-20 02:09:54 +01:00
814c1cf2b2
spellfix
2018-07-18 13:00:45 -07:00
67f039509a
Merge pull request #6498 from neumayer/ocimetadata
...
Allow instance metadata to be specified in config
2018-07-18 18:27:27 +01:00
885ecb0790
Issue-6309 Amazon Chroot Provider
...
- Add tags on CreateVolume
2018-07-18 13:01:15 +03:00
7630268e1d
Incorporate review comments
2018-07-17 17:41:19 +02:00
9fffe4056e
Merge pull request #5452 from smaato/tag-spot-requests
...
Enable tagging of spot requests
2018-07-16 13:00:07 -05:00
451cbd8aa9
Merge pull request #6487 from sermilrod/Honour-cloudstack-projectid
...
Honour cloudstack projectid
2018-07-16 13:53:06 +02:00
f4020835d6
flag to setup networking without firewall rules
2018-07-16 13:06:51 +02:00
472a7820eb
Using UI keypair meaningful message
2018-07-16 11:39:15 +02:00
e729b21212
passing projectid to getRootVolumeID rather than the whole config struct
2018-07-16 11:38:14 +02:00
2fec76ea87
Check if spot price is empty, when spot_tags is set
2018-07-13 22:42:42 +02:00
b6b907f523
read in the environment variables that government wait time and polling time for the AWS wait in step_stop_ebs_volume
2018-07-13 09:43:28 -07:00
a41a4658ee
make packer builder honour projectid setting if provided
2018-07-13 17:58:46 +02:00
eae0556dc5
Add option to enable/disable create firewall/acl rules
2018-07-13 17:58:39 +02:00
1d15f09e36
Merge pull request #6440 from DanHam/simplify-vmx-find-disks
...
Further simplify enumeration of attached disks for VMware VMX builder
2018-07-12 11:05:35 -07:00
fa7f54cb55
azure: satisfy Azure password requirements
2018-07-11 15:32:45 -07:00
8e22803099
fix loading of environment variables for managing aws waiters
2018-07-11 13:10:38 -07:00
12f1b2421d
Merge pull request #6332 from hashicorp/do_6177
...
Replace home-grown waiters with aws sdk's built in waiters
2018-07-11 11:17:02 -07:00
f657ca39c9
refactored env var code and tests so that I don't have to set env vars during tests to check logic
2018-07-11 10:36:21 -07:00
14166fdd99
update amazon import docs to include the env vars for setting aws waiter delays and timeouts
2018-07-11 10:36:21 -07:00
bfbe318727
fix the homegrown waiters
...
fix image import; issue was with wait options not being evaluated
2018-07-11 10:36:21 -07:00
f49a2d8aed
move UI call to before the wait; add context to these steps
2018-07-11 10:36:21 -07:00
cf63dd10bf
replace AMIStateRefreshFunc, InstanceStateRefreshFunc, our spot instance waiter, our chroot volume waiter, and our snapshot waiters with waiters form AWS's SDK.
2018-07-11 10:34:20 -07:00
62d9dcb822
Merge pull request #6477 from jabbera/fixMaxResourceGroupLength
...
managed_image_resource_group_name max length change
2018-07-11 10:23:30 -07:00
5ea6429cd6
managed_image_resource_group_name max length change
2018-07-11 11:31:51 -04:00
8e852af1eb
Merge pull request #6448 from DanHam/fix-esxi-displayName
...
ESXi: Fix failure to discover IP or export VM when 'displayName' differs from 'vm_name'
2018-07-10 16:57:16 -07:00
7e4fb9adb5
vnc_bind_address not getting passed through to qemu
...
This was mostly addressed in commit
hashicorp/packer@fa273f3
Just missing vncIP from step_type_boot_command.go
2018-07-09 14:05:39 -06:00
adfee4933a
Merge pull request #6437 from hashicorp/retry_convert
...
make the convert retryable in case it takes a bit to release a lock
2018-07-09 11:09:57 -07:00
3dbf1cb371
Enable tagging of spot requests
...
This adds a new parameter to the EBS builders named `spot_tags'. This
parameter accepts a map of tags, much like `tags'. These tags will be
applied to a spot request that is created.
Improve visibility.
2018-07-07 16:06:51 +02:00
a39c5887fb
Test we halt if a bad path is set in vmx_path
2018-07-06 10:58:25 +01:00
21117e5d38
Test we fail if displayName is not stored in the statebag as 'display_name'
2018-07-06 10:58:25 +01:00
88c43ec98d
Test we fail if the displayName key is not found in the VMX
2018-07-06 10:58:24 +01:00
d68d26a6e5
Fix tests: We now need to set `displayName` key/val pair in the test VMX
2018-07-06 10:58:24 +01:00
902cea0f30
ESXi: Fix failure to export VM when `displayName` differs from `vm_name`
...
ovftool requires we pass in `displayName` as part of the source locator
string so that it can successfully determine the VM intended for export.
2018-07-06 10:58:17 +01:00
cd7d3812ea
ESXi: Fix failure to get VM IP when `displayName` differs from `vm_name`
...
The value in the Name field returned by 'esxcli network vm list'
actually returns the VMs `displayName`. As such, we need to match
against `displayName` to discover the VMs 'WorldID'.
'WorldId' is ultimately used/needed as an argument in the command that
returns the VMs IP.
2018-07-06 10:58:09 +01:00
3eab3cc99b
ESXi builds require we store the value of displayName in the statebag
...
The value of displayName is needed by later steps:
* When determining the IP address of the build VM
* When exporting the VM using ovftool
By default Packer will configure the VMX so `displayName` is equal to
the value defined for `vm_name` in the build template. However, it is
possible (and sometimes desirable) to set a custom value for
`displayName`.
Users can set a custom `displayName` through use of the `vmx_data`
option in their template.
2018-07-06 01:58:09 +01:00
4b1f96b527
Merge pull request #6439 from jbonachera/scaleway-config-bootscript
...
scaleway: add 'bootscript' configuration parameter
2018-07-04 10:10:19 +02:00
8658eaf1ac
Merge pull request #6424 from DanHam/fix-esxi-export-hang
...
Prevent hang on export when using VMware ISO builder on remote ESXi host
2018-07-02 16:42:08 -07:00
939aa7e289
Add test: We shouldn't error when main remote options are unset
2018-07-02 18:13:19 +01:00
efcdf60d96
Add tests to ensure remote_password is set when exporting with ovftool
2018-07-02 18:13:19 +01:00
0d9134bdbc
Fix existing tests as they were not doing what they should have been
...
* Fix test to check for remote_host when remote_type is set
* Fix tests by including remote_password where required
2018-07-02 18:12:41 +01:00
eee16262b6
Remove duplicate/redundant test
2018-07-02 18:10:50 +01:00
c8199458a7
Prevent hang on export for remote ESXi build due to empty remote_password
2018-07-02 18:10:50 +01:00
406f4eeb93
Merge pull request #6394 from conradjones/master
...
Add support to vmware-vmx for linked clones
2018-07-02 09:50:24 -07:00
22e5523faa
Allow instance metadata to be specified in config
2018-07-02 10:48:08 +02:00
fff72780e1
Further simplify enumeration of attached disks for VMware VMX builder
...
* Collate separate regexp's into one for greater efficiency
* Inline function and remove unnecessary struct and variables
2018-07-01 16:18:33 +01:00
d9b6924986
Add cloneType to fusion driver
2018-06-30 16:31:42 +01:00
eda85a4daf
scaleway: add 'bootscript' configuration parameter
2018-06-29 19:44:56 +02:00
2b2c860df8
make the convert retryable in case it takes a bit to release a lock
2018-06-28 14:21:28 -07:00
c67d59515c
Merge pull request #6370 from arizvisa/patch-1
...
Allow StepAttachIso in the VirtualBox builder to resolve symbolic links when processing the IsoPath.
2018-06-27 10:30:30 -07:00
b600be009d
Pass context into OCI client
2018-06-26 10:17:02 +01:00
5a6a389e66
Merge pull request #6415 from brumfb/skip_invalid_lease_files
...
Fixes VMWare Builder issue regarding DHCP-less NAT networks.
2018-06-25 16:47:04 -07:00
78c0b7bd9c
Merge pull request #6408 from harveylowndes/oci-support-custom-instance-display-name
...
Support instance display name configuration for OCI
2018-06-25 13:17:12 -07:00
04ff0761e6
Notify that we are skipping file, but retain error message
2018-06-25 08:28:32 -07:00
a69e2ac78e
Support instance display name configuration
2018-06-25 11:45:59 +01:00
7bab499b73
fix vpc clean up issue
2018-06-25 09:16:06 +08:00
f511c706c9
fix alicloud builder eip allocating issue
2018-06-23 16:34:45 +08:00
591bfe3dfa
Continue searching for leases even if one of the files cannot be read.
2018-06-22 18:09:27 -07:00
ec8747a042
They finally added https on download.virtualbox.org
...
Because downloading SHA256SUMS via http is a fun joke
2018-06-22 00:45:20 +03:00
abfb9f24d6
revert accidental debugging change
2018-06-17 01:45:26 +01:00
d05a601d00
Add support to vmware-vmx builder for linked clones.
2018-06-17 01:38:42 +01:00
58e4176a73
Merge pull request #6385 from enricou/wip/add-northeast-3
...
Add ap-northeast-3 region
2018-06-15 10:46:36 -07:00
58f73aabbf
Add ap-northeast-3 region
2018-06-15 07:15:41 +00:00
4e2b1756f9
Fix misprints in steps names
2018-06-15 12:12:40 +07:00
47a3315fde
Added a missing reference to the "path/filepath" module.
...
Lol. Dammit.
2018-06-11 18:07:43 -05:00
963932699e
Remove a stray tab that resulted from poor usage of Github's file editor.
...
That's what I get for not making a proper branch...
2018-06-11 18:02:52 -05:00
9b30c9aed0
Allow StepAttachIso in the VirtualBox builder to resolve symbolic links when processing the IsoPath.
...
This just closes out a really old issue (#3437 ) by using `filepath.EvalSymLinks` to resolve the symbolic link that the user specifies for the IsoPath.
2018-06-11 17:53:54 -05:00
2b60934420
Merge pull request #6363 from hashicorp/fix_6358
...
sh -c to execute command to accomodate communicator change
2018-06-11 10:25:25 -07:00
5d35c71358
Merge pull request #6362 from rickard-von-essen/os-token
...
openstack: Add support for token authorization and cloud.yaml
2018-06-08 16:26:34 -07:00
87a93e84ac
sh -c to execute command to accomodate communicator change
2018-06-08 13:14:55 -07:00
3bdf1f1849
openstack: Add support for token authorization and cloud.yaml
...
via config options `cloud` and `token` and environment variables
OS_CLOUD and OS_TOKEN.
2018-06-08 21:38:26 +02:00
10549d34b6
Merge pull request #6322 from sieben/remove_vc
...
Remove the VC product line
2018-06-08 09:55:24 -07:00
c586312bf7
Merge pull request #4538 from hashicorp/defaultovf
...
builder/vmware: correctly default export format to ovf
2018-06-07 11:36:48 -07:00
b23d6c9589
fixing infinite loop issue deleting existing resources if we have a empty target resource
2018-06-06 15:25:19 -07:00
c0ae1b7790
digitalocean: artifact should include build region and fixed docs
...
- Add the build region to the list of regions for the artefact
- Corrected docs: `snapshot_name` doesn't have to be unique.
- Updated example to use Ubuntu 16.04
2018-06-03 16:37:38 +02:00
10f118b14c
Update driver_gce.go
...
Added "rhel-sap-cloud" Projects_ID.
2018-05-31 11:29:57 +05:30
31c7374869
Merge pull request #6303 from hashicorp/do_5871
...
add get windows default credentials to oci builder
2018-05-29 16:12:15 -07:00
dba9f1b015
Remove the VC product line
2018-05-28 16:19:51 +02:00
b97475b647
Merge pull request #6265 from DanHam/enable-t2-unlimited
...
Add support for T2 Unlimited for Amazon builders
2018-05-25 00:26:17 +04:00
af7f7f2ce9
Fix redundant Sprintf
2018-05-24 21:05:03 +01:00
08218222dc
add get windows default credentials to oci builder
2018-05-24 10:47:37 -07:00
62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
...
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
e670eed315
Add new option, nvme_device_path, so that we can properly mount nvme block devices.
2018-05-23 09:16:40 -07:00
3dd6bf5781
Merge pull request #6285 from harijayms/devicelogin
...
Devicelogin Support for Windows and not requiring object ID
2018-05-22 11:26:47 -07:00
a13a2511f9
Added additional error message if we failed to parse token
2018-05-21 22:20:36 -07:00
1bd7aa534e
Addressed PR feedback
2018-05-21 21:38:41 -07:00
a8b6a04dda
Merge pull request #6194 from hashicorp/fix_6176
...
allow user to mount entire block device in chroot builder
2018-05-21 15:28:18 -07:00
8a3e599cad
Added text to point out two device auth
2018-05-21 11:05:59 -07:00
da67df6d03
space fix
2018-05-18 21:17:19 -07:00
4992429e8c
Minor comment fixes
2018-05-18 17:34:01 -07:00
00e809cb7e
Refactored the change into a new function
2018-05-18 15:21:49 -07:00
ea9b2a8b5f
review feedback
2018-05-18 12:09:42 -07:00
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
...
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
...
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
667113338a
missed formating
2018-05-18 01:41:00 -07:00
7f2277676a
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:34:12 -07:00
77fe1bffe4
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:25:19 -07:00
de1783240f
Updates to remove space changes
2018-05-18 00:53:44 -07:00
91eed4da52
trim right of the keyvault url
2018-05-18 00:44:25 -07:00
df5cc234fc
updates
2018-05-18 00:39:57 -07:00
1f46271a6b
Ensuring device login works for Windows build
2018-05-18 00:32:01 -07:00
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
...
Async delete Resource Group
2018-05-16 15:13:09 -07:00
c925a02f82
don't chown to close the security issue
2018-05-16 21:40:22 +00:00
3192f5e0da
qemu builder: add the 'use_backing_file' setting for QCOW2 images
2018-05-16 10:22:50 -04:00
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
2018-05-16 13:52:00 +01:00
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
2018-05-16 12:55:59 +01:00
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00
2c339b99d2
Sort run config options alphabetically
2018-05-15 12:25:06 +01:00
c8c9bbb22a
Async delete Resource Group
2018-05-14 20:06:23 -07:00
5710c0aca1
Making log output clearer for hyper-v gui connection
2018-05-14 20:53:51 +10:00
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
...
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
...
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
13c0b0b370
Added warning for VHD creation and updated samples
2018-05-10 13:15:35 -07:00
6f00596053
Adds config option to specify hyper-v secure boot template
2018-05-10 19:00:35 +02:00
84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
...
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
a866232ac9
Use regex based approach to detect attached disks
2018-05-08 12:52:39 +01:00
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
80a096cadd
azure: device login for US Gov
2018-05-06 20:59:38 -07:00
8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
...
Update Azure SDK
2018-05-04 09:47:28 -07:00
4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
...
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
169f9d22e6
Update 'the other place' too
2018-05-04 00:32:15 +00:00
80f57308d7
Process review feedback
2018-05-04 00:28:34 +00:00
420a5842b9
Merge pull request #6231 from cantorek/f-randomize-osdiskname
...
Randomize osDisk name for Azure Managed Image builds.
2018-05-03 14:55:42 -07:00
0521efa200
correctly log reason waiting for ami failed.
2018-05-03 12:27:09 -07:00
7d5ebd5500
Merge pull request #6217 from alessiot77/5887
...
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
c47e5d19f0
Fix use of auto generated ssh key for scaleway builder
2018-05-03 11:33:28 +01:00
585b93cfd6
Follow variable privateKey <-> statebag private_key convention
2018-05-03 00:33:12 +01:00
78d68880c0
Randomize osDisk name for Azure Managed Image builds.
...
This fixes #6115
2018-05-02 22:42:08 +02:00
07d8c71a2d
Create and use context for Builder.Run
2018-05-01 23:40:40 +00:00
e90c87f885
Merge pull request #6210 from hashicorp/add_windows_sql_cloud_to_defaults
...
add windows-sql-cloud to the list of projects to check for an image name
2018-05-01 12:57:10 -07:00
cf94086b5f
Formatting fixes
2018-05-01 19:53:20 +00:00
6260151034
Merge pull request #6226 from hashicorp/fix6225
...
builder/qemu: properly prepare boot command.
2018-05-01 12:41:11 -07:00
4f1395e0f6
builder/qemu: properly prepare boot command.
2018-05-01 12:40:00 -07:00
c13965c0ce
Add acceptance tests
2018-05-01 15:39:50 +00:00
a3fb24639a
make tests pass again
2018-05-01 15:39:50 +00:00
09ce3c9803
Make it compile again
2018-05-01 15:39:50 +00:00
3d4c7d0df1
Feature Request: Log reason why AMI creation failed
2018-04-30 20:59:13 +01:00
25dd27a164
Remove tmp directories created by builder/vmware/common tests
2018-04-30 20:38:03 +01:00
13b7078cb0
Remove tmp directories created by builder/virtualbox/common tests
2018-04-30 20:38:03 +01:00
475b3978d2
Remove tmp directories created by builder/parallels/common tests
2018-04-30 20:38:03 +01:00
5642f8cb01
Remove tmp files created by builder/googlecompute tests
2018-04-30 20:38:03 +01:00
9b6fc5a58d
Remove tmp files created by builder/amazon/instance tests
2018-04-30 18:16:46 +01:00
54e9690dff
Remove tmp files created by builder/amazon/common tests
2018-04-30 18:16:46 +01:00
96adb4a9d1
Remove tmp files created by builder/alicloud/ecs tests
2018-04-30 18:16:46 +01:00
373226e9c5
Extract state reason for failure
2018-04-28 12:40:48 +01:00
09bb21774d
alessio.tomasino@yahoo.co.uk
2018-04-28 11:02:53 +01:00
c27f3e9445
alessio.tomasino@yahoo.co.uk
2018-04-28 11:00:33 +01:00
c828015bc3
Follow variable varName <-> statebag var_name convention
2018-04-27 20:09:19 +01:00
df5c67090e
Merge pull request #6193 from adarobin/hvf
...
add support for hvf accelerator to qemu builder
2018-04-27 11:41:01 -07:00
ed6d999b1f
add windows-sql-cloud to the list of projects to check for an image name
2018-04-27 11:24:08 -07:00
f342975ff3
Fix test - reporting compaction results requires a tmp file
2018-04-27 16:40:44 +01:00
08f9d619a9
Report the result of the disk compaction step
2018-04-27 16:40:29 +01:00
10d93dffa4
Fix tests for vmware/common
2018-04-27 16:40:23 +01:00
a729ecda87
Fix tests for vmware/vmx builder
2018-04-27 16:40:13 +01:00
c48a7889f9
Simplify handling of disks by collating requirements and unifying ops
2018-04-27 16:39:52 +01:00
29b89e63b8
add support for hvf accelerator to qemu builder
2018-04-27 10:11:20 -04:00
879319a76c
Merge pull request #6202 from rickard-von-essen/fix-6184
...
builder/parallels-pvm: Add missing compaction of disks
2018-04-26 15:44:12 -07:00
67a9c7fb92
we never expect remote cache to be a directory.
2018-04-26 12:40:40 -07:00
de1dac1bdf
don't delete the cache directory.
2018-04-26 12:40:40 -07:00
97cfd60b82
Remove remote cache correctly.
2018-04-26 12:40:35 -07:00
673d4579e4
Ack! Forgot to include the template variable in the definition for vmxTemplateData for commit 0e519d79e0. Now it's added..
2018-04-26 14:22:37 -05:00
0e519d79e0
Modified iso/step_create_vmx.go in the vmware-iso builder to also specify the "bios.hddOrder" field depending on the hdd device that was specified. This might close issue #6197
2018-04-26 14:16:50 -05:00
5d8b476a7f
Fixed the regex in common/step_clean_vmx.go for the VMware builder to also support removal of sata-based cdrom devices. Also added a comment in iso/step_create_vmx.go that links both pieces of related code.
2018-04-26 14:01:58 -05:00
451e3d0554
builder/vmware-esxi: remove floppy files when done
2018-04-26 10:47:33 -07:00
3aebd5f462
Add use_fixed_vhd_format Hyper-V ISO option
2018-04-26 13:35:19 -04:00
77d0ba492d
parallels-pvm: Add missing compaction of disks
2018-04-26 14:09:17 +02:00
59e3ec722d
allow user to mount entire block device in chroot builder
2018-04-25 10:47:52 -07:00
ef03e97dc3
pass MacAddress to StepCreateVM
2018-04-24 20:39:42 -04:00
148f7d39e4
Merge pull request #6142 from harveylowndes/use-official-go-sdk
...
builder/oracle: Use official OCI Go SDK
2018-04-24 16:34:38 -07:00
db65c99bf4
update code based on master and update docs
2018-04-24 10:35:27 +01:00
e2e7953fe4
Merge branch 'master' into allow_gcp_winrm_password
2018-04-24 10:25:27 +01:00
cbdf9db832
Use contexts with amazon waiters.
2018-04-23 12:57:15 -07:00
6bbfe7e0bd
remove useless check against format
2018-04-23 10:24:49 -07:00
fdeadfe3f6
builder/vmware: correctly default export format to ovf
2018-04-23 10:17:53 -07:00
0e80d98805
Merge pull request #6166 from hashicorp/parallelsfixes
...
forcefully stop parallels vm.
2018-04-23 10:08:35 -07:00
69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
...
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
e455e7b054
Merge pull request #6074 from DanHam/fix-vmx-compacting-error
...
Fix error with VMware vmx builder at compacting stage
2018-04-23 09:03:36 -07:00
a2a593759e
Merge pull request #6041 from Xeite/f-add-instance-name
...
builder/openstack: Add instance_name config to OpenStack builder
2018-04-23 08:47:50 +02:00
bd9e585cb9
Add test for enumeration of vmx network type
2018-04-21 22:49:36 +01:00
94d5a7f2e2
Fix copy/paste error referencing Virtualbox
2018-04-21 22:49:36 +01:00
1aee759f06
Fix tests and reconfigure for support of multi-disk vm
2018-04-21 22:49:36 +01:00
6c9d4efd9f
Fix error on compaction step of vmx build. Support compacting multi-disk vm
2018-04-21 22:49:36 +01:00
bcbee45bf9
Merge pull request #6039 from stack72/triton-insecure-skip-tls-verify
...
builder/triton: Add support to Skip TLS Verification of Triton Certificate
2018-04-20 13:44:28 -07:00
024fac4b4f
Merge pull request #6129 from hashicorp/bc_replace
...
Replace boot command parser with PEG parser.
2018-04-20 12:21:20 -07:00
5a10e5a038
fix invalid disc_discard setting error message
2018-04-20 13:17:40 +02:00
11de2b9759
remove unnecessary log line.
2018-04-19 16:13:24 -07:00
c920e0a20b
forcefully stop parallels vm.
...
also only output parallels version once.
2018-04-19 16:11:29 -07:00
1d36ef038c
implement boot config struct for hyperv
2018-04-19 14:26:31 -07:00
a0c9ddb9ae
implement boot config struct for virtualbox
2018-04-19 14:26:31 -07:00
c8e76ce298
implement config struct for qemu
2018-04-19 14:26:31 -07:00
c6299972b9
s/boot_command/bootcommand/
2018-04-19 14:26:31 -07:00
7990966a09
fix boot command config struct name
2018-04-19 14:26:31 -07:00
e662927623
Implement boot config struct for parallels
2018-04-19 14:26:30 -07:00
408eba88ad
flatten boot command config and implement for vmware
2018-04-19 14:26:30 -07:00
94129b7fe3
we're using PC-XT (set1) not PC-AT
2018-04-19 14:26:30 -07:00
a46a7afa20
Remove old tests.
2018-04-19 14:26:29 -07:00
cba4d3235f
cleanup
2018-04-19 14:26:29 -07:00
bf0a320125
Implement new parser for qemu boot command
2018-04-19 14:26:29 -07:00
bdb1eee7d8
Implement new parser for HyperV boot command
2018-04-19 14:26:29 -07:00
81d127768c
Add key press interval to virtualbox.
2018-04-19 14:26:29 -07:00
59376294ef
Maximize scancode throughput.
...
Let's cache the scancodes and flush them at the end. Also make sure to
send only as many as the driver can send correctly. It's important here
to chunk the scancodes correctly, so that we don't accidentally split them
over successive calls to the driver
2018-04-19 14:26:29 -07:00
9b7704c714
Implement new parser for Parallels boot command
2018-04-19 14:26:29 -07:00
99d61920d0
Abstract vbox driver into PC-AT driver.
2018-04-19 14:26:29 -07:00
e4af71858f
Implement new parser for Virtualbox boot command
...
Remove boot wait for virtualbox run step
2018-04-19 14:26:29 -07:00
1c0af28662
Some cleanup and comments.
2018-04-19 14:26:29 -07:00
4e2f14196a
Rely on context to cancel typing boot command.
2018-04-19 14:26:28 -07:00
673245afcf
Replace boot command parser with PEG parser.
2018-04-19 14:26:28 -07:00
f5c031baf9
Merge pull request #5941 from synax/hyper-v-disk-block-size
...
Adds Support to configure hyper-v disk block size
2018-04-19 11:27:52 -07:00
c442ba165e
Migrate to official OCI Go SDK
2018-04-17 10:30:42 +01:00
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
ec6f8264bf
fix winrm password access in google compute
2018-04-16 10:56:26 +01:00
ee1ff3132d
remove attempt to discover whether destination is a directory from upload function in various communicators
2018-04-10 08:13:06 -07:00
83162717ed
Merge pull request #4563 from marema31/vmware-iso-warn-esx
...
builder/vmware-iso: Fail on wrong remote_type value
2018-04-06 16:52:26 -07:00
f094b3be85
update changelog
2018-04-05 16:32:03 -07:00
cb90e8b375
Merge pull request #6111 from hashicorp/replace4448
...
Restrict deregistered AMIs to those owned by self.
2018-04-05 16:30:37 -07:00
d70451f82e
Merge pull request #6106 from sethvargo/sethvargo/useragent
...
Add a common package for specifying useragent and adopt that everywhere
2018-04-05 15:38:11 -07:00
d236f26439
allow users to access winrm password in powershell and elevated powershell provisioners
2018-04-05 15:24:54 -07:00
302b1988a5
Restrict deregistered AMIs to those owned by self.
2018-04-05 13:29:36 -07:00
5eeac07b63
Include existing azure user agent
2018-04-05 14:28:51 -04:00
b17b333e29
Add a common package for specifying useragent and adopt that everywhere
...
There were 5 different formats for the Packer useragent string. This
fixes that and unifies it into a helper package.
I did not touch oracle's user-agent, because it looked kinda special.
2018-04-05 14:28:50 -04:00
f2df7a45ba
Merge pull request #6096 from arizvisa/GH-5882
...
Fixes the DHCP lease and configuration pathfinders for VMware Player.
2018-04-02 16:57:20 -07:00
67d2de8de1
Merge pull request #6079 from hashicorp/do_5866
...
add user data and user data file to oracle oci builder
2018-04-02 16:48:48 -07:00
d6e5b01a23
Merge pull request #6095 from hashicorp/OPaniC
...
prevent panics when cleaning up resources that haven't been created.
2018-04-02 16:34:34 -07:00
22608f3efd
Merge pull request #6088 from adongy/master
...
Expose more source ami data in the template
2018-04-02 16:32:16 -07:00
7e13b5c62a
prevent panics when cleaning up resources that haven't been created.
2018-04-02 11:56:11 -07:00
52f69cd91a
Validate image name.
2018-04-02 11:22:15 -07:00
2c2904c095
Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases..
2018-03-30 18:19:25 -05:00
7e9699675f
Modified device matching logs to look more consistent.
2018-03-30 18:15:46 -05:00
0533e1ad9c
Validate destination image name.
2018-03-30 13:01:52 -07:00
04790695e6
Add interpolate_build_info_test tests
2018-03-30 16:46:35 +02:00
507b3619e7
Expose more source ami data in the template
2018-03-30 10:47:11 +02:00
6e176f97a0
Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network.
2018-03-29 13:12:59 -05:00
646523c5f4
Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers.
2018-03-29 13:04:25 -05:00
f2fc064037
Merge pull request #6056 from rjosephwright/snapshots
...
Modify ebssurrogate builder to snapshot all launch devices
2018-03-29 10:15:19 -07:00
541d33a80f
Merge pull request #6067 from mcandre/virtualbox-fixes
...
VirtualBox fixes
2018-03-29 10:13:49 -07:00
56af885212
Avoid warning when using raw format.
...
When using the raw image format and attempting to resize it we get the following error message:
```
WARNING: Image format was not specified for 'test.raw' and probing guessed raw.
Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
Specify the 'raw' format explicitly to remove the restrictions.
```
Specifying the format will remove this warning.
2018-03-29 14:51:02 +03:00
7623c26e4e
Merge pull request #6057 from arizvisa/GH-5925
...
Fixed a case-sensitivity issue when determing the network type during the cloning step in the vmware-vmx builder
2018-03-28 13:54:09 -07:00
16d044b398
add user data and user data file to oracle oci builder
2018-03-28 13:27:41 -07:00
58ecd32289
remove redundant security_protocol code from the winrm implementation of the oracle-classic provisioner
2018-03-28 10:54:06 -07:00
fdc6ac631a
fix vbox scancodes and support critical key combinations during boot-time operations
2018-03-26 18:35:45 -05:00
55702a697a
Ack, forgot to :w in vim. Changed ui.Say in step_clone_vmx.go to use fmt.Sprintf as it originally was a call to log.Printf.
2018-03-25 19:03:46 -05:00
1913517d29
Fix formatting by running `make fmt`
2018-03-25 19:51:49 -04:00
72da7cbfbb
Fixed a case-sensitivity issue when determing the network type during cloning in the vmware-vmx builder and added also some logs that output the different options that were determined from the .vmx. This outputs more accurate debug information and helps out with issue #5925
2018-03-25 18:51:37 -05:00
cb3699a584
Modify ebssurrogate builder to snapshot all launch devices
...
Documentation for ebssurrogate states that all of the devices in
`launch_block_device_mappings` are snapshotted and included in the
image. In fact, only the device that was designated as the root
device was snapshotted. This patch modifies the builder to create
snapshots of all the devices and include them in the image. This
allows creating images with separate filesystems preconfigured,
rather than having to add volumes to `ami_block_device_mappings`
and configure them after boot.
2018-03-25 19:37:44 -04:00
7253d6547b
minor LXD documentation tweaks
2018-03-23 15:46:39 -07:00
088b4ab275
Merge pull request #6038 from ChrisLundquist/clundquist/more-lxd-config
...
[WIP] LXD fixes and feature requests
2018-03-23 15:38:28 -07:00
072cd6b745
Merge pull request #5998 from hashicorp/do_5895
...
allow users of AWS to use the dynamically-generated admin password wh…
2018-03-22 16:01:22 -07:00
95aa7e67bd
Merge pull request #5893 from neumayer/privateip
...
Allow using private ip addresses for oracle oci builder
2018-03-22 09:42:19 -07:00
61432cd257
Update logs to talk about IP instead of public IP
...
When logging we don't know whether we use a private or public ip, just
the ip itself.
2018-03-22 09:08:25 +01:00
1f4212efa7
builder/openstack: Add instance_name config to OpenStack builder
...
RFC952 restricts hostname not to use underline(_) and period(.), so
private cloud with legacy DNS system does not allow just to use
image_name for name of server.
Add instance_name config option for servers which packer creates to
make instance_name configurable. If instance_name is not specified,
by default it works like the past using image_name for instance_name.
2018-03-22 11:20:14 +09:00
ef4f3f143b
Merge pull request #5985 from AndiDog/f-5979-vmware-fusion-guestip-lookup-multiple-devices
...
Handle multiple devices per VMware network type
2018-03-21 17:12:36 -07:00
eb201724c1
azure: unit tests for naming temp resources
2018-03-20 16:20:11 -07:00
c877312a4d
builder/triton: Add support to Skip TLS Verification of Triton URL
...
In order to allow Packer to connect to Private Triton installations
we now expose `insecure_skip_tls_verify` which, if set to true, will
allow the user to make requests to Triton installations that use a
certificate not signed by a trusted root CA
2018-03-20 22:10:12 +02:00
4f5e7fe060
first pass at allowing configurable sleep timeouts, profiles, and launch configs
2018-03-20 19:30:46 +00:00
aa54f908ed
Merge pull request #6019 from hashicorp/fix-aws-credentials
...
Fix aws credentials
2018-03-19 10:13:09 -07:00
49958391b3
better error when source_path doesn't exist.
2018-03-19 09:58:39 -07:00
b16f2ec64b
builder/amazon: Use sdk default cred providers
...
I think we were overcomplicating things. The SDK provides the correct
credential chain by default, so let's use that. This patch does a quick
check for static credentials and uses those if found, then defaults to
the default credential provider chain.
This patch also removes the metadata timeout argument. Current versions
of the SDK have short timeouts by default, so I don't believe this is
needed.
2018-03-15 16:49:47 -07:00
e483087574
builder/amazon: Use service default retries.
...
Each service has its own preconfigured number of times to retry.
Lets use that instead of setting a global number.
2018-03-14 22:26:35 -07:00
d689e6b4d3
allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.
2018-03-14 15:58:12 -07:00
414dd80e61
Merge pull request #6013 from jsoref/spelling
...
Spelling
2018-03-14 09:50:27 -07:00
27dfe92f1c
spelling: virtualization
2018-03-14 03:29:14 +00:00
0171dfc890
spelling: validating
2018-03-14 03:28:19 +00:00
b81672c906
spelling: valid
2018-03-14 03:28:00 +00:00
33f90d7783
spelling: unmarshalling
2018-03-14 03:27:22 +00:00
3b694feabc
spelling: transfer
2018-03-14 03:25:35 +00:00
5a393d4fac
spelling: template
2018-03-14 03:24:51 +00:00
c563ef0797
spelling: structure
2018-03-14 03:23:56 +00:00
007930ec2d
spelling: restricted
2018-03-14 03:20:51 +00:00
aae5b50dab
spelling: response
2018-03-14 02:19:26 +00:00
8294c8bc66
spelling: receive
2018-03-14 02:19:01 +00:00
fa36e1d961
spelling: processing
2018-03-14 02:17:22 +00:00
8c72bba160
spelling: possible
2018-03-14 02:14:18 +00:00
aeb25d2c61
Merge pull request #5991 from evandbrown/google-disable-default-service-account
...
builder/googlecompute: Optionally disable service account
2018-03-13 13:39:08 -07:00
7eda44d28c
builder/googlecompute: disambiguate disable_default_service_account
...
This change requires 'disable_default_service_account=false' in order to
set 'service_account_email'.
This is a guard against an incorrect assumption
that disabling the default service account would mean that no service
account would be used.
2018-03-13 12:39:41 -07:00
2de0652eb4
Merge pull request #6003 from boumenot/pr-azure-support-force
...
azure: respect -force for managed image deletion
2018-03-13 09:47:16 -07:00
18f51e7338
spelling: parameters
2018-03-13 08:29:17 +00:00
61030c0d85
spelling: output
2018-03-13 08:27:26 +00:00
e43b8de3b1
spelling: network
2018-03-13 08:14:30 +00:00
d987fcefc3
spelling: multiples
2018-03-13 08:12:53 +00:00
cab8b6ed68
spelling: maximum
2018-03-13 08:10:20 +00:00
73d3d65b84
spelling: marshal
2018-03-13 08:10:01 +00:00
964d5dd55e
spelling: mapstructure
2018-03-13 08:09:41 +00:00
ae4abedfa2
spelling: mandatory
2018-03-13 08:10:59 +00:00
933ac20e68
spelling: instance
2018-03-13 08:04:50 +00:00
62f59662a3
spelling: installation
2018-03-13 08:04:40 +00:00
1e99dce12b
spelling: inertness
2018-03-13 08:05:14 +00:00
3a31baae4f
spelling: incorrect
2018-03-13 08:00:05 +00:00
57c0e9e4a7
spelling: illegal
2018-03-13 08:02:43 +00:00
210f8e8312
spelling: hyphen
2018-03-13 07:59:00 +00:00
24b4c36fc9
spelling: function
2018-03-13 07:52:02 +00:00
dc942a0d8a
spelling: first
2018-03-13 07:50:00 +00:00
466f0d2be4
spelling: firewall
2018-03-13 07:49:46 +00:00
041a115f65
spelling: existent
2018-03-13 08:15:56 +00:00
33bf6de921
spelling: exceeds
2018-03-13 07:46:49 +00:00
04d6bfc696
spelling: environment
2018-03-13 07:41:21 +00:00
9b9ab4c492
spelling: encrypt
2018-03-13 07:41:47 +00:00
83471c8399
spelling: doesn't
2018-03-13 07:39:58 +00:00
60ef3c3374
spelling: directories
2018-03-13 07:37:32 +00:00
939e7d5587
spelling: delete
2018-03-13 07:36:38 +00:00
efb525f03d
spelling: creating
2018-03-13 07:22:37 +00:00
935c8e9a28
spelling: configuration
2018-03-13 08:19:16 +00:00
47a4bbd9f5
spelling: compaction
2018-03-13 07:22:09 +00:00
5010bfda39
spelling: comes
2018-03-13 07:20:55 +00:00
f362789174
spelling: because
2018-03-13 07:15:08 +00:00
7895051962
spelling: attribute
2018-03-13 07:12:16 +00:00
75a7ceec48
spelling: alicloud
2018-03-13 07:09:12 +00:00
fe98bcc5a1
spelling: address
2018-03-13 07:07:10 +00:00
8481663d4a
Merge pull request #6005 from boumenot/pr-azure-randomize-resource-names
...
azure: support concurrent deployments in the same resource group
2018-03-12 17:00:44 -07:00
5055fa66aa
Merge pull request #5987 from mcandre/multibyte-scancodes
...
send multibyte scancodes accurately to virtualbox
2018-03-12 16:23:41 -07:00
2a88672cd9
add test for modifyer keypress commands
2018-03-12 15:08:30 -07:00
3207ffbd9a
Merge pull request #6002 from mcandre/fix-6001
...
fix later commands overwriting earlier commands
2018-03-12 15:07:43 -07:00
2a21032964
azure: randomize NIC and Public IP names
2018-03-11 20:47:45 -07:00
149ce52079
azure: respect -force for managed image deletion
2018-03-10 10:43:28 -08:00
1d48812b34
fix later commands overwriting earlier commands
2018-03-09 20:17:43 -06:00
b1eaaed6fb
Merge pull request #5970 from boumenot/pr-azure-plan-info
...
azure: support for marketplace plan information
2018-03-09 15:21:03 -08:00
1ef491d4c8
incorporate reviewer feedback
2018-03-08 22:43:26 -08:00
4a2c124ea2
builder/googlecompute: Optionally disable service account
...
The ability to use a service account other than the default was
introduced in #5928 . This change adds to that by introducing the
'disable_default_service_account' config option. If true - and
'service_account_email' is not set - Packer will create a GCE VM
with no service account.
2018-03-07 20:53:26 -08:00
f305a2f4c2
send multibyte scancodes accurately to virtualbox
2018-03-07 10:59:02 -06:00
ff92fb883d
Handle multiple devices per VMware network type
...
Fixes #5979
2018-03-07 10:59:55 +01:00
ac2e02b938
remove loglines that should not have made it onto master
2018-03-06 14:12:39 -08:00
97060d100c
Merge pull request #5928 from kri5/service_account_gce
...
Builder GoogleCompute: Allows to specify GCE service account build VM
2018-03-06 13:41:33 -08:00
d3f1b501c6
Merge pull request #5975 from arizvisa/GH-5961
...
Disable the usage of the XHCI bus for USB on the vmware-iso builder.
2018-03-06 09:48:38 -08:00
df6cdcc7f7
Disable the usage of the XHCI bus for USB on the vmware-iso builder.
...
Some platforms with incomplete XHCI implementations (i.e. FreeBSD)
will poll the bus despite there being no usb devices available.
This disables XHCI by default and documents how to enable it using
the vmx_data option.
This closes issue #5961 .
2018-03-05 20:58:43 -06:00
980c777000
Merge pull request #5960 from LessMo/master
...
builder/amazon: Added new region cn-northwest-1
2018-03-05 17:41:12 -08:00
585e31e47a
Merge pull request #5974 from boumenot/pr-azure-better-error-message
...
azure: better error message
2018-03-05 17:28:50 -08:00
d2e593de37
azure: support for marketplace plan information
2018-03-05 09:05:21 -08:00
8166ba2d8d
azure: better error message
2018-03-04 21:21:02 -08:00
e0ac07f5db
azure: correct function name spelling
2018-03-03 08:53:10 +00:00
DanHam
Matthew Hooker
Andrew Pryde
Anshul Sharma
xxx
James Nugent
Sander van Harmelen
Sergio Millan Rodriguez
Mark Meyer
Megan Marsh
Christopher Boumenot
Mike
Michael Gibson
Edouard Bonlieu
Conrad Jones
Julien BONACHERA
Owain Lewis
Bob Brumfield
Harvey Lowndes
willmao
Alexander Georgievskiy
EC2 Default User
Pavel Vasilevich
Ali Rizvi-Santiago
Hariharan Jayaraman
Rickard von Essen
deepuashokan85
Rémy Léone
Paul Meyer
Christopher Boumenot
Chris Lundquist
Matt Coleman
Unknown
Stefan Henseler
Paul Meyer
Oskar Wycislak
AlessioT
Adam Robinson
Ali Rizvi-Santiago
Matthew Donoughe
Richard Nienaber
Evgeni Golov
Seth Vargo
ADO
Omer Katz
Andrew Pennebaker
Joseph Wright
Yang Youseok
stack72
Josh Soref
Evan Brown
Andreas Sommer