2e989088e5
amazon-ebssurrogate: allow enabling ena/sr-iov on spot instances
2019-11-21 11:13:32 +01:00
08e97ba4d8
generate code for no_ephemeral option
2019-11-20 13:49:04 -08:00
0e2bdc8be6
forcibly prevent ephemeral drives from being created in the amazon-ebs builder, when no_ephemeral is set
2019-11-20 13:42:14 -08:00
b40e5d90b6
builder/amazon/common/step_pre_validate: Return DescribeVpcs errors
2019-11-19 20:18:53 +00:00
afb880c134
test/builder/amazon/common/step_pre_validate: Update DescribeVpcs mock
...
* Update condition to check for a empty VpcId
2019-11-19 14:48:07 -05:00
074be9942d
Only validate the user has provided a subnet_id when vpc_id has been set
2019-11-19 14:09:58 +00:00
3571c585bb
builder/googlecompute: fix dropped error ( #8385 )
2019-11-19 11:41:39 +01:00
ad74a87b5c
Merge pull request #8360 from hashicorp/fix-7167
...
builder/amazon: Add validation for `subnet_id` when specifying `vpc_id`
2019-11-18 16:50:11 -05:00
f9f4726eff
builder/amazon/step_pre_validate: Add check for non-default VPCs
...
Subnet information is only really needed when the specified `vpc_id` is
not the default VPC for the region where the builder is being executed.
This change uses the AWS API to determine if the VPC provided is a
non-default VPC and only validates the existence of a `subnet_id` if a
user has provided a non-default `vpc_id`.
Tests after change
```
> make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc'
...
=== RUN TestStepPreValidate_checkVpc
=== RUN TestStepPreValidate_checkVpc/DefaultVpc
=== RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet
=== RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet
=== RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc
=== RUN TestStepPreValidate_checkVpc/NoVpcInformation
--- PASS: TestStepPreValidate_checkVpc (0.00s)
--- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s)
--- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s)
--- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s)
--- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s)
--- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s)
PASS
...
```
2019-11-18 16:44:09 -05:00
ef137a8f08
Merge pull request #8380 from bennu/qemu-args
...
fix: persist default drive/device
2019-11-18 11:05:45 -08:00
dfa134cd98
ditch else statement for improved clarity
2019-11-18 10:11:59 +01:00
ce8bca349f
Update builder/amazon/ebs/step_create_ami.go
...
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
2019-11-18 10:11:59 +01:00
a35ac0127e
fix bug in step_region_copy
2019-11-18 10:11:59 +01:00
30ccab472f
fix: persist default drive/device
2019-11-17 04:38:30 -03:00
437983343a
Merge pull request #8371 from stephentawn/master
...
Fix error message when ovftool is missing
2019-11-14 16:07:12 -08:00
c66219084e
Fix error message when ovftool is missing
2019-11-14 23:11:16 +00:00
59472c6aad
builder/lxc: fix dropped error
2019-11-14 13:40:40 -08:00
488e539f63
builder/amazon: Add helper function for checking against AWSError
...
Replace all straight forward occurrences of `if err, ok := err.(awserr.Error)` with the `isAWSErr` helper function
2019-11-12 15:27:47 -05:00
4c9cfed743
builder/ncloud: fix dropped error
2019-11-11 20:56:55 -08:00
418152f23a
builder/digitalocean: fix dropped error on RSA key generation
2019-11-08 10:35:48 -08:00
643fce7b8a
builder/hcloud: handle dropped ssh errors
2019-11-08 11:35:58 +01:00
db4f242a24
go generate ./builder/qemu after #7676
2019-11-08 11:27:00 +01:00
6e2456d028
make error messaging around ResourceNotReady better, update docs with other possible issues ( #8349 )
2019-11-08 11:15:24 +01:00
98c94ab8cb
Merge pull request #7676 from ltrager/master
...
Add display template option for qemu.
2019-11-07 15:41:17 -08:00
e70e82d892
Merge pull request #8342 from cove/retry-runinstances2
...
retry runinstances aws api that wasn't retried
2019-11-07 15:39:02 -08:00
f2f544c434
fixed get copy region value ( #8345 )
2019-11-07 11:12:19 +01:00
d5ba530b26
make it clear we expect pem format not some other formate ( #8344 )
2019-11-07 10:30:51 +01:00
5f02150e05
builder/vmware/common: defer close after testing for errors
2019-11-06 14:28:17 -08:00
2898d66812
retry runinstances aws api that wasn't retried and could fail
2019-11-06 14:06:35 -08:00
a36b94320a
virtualbox: simplify ParseSnapshotData
2019-11-06 10:24:20 +01:00
5a0dc48f0f
builder/file: defer close after testing for errors
2019-11-05 11:40:42 -08:00
116a038de9
Update snapshot.go
...
avoid a panic on a too short slice.
2019-11-05 15:48:32 +01:00
44a7c49334
Merge pull request #8320 from hashicorp/do_8228
...
re-add backwards incompatible changes to 1.5.0
2019-11-05 14:40:48 +01:00
ee6b72570b
Update builder.hcl2spec.go
2019-11-05 14:21:07 +01:00
5692294a96
use absolute path for vagrantfile to avoid confusion with build directory later
2019-11-04 15:15:37 -08:00
6c704f7046
Revert "fix template imports"
...
This reverts commit 0e70e0e5a4
2019-11-04 14:29:00 -08:00
d010762dbf
Revert "Revert "Qemu builder disk size as a string""
...
This reverts commit 9c782f4d04
2019-11-04 14:28:48 -08:00
517834d528
Revert "Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name""
...
This reverts commit 44f91c9afc
2019-11-04 14:28:40 -08:00
14243ce56a
Merge pull request #8305 from hashicorp/fix_8301
...
allow nvme, since virtualbox 6.0 allows it
2019-11-04 17:58:18 +01:00
c935eb1435
Merge pull request #8308 from alrs/prune-dead-linode-func
...
builder/linode: remove unused sshConfig() and associated import
2019-11-04 15:57:29 +01:00
a23801d4a9
builder.virtualbox.iso: document that EFI mode needs to be enabled for pcie/nvme to work too
2019-11-04 14:30:59 +01:00
9924d16fc3
builder/vmware/common: remove unused testHWConfig()
2019-11-01 19:13:26 -07:00
6eefe55e23
builder/vmware/iso: remove unused testState()
2019-11-01 19:11:42 -07:00
af1e41793d
builder/linode: move commHost() out of orphaned ssh.go
2019-11-01 19:02:52 -07:00
9dad09b9d3
builder/linode: remove unused sshConfig() function and associated import
2019-11-01 18:58:14 -07:00
fcb65ee422
Merge pull request #8307 from hashicorp/fix_8116
...
delete amazon import post-processor intermediary snapshots
2019-11-01 14:55:22 -07:00
e9e4c102e5
delete amazon import post-processor intermediary snapshots
2019-11-01 14:17:44 -07:00
974eba443a
update docs to include warning about extension pack
2019-11-01 09:48:35 -07:00
b790776096
vbox iso: use NVMe Controller when the hard drive interface if pcie
2019-11-01 14:43:59 +01:00
86e24df947
Merge pull request #8304 from alrs/remove-dead-openstack-test-function
...
builder/openstack: remove dead testConfig() function
2019-11-01 11:06:50 +01:00
1b7ef252d2
Merge pull request #8303 from alrs/amazon-builder-cleanup
...
Cleanup builder/amazon/common
2019-11-01 11:06:06 +01:00
6f54468dd5
fix mocks
2019-10-31 15:36:22 -07:00
65ad3105b3
udpdate generated code
2019-10-31 15:28:36 -07:00
9343a23021
add driver calls to enable nvme controller
2019-10-31 15:21:52 -07:00
d2867c47f0
allow nvme, since virtualbox 6.0 allows it
2019-10-31 14:43:46 -07:00
b68c75ea3e
builder/openstack: remove dead testConfig() function
2019-10-31 13:36:00 -07:00
d072079899
builder/amazon/common: remove dead test type and function mockEC2Conn_Modify_EBS.ModifyInstanceAttribute()
2019-10-31 12:38:32 -07:00
953be1603b
builder/amazon/common: remove dead test type and function mockEC2ConnSpot.DescribeSpotPriceHistory()
2019-10-31 12:34:11 -07:00
7a09f9c678
builder/amazon/common: remove dead test function fakeModifyEBSBackedInstanceState()
2019-10-31 12:22:10 -07:00
0a13b620d6
builder/amazon/common: remove dead test function StepModifyEBSBackedInstance_EnableAMIENASupport()
2019-10-31 12:19:28 -07:00
c74df8b652
builder/amazon/common: remove dead test function getMockConnSpot()
2019-10-31 12:15:53 -07:00
e5e2bfa83f
builder/amazon/common: remove nil check on slice, len() on nil slices is zero
2019-10-31 12:09:32 -07:00
1efd86e809
Linode: remove unused StateTimeout field
2019-10-31 16:13:06 +01:00
819329228a
Change back to make sure all durations are a time.Duration
...
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:
* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
2019-10-31 16:12:07 +01:00
bf3d9841c6
Force durations to be passed a strings
...
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
2019-10-31 11:47:19 +01:00
ada9821897
Merge pull request #8294 from hashicorp/do_7974
...
add insert_key option for toggling whether to add Vagrant's insecure key
2019-10-31 10:27:27 +01:00
2fa79c6086
fix tests
2019-10-30 13:48:12 -07:00
8f996cd4de
update docs
2019-10-30 13:36:56 -07:00
3b3aa562ed
add insert_key option for toggling whether to add Vagrant's insecure key
2019-10-30 13:27:34 -07:00
553ca2e15d
Merge pull request #8293 from alrs/fix-azure-chroot-dropped-err
...
builder/azure/chroot: fix dropped error
2019-10-30 13:13:25 -07:00
ca64cc1237
Merge pull request #8261 from shawnmssu/feature/ucloud_import
...
Packer Post-Processor support UCloud import
2019-10-30 13:11:55 -07:00
6862e3534f
builder/azure/chroot: fix dropped error
2019-10-30 11:14:32 -07:00
6191b9c8c6
Merge pull request #8288 from hashicorp/fix_8271
...
add some extra layers of validation to make sure that people don't tr…
2019-10-30 10:41:52 -07:00
d084cd1895
Update builder/amazon/common/ami_config.go
2019-10-30 09:41:23 -07:00
d915618819
Merge pull request #8289 from hashicorp/test_filter_builder
...
add test to catch this case
2019-10-30 10:34:58 +01:00
545575b879
optimize code about ufile config
2019-10-29 16:11:44 -07:00
37e898e115
optimize code style
2019-10-29 16:11:44 -07:00
9de1c42ad4
fix ucloud builder acctest
2019-10-29 16:11:44 -07:00
a4f95c8e7d
fux gebeaj
2019-10-29 16:11:44 -07:00
2c513fce64
update ucloud packer
2019-10-29 16:11:43 -07:00
61f9d3a9fe
add ucloud import
2019-10-29 16:11:43 -07:00
e9f02e44cb
add test to catch this case
2019-10-29 11:28:56 -07:00
7cf47fc463
add some extra layers of validation to make sure that people don't trip over magical encrypt_boot settings later in the build
2019-10-29 11:26:22 -07:00
5da5b00e1c
[builder/openstack] adds option to discover provisioning network
2019-10-29 13:02:27 -04:00
8b6f1358fb
Merge pull request #8281 from alrs/fix-builder-oneandone-errors
...
builder/oneandone: fix dropped errors
2019-10-29 12:25:27 +01:00
b2b12d6b04
Merge pull request #8280 from blinohod/cloudstack-display-name
...
[WIP] Add instance_display_name for cloudstack builder
2019-10-29 12:19:50 +01:00
e2283445f2
need to initialize variables scoped to the individual loop, because the address of k,v stay the same and that means we overwrite previous variables when assigning them to the struct directly.
2019-10-28 14:31:13 -07:00
6f7693577d
builder/oneandone: fix dropped errors
2019-10-28 08:25:48 -07:00
da7e72246c
Add instance_display_name parameter for Cloudstack builder
...
This change introduce instance_display_name optional parameter
for Cloudstack builder to set custom VM display name.
By default it is set to "Created by Packer".
2019-10-26 21:13:45 -07:00
0cb098b713
regenerate code because of hyperv refactor
2019-10-25 09:52:37 -07:00
2d01b3b7ab
Merge pull request #8274 from hashicorp/fix_8264
...
Make Vagrant driver code pass through logs as it receives them rather…
2019-10-24 14:38:53 -07:00
a783a09ea3
Merge pull request #8269 from paulmey/paulmey/generalize-chroot
...
[amazon/chroot] Move common/generic chroot builder steps to common directory
2019-10-24 14:32:01 -07:00
a7be0bed30
Make Vagrant driver code pass through logs as it receives them rather than buffering and returning them all at the end of the call.
2019-10-24 13:12:35 -07:00
eccdb44e3b
Merge pull request #8246 from hashicorp/fix_8089
...
Add the additional_disk_size option tho the hyperv vmcx builder.
2019-10-24 11:50:58 -07:00
7928b5b045
fix transcription error from when we moved to generated docs
2019-10-24 10:19:03 -07:00
3be7d81ce2
Move common steps together
2019-10-24 04:21:46 +00:00
e6dfe301ac
Move CommandWrapper & ShellCommand to common
2019-10-24 04:06:29 +00:00
1731f87ad0
Merge pull request #8186 from puetzk/issue8178
...
fix: set openstack metadata for use_blockstorage_volume
2019-10-23 12:53:30 -07:00
436e21ae15
Merge branch 'master' into pr/8186
2019-10-23 12:08:02 -07:00
b54a2ee09d
Set correct user agent for Azure clientset
2019-10-23 11:31:29 -07:00
Anthony Dong
Megan Marsh
DanHam
nywilken
Lars Lehtonen
bugbuilder
Stephen Tawn
Adrien Delorme
Li Kexian
cove
Adrien Delorme
mingsheng.su
Andrey Kaipov
Michael Bochkaryov
Paul Meyer