nywilken
5a54c99e98
post-processor/vagrant-cloud: Update error handling for VagrantCloud API responses
...
This change updates the underlying type of VagrantCloudErrors.Errors to match the expected errors response type and adds a simple test to verify the parsing of various error responses.
Tests before change
```
--- FAIL: TestVagranCloudErrors (0.00s)
client_test.go:23: failed to decode error response: json: cannot unmarshal array into Go struct field VagrantCloudErrors.errors of type map[string][]string
client_test.go:23: failed to decode error response: json: cannot unmarshal array into Go struct field VagrantCloudErrors.errors of type map[string][]string
client_test.go:26: failed to get expected response; expected "", got "error1. error2"
client_test.go:23: failed to decode error response: json: cannot unmarshal array into Go struct field VagrantCloudErrors.errors of type map[string][]string
client_test.go:26: failed to get expected response; expected "", got "message Bad credentials"
```
Test after change
```
--- PASS: TestVagranCloudErrors (0.00s)
```
2020-01-13 11:55:53 -05:00
Pit
d7d00d8069
Fix regression in docker-tag post-processor ( #8593 )
...
GH-8392 introduced the feature that multiple tags can be specified. This
(presumably inadvertently) broke the option to tag an image without the
actual tag specified -- Docker handles this by assuming `latest` as the
tag.
In addition, use-cases exist for the `repository` field containing the
tag already, which was also broken.
2020-01-13 11:41:52 +01:00
Sylvia Moss
d6a351b173
Rename communicator config variables and remove deprecated code ( #8584 )
2020-01-09 08:37:30 -08:00
Sylvia Moss
baa203bb53
Adds acpi_shutdown to virtualbox builder ( #8587 )
2020-01-09 08:36:19 -08:00
Moss
6a2d73a0e9
Add missing doc variable description
2020-01-08 15:28:53 -08:00
Megan Marsh
e87aa237dd
Get plugin up to parity with v1.5.0. Remove custom jetbrains-internal testing logic; disable acceptance tests (for now) until we can set up a test rig inside of HashiCorp. Regenerate code based on vendoring changes.
2020-01-08 14:41:51 -08:00
Hanjie Wang
d9a128a375
In Vagrant post-processor, check whether the host system is able to create a dummy Vagrant box before processing ( #8431 )
2020-01-08 11:33:39 -08:00
Megan Marsh
49a33c04cd
Merge pull request #8511 from TJM/vsphere_template_markas
...
[post-processor/vsphere-template] Simplify method to use vm.MarkAsTemplate (optionally)
2020-01-08 09:41:43 -08:00
Shengyu Liu
c3c2622204
builder/tencentcloud: Correct the image name length validation, the max length of image name is 60 ( #8536 )
2020-01-08 12:05:37 +01:00
Megan Marsh
073eda76aa
remove extraneous files from when vsphere builder was a plugin, and move README into packer website as separated docs for vsphere-clone and vsphere-iso. Move option descriptions into struct code, and generate documentation directly from those structs as we do inside of the other builders
2020-01-07 16:59:31 -08:00
Tommy McNeely
e469140678
workaround for mapstructure-to-hcl2 and booleans
2020-01-07 16:58:40 -07:00
Megan Marsh
8cb1f7b1c1
Merge branch 'master' into merge-vsphere-builder
2020-01-07 14:23:38 -08:00
Megan Marsh
3c5ce79c2f
add @alexyueer to codeowners for alicloud
2020-01-07 12:48:38 -08:00
Megan Marsh
eeac289fa5
Merge pull request #8535 from alexyueer/master
...
fix issue #8534
2020-01-07 12:47:23 -08:00
Megan Marsh
21edd085c7
Merge pull request #8560 from alexyueer/feature/support_aliyun_profile_20200103
...
support aliyun profile
2020-01-07 12:45:54 -08:00
Megan Marsh
e9bb81a440
Merge pull request #8578 from hashicorp/unstick_vmware_shutdown_tests
...
bump the timeout to a very high level to protect against laggy CI mac…
2020-01-07 12:44:48 -08:00
Megan Marsh
7d789a1483
Merge pull request #8579 from hashicorp/do_8562
...
step_download: return without error if Urls is empty
2020-01-07 12:01:24 -08:00
Megan Marsh
c446bf07c5
Merge pull request #8574 from hashicorp/fix_8541
...
Fix 8541
2020-01-07 12:00:27 -08:00
Megan Marsh
9903c4bdd1
update changelog
2020-01-07 11:55:59 -08:00
Megan Marsh
90bdcf58bd
update step_download to return an ActionContinue if the URls field is empty. this allows us to simplify the hyperv builder, and is still safe because all other builders and uses of step_download already validate that the iso url is not empty if that's what they need, most of them inside of the IsoConfig prepare function.
2020-01-07 10:45:24 -08:00
Megan Marsh
be3c1ef106
bump the timeout to a very high level to protect against laggy CI machines
2020-01-07 09:59:25 -08:00
Megan Marsh
af2c4346f8
Merge pull request #8561 from ata18/ata18-end-of-life
...
Set expiry for image versions in SIG
2020-01-07 09:53:14 -08:00
Megan Marsh
72076922a6
Merge pull request #8576 from hashicorp/fix_8575
...
virtualbox/vm.Builder: use config as a non pointer to avoid a panic
2020-01-07 09:32:53 -08:00
Megan Marsh
8ebd3a9acb
Merge pull request #8567 from rgl/fix-handle-libvirt-qemu-disk-size-string
...
correctly handle the diskSize property as a qemu size string
2020-01-07 09:29:26 -08:00
Adrien Delorme
7b5a868de2
virtualbox/vm.Builder: use config as a non pointer to avoid a panic
...
this is a continuation to #8513
2020-01-07 16:55:50 +01:00
Adrien Delorme
13ea97a1df
mapstructure-to-hcl2: make basic named types pointers ( optional )
2020-01-07 12:46:27 +01:00
Adrien Delorme
d8c3385814
hcl2template/mock.go: add fields with named types
2020-01-07 12:45:42 +01:00
Adrien Delorme
dc5bde97d7
log& skip field if struct tag parse did not work
2020-01-07 12:11:50 +01:00
Adrien Delorme
731904d3d2
mapstructure-to-hcl2: use accessor for named types and not named type + go genrate + tests
2020-01-07 11:44:22 +01:00
Megan Marsh
be97507088
delete qmp socket path. Also, clean up unnecessary use of statebag to recieve step values. ( #8572 )
2020-01-07 11:18:01 +01:00
hairesis
bb71db6b39
docs/provisioners/ansible: Add playbook to basic example. ( #8508 )
2020-01-07 11:07:05 +01:00
Ricard Clau
b2578ee0f9
Fix typo in Synopsis for galaxycommand fixer ( #8573 )
2020-01-07 11:05:35 +01:00
Adrien Delorme
f828255103
Merge pull request #8569 from hashicorp/fix_8539
...
[Fix 8539] fix crash when build.sources is set to an invalid name
2020-01-07 11:03:37 +01:00
Aishwarya Thangappa
9f24869e36
Update the error handling for end-of-life-date parsing
2020-01-06 22:58:26 -08:00
Aishwarya Thangappa
9569d35d14
Set expiry for image versions in SIG
...
Updates azure builder to support setting end-of-life-date for
image versions in shared image gallery. In addition, this change adds
the ability to set the global replica count for the image version
and allows the vms deployed from the latest version of the Image
Definition to exclude this Image Version.
2020-01-06 22:58:26 -08:00
Tommy McNeely
e101676e29
Doc update for markAsTemplate
2020-01-06 15:55:01 -07:00
Tommy McNeely
7f7b54ea31
Use vm.MarkAsTemplate, optionally reregister
2020-01-06 15:34:50 -07:00
Megan Marsh
b7ee807cf1
Merge pull request #8571 from hashicorp/fix_8565
...
fix ssh interface docs for amazon builders
2020-01-06 14:34:40 -08:00
Megan Marsh
d95b0122f8
Merge pull request #8542 from TJM/plugin_logs
...
Parse out -PACKERSPACE- before looking for exec
2020-01-06 14:14:46 -08:00
Megan Marsh
6655f93b59
fix typo and regenerate code
2020-01-06 14:12:29 -08:00
Megan Marsh
e525d2bd6e
Merge pull request #8570 from hashicorp/fix_ansible_winrm
...
fix winrmpass sanitization to account for empty string value.
2020-01-06 14:06:33 -08:00
Megan Marsh
99caaf6cc2
Merge pull request #8543 from TJM/fix_external
...
Fix permission denied for external plugins, path was empty
2020-01-06 14:05:02 -08:00
Megan Marsh
7411a8a6ef
Merge pull request #8550 from tpounds/add-ami-owner-to-template
...
Add source AMI owner ID/name to build template
2020-01-06 13:38:49 -08:00
Tommy McNeely
469a4d2a11
Fix names of range variables to reduce confusion and remove overriden plugin name
2020-01-06 13:19:39 -07:00
Megan Marsh
76251e5fd2
fix ssh interface docs for amazon builders
2020-01-06 12:01:30 -08:00
Tommy McNeely
72112ccae2
Make the path assignment less confusing
2020-01-06 12:50:12 -07:00
Megan Marsh
4b9568e409
fix winrmpass sanitization to account for empty string value.
2020-01-06 10:07:30 -08:00
Adrien Delorme
79d7b3e636
regroup duplicate error message
2020-01-06 17:10:12 +01:00
Adrien Delorme
0102f5b6fa
remove unecessary inexistant block panic + add test
...
the hcl library will error for us
2020-01-06 16:56:42 +01:00
Lars Lehtonen
8098ba9cdf
builder/virtualbox/common: remove unused url variable ( #8559 )
2020-01-06 16:45:05 +01:00