Commit Graph

43 Commits

Author SHA1 Message Date
Adrien Delorme 840e67f775
HCL2: when we see a map generate an attribute spec instead of a block spec (#9035)
* mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec

this will alow to do

tags = {
 key = "value"
}

instead of

tags {
  key = "value"
}

This will also enable using variables directly for those tags

* generate code

* update tests
2020-04-14 16:05:13 +02:00
Wilken Rivera 9ec8b67392
Add golangci-lint to project (#8686)
* Add golangci-lint as linting tool

* Disable failing staticchecks to start; GitHub issue to handle coming soon

* Run `goimports -w` to repair all source files that have improperly
formatted imports

* makefile: Add ci-lint target to run on travis

This change adds a new make target for running golangci-lint on newly
added Go files only. This target is expected to run during Packer ci builds.

* .github/contributing: Add code linting instructions

* travis: Update job configuration to run parallel builds
2020-02-14 11:42:29 -05:00
Sylvia Moss 08b0bd1d2c
Fix HCL2 code generation for slices within another slice (#8669) 2020-02-03 17:03:28 +01:00
Sylvia Moss dc31bad539
Sharing info with post-processors via artifact (#8632) 2020-01-30 11:27:58 +01:00
Adrien Delorme 731904d3d2 mapstructure-to-hcl2: use accessor for named types and not named type + go genrate + tests 2020-01-07 11:44:22 +01:00
Adrien Delorme 4b7132c87c Merge remote-tracking branch 'origin/master' into sharing_info 2019-12-17 11:57:09 +01:00
Adrien Delorme 0785c2f6fc
build using HCL2 (#8423)
This follows #8232 which added the code to generate the code required to parse
HCL files for each packer component.

All old config files of packer will keep on working the same. Packer takes one
argument. When a directory is passed, all files in the folder with a name
ending with  “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format.
When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed
using the HCL2 format. For every other case; the old packer style will be used.

## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files

I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields

## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file.

  This is a breaking change for packer plugins.

a packer component can be a: builder/provisioner/post-processor

each component interface now gets a `ConfigSpec() hcldec.ObjectSpec`
which allows packer to tell what is the layout of the hcl2 config meant
to configure that specific component.

This ObjectSpec is sent through the wire (RPC) and a cty.Value is now
sent through the already existing configuration entrypoints:

 Provisioner.Prepare(raws ...interface{}) error
 Builder.Prepare(raws ...interface{}) ([]string, error)
 PostProcessor.Configure(raws ...interface{}) error

close #1768


Example hcl files:

```hcl
// file amazon-ebs-kms-key/run.pkr.hcl
build {
    sources = [
        "source.amazon-ebs.first",
    ]

    provisioner "shell" {
        inline = [
            "sleep 5"
        ]
    }

    post-processor "shell-local" {
        inline = [
            "sleep 5"
        ]
    }
}

// amazon-ebs-kms-key/source.pkr.hcl

source "amazon-ebs" "first" {

    ami_name = "hcl2-test"
    region = "us-east-1"
    instance_type = "t2.micro"

    kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c"
    encrypt_boot = true
    source_ami_filter {
        filters {
          virtualization-type = "hvm"
          name =  "amzn-ami-hvm-????.??.?.????????-x86_64-gp2"
          root-device-type = "ebs"
        }
        most_recent = true
        owners = ["amazon"]
    }
    launch_block_device_mappings {
        device_name = "/dev/xvda"
        volume_size = 20
        volume_type = "gp2"
        delete_on_termination = "true"
    }
    launch_block_device_mappings {
        device_name = "/dev/xvdf"
        volume_size = 500
        volume_type = "gp2"
        delete_on_termination = true
        encrypted = true
    }

    ami_regions = ["eu-central-1"]
    run_tags {
        Name = "packer-solr-something"
        stack-name = "DevOps Tools"
    }
    
    communicator = "ssh"
    ssh_pty = true
    ssh_username = "ec2-user"
    associate_public_ip_address = true
}
```
2019-12-17 11:25:56 +01:00
Megan Marsh 0f6d1beccf add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables. 2019-12-16 21:23:05 -08:00
Adrien Delorme 078ba7c8c3 commit old code generation tool
for history
2019-10-15 12:56:42 +02:00
Marin Salinas e634caee0a remove chroot acc test 2019-07-18 12:07:08 -05:00
Marin Salinas 7e23f14d4e fix: chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas dc0db4b322 fix: change osc builder to be passed a context for cancellation and remove conflicts 2019-07-18 09:39:08 -07:00
Marin Salinas ed2d2b9058 refactor: clean duplicate files with aws chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas 488535118d refactor: change validation when bsu is set 2019-07-18 09:39:08 -07:00
Marin Salinas 6820806436 refactor: add err check in create tags 2019-07-18 09:39:08 -07:00
Marin Salinas f28c3877e3 refactor: remove unused attributes 2019-07-18 09:39:08 -07:00
Marin Salinas 4b52816935 fix: go modules conflicts 2019-07-18 09:39:08 -07:00
Marin Salinas 810e30e8e1 refactor: fix symlink issue on ubuntu 2019-07-18 09:39:08 -07:00
Marin Salinas 8b8eb70e19 feature: add create tags to volume 2019-07-18 09:39:08 -07:00
Marin Salinas db2832d80c fix: change name of dirs 2019-07-18 09:39:08 -07:00
Marin Salinas 683431afa2 fix acceptance test configuration 2019-07-18 09:39:08 -07:00
Marin Salinas 9d6c4a8e5b feature: add remaining steps and and create artifact in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas 70d2ff3d8a feature: add create omi step in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas 6843b64331 feature: add eartly cleanup and snapshot steps in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas 352972a33d feature: add chroot provision step in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas 31367ff768 feature: add copy files step in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas 07b1580003 feature: add mount extra step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas b3d165e864 feature: add post mount commands step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas 6e6bdc4f42 feature: add mount device step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas 00ab0097de feature: add pre mount commands step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas 0f51ab5c08 feature: add early unflock step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas b3310f65a6 feature: add link volume step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas f1e5dafc71 fix: convert volume size to Gib before volume creation 2019-07-18 09:39:07 -07:00
Marin Salinas b246bf7329 wip: add create_volume step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas b7f8c6ad9d feature: add prepare device for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas bf2d66c4e6 feature: add file lock step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas 66cf27fe31 feature: add step check root device step in chrrot builder 2019-07-18 09:39:07 -07:00
Marin Salinas bc907f0fd0 feature: add vm info step 2019-07-18 09:39:07 -07:00
Marin Salinas a3b0c28bb6 test: add acceptance basic test for outscale chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas 2f87427fd4 feature: add chroot build prepare function implementation 2019-07-18 09:39:07 -07:00
Marin Salinas 0d5ce8b9b9 feature: add chroot build cancel function implementation 2019-07-18 09:39:07 -07:00
Marin Salinas 30d5b1f7c2 feature: add chroot builder configuration 2019-07-18 09:39:07 -07:00
Marin Salinas 0c47ee55e6 feature: add chroot builder structure 2019-07-18 09:39:07 -07:00