Commit Graph

15138 Commits

Author SHA1 Message Date
Megan Marsh 082d806b1f fix httpip acquisition 2020-05-21 09:39:54 -07:00
Wilken Rivera 2e326ef334 Switch back to call operator as opposed to dot sourcing
* Ensure child scope doesn't conflict with parent scope
* Add elevated user options to tests case.
2020-05-21 09:07:55 -04:00
Wilken Rivera 38f799df3e Add conditional to check if LastExitCode is defined
* Add broken requires statement test case
* Add test case to reproduce invalid LastExitCode
2020-05-21 09:07:43 -04:00
Wilken Rivera 35df3914d2 provisioner/powershell: Update default execute command to handle script errors
This change sets the ErrorActionPreference and wraps the script execution in a Try/Catch statement so that the provisioner can capture any errors encountered when running the script. In addition to the try/catch the `&` operator is replaced by the `.` sourcing operator to ensure the script is executed in the same scope as the parent command (so that errors bubble up properly).

Tests after change
```
⇶  ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test ./provisioner/powershell/... -timeout=1h
ok      github.com/hashicorp/packer/provisioner/powershell      915.865s
```
2020-05-21 09:05:43 -04:00
Wilken Rivera 13e0c1a097 tests/provisioner/powershell: Add acceptance test to reproduce issue 4916 2020-05-21 09:05:43 -04:00
Rui Lopes 06fad6cc4f qemu: add support for using a network bridge 2020-05-20 16:46:32 -07:00
Megan Marsh 6ad67f6800 update changelog 2020-05-20 15:10:40 -07:00
Megan Marsh b3ece95f27
Merge pull request #9254 from ad-m/hyperone-builder-hcl
HCL compliance for HyperOne builder
2020-05-20 13:15:21 -07:00
Megan Marsh 782342a707
Merge pull request #9202 from overdrive3000/improve-secrets-manager
Add support for specifying key to fetch from AWS Secrets Manager
2020-05-20 13:13:28 -07:00
Sylvia Moss be9dbaacd7
Interpolate generatedData in the Inspec provisioner (#9262)
* Interpolate generatedData in the Inspec provisioner

* Add inspec license section to inspec docs

* add user arg if user config it not empty

* increase resource size for check-lint pipeline

* update changelog

* Update provisioner/inspec/provisioner.go

* Update provisioner/inspec/provisioner.go

Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-05-20 15:43:41 -04:00
Wilken Rivera c084be974b
Merge pull request #9264 from hashicorp/update-cty-funcs
Update github.com/hashicorp/go-cty-funcs to master
2020-05-20 15:10:09 -04:00
Megan Marsh 24dd7e9dbb
Merge pull request #9257 from hashicorp/azr-hcl2-use-source-type-and-name
HCL2: use source type and name as Name of a CoreBuild
2020-05-20 11:36:15 -07:00
Megan Marsh 3c782e9d03
Merge pull request #9239 from hashicorp/enable_artifice
Add Artifice postprocessor ID to valid artifacts for postprocessors t…
2020-05-20 10:46:44 -07:00
Adrien Delorme 5fdd1d1dee get github.com/hashicorp/go-cty-funcs@0d04eb807361 2020-05-20 15:51:34 +02:00
Adrien Delorme b01fb30c36 Update CHANGELOG.md 2020-05-20 12:28:13 +02:00
Adrien Delorme 1e8e8a4e45 Update CHANGELOG.md 2020-05-20 12:27:54 +02:00
Wilken Rivera d3aa53c9da
docs/hcl2: Update HCL2 beta note link (#9258)
This change updates the Beta notes on the Packer docs site with a link
to the pinned HCL2 implementations list issue.

Closes #9175
2020-05-20 12:24:45 +02:00
Megan Marsh 4041cb7775 generated code 2020-05-19 16:10:51 -07:00
Megan Marsh 1c214628ed
Merge pull request #9234 from hashicorp/hcl_force_and_debug
enable force, debug, and on-error for hcl2 builds
2020-05-19 16:02:06 -07:00
Megan Marsh 557eb015ea make artifice post-processor play nicely with vagrant post-processor, including template validation., Update docs for each. 2020-05-19 15:52:12 -07:00
Adam Dobrawy df86b14572
Add CODEOWNERS of bats tests (#9259) 2020-05-19 15:05:57 -04:00
Megan Marsh 58b32ebefa
Merge pull request #9251 from hashicorp/fix_9249
builder/azure-arm: Update runtime constants with a valid DataDiskName
2020-05-19 11:00:44 -07:00
Adrien Delorme 1ddf2a7d05 Update types.packer_config_test.go 2020-05-19 17:35:24 +02:00
Adrien Delorme d431db0a38 HCL2: use source type and name as Name of a CoreBuild 2020-05-19 17:22:04 +02:00
Wilken Rivera 3cd13ae1e5
update changelog
Add 9238 to list of bug fixes
2020-05-19 11:05:59 -04:00
Wilken Rivera 508f6497bb
update changelog
Minor formatting changes
2020-05-19 10:40:51 -04:00
Wilken Rivera fd0a511eb2 update changelog 2020-05-19 10:37:19 -04:00
jhawk28 820f353573
(vsphere-iso) remove deprecated network and disk fields (#9149)
* remove deprecated network and disk fields
2020-05-19 10:06:12 -04:00
Juan Mesa b73602eadd Fix corrections
* Fix typos in comments.
* Add documentation of how to use multiple keys with `aws_secretsmanager` function.
* Move `Client` struct to `secretsmanager.go` file.
2020-05-19 13:16:28 +02:00
Adam Dobrawy 541ec89654
Add CODEOWNERS for examples (#9255) 2020-05-19 12:28:16 +02:00
Sylvia Moss 1c30a71d09
Replace file shared state by statebag (#9238) 2020-05-19 11:49:48 +02:00
Adam Dobrawy cc62fc9ebb builder/hyperone: Add tests for HCL syntax 2020-05-19 01:21:00 +02:00
Adam Dobrawy a3cba02c86 builder/hyperone: Add examples for HCL syntax 2020-05-19 01:20:25 +02:00
Wilken Rivera c954831bb2 builder/azure-arm: Update runtime constants with a valid DataDiskName
This change fixes an issue where using the `disk_additional_size` configuration option would cause builds to fail.

Build results before the change
```
==> Builds finished but no artifacts were created.
Build 'azure-arm' errored: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details." Details=[{"code":"BadRequest","message":"{\r\n  \"error\": {\r\n    \"code
\": \"InvalidParameter\",\r\n    \"message\": \"The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\\\\W][\\\\w-._]{0,79}(?\u003c![-.])$.\",\r\n    \"target\": \"dataDisk.name\"\r\n  }\r\n}"}]

```

Build results after change
```
Build 'azure-arm' finished.

==> Builds finished. The artifacts of successful builds are:
--> azure-arm: Azure.ResourceManagement.VMImage:

OSType: Linux
ManagedImageResourceGroupName: test-pkr
ManagedImageName: wilkenPacker9249
```

Closes #9249
2020-05-18 14:57:20 -04:00
Megan Marsh 170520dcca update changelog 2020-05-15 14:22:59 -07:00
Megan Marsh c6ca83bf9b
Merge pull request #9240 from rberlind/master
replace clean_image_name with clean_resource_name
2020-05-15 14:17:48 -07:00
Roger Berlind fdca7175fc replace clean_image_name with clean_resource_name
The change was mostly made except in one example for Google
2020-05-15 16:33:27 -04:00
Megan Marsh b982d987a7 Add Artifice postprocessor ID to valid artifacts for postprocessors that perform artifact type validation 2020-05-15 13:13:43 -07:00
Wilken Rivera c5e38a2699
docs/amazon-ebssurrogate: Add Session Manager documentation (#9236) 2020-05-15 14:58:10 +02:00
Juan Mesa 78509a58e7 Remove github.com/overdrive3000/secretsmanager package from vendors 2020-05-15 14:04:07 +02:00
Juan Mesa 55fa3e1b0b Add support for specifying key to fetch from AWS Secrets Manager 2020-05-15 13:50:33 +02:00
Megan Marsh ee5635722b enable force, debug, and on-error for hcl2 builds 2020-05-14 16:22:51 -07:00
Megan Marsh e3635566eb
Merge pull request #9232 from hashicorp/d-amazon-ssm-doc-updates
docs/builder/amazon: Add Session Manager Connection documentation to supported builders
2020-05-14 13:23:03 -07:00
Wilken Rivera bcaf9f124f docs/builder/amazon: Add Session Manager Connection documentation to supported builders 2020-05-14 15:17:22 -04:00
Megan Marsh 2661f7e0f1
Merge pull request #9229 from hashicorp/d-azure_arm-custom_managed_image_resource_update
docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
2020-05-14 11:54:33 -07:00
Megan Marsh 533fbc1381
Merge pull request #9139 from hashicorp/hcl2_commands_refactor
Hcl2 commands refactor
2020-05-14 11:16:12 -07:00
Megan Marsh bdd0141526
Merge pull request #9226 from hashicorp/powershell-cleanup-retry-logic
provisioner/powershell: Update cleanup logic
2020-05-14 11:03:46 -07:00
Wilken Rivera f31f5bc61b docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
Closes #9199
2020-05-14 13:31:40 -04:00
Wilken Rivera c330d2f04c provisioner/powershell: Update cleanup logic
This change reduces the retry timeout from 5m to 1m, and sets the
RetryDelay to 10s for a total of 6 retries. In additional to the retry
time reduction the cleanup script will now check to see if the
provisioner script created by Packer exists before trying to delete to
prevent any file not found issues.

Closes #9181
Closes #9189
2020-05-14 10:21:45 -04:00
Sylvia Moss df3bac3104
remove codecov status (#9225) 2020-05-14 16:02:51 +02:00