Megan Marsh
4ef34f7fba
fix iso config prepare
2020-05-08 14:11:51 -07:00
Megan Marsh
9476aa03de
Merge pull request #9105 from hashicorp/google_iap
...
Implement iap proxy for googlecompute
2020-05-08 12:40:42 -07:00
Megan Marsh
fcef10fd2f
Merge pull request #9082 from hashicorp/f-amazon_builder-ssm-session-tunnel-poc
...
builder/amazon: Add SSM Session Manager as a SSH interface connection
2020-05-08 12:40:03 -07:00
Megan Marsh
a55b73473a
fix logic
2020-05-08 10:24:28 -07:00
Megan Marsh
dde162622d
use local port in listener config, when set
2020-05-08 10:20:47 -07:00
Megan Marsh
81e043f2b0
fix windows tests
2020-05-08 10:13:43 -07:00
Megan Marsh
60600e6cf6
make windows work with account files containing spaces
2020-05-08 10:13:43 -07:00
Megan Marsh
dae60799bc
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
fda55fe928
deduplicate excess code
2020-05-08 10:13:43 -07:00
Megan Marsh
54b33ad8d1
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
850303b8b8
get gcloud integration working on Windows
2020-05-08 10:13:43 -07:00
Megan Marsh
c578afc62c
working on windows
2020-05-08 10:13:43 -07:00
Megan Marsh
32752d4577
fix linting and tests
2020-05-08 10:13:43 -07:00
Megan Marsh
b5744efb42
add config prepare tests
2020-05-08 10:13:43 -07:00
Megan Marsh
f583674cd6
linding
2020-05-08 10:13:43 -07:00
Megan Marsh
4fc92d7858
add tests
2020-05-08 10:13:42 -07:00
Megan Marsh
937a4859d4
Make retries a bit smarter, clean up language to be gentler, and give up on parsing stdout for tunnel launch
2020-05-08 10:13:42 -07:00
Megan Marsh
3e1ddad0c7
fix behavior when not using IAP, try to use more sophisticated streaming than buffer.String()
2020-05-08 10:13:42 -07:00
Megan Marsh
9353635b43
send sigint instead of sigkill; we can at least ask the tunnel nicely to shut down.
2020-05-08 10:13:42 -07:00
Megan Marsh
f67a8ab431
revert unneeded changes to driver roles
2020-05-08 10:13:42 -07:00
Megan Marsh
80ecd2013d
basic untested implementation for Windows. May leave zombie processes lying around
2020-05-08 10:13:42 -07:00
Megan Marsh
3cd28e98a7
linting
2020-05-08 10:13:42 -07:00
Megan Marsh
365eb09842
import context
2020-05-08 10:13:42 -07:00
Megan Marsh
eb05f6ff88
fix windows
2020-05-08 10:13:42 -07:00
Megan Marsh
d713f7ec64
add conditional building becasue windows support is still forthcoming
2020-05-08 10:13:42 -07:00
Megan Marsh
e6073bcec7
implement iap proxy for googlecompute. ssh-only so far
2020-05-08 10:13:42 -07:00
Ryo Tagami
fdc73376ba
floppy_label Parameter for vsphere-iso Builder ( #9187 )
...
Add ability to specify `floppy_label` parameter for `vsphere-iso`
builder, which would be especially beneficial when someone wants to pass
information to cloud-init via floppy disk images.
Signed-off-by: Ryo Tagami <rtagami@airstrip.jp>
2020-05-08 16:13:54 +02:00
Markus Liljedahl
d807e81adb
Changed default disk size for when using googlecompute to match minimum disk sice to the google api. Closes https://github.com/hashicorp/packer/issues/9023 ( #9071 )
2020-05-08 15:55:38 +02:00
Wilken Rivera
89fb7bb080
Apply suggestions from code review
...
Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-05-08 09:36:43 -04:00
Wilken Rivera
056f1f6e76
docs/amazon/builder: Add not about using a temporary_iam_instance_profile_policy_document
2020-05-08 09:32:54 -04:00
Wilken Rivera
bf1da57a05
Update address to localhost to be consistent with other proxies
2020-05-08 09:32:54 -04:00
Wilken Rivera
7cea7466ba
buider/amazon: Add `session_manager_port` option for setting a custom local port
2020-05-08 09:32:54 -04:00
Wilken Rivera
0d13c634b7
Update logging constructs for Session Manger driver
2020-05-08 09:32:49 -04:00
Wilken Rivera
81c40b8d08
Add section to docs about the session-manager-plugin tunnel
2020-05-08 09:32:49 -04:00
Wilken Rivera
5f68303504
Remove no longer needed port check
...
The communicator code base will default to the correct port settings for
valid communicators and fail the build for non valid communicators.
2020-05-08 09:32:49 -04:00
Wilken Rivera
3ae7ab994b
step_create_ssm_tunnel: Add port availability check for LocalPortNumber
2020-05-08 09:32:49 -04:00
Wilken Rivera
08dc2cb847
Remove call to unstubbed session start
2020-05-08 09:32:49 -04:00
Wilken Rivera
f498866c3a
Update validation for session_manager connectivity
...
Validation will now check that either a IamInstanceProfile or a TemporaryIamInstanceProfilePolicyDocument is set
2020-05-08 09:32:49 -04:00
Wilken Rivera
2f09b74587
amazon/builder: Move port validation for security group into RunConfig.Prepare
2020-05-08 09:32:48 -04:00
Wilken Rivera
3f6b28b70c
Add SSMTunnel step to other amazon builders, minus chroot
2020-05-08 09:32:48 -04:00
Wilken Rivera
743df19af2
Add tests for driver and ssm tunnel step
2020-05-08 09:32:48 -04:00
Wilken Rivera
e53d6aea66
amazon/ssm_driver: Update to support command context
...
* Defer the release of the found port to prevent possible Packer build collisions.
2020-05-08 09:32:48 -04:00
Wilken Rivera
5e14089851
tests/builder/amazon: Add basic testing for session_manager
...
* Add a test to ensure the proper host is returned when using session_manager
* Add a basic driver test for the validating that the SSMDriver will fail if the plugin is not in the path.
2020-05-08 09:32:48 -04:00
Wilken Rivera
60e0ba7e68
Update iam instance profile name
2020-05-08 09:32:48 -04:00
Wilken Rivera
d5a0262d6c
builder/amazon/instance: Add session manager support
2020-05-08 09:32:48 -04:00
Wilken Rivera
e515aefee3
Add validation checks for session_manager
...
* Session manager connectivity only supported via SSH
* Session manager requires the use of an iam instance profile with system manager permissions
2020-05-08 09:32:48 -04:00
Wilken Rivera
c1d2477d18
builder/amzon: Update port configuration for WinRM
...
Connectivity for WinRM works for the initial connection, but fails to upload any provisioning scripts - need to dive in deeper.
For now connectivity over SSH works as expected.
2020-05-08 09:32:48 -04:00
Wilken Rivera
fbffbd1899
docs/builder/amazon: Add short blurb for connecting via the AWS session_manager interface
2020-05-08 09:32:48 -04:00
Wilken Rivera
520061dee6
builder/amazon: Update Session Manger connectivity
...
* Update security group creation step skip ingress rules if using session manager
* Update create ssm tunnel step to dynamically set a session port
* Add SSHPort function to common to return session-manager tunnel port
* Update SSHHost to return proper host for session-manager
2020-05-08 09:32:48 -04:00
Wilken Rivera
3dd46eb5f4
Add PoC of connectivity using session-manager-plugin
...
* Add a bunch of hard coded values for testing on port 8081; ssh configs
are set to localhost and 8081
* Add a base drive for communicating with the session manager plugin
* Update step for creating tunnel to actually create SSM session tunnel via driver
2020-05-08 09:32:48 -04:00
Wilken Rivera
16604373ac
initial ssm tunnel changes - not working
2020-05-08 09:32:48 -04:00
Ryan Hartje
b86efe7604
Vbox Checksum Bugfix ( #9101 )
...
* attempting to repro github issue 9049
* update vbox ovf configtest to table test for mixedcase bug
2020-05-07 19:08:52 -04:00
Megan Marsh
26d05abd4f
Merge pull request #9182 from hashicorp/fix_9131
...
support pushing multiple tags
2020-05-07 12:09:19 -07:00
Adrien Delorme
62556c464c
Update builder/docker/artifact_import.go
2020-05-07 11:39:09 +02:00
Megan Marsh
02c1cf5b28
support pushing multiple tags
2020-05-06 16:39:41 -07:00
Megan Marsh
49af617be3
Merge pull request #9179 from hashicorp/fix_9177
...
fix docs for video_ram to use correct units
2020-05-06 09:53:40 -07:00
Megan Marsh
279fbb45ab
Merge pull request #9174 from hashicorp/do_9145
...
output_filename virtualbox option.
2020-05-06 09:40:33 -07:00
Megan Marsh
9baf2edd94
fix docs for video_ram to use correct units
2020-05-06 09:39:41 -07:00
Megan Marsh
5b4de6b16f
fix tests
2020-05-06 09:27:20 -07:00
Megan Marsh
aa09c52059
generated docs
2020-05-06 09:23:15 -07:00
Megan Marsh
2e2374b6be
add tests
2020-05-05 18:52:31 -07:00
Megan Marsh
f0d2680426
remove spot_price_auto_product from docs ( #9173 )
2020-05-05 20:48:27 -04:00
Megan Marsh
73eda08540
allow user defined output filename
2020-05-05 16:09:05 -07:00
Megan Marsh
6a682aca2e
Merge pull request #9124 from GennadySpb/yandex-export-post-processor
...
[WIP] Yandex export post processor
2020-05-05 11:01:13 -07:00
Megan Marsh
7e0cfd8b77
add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs
2020-05-01 10:31:38 -07:00
Megan Marsh
3f8ee2b426
add exported files to VSphere artifact ( #9020 )
...
* add exported files to VSphere artifact
* clean up grammar for vsphere template docs
* add to vsphere clone
2020-04-30 15:22:57 -04:00
Rui Lopes
86ac132056
hyperv: add support for setting the boot order ( #9046 )
2020-04-30 13:31:41 +02:00
Wilken Rivera
86ab71f56e
test/azure/arm: Add regression test case for ssh_username overrides ( #9136 )
...
This test is for the regression fixed in #9103
Before fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
--- FAIL: TestConfigUserNameOverride (0.42s)
config_test.go:75: Expected 'c.Comm.SSHPassword' to be set to generated password, but found ""!
config_test.go💯 Expected 'UserName' to be set to 'override_winrm_username', but found "packer"!
FAIL
FAIL github.com/hashicorp/packer/builder/azure/arm 0.425s
FAIL
```
After fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
ok github.com/hashicorp/packer/builder/azure/arm 0.379s
```
* Fix variable names in error messages
2020-04-30 10:49:58 +02:00
Megan Marsh
30061b3def
Merge pull request #9095 from VladRassokhin/vsphere-disable-shutdown
...
Add disable_shutdown option to VSphere builders
2020-04-29 15:18:24 -07:00
Megan Marsh
2a560a517e
Merge pull request #8946 from thor/feature/vgpu-profiles
...
Add support for specifying vGPU profiles
2020-04-29 13:27:19 -07:00
Vladislav Rassokhin
03c4bebf00
Add disable_shutdown option to VSphere builders
...
Also don't try to shut down VM if it's already off, otherwise VSphere would raise an error: "The attempted operation cannot be performed in the current state (Powered off)."
2020-04-29 14:19:43 +03:00
Gennady Lipenkov
aa595fa1aa
Rename arg
2020-04-27 02:37:10 +03:00
Gennady Lipenkov
9489a46f32
Make some steps exportable, add 'GetInstanceMetadata' method
2020-04-27 02:19:08 +03:00
jhawk28
c43a52aafe
fix issue where -force is not working with vsphere builders ( #9039 )
...
* add better error support to check if vm exists use path.Join so that it looks up the VM correctly turn off VM if it is still running
* fix the vsphere-clone also
* add a common precleanvm to the driver to dedupe iso and clone logic, reduce the if nesting
2020-04-23 08:07:07 -04:00
Wilken Rivera
e0d2f4fd69
builder/azure-arm: Fix SSH connection for temporary admin users specified in `ssh_username` ( #9103 )
2020-04-23 11:04:49 +02:00
Paul Meyer
26d768f429
[builder/azure-chroot] Shared image source ( #9070 )
2020-04-23 11:03:17 +02:00
Lars Lehtonen
ab119d3270
builder/azure/chroot: fix dropped error ( #9106 )
2020-04-23 10:53:13 +02:00
Adrien Delorme
da4a5224be
HCL2 singular blocks: use key/value or name/value depending on how the service names things ( #9078 )
...
* make sure keyvalue and namevalue filters are using the same naming as the service being used
* make docs a bit more readable for KeyValues too
* Update website/pages/docs/from-1.5/expressions.mdx
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-04-23 10:46:49 +02:00
Megan Marsh
50823e2573
Merge pull request #9093 from Hakujou/osc-bsu-fix
...
Compliance with oAPI spec for Outscale osc-bsu builder
2020-04-21 10:49:46 -07:00
Matthew Sanabria
761abdda4e
Updating documentation for azure-arm builder ( #9097 )
2020-04-21 10:47:48 +02:00
GennadySpb
1155ab8e3c
Add 'target_image_folder_id' for builder/yandex ( #9080 )
...
Add 'target_image_folder_id' for builder/yandex
Closes #9079
2020-04-20 15:20:05 +02:00
Romain Lecat
1f4e8785f3
Compliance with oAPI spec for Outscale OSC-BSU
2020-04-20 15:00:51 +02:00
vijayrajah
5d2fee04b2
builder/azure: enable boot Diagnostics ( #9053 )
...
* enable boot Diagnostics
2020-04-20 07:29:13 -04:00
Wilken Rivera
cc367bd0b7
Merge pull request #9045 from lausser/cloud-init
...
feat(proxmox): add ability to add a cloud-init drive
2020-04-17 14:09:02 -04:00
Paul Meyer
89f3aa0bd6
[builder/azure-arm] Use VM/build location for image location ( #9068 )
...
* [builder/azure-arm] Use VM/build location for image locationThe builder was using the location of the containing resource group asthe image location, but the API call can only create images in the samelocation as the source VM that is being captured.
2020-04-17 05:43:03 -04:00
Megan Marsh
855808ec6f
Merge pull request #8970 from szamfirov/shielded_vm_support
...
Adding custom shielded images support (GCP)
2020-04-16 16:32:04 -07:00
Svetlin Zamfirov
b706f02408
Fixing auto-generated code errors
2020-04-16 16:22:42 -07:00
Svetlin Zamfirov
d827f4f757
Adding custom shielded images support (GCP)
...
Adds `enable_secure_boot`, `enable_vtpm` and `enable_integrity_monitoring`
config options to enable building of custom Shielded GCP Compute images.
Feedback on this is more than welcome as this is my first attempt in
contributing to anything Packer related.
Packer is great for us to build custom images on top of GCP but we would
like to enhance that to support Shielded VM images. This will allow us
to have more secure and trusted images which our team(s) will be using.
2020-04-16 16:22:41 -07:00
Megan Marsh
08787ba31f
Merge pull request #9028 from vijayrajah/set_azure_custom_res_names
...
Set Custom Resource Names for Azure-Arm builds
2020-04-16 15:58:41 -07:00
Vijay Rajah
da7382980a
Fix failing test & format code
2020-04-17 00:17:39 +05:30
vijayrajah
fff06353b7
Update builder/azure/arm/tempname.go
...
refactor the code.. thanks for the suggestion @sylviamoss
Co-Authored-By: Sylvia Moss <sylviamoss.m@gmail.com>
2020-04-17 00:04:39 +05:30
Adrien Delorme
73242e8de4
make sure keyvalue and namevalue filters are using the same naming as the service being used
2020-04-16 17:22:13 +02:00
Gerhard Lausser
dc2813c8e2
feat(proxmox): add ability to add a cloud-init drive
2020-04-15 22:00:42 +02:00
Wilken Rivera
d580ea7950
Merge pull request #9069 from tencentyun/master
...
builder/tencent: fixed InstanceOperationInProgress error #9054
2020-04-15 07:21:33 -04:00
Thor K. Høgås
ebfc5bcdcb
Merge branch 'master' into feature/vgpu-profiles
2020-04-15 12:02:37 +02:00
Wilken Rivera
e8f8ebf132
builder/vmware: Add some additional debug logging to the driver version check ( #9064 )
2020-04-15 10:34:48 +02:00
Li Kexian
632610d9c0
fixed InstanceOperationInProgress error #9054
2020-04-15 12:38:50 +08:00
Megan Marsh
440f540e28
fix merge issues with generated code
2020-04-14 10:31:57 -07:00
Vladislav Rassokhin
5f2849b5b4
builder/vsphere-clone: support firmware changing
2020-04-14 10:28:43 -07:00
Vladislav Rassokhin
91a1ad63fa
builder/vsphere-iso: support EFI Secure Boot using another value in `firmware` ( #8873 )
2020-04-14 10:28:22 -07:00