Adrien Delorme
819329228a
Change back to make sure all durations are a time.Duration
...
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:
* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
2019-10-31 16:12:07 +01:00
Adrien Delorme
bf3d9841c6
Force durations to be passed a strings
...
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
2019-10-31 11:47:19 +01:00
mingsheng.su
4f140d0071
fix docs of ucloud-uhost
2019-10-30 15:05:54 +08:00
mingsheng.su
545575b879
optimize code about ufile config
2019-10-29 16:11:44 -07:00
mingsheng.su
37e898e115
optimize code style
2019-10-29 16:11:44 -07:00
mingsheng.su
1099777978
update bucket about no create
2019-10-29 16:11:43 -07:00
mingsheng.su
083d7896f4
update message of ucloud import
2019-10-29 16:11:43 -07:00
mingsheng.su
2c513fce64
update ucloud packer
2019-10-29 16:11:43 -07:00
mingsheng.su
61f9d3a9fe
add ucloud import
2019-10-29 16:11:43 -07:00
Lars Lehtonen
5edabfc849
post-processor/compress: fix dropped errors
2019-10-28 16:19:46 -07:00
Adrien Delorme
078ba7c8c3
commit old code generation tool
...
for history
2019-10-15 12:56:42 +02:00
Adrien Delorme
771a6e55ef
pp.google.[import|export]: unexport Account field
...
so it doesnt temper with hcl2 cfg generation
2019-10-15 12:56:42 +02:00
Adrien Delorme
af08e2a410
pp.alicloud-import: remove duplicate AlicloudImageName field
...
( already defined in packerecs.Config )
2019-10-15 12:56:42 +02:00
Andrew Starr-Bochicchio
ae1bb856a3
digitalocean-import: Fix panic when 'image_regions' not set ( Fixes : #7843 ).
2019-10-01 21:14:15 -04:00
Lars Lehtonen
21f2e67462
post-processor/vagrant-cloud: fix dropped errors
2019-09-26 09:23:09 -07:00
Megan Marsh
3c14c50aba
Allow user to real oauth token from properly configured Vault instance
2019-09-23 13:26:03 -07:00
Megan Marsh
61b237b6f7
Merge pull request #8097 from onematchfox/vagrant-cloud
...
post-proc(vagrant-cloud) allow blank access_token (no auth) for private vagrant box hosting
2019-09-19 11:19:57 -07:00
Megan Marsh
9e28b2f5cf
fix post-processor
2019-09-16 13:45:28 -07:00
Brian Fox
331babc2ce
allow blank access_token (no auth) for private vagrant box hosting
2019-09-12 12:37:53 +02:00
Robbert Müller
9f972375ed
Removed whitelist check for builders
...
Fixes https://github.com/hashicorp/packer/issues/8060
Signed-off-by: Robbert Müller <spam.me@grols.ch>
2019-09-04 18:34:39 +02:00
DanHam
ca9b500e76
Fix test output: Correct copy/paste errors and make message clearer
2019-08-22 09:48:32 +01:00
DanHam
7770ade74c
Clearer error message for artifice users. OCD nits and logging
2019-08-21 14:32:26 +01:00
DanHam
e9ab2203ba
Should return provider correctly with artifacts from other builders or pp's
2019-08-21 14:32:25 +01:00
DanHam
e8336039d9
Should return provider correctly with good box and artifice pp
2019-08-21 14:32:25 +01:00
DanHam
aee400836f
Should return an error if the provider kv pair is not in the metadata file
2019-08-21 14:32:25 +01:00
DanHam
a7603f63c7
Should return an error if the metadata file has badly formatted JSON
2019-08-21 14:32:25 +01:00
DanHam
57137c6e33
Should return an error if the value of the provider key is empty
2019-08-21 14:32:25 +01:00
DanHam
d1327fe422
Should return an error if the metadata file is empty
2019-08-21 14:32:24 +01:00
DanHam
a9e22a6bb2
Should return the provider by parsing the json in the box metadata file
2019-08-21 14:32:24 +01:00
DanHam
0bf0e7c078
Should return an error when the metadata file is not in the box tar archive
...
Split out box creation into new helper function
2019-08-21 14:32:24 +01:00
DanHam
063e4bd3e5
Should return an error if the box tar archive is empty
2019-08-21 14:32:24 +01:00
DanHam
9c6b355088
Should return an error if the box is a plain gzip file
2019-08-21 14:32:24 +01:00
DanHam
35d326de39
Add basic workings to function. Return an error if box file is empty
2019-08-21 14:32:23 +01:00
DanHam
6b5cf6dcb2
Should return an error when the box file is missing
2019-08-21 14:32:23 +01:00
DanHam
e8c586175e
Intention: Allow use of artifice pp with vagrant-cloud pp
...
The Vagrant-Cloud and Vagrant provider (e.g. virtualbox, vmware_desktop
etc.) must be determined differently depending on the builder or
post-processor supplying the artifact.
Adds a wrapper function that:
* Uses the original method of determining the provider when the artifact
is provided by either the Vagrant builder or Vagrant post-processor
* Uses a new (currently empty) function when the artifact is provided
via the Artifice post-processor
2019-08-21 14:32:23 +01:00
DanHam
3f4f429c3d
Should return an error when artifact file does not have .box extension
2019-08-21 14:32:23 +01:00
DanHam
57308b0126
Should return an error with an invalid BuilderId
2019-08-21 14:32:23 +01:00
DanHam
1bffdd9bff
Add option to allow box Vagrantfile to be dynamically generated during build
2019-08-13 09:09:28 +01:00
DanHam
19f3a63ee1
Tests: Should not error when template is to be created during build
2019-08-13 09:09:28 +01:00
DanHam
4b042ac402
Tests: Should not error when `vagrantfile_template` exists
2019-08-13 09:09:27 +01:00
DanHam
8ddbb791a1
Fix typo
2019-08-05 17:25:21 +01:00
Megan Marsh
a87ce366b3
Merge pull request #7835 from hashicorp/google_oauth
...
replace some bespoke google auth code with code from golang's oauth2 …
2019-07-08 09:48:27 -07:00
Megan Marsh
0dfb3cc56f
replace some bespoke google auth code with code from golang's oauth2 library
2019-07-03 14:27:33 -07:00
Marc Falzon
d82c4f0057
fixup! fixup! fixup! fixup! Add Exoscale Import post-processor
2019-07-03 09:28:42 +02:00
Marc Falzon
9ce5f5dcee
fixup! fixup! fixup! Add Exoscale Import post-processor
2019-07-02 10:15:09 +02:00
Marc Falzon
00c2df24df
Add Exoscale Import post-processor
...
This change adds a new `exoscale-import` post-processor allowing users
to create Private Templates on Exoscale.
2019-07-01 08:40:26 +02:00
chhaj5236
6b081cc41c
update alicloud builder to use official SDK ( #7477 )
2019-04-26 10:37:49 +08:00
Adrien Delorme
aee73d745d
update code after go mod update
2019-04-11 14:19:24 +02:00
Adrien Delorme
d72040f4fa
move retry code into the common/retry pkg and make retry context aware
2019-04-09 17:46:38 +02:00
Adrien Delorme
f555e7a9f2
allow a provisioner to timeout
...
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
2019-04-08 20:09:21 +02:00