Commit Graph

11924 Commits

Author SHA1 Message Date
Megan Marsh 7dbd42c7f3 update changelog 2019-02-28 11:50:39 -08:00
Megan Marsh 1e47421ba1
Merge pull request #7351 from hashicorp/move_pause_before_connection
move pause to after connection can be established.
2019-02-28 10:56:11 -08:00
Stephen Fox 56c17941fe Added comment to authorized_keys 'sed' calls per review. 2019-02-28 10:54:14 -05:00
Stephen Fox 856810e82e Coalesce private key type switch cases per review feedback. 2019-02-28 09:56:11 -05:00
Stephen Fox 672b22bd13 Move 'CreateKeyPairConfig' closer to callers.
Per review feedback.
2019-02-28 09:44:25 -05:00
Stephen Fox 302828905d Move 'FromPrivateKeyConfig' closer to caller.
Per review feedback.
2019-02-28 09:42:20 -05:00
Stephen Fox ed06656613 Update 'authorizedKeysLine' doc per review feedback. 2019-02-28 09:40:00 -05:00
Stephen Fox 415ef26768 Removed TODO about key pair description per review feedback. 2019-02-28 09:30:30 -05:00
Adrien Delorme 22df491c67 mock tty using interfaces to test more easily 2019-02-28 14:40:55 +01:00
Chris Marget 0f1bde760c
Merge pull request #4 from stephen-fox/refactor-ssh-key-pair-logic
Initial take on code review feedback from @azr.
2019-02-27 17:05:44 -05:00
Brendan Devenney 328cbf4e42
Merge branch 'master' into feature/7322 2019-02-27 19:29:18 +00:00
Adrien Delorme 7f5c794e5f add go-tty vendor 2019-02-27 17:01:02 +01:00
Adrien Delorme 239a0c633f use go-tty in ui.Ask to fix #7299 2019-02-27 16:59:59 +01:00
Adrien Delorme c588a8a24d Revert "cheggaaa.pb: try to not open tty at init to see if it causes #7299"
This reverts commit 4e55278839.
2019-02-27 16:52:55 +01:00
Adrien Delorme f535464097 up a test 2019-02-27 11:17:56 +01:00
Adrien Delorme f03cbd8a10 aws: allow to pass nil bool as encryption parameter
to retain current encryption settings

this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted

This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
2019-02-27 11:17:56 +01:00
Adrien Delorme ce8532e94b aws: document ValidateRegion better 2019-02-27 11:17:08 +01:00
Adrien Delorme 6af621c37a aws: StepAMIRegionCopy call waitgroup.add only once 2019-02-27 11:17:08 +01:00
Adrien Delorme 0e8afa37d5
Merge pull request #7347 from amphied/master
Fix support for aws-us-gov
2019-02-27 10:57:53 +01:00
Michael F 01a0b0c766 kmsArnStartPattern - fix support for aws-us-gov
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html

Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
2019-02-26 16:54:54 -08:00
Megan Marsh 9db844a807 move pause to after connection can be established. 2019-02-26 12:24:45 -08:00
Megan Marsh b8510f35fc
Merge pull request #7330 from hashicorp/except_post_processor_tests
name a post-processor to it's type when it is not named
2019-02-26 09:26:17 -08:00
Adrien Delorme cc2e30826b
Merge pull request #7344 from ad-m/patch-1
Add hyperone builder to CHANGELOG.md
2019-02-26 16:16:59 +01:00
Adrien Delorme 4e55278839 cheggaaa.pb: try to not open tty at init to see if it causes #7299 2019-02-26 11:55:39 +01:00
Adrien Delorme b32449cdcc
Merge pull request #7336 from dkuntz2/make-private-ip-fixer-error-more-clearly
Make the amazon-private-ip fixer errors more visible
2019-02-26 09:47:31 +01:00
Megan Marsh 674ff489a9
Merge pull request #7343 from hashicorp/fix_6369
move snapshot deletion to cleanup; this allows people with tag-specif…
2019-02-25 17:50:14 -08:00
Megan Marsh 026e543b24 move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation 2019-02-25 17:01:19 -08:00
Stephen Fox 2ef6b9247d Initial take on code review feedback from @azr.
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00
Megan Marsh 134cf3a141 update gemfile to fix vulnerability in bootstrap-saas dependency 2019-02-25 12:58:35 -08:00
Don Kuntz 279fb7a632 gofix 2019-02-25 14:41:26 -06:00
Adam Dobrawy 419a8c3324
Add hyperone builder to CHANGELOG.md 2019-02-25 21:31:22 +01:00
Don Kuntz b0589c9643 Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip 2019-02-25 14:20:14 -06:00
Don Kuntz 04de86d211 Add test for non-boolean values in ssh_private_ip for FixerAmazonPrivateIP 2019-02-25 14:19:13 -06:00
Megan Marsh 3b726e66c1 swap region copy and encryption steps 2019-02-25 11:03:03 -08:00
Sargun Dhillon 142a84ef43 amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour
There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
2019-02-25 10:45:23 -08:00
Megan Marsh 1c3bc70b12
Merge pull request #7338 from chhaj5236/feature/update_aliyun_sdk
alicloud: update aliyun sdk to support eu-west-1 region
2019-02-25 09:32:02 -08:00
Megan Marsh 3f7c4f7406
Merge pull request #7341 from hashicorp/fix_7325
openstack WaitForImage: pass context for cancellation
2019-02-25 09:30:36 -08:00
Megan Marsh 05897c8653
Merge pull request #7294 from hyperonecom/hyperone
Add HyperOne builder
2019-02-25 08:30:04 -08:00
Megan Marsh f7ba933809
Merge pull request #7332 from joellopes03/fix_7301
Use IMDS to get subscription for Azure MSI
2019-02-25 08:25:12 -08:00
Adrien Delorme b9411712eb builder/openstack/step_create_image.go: pass context for cancellation
fix #7325
2019-02-25 15:03:11 +01:00
Adrien Delorme 3cda840504
Merge pull request #7329 from lrxcy/fix_190220
add Endpoints Description
2019-02-25 09:02:32 +01:00
Miłosz Smółka 94a7a07c87 Merge branch 'master' into hyperone 2019-02-24 15:16:21 +01:00
Brendan Devenney 4d2a5fb9a2
Implement template marshalling logic
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 22:41:07 +00:00
Brendan Devenney afba444373
Refactor rawTemplate to better align with real raw template structure
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 21:42:27 +00:00
Miłosz Smółka 0673bb2c57 Add cleanup for stepCreateImage 2019-02-23 14:57:19 +01:00
gregorybrzeski ad9349a6c5 add reviewers for builder to CODEOWNERS file 2019-02-23 12:13:41 +01:00
lrxcy ab939989ea fix some typos 2019-02-23 14:03:48 +08:00
Brendan Devenney 610eecfc99
Track sensitive variable keys to support JSON template writing
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 04:52:03 +00:00
Brendan Devenney d8793e3f85
Store comments in the Template structure
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 04:37:08 +00:00
bozhi.ch f751e20b7e update aliyun sdk to support eu-west-1 region 2019-02-23 11:43:35 +08:00