Matthew Hooker
49958391b3
better error when source_path doesn't exist.
2018-03-19 09:58:39 -07:00
Megan Marsh
414dd80e61
Merge pull request #6013 from jsoref/spelling
...
Spelling
2018-03-14 09:50:27 -07:00
Josh Soref
964d5dd55e
spelling: mapstructure
2018-03-13 08:09:41 +00:00
Josh Soref
57c0e9e4a7
spelling: illegal
2018-03-13 08:02:43 +00:00
Josh Soref
041a115f65
spelling: existent
2018-03-13 08:15:56 +00:00
Megan Marsh
5055fa66aa
Merge pull request #5987 from mcandre/multibyte-scancodes
...
send multibyte scancodes accurately to virtualbox
2018-03-12 16:23:41 -07:00
Megan Marsh
2a88672cd9
add test for modifyer keypress commands
2018-03-12 15:08:30 -07:00
Andrew Pennebaker
1d48812b34
fix later commands overwriting earlier commands
2018-03-09 20:17:43 -06:00
Andrew Pennebaker
f305a2f4c2
send multibyte scancodes accurately to virtualbox
2018-03-07 10:59:02 -06:00
SwampDragons
7d5d62d748
Merge pull request #2906 from arizvisa/GH-2377
...
Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme
2018-02-05 09:53:47 -08:00
Matthew Hooker
8cd403425e
test fixes WIP
2018-01-24 17:09:17 -08:00
Matthew Hooker
5d48d658b4
Wire context through misc steps
...
Some steps actually need to pass the context around, so let's create
a ctx variable and pass it.
2018-01-24 17:09:17 -08:00
Matthew Hooker
7a189a83a1
fix imports
...
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
a831d522be
change run signatures
...
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.
`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
366dc3da0a
move multistep imports to helper.
...
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
Matthew Hooker
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
Ali Rizvi-Santiago
c17f827e1d
Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols.
2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
3cf448f6ec
Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path.
2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
5d97b105a8
Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist.
2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
e940dc7e42
Fixed a config_test that should've failed but didn't because ftp:// uris work now. HeH!
2018-01-16 13:37:31 -06:00
SwampDragons
fb730cf521
Merge pull request #5761 from hashicorp/fix_5713
...
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-11 11:48:26 -08:00
Megan Marsh
3ace5bb91b
simplify FileExistsLocally
2018-01-10 16:11:17 -08:00
Megan Marsh
216c44b153
fix FileExistsLocally
2018-01-09 15:47:07 -08:00
Megan Marsh
e164621bfe
log line to help prevent confusion when guest_additions_url is set from env variable that is empty
2018-01-05 09:19:38 -08:00
Megan Marsh
4f3b470804
add helper function to manage validation of filepaths created using DownloadableURL
2018-01-03 16:53:47 -08:00
Ali Rizvi-Santiago
4fcd542d0c
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-02 21:09:41 -06:00
Megan Marsh
6756df9510
use url library instead of parsing string naiively
2017-11-13 12:57:53 -08:00
Megan Marsh
771349e58c
fix error message
2017-11-13 12:52:47 -08:00
Megan Marsh
764be03876
didn't mean for this error message to get changed
2017-11-13 12:42:57 -08:00
Megan Marsh
0d18de2942
do validation in vmx config stage
2017-11-13 12:42:57 -08:00
Matthew Hooker
fb098d045d
builder/virtualbox-ovf retry removing VM.
...
moves behavior from builder/virtualbox-iso into the driver
so it is automatically available to callers.
2017-10-25 10:27:33 -07:00
SLAZ666
f6bb79784f
Add option keep_registered to virtualbox-ovf builder
2017-09-13 15:37:26 +02:00
Matthew Hooker
94d7a4ce8d
post-processor/vagrant-cloud: try upload once
...
* fixes multiple uploads mentioned in #4973
* removed unused token code
2017-06-12 17:34:32 -07:00
Matthew Hooker
ab81b3ef7d
Merge pull request #4699 from BenPhegan/virtualbox_sata_port_count
...
Add configuration to virtualbox-iso to allow sata port count configuration
2017-06-05 15:21:12 -07:00
Matthew Hooker
0c116981ab
Merge pull request #4960 from rickard-von-essen/issue-4959
...
virtualbox: Don't add portforwarding if comm = none
2017-06-02 13:15:43 -07:00
Rickard von Essen
31b93a3026
virtualbox: Don't add portforwarding if comm = none
...
Closes : #4959
2017-06-02 21:58:34 +02:00
JD Friedrikson
a0052fdb68
Specify InsecureIgnoreHostKey for HostKeyCallback
...
[A recent breaking change upstream in Golang's crypto
library](e4e2799dd7
)
has broken SSH connectivity for a few builders:
```
==> qemu: Waiting for SSH to become available...
2017/05/20 16:23:58 ui: ==> qemu: Waiting for SSH to become available...
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 [INFO] Attempting SSH connection...
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 reconnecting to TCP connection for SSH
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 handshaking with SSH
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 handshake error: ssh: must specify HostKeyCallback
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 [DEBUG] SSH handshake err: ssh: must specify HostKeyCallback
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 [INFO] Attempting SSH connection...
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 reconnecting to TCP connection for SSH
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 handshaking with SSH
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 handshake error: ssh: must specify HostKeyCallback
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 [DEBUG] SSH handshake err: ssh: must specify HostKeyCallback
```
Specifying HostKeyCallback as insecure should make things work again
and would make sense for packer's use case.
2017-05-20 16:17:04 -04:00
Ben Phegan
c4b8e8e5df
Merge branch 'master' into virtualbox_sata_port_count
2017-05-01 09:23:05 +10:00
Matthew Hooker
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
Matthew Hooker
4fcbf75da9
s/non existent/nonexistent/
2017-03-29 12:38:33 -07:00
Matthew Hooker
35578d9ed1
remove unnecessary type conversions
2017-03-28 20:36:21 -07:00
Matthew Hooker
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
Matthew Hooker
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
Matthew Hooker
35480e21b2
fix typo
2017-03-24 11:56:49 -07:00
Matthew Hooker
0ad6b169bc
builder/virtualbox: retry removing floppy controller
2017-03-23 23:58:23 -07:00
Ben Phegan
0c777a1d63
Fix for DriverMock not implementing Driver
2017-03-23 12:11:19 +11:00
Ben Phegan
67eb600c08
Add sata_port_count so that a SATA controller can be created with more than 1 port. The default of prevents additional drives being added. Default preserved if not overridden.
2017-03-22 23:09:25 +11:00
Matthew Hooker
68e2b150cd
builder/virtualbox: allow skipping upload of version file
2017-03-16 18:14:11 -07:00
Matthew Hooker
84fc62f6b2
Merge pull request #4496 from mitchellh/vmrmguest2
...
builder/virtualbox: remove guest additions
2017-02-03 23:14:35 -08:00
Matthew Hooker
70af3d8148
Merge pull request #4497 from mitchellh/f-clickable-links
...
Make rdp and vnc links clickable by adding the protocol
2017-02-02 12:41:59 -08:00