Commit Graph

383 Commits

Author SHA1 Message Date
Mitchell Hashimoto d89fd906a4 Merge pull request #1504 from sneal/always-remove-vmx-floppy-entries
Clean VMX step should always remove floppy.
2014-10-14 16:09:28 -07:00
Shawn Neal 5fd9651982 GH 1508 - Ensure Packer VMX is updated and saved
We need to ensure the VMWare process has exited before attempting to run VMX file cleanup steps, otherwise VMWare may overwrite our changes. While Packer does its best to ensure VMWare has exited, there's still a race condition on some OSs between VMWare flushing the VMX and Packer updating it. The workaround is to artifically wait 5 seconds.

When using the VMX builder its possible for the source machine to have a floppy and/or CD-ROM mounted which gets cloned to the new VM Packer spins up, but have no Packer configuration for those devices. With this change we always attempt to remove the mounted devices regardless of the Packer configuration.
2014-09-24 09:42:10 -07:00
Julian Phillips 90a57c411f Expand Artifact API to expose build state
In order that something consuming an artifact can have access to extra
builder specific data add the State method which allows the caller to
ask for arbitary values by name.
2014-09-22 11:15:47 +01:00
Jason A. Beranek 8689301d68 builder/vmware-esxi: Ignore localhost for VNC lookup [GH-1480]
Adds logic to ESXi driver VNC Address function to ignore listen
  addresses that bind to localhost (127.0.0.1), this allows certain
  default ports to be available on ESXi for VNC connections
2014-09-16 22:00:52 -05:00
Shawn Neal 7d9c252b3a Clean VMX step should always remove floppy.
When using the VMX builder its possible for the source machine to have a floppy configured which gets cloned to the new VM Packer spins up. When the new VM's Packer config doesn't have a floppy_files config entry, the Packer clean VMX step fails to remove the floppy disk from the new VM. This can cause build failures, for example with the vsphere post processor; generating errors like:

* Post-processor failed: Failed: exit status 1
Error: File (/home/teamcity/tmp/buildTmp/packer941120499) could not be found.

Opening the cloned VM's VMX file you can clearly see it has a floppy entry from the source machine's VMX file (exact same path) even though the Packer config contains no floppy_files entry.
2014-09-16 18:27:00 -07:00
John Deatherage e571a133b0 fixed vmware-vmx step order 2014-09-14 04:28:55 -07:00
Ross Smith II a7aa20c8c7 Add support for VMware Fusion 7 Pro [GH-1478] 2014-09-10 10:14:50 -07:00
Jason A. Beranek b6eb3eba1d builder/vmware-esxi: Add configuration options for remote cache path
Add configuration option to explicitly control where Packer uploads
  ISO and floppy files to on ESXi hosts. The `remote_cache_datastore`
  defaults to the `remote_datastore` value. The 'remote_cache_directory'
  defaults to 'packer_cache', similar to the local caching capabilities.

  Addresses issues with [GH-1218] and [GH-1221] where paths for uploaded
  ISO and floppy files are not written to a valid location in the
  datastore.
2014-09-10 00:10:06 -05:00
Mitchell Hashimoto 75395af12d Merge branch '1064-fix-upload-file-permissions' of github.com:rasa/packer into rasa-1064-fix-upload-file-permissions
Conflicts:
	builder/parallels/common/step_upload_parallels_tools.go
	builder/vmware/common/step_upload_tools.go
	provisioner/chef-client/provisioner.go
	provisioner/chef-solo/provisioner.go
2014-09-08 13:20:46 -07:00
Mitchell Hashimoto 812ba35479 fmt 2014-09-08 10:28:21 -07:00
Mitchell Hashimoto 1a45b96674 builder/vmware: add VNC to vmx 2014-09-05 12:10:40 -07:00
Mitchell Hashimoto b72605c2f6 builder/vmware: style 2014-09-05 12:01:07 -07:00
Mitchell Hashimoto 759c46487c builder/vmware-vmx: support http files 2014-09-05 11:59:46 -07:00
Mitchell Hashimoto c74f0c7cfe Merge branch '1082-add-boot-commands-to-vmx-and-ovf-builders' of github.com:rasa/packer into rasa-1082-add-boot-commands-to-vmx-and-ovf-builders
Conflicts:
	builder/virtualbox/ovf/config.go
	builder/vmware/vmx/config.go
2014-09-05 11:42:01 -07:00
Mitchell Hashimoto 71d0c39ef9 builder/vmware: better error if clone not supported [GH-787] 2014-09-05 11:28:43 -07:00
Mitchell Hashimoto ac58773eed builder/vmware: better error output from vmrun 2014-09-05 11:27:33 -07:00
Mitchell Hashimoto caca50324e Merge pull request #1426 from jasonberanek/vnc-fixes
vmware-iso/esxi: fix multiple issues with VNC address discovery
2014-09-05 10:45:17 -07:00
Mitchell Hashimoto cf731bf65c builder/vmware: no error if stopping already stopped [GH-1300] 2014-09-05 10:29:35 -07:00
Mitchell Hashimoto 67afff5ede fmt 2014-09-03 21:27:54 -07:00
Mitchell Hashimoto 76a8221636 builder/*: extract key path to ssh.Signer 2014-09-03 20:23:39 -07:00
Mitchell Hashimoto 953fd27a27 Merge pull request #1167 from rasa/1057-add-floppy-files-to-vmware-vmx-v2
builder/vmware-vmx: add floppy_files support
2014-09-02 11:09:25 -07:00
Mitchell Hashimoto 8d88aaf150 Merge pull request #1168 from rasa/972-add-clone-support-for-vmware-player-6-v2
builder/vmware: add VMWare Player 6 support
2014-09-02 11:08:18 -07:00
Mitchell Hashimoto ba3bae8a65 Merge pull request #1239 from StefanScherer/fix_skip_floppy_in_vmx_data_post_step
builde/vmware: skip adding floppy again in vmx_data_post step
2014-09-02 10:02:17 -07:00
Mitchell Hashimoto 3827c02126 Merge pull request #1396 from ianunruh/feature/vmware-ssh-host-template
builder/vmware: Add templating to VMware SSH host option
2014-09-02 09:19:50 -07:00
Fabio Rapposelli d2a9a98eeb Fixed multiple VMware typos. 2014-08-22 10:07:36 +02:00
Jason A. Beranek ebdfa2bc56 vmware-iso/driver-esxi: Fix VNC detection of used ports
Fixes error in earlier commit that didn't properly detect a port
  was listened to.
2014-08-20 20:42:05 -05:00
Jason A. Beranek 93e4475d6a vmware-iso/driver-esxi: Detect VNC in cross-platform way [GH-1372]
Use VMware calls to determine ports being listened to, and determine
  free VNC port
2014-08-18 21:50:48 -05:00
Jason A. Beranek 2c41d59e21 vmware-iso: Update VNCAddressFinder interface to return errors from VNCAddress() 2014-08-18 20:34:37 -05:00
Jason A. Beranek 6acbc91ff7 vmware-iso: Fix error vnc min/max ports [GH-1288] 2014-08-18 20:15:15 -05:00
notogawa eacae832ad Fixes #1334, Add power on retry to ESXi Driver. 2014-08-11 16:43:34 +09:00
Ian Unruh 100200e1ae Add templating to VMware SSH host option 2014-08-07 11:11:08 -04:00
Ross Smith II 2c8ea2b6d2 Merge pull request #1361 from sneal/do-not-add-floppy-files-to-vmx
Do not re-add floppy disk files to VMX
2014-07-21 18:09:19 -07:00
Shawn Neal 05ebc8f316 Do not re-add floppy disk files to VMX
This commit fixes errors like this in the vsphere post-processor when using floppy files in the builder step:
Error: File (/var/folders/zl/57c1vmr532z_ryf1scw53_b9ycmxh7/T/packer964492999) could not be found

The configure VMX step re-adds the floppy files, so we need to configure the VMX and _then_ clean the VMX in that order.
2014-07-21 17:06:43 -07:00
Mitchell Hashimoto 67bad68c9f Merge pull request #1250 from higebu/check-upload-iso-hash
builder/vmware/esxi: checksum iso upload to not always upload
2014-07-19 09:42:26 -07:00
yuuzi41 982e523ba2 fix invalid esx5 path separator in windows
before, this code had joining path elements by filepath module. filepath module generate path string with backslash-joined in Windows. but ESX require path string with slash-joined. it means that this code generate illegal path string in windows. illegal path string raised "Error creating disk".

this patch fixes path separator from backslash to slash in windows. from this, creating disk would succeed without error.
2014-07-02 21:55:47 +09:00
Yuya Kusakabe 2b8ebe65e4 Resolves #1256, add warning mesasge to VMware ESXi driver 2014-06-25 11:20:24 +09:00
StefanScherer 9dc06b608e increase VMware cleanup timeout to 120 seconds 2014-06-20 01:07:40 +02:00
Yuya Kusakabe 6ff38c86ea Fixes #1244, Add a check for upload iso hash to ESXi Driver 2014-06-12 14:33:34 +09:00
StefanScherer de5c38e6c5 skip adding floppy again in vmx_data_post step 2014-06-09 01:02:21 +02:00
Ross Smith II e93697ab4e builder/virtualbox-ovf,vmware-vmx: add `boot_command` support
Fixes #1082
2014-05-12 21:19:24 -07:00
Ross Smith II 750ffc8a54 builder/vmware: add VMWare Player 6 support
Also added VMWare Player support in Windows
Fixes #972
2014-05-12 18:35:37 -07:00
Ross Smith II 8313856949 builder/vmware-vmx: add floppy_files support 2014-05-12 18:24:03 -07:00
Ross Smith II 38d1d7fd3c Update vmx_config.go
Tiny typo.
I really should add a unit test here.
2014-05-12 14:43:12 -07:00
Ross Smith II b397d75a52 Update driver_workstation9.go
1 line typo
2014-05-11 08:46:19 -07:00
Mitchell Hashimoto 6a930d819c builder/vmware/common: remove unnecessary tags 2014-05-10 10:21:44 -07:00
Mitchell Hashimoto d925331902 fmt 2014-05-10 10:19:35 -07:00
Mitchell Hashimoto ad72c5a4bb builder/vmware/common: more tests 2014-05-10 10:19:14 -07:00
Mitchell Hashimoto 7e991af48e builder/vmware/common: tests for StepPrepareTools
/cc @rasa - an example
2014-05-10 10:16:53 -07:00
Mitchell Hashimoto 1b1d87128c Merge pull request #1154 from rasa/765-add-tools-upload-flavor-support-in-vmware-vmx
builder/vmware-vmx: Added tools_upload_flavor support
2014-05-10 10:07:34 -07:00
Ross Smith II 779c7184a2 go fmt 2014-05-09 21:12:14 -07:00
Ross Smith II d92179847d provisioner/file: set file/directory permissions
fixes #1064
2014-05-09 21:03:35 -07:00
Mitchell Hashimoto e9727df15e Merge pull request #1146 from higebu/fix-esxi-driver-iso-upload-path
Fixes #1062, ESXi Driver supports PACKER_CACHE_DIR
2014-05-09 19:56:28 -07:00
Ross Smith II ba13239672 builder/vmware-vmx: Added tools_upload_flavor support 2014-05-09 17:24:19 -07:00
Ross Smith II bdfac49410 builder/vmware: added vmx_data_post option 2014-05-09 09:25:15 -07:00
Yuya Kusakabe 6dc858e6cf Fixes #1062, ESXi Driver supports PACKER_CACHE_DIR 2014-05-09 13:16:18 +09:00
Jaime Soriano Pastor 32bb745734 Force LANG=C before appending rest of environment, as only first occurence is used 2014-05-08 17:11:19 +02:00
Ross Smith II bea167a48e builder/vmware-vmx: add floppy_files support
fixes #1057
2014-05-06 17:20:26 -07:00
Jakob A. Dam 40150c376d Fix http_files typo in comments 2014-05-06 17:13:15 +02:00
Yuya Kusakabe 5cac40b47c Fixes #1106, Remote ESXi builder doesn't upload floppy 2014-05-03 18:41:00 +09:00
Yuya Kusakabe 7ff781b258 Revert the way to retrieve vm ip in VMware ESXi Driver 2014-05-03 00:25:58 +09:00
Ross Smith II f2186fa6ff Merge pull request #995 from asatara/add-ssh-host-vmware
Added ssh_host variable to vmware iso builder
2014-04-28 11:33:40 -07:00
Mitchell Hashimoto 91574c3a60 builder/vmware: fix builds 2014-04-26 12:25:18 -07:00
Mitchell Hashimoto 5fac6c79c4 fmt 2014-04-26 11:12:43 -07:00
Mitchell Hashimoto e84e5e4f2c Merge branch 'update-ssh-package' of github.com:higebu/packer into higebu-update-ssh-package
Conflicts:
	builder/amazon/common/ssh.go
	builder/digitalocean/ssh.go
	builder/googlecompute/ssh.go
	builder/openstack/ssh.go
	communicator/ssh/communicator_test.go
	communicator/ssh/keychain.go
	communicator/ssh/keychain_test.go
2014-04-26 11:12:06 -07:00
higebu 37b92dff3a Fix unknown command and syntax error of the ESX5Driver 2014-04-22 00:27:33 +09:00
Ross Smith II 3f4baf4aec Merge pull request #1011 from rasa/add-cloning-in-windows
builder/vmware-vmx: add cloning support on Windows [GH-824]
2014-04-21 07:38:05 -07:00
higebu f087ce16dc Fix the build problem by updating ssh package 2014-04-15 10:17:26 +09:00
Ross Smith II 27491f93f8 use old ssh code until higebu's branch is ready, see #1019 2014-04-11 08:23:12 -07:00
Ross Smith II d420947db6 added %s for productVersion param 2014-04-06 15:50:19 -07:00
Ross Smith II 72924f0d56 builder/vmware-vmx: add cloning support on Windows [GH-824] 2014-04-06 15:31:49 -07:00
asatara ecbb0e8498 Added ssh_address variable to vmware builders 2014-03-31 11:54:14 -07:00
Mitchell Hashimoto 3c59d0ef96 builder/vmware/common: fix failing tests on Windows 2014-03-07 10:29:04 -08:00
Mitchell Hashimoto 68524a3840 builder/vmware/common: fix build tag for Windows 2014-03-07 10:22:33 -08:00
Mitchell Hashimoto 4576093c17 fmt 2014-02-24 08:26:51 -08:00
Mitchell Hashimoto 9a62269116 Merge pull request #900 from pmyjavec/ws10-linux-driver
VMWare Workstation 10 driver for Linux
2014-02-24 08:25:03 -08:00
Mitchell Hashimoto e3c0715eab fmt 2014-02-21 15:11:56 -08:00
Mitchell Hashimoto d44a42b04f Merge pull request #884 from pmyjavec/vmware-iso-driver-fix
builder/vmware: get host IP by creating & inspecting connection, allows hypervisor...
2014-02-21 15:11:35 -08:00
Mitchell Hashimoto 9f7670a50f builder/vmware-iso: output upload error [GH-899] 2014-02-21 14:07:25 -08:00
Paul Myjavec 3ea4aa1a5a added workstation 10 driver for linux 2014-02-21 15:20:54 +11:00
Paul Myjavec 6e7a69372a these functions can be shared by 9 and 10 vmware workstation drivers 2014-02-20 20:08:57 +11:00
Paul Myjavec aedef06016 esx5, Get host IP by creating & inspecting connection, allows hypervisor to reside in other networks 2014-02-20 19:37:12 +11:00
Mitchell Hashimoto 430963f400 fmt 2014-01-19 19:30:11 -08:00
Myles Steinhauser 28286d2821 Fix tabs vs spaces 2014-01-13 00:03:10 -05:00
Myles Steinhauser e4cfcb2a8a Add more special scancodes 2014-01-10 12:40:43 -05:00
Mitchell Hashimoto 12938fe36b builder/virtualbox,vmware: checksum not required if checksum type is
none
2014-01-04 11:10:13 -08:00
Mitchell Hashimoto c74b3758d3 builder/vmware-iso: ESX5Driver impl OutputDir [GH-773] 2014-01-01 20:55:08 -08:00
Mitchell Hashimoto 2b801a7b12 builder/vmware,virtualbox: checksum_type can be "none" [GH-471] 2013-12-28 09:59:47 -07:00
Mitchell Hashimoto eeadafc452 builder/vmware/*: can specify path to fusion [GH-677] 2013-12-27 08:37:39 -07:00
Mitchell Hashimoto 9362cb5364 builder/vmware/vmx: set the full_disk_path so compacting works 2013-12-26 15:44:39 -07:00
Mitchell Hashimoto 8e75075ec9 builder/vmware/vmx: compact disk 2013-12-26 15:35:37 -07:00
Mitchell Hashimoto f134bcc3f4 builder/vmware/common: better UI when forcibly shutting down 2013-12-26 15:34:53 -07:00
Mitchell Hashimoto 2b3d98d48d builder/vmware/vmx: create artifact 2013-12-26 15:32:38 -07:00
Mitchell Hashimoto 7f38cea9f3 builder/vmware/vmx: shutdown 2013-12-26 15:31:23 -07:00
Mitchell Hashimoto ac8354ad9c builder/vmware/vmx: step connect SSH 2013-12-26 15:28:15 -07:00
Mitchell Hashimoto e11f655d22 builder/vmware/vmx: run the VMs 2013-12-26 15:26:09 -07:00
Mitchell Hashimoto 286edcb2b4 builder/vmware/vmx: configure VMX 2013-12-26 15:14:19 -07:00
Mitchell Hashimoto 03fb5fb0f1 builder/vmware/common: Fusion6 driver can clone 2013-12-26 15:03:12 -07:00
Mitchell Hashimoto 8fecdf179d builder/vmware/common: Fusion6Driver 2013-12-26 14:54:26 -07:00
Mitchell Hashimoto f23d66a1b9 builder/vmware/vmx: clone vmx 2013-12-26 14:39:41 -07:00
Mitchell Hashimoto 82fad98b07 builder/vmware/vmx: set the settings for cloning vmx 2013-12-26 08:36:00 -07:00