Commit Graph

179 Commits

Author SHA1 Message Date
kopernikus 84bd2ff754 option to keep the VM registered with esxi 2016-03-16 23:17:35 +01:00
Chris Bednarski 24dc798cfb Revert "Prevalidate Hardware Specs on Linux"
This reverts commit eda84cb2d3.
2016-02-02 12:41:43 -08:00
Chris Bednarski 6504f4f777 Revert "Only validate vmware resources on local hosts"
This reverts commit f01578c91e.
2016-02-02 12:41:42 -08:00
Chris Bednarski ffb85f6ea5 Merge pull request #3096 from grubernaut/f-resource-limits
Prevalidate Hardware Specs on Linux
2016-01-25 21:06:14 -08:00
Jake Champlin f01578c91e Only validate vmware resources on local hosts
Disable resource validation when `remote_type` is specified
2016-01-25 12:01:56 -05:00
Jake Champlin eda84cb2d3 Prevalidate Hardware Specs on Linux
Prevalidates hardware resources on Linux platforms for Virtualbox and
VMware builders. This is currently only available on Linux, as enabling
for both Darwin and Windows platforms, relies on cgo bindings that would
prevent effective cross-compilation.

Packer will now fail to build and validate templates if the template is
requesting that the VM to be created would allocate more system
resources than the host system has available.

This _however_ doesn't catch parallel builds that overflow the hosts
resources, will probably still need a better error message for VM's
failing to boot in that case.

Example Outputs:

```
$ $GOPATH/bin/packer build -debug ./vmware-iso.json
Debug mode enabled. Builds will not be parallelized.
vmware-iso output will be in this color.

2 error(s) occurred:

* Unavailable Resources: RAM - Requested - 204800000MB - Available 21721MB
* Unavailable Resources: Disk - Requested - 4000000000MB - Available 76701MB
```

```
$ $GOPATH/bin/packer build -debug ./vbox-iso.json
Debug mode enabled. Builds will not be parallelized.
virtualbox-iso output will be in this color.

2 error(s) occurred:

* Unavailable Resources: RAM - Requested - 10240000MB - Available 21721MB
* Unavailable Resources: Disk - Requested - 1000000000MB - Available 76701MB
```
2016-01-21 18:19:11 -05:00
Chris Bednarski 9358e8c355 Merge branch 'hotfix/rearrange_vmx_cleanup' of https://github.com/israelshirk/packer into b-2709 2016-01-21 13:36:02 -08:00
Anders Quist 077f9621f2 Merge branch 'master' of https://github.com/mitchellh/packer 2016-01-15 08:11:35 +01:00
Chris Bednarski ab721b7cb1 Merge pull request #2898 from markpeek/http-refactor
Refactor http server config into common
2016-01-14 17:10:17 -08:00
Chris Bednarski e6f1ea9ab2 Merge pull request #2911 from jtslear/endless-loop
vmware-iso-builder: Corrects logic checking destroy
2016-01-14 15:00:34 -08:00
Anders Quist 23246c01cf Fix for non consequent if statement (failing ESXi iso builds). 2016-01-10 18:34:21 +01:00
michael 499bd5a362 Add support for SSH Key Authentication with ESX builder 2015-11-03 19:08:35 -08:00
John T Skarbek cf4a19a304 vmware-iso-builder: Corrects logic checking destroy
* I suspect the logic written for checking if the vm has been destroyed is incorrect.  The test will come back from the esx server indicating that the vm is gone as it should, but the logic I believe is reversed so we never hit the break in the if statement
* Feedback is MORE than welcome
2015-11-03 14:49:53 -05:00
Mark Peek 7f149e595d Refactor http server config into common 2015-11-01 14:45:47 -08:00
Yuya Kusakabe 07079a5905 Fix #2892 2015-10-31 19:32:40 +09:00
Mark Peek 581ab9f4f5 Merge pull request #2849 from markpeek/iso-cleanup
Refactor builder ISO options
2015-10-26 21:43:59 -07:00
Mark Peek 0d2fa223f2 builder/vmware-esxi: hide password in ovftool command 2015-10-23 16:51:03 -07:00
Mark Peek 9d0c443ca2 builder/vmware-esxi: Add format validation and step_export tests 2015-10-23 16:50:14 -07:00
Yuya Kusakabe 699c673536 builder/vmware-esxi: Add step_export
If `format` option is configured, packer exports the VM with ovftool.

website: Document about OVF Tool and `format` option.

post-processor/vsphere: Enable to use `mitchellh.vmware-esx` artifact type and OVF and OVA formats, fixes #1457.
2015-10-23 09:00:53 +09:00
Mark Peek cdcffecc2d Refactor builder ISO options
The ISO builders (parallels, qemu, virtualbox, and vmware) had too
much common code which needed to be maintained separately. This change
moves that code to a common ISO configuration.
2015-10-20 16:27:47 -07:00
Brian Dwyer a563944b58 Fix #2695: Prevent duplicate ISO download for multi-builder builds
Add extension to VMware ISO builder to bring in sync with
Virtualbox ISO builder
2015-10-20 12:54:04 -07:00
Mark Peek e9657e6a9f Merge pull request #2642 from oliviertremblay/master
Make TargetPath customizable
2015-10-20 12:11:13 -07:00
Mark Peek e5a713ff01 Alternative fix for #2641: make random script name actually random 2015-10-11 13:31:09 -07:00
Israel Shirk c81a486f34 Rearranges vmware builders to put compaction before VMX finalization to avoid stomping VMX changes 2015-09-18 07:51:46 -06:00
Olivier Tremblay f301a6454d Added documentation, renamed config param to iso_target_path 2015-08-20 07:37:24 -04:00
Olivier Tremblay 223e35fc65 Makes StepDownload's TargetPath customizable.
I exposed TargetPath as a config file option "target_path". I don't like
the name, but it follows the naming convention. The purpose of TargetPath
stands unmodified, and it enables a fair amount of customization.
2015-07-28 07:45:02 -04:00
Mitchell Hashimoto 4a60e469e9 update CHANGELOG 2015-06-29 09:33:20 -07:00
Israel Shirk 88fac0b49c Have nonesum run stat rather than nonesum because nonesum sums none. k. 2015-06-25 19:03:00 -06:00
Mitchell Hashimoto 84189f7a28 builder/*: properly save interpolation context 2015-06-22 09:22:42 -07:00
Marc Siegfriedt 667c53942b use template for additional disks 2015-06-15 12:40:34 -07:00
Mitchell Hashimoto 70af21615e Merge pull request #2233 from mitchellh/b-output-dir
builder/virtualbox,vmware: validate output dir in step
2015-06-15 09:40:36 -07:00
Mitchell Hashimoto 115d583cff helper/communicator: make host more generic 2015-06-13 19:23:33 -04:00
Mitchell Hashimoto b61ed3adfc builder/vmware: convert to helper/comm 2015-06-13 18:52:44 -04:00
Mitchell Hashimoto d851898131 builder/vmware: mirror virtualbox output dir changes 2015-06-13 17:00:14 -04:00
Mitchell Hashimoto 71d8c6610a Merge pull request #1968 from bhcleek/master
do not request a pty
2015-06-13 16:23:31 -04:00
Mitchell Hashimoto 9da9ce6046 vmware/iso: disk_additional_size 2015-06-10 12:41:17 -07:00
Mitchell Hashimoto 3ba9d70b22 Merge pull request #1382 from sneal/AdditionalDisksForVMwareISO
Additional disks for vmware iso
2015-06-10 12:39:50 -07:00
Mitchell Hashimoto 1d653efe90 Merge pull request #2174 from brandonheller/master
vmware/iso: support hierarchical output directories
2015-06-10 11:33:59 -07:00
Mitchell Hashimoto 23a48d6619 go fmt 2015-06-08 21:34:20 -07:00
Shawn Neal e9a491ae45 New interpolation for additional vmware disks 2015-06-04 11:44:07 -07:00
Eric Richardson 7dfb837ddb Formatting cleanups from `go fmt` 2015-06-04 08:22:50 -07:00
Eric Richardson fab9ca9cdb Initial work to implement additional disk support in the vmware-iso builder
* Matches the syntax from mitchellh/packer#703
* Creates disk(s), adds them to the vmx template, and runs compact at the end
2015-06-04 08:22:50 -07:00
Brandon Heller a7eeb6a6a7 vmware/iso: support hierarchical output directories
When providing a hierarchical output_directory value like
'transient/jenkins-slave', the VM would fail to build in the CreateDisk
step.  The properly created output directory would not match the location
provided to CreateDisk, since datastorePath() did not properly split such
paths.  Now this case works; tested hierarchical and singular
output_directory values.
2015-06-04 02:49:58 -07:00
jszwedko b1497b951c code.google.com/p/go.crypto/ssh -> golang.org/x/crypto/ssh
code.google.com/p/go.crypto/ssh is now at golang.org/x/crypto/ssh as of
https://code.google.com/p/go/source/detail?spec=svn.crypto.69e2a90ed92d03812364aeb947b7068dc42e561e&repo=crypto&r=8fec09c61d5d66f460d227fd1df3473d7e015bc6

Using the code.google.com import redirects properly, but runs into
issues if you try to use a subpackage of `ssh`, e.g. `agent` which
refers to golang.org/x/crypto/ssh causing conflicts if your types expect
code.google.com/p/go.crypto/ssh.

This is a precursor to a PR for #1066.
2015-05-28 08:17:49 -07:00
Mitchell Hashimoto f5945eeb1b vmware/iso: new interpolation 2015-05-27 14:16:28 -07:00
Emil Hessman 57468b3d1a builder/vmware/iso: fix incorrect printf verb type in test
Fixes the following vet report:

builder/vmware/iso/builder_test.go:178: arg b.config.DiskSize for printf verb %s of wrong type: uint
2015-02-25 05:43:18 +01:00
Billie H. Cleek 2184892f8a do not request a pty
Change the default behavior from requesting a PTY when executing a
command with the ssh communicator to requesting a PTY only when
configured to do so.

Update the vmware builders to be fully backward compatible with the new
behavior.
2015-02-12 20:18:54 -08:00
Christian Groschupp e9246ec490 builder/vmware/iso: Upload VMX to ESX5 after editing [GH-1422,GH-1083] 2014-11-16 19:48:02 +01:00
Mitchell Hashimoto 0db6cd3533 Merge pull request #1330 from qur/qemu-vagrant
Qemu vagrant
2014-10-28 08:42:17 -07:00
Mitchell Hashimoto 6c44d72112 Merge pull request #1403 from notogawa/issue-1334
Fixes #1334, Add power on retry to ESXi Driver.
2014-10-28 08:35:42 -07:00
Mitchell Hashimoto e422a45449 fmt 2014-10-28 08:35:21 -07:00
Mitchell Hashimoto 00543fe582 Merge pull request #1479 from jasonberanek/esxi-remote-cache
buidler/vmware-esxi: Add configuration options for the remote location to cache ISO and floppy files
2014-10-28 08:28:15 -07:00
Nick Cronin 1aa102dd06 addresses #1191 - Add VMWare virtualhw.version configuration option under 'version' 2014-10-28 11:49:04 +11:00
Julian Phillips 90a57c411f Expand Artifact API to expose build state
In order that something consuming an artifact can have access to extra
builder specific data add the State method which allows the caller to
ask for arbitary values by name.
2014-09-22 11:15:47 +01:00
Jason A. Beranek 8689301d68 builder/vmware-esxi: Ignore localhost for VNC lookup [GH-1480]
Adds logic to ESXi driver VNC Address function to ignore listen
  addresses that bind to localhost (127.0.0.1), this allows certain
  default ports to be available on ESXi for VNC connections
2014-09-16 22:00:52 -05:00
Jason A. Beranek b6eb3eba1d builder/vmware-esxi: Add configuration options for remote cache path
Add configuration option to explicitly control where Packer uploads
  ISO and floppy files to on ESXi hosts. The `remote_cache_datastore`
  defaults to the `remote_datastore` value. The 'remote_cache_directory'
  defaults to 'packer_cache', similar to the local caching capabilities.

  Addresses issues with [GH-1218] and [GH-1221] where paths for uploaded
  ISO and floppy files are not written to a valid location in the
  datastore.
2014-09-10 00:10:06 -05:00
Mitchell Hashimoto 75395af12d Merge branch '1064-fix-upload-file-permissions' of github.com:rasa/packer into rasa-1064-fix-upload-file-permissions
Conflicts:
	builder/parallels/common/step_upload_parallels_tools.go
	builder/vmware/common/step_upload_tools.go
	provisioner/chef-client/provisioner.go
	provisioner/chef-solo/provisioner.go
2014-09-08 13:20:46 -07:00
Mitchell Hashimoto 1a45b96674 builder/vmware: add VNC to vmx 2014-09-05 12:10:40 -07:00
Mitchell Hashimoto 759c46487c builder/vmware-vmx: support http files 2014-09-05 11:59:46 -07:00
Mitchell Hashimoto c74f0c7cfe Merge branch '1082-add-boot-commands-to-vmx-and-ovf-builders' of github.com:rasa/packer into rasa-1082-add-boot-commands-to-vmx-and-ovf-builders
Conflicts:
	builder/virtualbox/ovf/config.go
	builder/vmware/vmx/config.go
2014-09-05 11:42:01 -07:00
Mitchell Hashimoto caca50324e Merge pull request #1426 from jasonberanek/vnc-fixes
vmware-iso/esxi: fix multiple issues with VNC address discovery
2014-09-05 10:45:17 -07:00
Mitchell Hashimoto 67afff5ede fmt 2014-09-03 21:27:54 -07:00
Mitchell Hashimoto ba3bae8a65 Merge pull request #1239 from StefanScherer/fix_skip_floppy_in_vmx_data_post_step
builde/vmware: skip adding floppy again in vmx_data_post step
2014-09-02 10:02:17 -07:00
Jason A. Beranek ebdfa2bc56 vmware-iso/driver-esxi: Fix VNC detection of used ports
Fixes error in earlier commit that didn't properly detect a port
  was listened to.
2014-08-20 20:42:05 -05:00
Jason A. Beranek 93e4475d6a vmware-iso/driver-esxi: Detect VNC in cross-platform way [GH-1372]
Use VMware calls to determine ports being listened to, and determine
  free VNC port
2014-08-18 21:50:48 -05:00
Jason A. Beranek 2c41d59e21 vmware-iso: Update VNCAddressFinder interface to return errors from VNCAddress() 2014-08-18 20:34:37 -05:00
Jason A. Beranek 6acbc91ff7 vmware-iso: Fix error vnc min/max ports [GH-1288] 2014-08-18 20:15:15 -05:00
notogawa eacae832ad Fixes #1334, Add power on retry to ESXi Driver. 2014-08-11 16:43:34 +09:00
Ross Smith II 2c8ea2b6d2 Merge pull request #1361 from sneal/do-not-add-floppy-files-to-vmx
Do not re-add floppy disk files to VMX
2014-07-21 18:09:19 -07:00
Shawn Neal 05ebc8f316 Do not re-add floppy disk files to VMX
This commit fixes errors like this in the vsphere post-processor when using floppy files in the builder step:
Error: File (/var/folders/zl/57c1vmr532z_ryf1scw53_b9ycmxh7/T/packer964492999) could not be found

The configure VMX step re-adds the floppy files, so we need to configure the VMX and _then_ clean the VMX in that order.
2014-07-21 17:06:43 -07:00
Mitchell Hashimoto 67bad68c9f Merge pull request #1250 from higebu/check-upload-iso-hash
builder/vmware/esxi: checksum iso upload to not always upload
2014-07-19 09:42:26 -07:00
yuuzi41 982e523ba2 fix invalid esx5 path separator in windows
before, this code had joining path elements by filepath module. filepath module generate path string with backslash-joined in Windows. but ESX require path string with slash-joined. it means that this code generate illegal path string in windows. illegal path string raised "Error creating disk".

this patch fixes path separator from backslash to slash in windows. from this, creating disk would succeed without error.
2014-07-02 21:55:47 +09:00
Yuya Kusakabe 6ff38c86ea Fixes #1244, Add a check for upload iso hash to ESXi Driver 2014-06-12 14:33:34 +09:00
StefanScherer de5c38e6c5 skip adding floppy again in vmx_data_post step 2014-06-09 01:02:21 +02:00
Ross Smith II e93697ab4e builder/virtualbox-ovf,vmware-vmx: add `boot_command` support
Fixes #1082
2014-05-12 21:19:24 -07:00
Mitchell Hashimoto 7e991af48e builder/vmware/common: tests for StepPrepareTools
/cc @rasa - an example
2014-05-10 10:16:53 -07:00
Mitchell Hashimoto 1b1d87128c Merge pull request #1154 from rasa/765-add-tools-upload-flavor-support-in-vmware-vmx
builder/vmware-vmx: Added tools_upload_flavor support
2014-05-10 10:07:34 -07:00
Ross Smith II 779c7184a2 go fmt 2014-05-09 21:12:14 -07:00
Ross Smith II d92179847d provisioner/file: set file/directory permissions
fixes #1064
2014-05-09 21:03:35 -07:00
Mitchell Hashimoto e9727df15e Merge pull request #1146 from higebu/fix-esxi-driver-iso-upload-path
Fixes #1062, ESXi Driver supports PACKER_CACHE_DIR
2014-05-09 19:56:28 -07:00
Ross Smith II ba13239672 builder/vmware-vmx: Added tools_upload_flavor support 2014-05-09 17:24:19 -07:00
Ross Smith II bdfac49410 builder/vmware: added vmx_data_post option 2014-05-09 09:25:15 -07:00
Yuya Kusakabe 6dc858e6cf Fixes #1062, ESXi Driver supports PACKER_CACHE_DIR 2014-05-09 13:16:18 +09:00
Jaime Soriano Pastor 32bb745734 Force LANG=C before appending rest of environment, as only first occurence is used 2014-05-08 17:11:19 +02:00
Jakob A. Dam 40150c376d Fix http_files typo in comments 2014-05-06 17:13:15 +02:00
Yuya Kusakabe 5cac40b47c Fixes #1106, Remote ESXi builder doesn't upload floppy 2014-05-03 18:41:00 +09:00
Yuya Kusakabe 7ff781b258 Revert the way to retrieve vm ip in VMware ESXi Driver 2014-05-03 00:25:58 +09:00
Mitchell Hashimoto 91574c3a60 builder/vmware: fix builds 2014-04-26 12:25:18 -07:00
Mitchell Hashimoto 5fac6c79c4 fmt 2014-04-26 11:12:43 -07:00
Mitchell Hashimoto e84e5e4f2c Merge branch 'update-ssh-package' of github.com:higebu/packer into higebu-update-ssh-package
Conflicts:
	builder/amazon/common/ssh.go
	builder/digitalocean/ssh.go
	builder/googlecompute/ssh.go
	builder/openstack/ssh.go
	communicator/ssh/communicator_test.go
	communicator/ssh/keychain.go
	communicator/ssh/keychain_test.go
2014-04-26 11:12:06 -07:00
higebu 37b92dff3a Fix unknown command and syntax error of the ESX5Driver 2014-04-22 00:27:33 +09:00
higebu f087ce16dc Fix the build problem by updating ssh package 2014-04-15 10:17:26 +09:00
Ross Smith II 27491f93f8 use old ssh code until higebu's branch is ready, see #1019 2014-04-11 08:23:12 -07:00
Mitchell Hashimoto e3c0715eab fmt 2014-02-21 15:11:56 -08:00
Mitchell Hashimoto d44a42b04f Merge pull request #884 from pmyjavec/vmware-iso-driver-fix
builder/vmware: get host IP by creating & inspecting connection, allows hypervisor...
2014-02-21 15:11:35 -08:00
Mitchell Hashimoto 9f7670a50f builder/vmware-iso: output upload error [GH-899] 2014-02-21 14:07:25 -08:00
Paul Myjavec aedef06016 esx5, Get host IP by creating & inspecting connection, allows hypervisor to reside in other networks 2014-02-20 19:37:12 +11:00
Mitchell Hashimoto 430963f400 fmt 2014-01-19 19:30:11 -08:00
Myles Steinhauser 28286d2821 Fix tabs vs spaces 2014-01-13 00:03:10 -05:00
Myles Steinhauser e4cfcb2a8a Add more special scancodes 2014-01-10 12:40:43 -05:00