22d1322bd9
always check for an error first when walking a path
2017-01-26 16:32:21 -08:00
c9259d116f
builder/amazon-ebsvolume: Fix interpolation of block_device
2017-01-26 21:27:36 +01:00
76f897077d
Merge pull request #4399 from rickard-von-essen/aws-interpolate
...
WIP: builder/amazon: Interpolate {{ .BuildRegion }} and {{ .SourceAMI }}
2017-01-26 11:41:16 -08:00
485fa58b43
Merge pull request #4443 from mitchellh/preservedockermode
...
communicator/docker: preserve file mode.
2017-01-26 11:22:00 -08:00
de7388fa0a
builder/amazon-ebsvolume: Fixed interpolation of tags
2017-01-25 19:40:43 +01:00
2a7c84e9ff
Merge pull request #4343 from vtolstov/qemu_convert
...
builder/qemu: allow to convert from any supported format
2017-01-24 01:12:31 -08:00
a51f492558
communicator/docker: preserve file mode.
2017-01-23 13:47:22 -08:00
6e891cf682
Fixed botched merge and review comments
2017-01-22 21:57:23 +01:00
9e2d69fb97
builder/docker: create export dir if needed
2017-01-21 23:51:08 -08:00
ba9cae5078
builder/amazon: Add SourceAMI and BuildRegion template
...
Added {{ .SourceAMI }} and {{ .BuildRegion }} template values availible
in `ami_description`, `run_tags`, `run_volume_tags`, `tags`, and
`snapshot_tags`.
2017-01-21 20:39:58 +01:00
f1175c1921
parallels/vmware: don't wait for shutdown command.
...
Resolves #4134
replaces/ closes #4379
Leaving Hyper-V builder alone for now until we can get a case that reproduces.
2017-01-20 01:44:18 -08:00
fc30f6cc0a
log tag creation.
...
closes #4427
2017-01-19 12:00:41 -08:00
56b5e97bf4
verify given security group
2017-01-18 15:25:31 -08:00
b265d2614f
builder/amazon: fix when using security_group_id
...
If `security_group_id` was specified with a group that didn't exist, packer
would go into an infinite loop waiting for it. We shouldn't make assumptions
about the status of explicitely set security groups, so let's just error out
right away if we can't find it.
2017-01-18 15:11:52 -08:00
7ad77b9e93
integrate new winrm transport interface
2017-01-18 22:11:48 +01:00
0a46d883df
Merge pull request #4409 from mitchellh/httpenvvar
...
set PACKER_HTTP_ADDR env var when available.
2017-01-18 12:35:14 -08:00
f5bf588393
tag all volumes
2017-01-18 11:34:46 -08:00
800351b7ca
fix panic and don't print each tag we add.
2017-01-18 11:34:36 -08:00
d9186dc8cf
add proper error handling for tagging source instance
2017-01-18 14:02:10 +01:00
ae016a1f25
simplify code flow: skip the step if no run_volume_tags provided
2017-01-18 13:03:05 +01:00
a65af51a4b
apply source instance default "Name" tag only if it's not provided in run_tags
2017-01-18 12:55:18 +01:00
36d8a1df1d
use common.ConvertToEC2Tags to apply tags to source EBS volumes, change Say message
2017-01-18 12:52:59 +01:00
aa70c82ec8
use ConvertToEC2Tags to apply tags to source instance, add Say message
2017-01-18 12:50:20 +01:00
26dd3af9ec
Merge pull request #4411 from rickard-von-essen/issue-4406
...
builder/vmware: Try to use `ip address` to find host IP
2017-01-17 22:02:59 -08:00
d4b043451f
Merge pull request #4357 from dave2/gh-4215
...
Openstack builder should use existing floating IPs before allocating them
2017-01-17 11:14:59 -08:00
94a2aae749
Merge pull request #4361 from Tom-Byrne/openstack-instance-metadata
...
support OpenStack instance (not image) metadata
2017-01-17 11:05:20 -08:00
81ad800fb6
builder/vmware: Try to use `ip address` to find host IP
...
Closes #4406
2017-01-17 10:33:48 +01:00
d2e59e4e92
set PACKER_HTTP_ADDR env var when available.
...
If using a builder that has an http server set up for file transfer,
expose the connection info to the shell provisioner through the environment
variable PACKER_HTTP_ADDR.
Closes #2869
2017-01-16 23:19:52 -08:00
6ad702ad74
Update comments to reflect current implementation
2017-01-14 20:11:51 -08:00
ee2d636840
Improve delay between key events
...
- Can now tune delay using PACKER_KEY_INTERVAL
- Added implementation to all of VMware and QEMU
- Removed double delay for QEMU
- Default key delay of 100ms (as before)
- Added docs to QEMU and VMware pages
2017-01-14 17:56:04 -08:00
d0c64f90d5
Read key interval from ENV; default to 100ms
2017-01-14 16:52:37 -08:00
da083506f1
Reduce key delay to 10ms to boot times are a lot faster
2017-01-14 16:52:24 -08:00
c1f5545986
compress pr #4395
2017-01-13 11:42:20 -08:00
9435fa62e3
Output error causing ebs volume deletion failure
...
When an ebs volume fails to delete, Packer reports that there
was an error deleting the volume and the volume id. But it doesn't
give you the details of what that error is. This commit adds the
error reported back to the standard output.
2017-01-13 15:33:47 +00:00
b9d08e9d56
Merge pull request #4385 from rickard-von-essen/issue-4383
...
docker: Fix crash when performing log in to ECR with an invalid URL.
2017-01-11 11:37:37 -08:00
112f5abdae
docker: Fix crash when performing log in to ECR with an invalid URL.
...
Closes #4383
2017-01-11 20:23:24 +01:00
98b0f018fa
Merge pull request #4378 from DanHam/skip-export-vmware
...
Add option to skip export of installed VM for VMware ISO builder
2017-01-10 15:24:58 -08:00
a3da92dc97
Merge pull request #4339 from DanHam/gh-4131
...
Add option to skip export of installed VM for vbox ISO & OVF builders
2017-01-10 15:08:15 -08:00
c7e8d671a9
Add option to skip export of installed VM for VMware iso builder
2017-01-10 11:44:11 +00:00
26fe9cf339
builder/amazon: Fix crash in amazon-instance
...
Closes #4360
2017-01-06 15:17:02 +01:00
377f451a9e
it's InvalidGroup
2017-01-05 16:56:49 -08:00
e54605c120
Properly wait for security group to exist.
...
Adds check for `InvalidGroupID.NotFound` in addition to
`InvalidSecurityGroupID.NotFound`.
Uses aws's `waiter` for clarity.
2017-01-05 15:20:28 -08:00
d7545c4ba0
support OpenStack instance metadata
2017-01-05 14:42:32 +00:00
08ef89f032
Openstack builder should use existing floating IPs before allocating them
...
Rather than always creating a new floating IP, search the provided pool
for an unallocated address and use this instead. Only allocate a temporary
address if there is no spare address in the pool.
Closes #4215
2017-01-05 08:59:49 +13:00
aef6e0e93f
Merge pull request #4304 from dave2/gh-4277
...
Querying EC2 security groups should report unexpected errors
2017-01-04 10:53:28 -08:00
85cf00069f
Merge pull request #4294 from legal90/iso-target-extension
...
Add "iso_target_extension" option for all local *-iso builders
2017-01-04 13:48:28 +01:00
01c09aa7f7
Merge pull request #4325 from siepkes/f-triton-builder-2
...
Add Joyent Triton Builder
2017-01-01 15:40:11 -06:00
ae2e59634c
Merge pull request #4341 from rahart/f-chroot-snapshots-crash
...
amazon-chroot builder snapshot interface panic
2017-01-01 22:13:11 +01:00
ac769be49a
Pause between each boot command element rather than each char with -debug
...
Fixes #4332
2016-12-31 11:57:11 +00:00
20349f750d
builder/qemu: allow to convert from any supported format
...
In case of disk_image: true user can have raw image, but in packer
template specify qcow2 image format.
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-12-30 17:19:14 +03:00
690302a6a3
Minor cleanup and style fix.
2016-12-29 18:58:56 +01:00
e31d75eca8
Quick fix for issue #4340
2016-12-29 09:16:52 -07:00
0ac071b6e7
Add option to skip export of installed VM for Virtualbox ISO & OVF builders
...
Closes #4131
2016-12-29 13:19:59 +00:00
0c9b576c05
* Unentagled SSH communication with VM's from the Cloud API SSH private
...
key.
* Improved documentation.
2016-12-29 13:24:56 +01:00
24786aeece
Processed code review feedback.
...
* Removed unneeded if statements.
* Made source machine name optional.
2016-12-28 16:03:11 +01:00
7606dd541b
* Contains the SSH fix by @watters of #3840 .
...
* Fixed minor lint error.
* Added documentation for this builder in `triton.html.md`.
* Added (and updated) the needed Joyent Triton Cloud API Go libraries
to `vendor.json`.
2016-12-27 17:05:27 +01:00
e15be036d7
builder: add Triton builder
...
This is a builder for Joyent's Triton system. It was originally at
jen20/packer-builder-triton, and subsequently at
joyent/packer-builder-triton on GitHub. The following commit vendors the
dependencies.
2016-12-24 10:25:31 +01:00
13bb4d153a
qemu builder now needs to explicitly set WinRMPort for StepConnect
...
Same as vbox builders, aligns qemu with changes to
helper/communicator/step_connect.go introduced by PR #2576
2016-12-23 23:15:51 +00:00
686ec1866e
vbox builders now need to explicitly set WinRMPort for StepConnect
...
Aligns vbox builders with changes to helper/communicator/step_connect.go
introduced by PR #2576
Fixes #4310
2016-12-23 15:55:10 +00:00
4939ea1a3b
Add support for Hyper-V admins security group
2016-12-22 14:59:25 +00:00
2e358ae4a1
Revert "builder/virtualbox: group keyboard codes"
2016-12-21 15:12:17 -08:00
4b1e014be8
builder/amazon: Crashes when multiple EBS vols are used
...
If you use a new EBS vol (which hasn't any snapshot) Packer crashes when
creating the AMI.
Closes #4303
2016-12-21 15:37:08 +01:00
308a01795c
Merge pull request #4305 from mitchellh/replace4247
...
builder/virtualbox: group keyboard codes
2016-12-20 18:15:38 -08:00
ee86dc87fd
fix broken test
2016-12-20 18:10:58 -08:00
aa177de54b
add test for #4247
2016-12-20 17:51:47 -08:00
ae5730c5a5
Querying EC2 security groups should report unexpected errors
...
As noted in #4277 , we don't report any errors from the loop waiting for
a security group to exist. Instead, we should accept 'errors' which result
from the group not yet existing, and report errors which are actual issues
the user needs to resolve (eg, IAM permissions are incorrect).
Closes #4277
2016-12-21 11:45:12 +13:00
f1dd0811d8
builders/openstack: fix for finding resource by ID.
...
Pass server serviceClient to create params so it can look up resources by ID.
Resolves #4299
2016-12-19 13:47:09 -08:00
9801e67fdc
Merge pull request #4293 from mitchellh/usedefaultdisplay
...
builder/qemu: add use_default_display option for osx compatibility
2016-12-19 11:41:36 -08:00
e4f6eaae9b
Merge pull request #4231 from artburkart/force-delete-snapshot-patch
...
Fixes acceptance test for PR #4223
2016-12-17 11:43:26 -08:00
57d07f227a
Add "iso_target_extension" option for all local *-iso builders
...
This option allows to set the extension of the ISO file after download.
Defaults to "iso". It makes sense for building Mac OS X guests, where the
bootable image is actually a DMG, not an ISO.
In particular, it is important for "parallels-iso" builder to set the right extension.
2016-12-17 12:50:30 +02:00
0339fcc442
builder/qemu: add use_default_display option
...
If set, won't set `-display dsl` as a default argument. Useful for osx
compatibility.
2016-12-16 17:44:54 -08:00
aa623e22a3
golint: Add comments for exported methods
2016-12-17 00:37:04 +02:00
73d87b07de
golint: Fix lint offences
2016-12-17 00:37:03 +02:00
00a90e622b
Remove unused constant "KeyLeftShift"
2016-12-17 00:37:03 +02:00
1ca841b499
Fix shadowed declarations
...
Performed by "go vet" tool
2016-12-17 00:37:03 +02:00
dde445bd0d
Fix style: Organize imports in groups
...
Performed by "goimports" tool
Style conventions: https://github.com/golang/go/wiki/CodeReviewComments#imports
2016-12-17 00:37:03 +02:00
319b85cb7a
Fix style: Use a consistent case for initialisms
...
https://github.com/golang/go/wiki/CodeReviewComments#initialisms
2016-12-17 00:36:56 +02:00
c61c7765ec
Merge pull request #4288 from troytoman/gce-network-uri
...
enable support for Google Compute XPN
2016-12-15 12:03:46 -08:00
88841cb0e4
Merge pull request #4283 from mitchellh/openstackhacks
...
builder/openstack: Add image visibility & members
2016-12-14 16:13:21 -08:00
754ed931e9
be nice if user gets the image visibility case wrong
2016-12-14 16:08:36 -08:00
d3c2239b9e
builder/amazon: Change shutdown_behaviour to shutdown_behavior
2016-12-14 21:59:16 +01:00
c24b4423b2
builder/amazon: Added new region London - eu-west-2
2016-12-14 10:55:19 +01:00
1408c3fde8
bugfix
2016-12-14 01:01:57 -08:00
00e4585ce5
first pass at adding new members
2016-12-13 16:32:30 -08:00
cbe7e9113a
return early if no set visibility
2016-12-13 16:32:15 -08:00
99667df17e
update image visibility own step
2016-12-13 16:28:54 -08:00
7bd211cf61
first attempt at modifying visibility
2016-12-13 15:21:20 -08:00
6a6e735d16
use 404 error type
2016-12-13 14:20:39 -08:00
01e3e7f7a3
Second part of resync of gophercloud
2016-12-13 14:06:01 -08:00
ac98aad1df
Fix log statement
2016-12-13 12:53:03 +01:00
45d4cf8b36
move powershell module to common
2016-12-12 18:34:15 -08:00
5e324d6bb4
apply #4041 to hyperV builder
2016-12-12 18:34:15 -08:00
e50fe9fd54
Porting over paulmey changes to license and copyright headers. Good guy Microsoft have changed the licensing to MPL2 and removed the copyright headers so that we can include it in the official Packer release.
...
1ce6ba91f7
2016-12-12 22:45:24 +00:00
e357c56186
Builders don't need to set this up anymore
2016-12-12 22:45:23 +00:00
74255c553b
Be smarter about loading guest additions iso. Windows 10 and Windows Server 2016 no longer come with iso. So default to not loading guest additions when the iso is missing
2016-12-12 22:45:22 +00:00
335615408a
Run go fmt on files
2016-12-12 22:45:19 +00:00
44f73fa75f
Changed ram_size_mb to ram_size
2016-12-12 22:45:18 +00:00
fb192ce6d6
Remove unused import
2016-12-12 22:45:17 +00:00
04a6880361
Remove unused import
2016-12-12 22:45:17 +00:00
3f0835aab2
Remove headless option as it is not used.
2016-12-12 22:45:16 +00:00
3c1df5a791
Remove inconsistent "_mb" from ram size
2016-12-12 22:45:14 +00:00
0515487062
Configuration settings are no longer used
2016-12-12 22:45:13 +00:00
20643e35a8
Do not specify a default username or password
2016-12-12 22:45:13 +00:00
d7117560cf
We are using powershell and Msvm to send keys to virtual keyboard so update comment
2016-12-12 22:45:12 +00:00
a27d75ff89
Fix comment left over from initial import
2016-12-12 22:45:11 +00:00
501845cb4f
SSHKeyPath and SSHWaitTimeout have been deprecated in favor of communicator configuration
2016-12-12 22:45:10 +00:00
c2d1f6b617
Added the ability to independently configure switch vlan. This will people to leave the switch in trunk mode and set a vlan for the vm.
2016-12-12 22:45:06 +00:00
48b6cc0650
Enable VlanID
2016-12-12 22:45:05 +00:00
9fbd1e472a
Add support for mac spoofing and dynamic memory.
...
To enable nested virtualization, mac spoofing, no dynamic memory and at least 4gb of ram should be set for the vm. Set warning if this has not been done.
Detected Virtualization Extensions are supported by the machine your are running on, as it only works for Windows 10 and Windows Server 2016 onwards.
2016-12-12 22:45:04 +00:00
6d391fc34a
Adding support for nested Hyper-V
2016-12-12 22:45:02 +00:00
f94c2cd2f7
Adding nested virtualization support
2016-12-12 22:45:01 +00:00
6342e1525d
s/EnabeSecureBoot/EnableSecureBoot/g
2016-12-12 22:45:01 +00:00
9c53df1e0e
Add special key modifiers to log output when used.
...
Update documentation to include new key modifiers.
2016-12-12 22:44:59 +00:00
5f7290c6f8
Add type scan support for ctrl, shift, alt.
...
<leftAlt>
<leftCtrl>
<leftShift>
<rightAlt>
<rightCtrl>
<rightShift>
Add type support for combinations of ctr, alt, shift with (only use lower case characters with this):
<leftAltOn>
<leftCtrlOn>
<leftShiftOn>
<leftAltOff>
<leftCtrlOff>
<leftShiftOff>
<rightAltOn>
<rightCtrlOn>
<rightShiftOn>
<rightAltOff>
<rightCtrlOff>
<rightShiftOff>
2016-12-12 22:44:58 +00:00
c1538c59c9
Builds in AppVeyor are failing as they do not have enough free memory. Drop the thresh hold a little more.
2016-12-12 22:44:57 +00:00
52c6cd5fc1
Test should run and pass even when run on an environment that does not have Powershel.
2016-12-12 22:44:53 +00:00
4d22bd1d4a
Generate switch name using uuid v1
2016-12-12 22:44:49 +00:00
7c754bf791
Try to match style of other builders
2016-12-12 22:44:48 +00:00
fb098fcbf0
http server has moved to common step
2016-12-12 22:44:47 +00:00
d878f4dd8e
A workaround for bug in Windows 10 and Windows 2016 where you have to specify a path when creating a dvd drive
2016-12-12 22:44:44 +00:00
bda2468404
removed unused reference
2016-12-12 22:44:40 +00:00
d1961b7c8e
Echo output when its used
2016-12-12 22:44:40 +00:00
18241e5215
Setting boot drive is generation specific
2016-12-12 22:44:37 +00:00
8477a0b748
Accidentally included bracket
2016-12-12 22:44:35 +00:00
e0c10dec12
If exit code = 1 and the length of the stderr is 0, then we can assume that the exit code was not set, so assume success
2016-12-12 22:44:34 +00:00
fe8d99fd8a
If we are not getting the exit code assigned then default to it being successful
...
Useful to know what the exit code is if there is an error
2016-12-12 22:44:31 +00:00
3cb621f890
Get rid of mount and unmount that does not specify controller location exactly
...
Handle cleanup if unmount step has not already done so
2016-12-12 22:44:30 +00:00
31ac1da28d
Setting boot drive message
2016-12-12 22:44:30 +00:00
4b6ce3da60
Build agents might not have guest additions
2016-12-12 22:44:29 +00:00
aaf9007249
Include cache in the state bag.
2016-12-12 22:44:28 +00:00
50a8d1b6b4
Forgot to check in these files.
2016-12-12 22:44:27 +00:00
010d171bec
GuestAdditionsMode and GuestAdditionsPath can be set in config. If GuestAdditionsMode == "attach" it will mount the HyperV Integration Services ISO. If GuestAdditionsPath is set, then it will be used as an alternative to where the HyperV Integration Service ISO is.
...
Included the build step to download ISO, so iso_urls works properly now.
Online activation should be done via provisioner
Installation of integration services should be done via provisioner
Cleaned up the way dvd drives are mounted and unmounted (still need to implement feature to find unused drives before adding a new one)
Cleaned up the way floppies are mounted and unmounted
2016-12-12 22:44:27 +00:00
422efeeaf6
Make use of driver instead of directly referencing hyper
...
Move inline powershell to hyperv
2016-12-12 22:44:26 +00:00
730c6217ad
Fix disk size test
...
Default minimum and maximum sizes were geared towards spinning up windows server instances. Linux instances are far more efficient and make do with lower requirements. Set the minimum sizes to match this.
2016-12-12 22:44:21 +00:00
9f94834826
Use correct formatting for printf
2016-12-12 22:44:19 +00:00
54733323a8
Should only default to first controller if its not 1 of the 2 controllers available
2016-12-12 22:44:18 +00:00
c24c882b84
Use simple naming convention for now
2016-12-12 22:44:16 +00:00
5f2c12324c
No need to remove floppy controller for 2nd generation vms
...
Don't want to be prompted for confirmation from powershell commandlets
2016-12-12 22:44:14 +00:00
837f9addd0
Check the floppy files and not the dvd files attached
2016-12-12 22:44:13 +00:00
4e8074d7e5
Need to expose generation as a public property
2016-12-12 22:44:13 +00:00
e18594f404
Hyperv generation 2 machines use scsi for dvd drives. Allow gen 1 machines to have at least 1 iso image attached
2016-12-12 22:44:12 +00:00
ef507c7bd7
Pass in any iso images to add as dvd drives during boot
2016-12-12 22:44:11 +00:00
3051ea6633
Quote powershell so that it does not try to interpret command to be run
...
Get VName out of state. This allows template replacement to be run on vmname
2016-12-12 22:44:10 +00:00
f3cc413bbb
Set the dvd to the first boot device
2016-12-12 22:44:08 +00:00
02db768018
With generation 2 machine by default a dvd drive is not created. So create a dvd drive for os if it does not exist.
...
Allow secure boot mode to be configured from config.
2016-12-12 22:44:07 +00:00
aa1f1da1ff
Support for boot_command
...
Setup local http server
Add compaction of hard drive
GetHostAdapterIpAddress function added for hyperv
renamed step step_start_vm to step_run to fall in ine with naming conventions of other builders
2016-12-12 22:44:07 +00:00
03b0698edd
Remove devices after it has been shut down
...
Attempt to stop vm, before deleting it
2016-12-12 22:44:06 +00:00
2d7cfcd65d
Throw error if we can't get mac or ip address during steps
2016-12-12 22:44:05 +00:00
87b3dec3d2
Wait until WinRM is available, before continuing with install. This is how other system like VeeWee do it.
...
Add support for number of cpus to use for vm
Add support for vm generation
2016-12-12 22:44:04 +00:00
79a5f90379
Use the convention for default vmname
...
Use the convention for default hdd size
Tests added for builder
2016-12-12 22:44:04 +00:00
Matthew Hooker
Rickard von Essen
Eike Verdenhalven
Roman Zhuzha
Chris Bednarski
Richard Moore
DanHam
Tom-Byrne
Zanetti, David
James Nugent
Vasiliy Tolstov
Jasper Siepkes
Travis Harrington
Tadas Medisauskas
Mikhail Zholobov
Alexander Krasnukhin
Taliesin Sisson
James Johnson
Patrick Lang
Taliesin Sisson