Megan Marsh
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting
...
Revert hddorder setting
2018-12-13 16:27:31 -08:00
Megan Marsh
7d5ea43f41
revert the hddorder being added to the vmx template, since it's breaking things for some of our users.
2018-12-13 09:58:24 -08:00
Megan Marsh
b95123f457
add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work.
2018-12-13 09:12:23 -08:00
Adrien Delorme
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes
...
revert changes to docker entrypoint; since this is a backwards-breaki…
2018-12-13 10:23:18 +01:00
Megan Marsh
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
...
Move logging about aws waiters to the access config prepare() so that…
2018-12-12 15:42:37 -08:00
Megan Marsh
2a79d64ae0
revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release
2018-12-12 15:30:24 -08:00
Megan Marsh
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id
...
Check that the KMS key ID is valid
2018-12-12 10:04:22 -08:00
Tom Elliff
12bf7fc4d6
Check that the KMS key ID is valid
...
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.
Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
2018-12-12 11:41:58 +00:00
Adrien Delorme
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087
...
fix virtualbox 6.0 beta command options
2018-12-11 11:54:56 +01:00
Adrien Delorme
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code
...
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-11 11:53:26 +01:00
Megan Marsh
a819217c93
fix virtualbox 6.0 beta command options
2018-12-10 15:18:21 -08:00
Ali Rizvi-Santiago
1a36458e9e
Tiny fix to replace some duplicate code with usage of the `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-10 16:24:27 -06:00
Megan Marsh
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
...
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
Ali Rizvi-Santiago
a6af04417e
Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument.
2018-12-10 15:09:56 -06:00
Megan Marsh
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
...
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
chhaj5236
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied
...
alicloud: delete copied image and snapshots if corresponding options are specified
2018-12-09 19:39:14 +08:00
Adrien Delorme
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965
...
Fix 6965
2018-12-07 13:35:00 +01:00
Megan Marsh
ce71932f95
Merge pull request #7061 from boumenot/pr-6773-caching-type
...
azure: configuration for disk caching
2018-12-06 15:06:21 -08:00
Megan Marsh
042e9ad14b
Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder.
2018-12-06 14:37:31 -08:00
Ali Rizvi-Santiago
2e977019e4
Modified the docker builder's default run_command to specify the shell via the entrypoint command line argument as suggested by @vrubiolo in #6920 .
2018-12-04 23:52:17 -06:00
bozhi.ch
0174a502eb
support -force option and update docs
2018-12-05 11:50:35 +08:00
Ali Rizvi-Santiago
310ea6c006
Updated docker's default config to use regular bourne shell instead of bourne again. Closes #6920 .
2018-12-04 18:28:48 -06:00
Ali Rizvi-Santiago
040a33567e
Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser..
2018-12-04 16:54:47 -06:00
Ali Rizvi-Santiago
79b68fb89c
Replaced the previous incorrect logic with an re-implementation of common.ExpandUser.
2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
e04986659a
Changed the logic for when to actually prefix a path with a u.HomeDir so that it's only done when a non-absolute path is specified.
2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
1a3c3f2ffc
Replaced all instances of mitchellh/go-homedir with an implementation based on os/user.
2018-12-04 16:53:33 -06:00
Megan Marsh
152f6fed8f
Merge pull request #7066 from arizvisa/vmware-temporary-devices
...
Add a "temporaryDevices" key to the statebag for the VMware builder
2018-12-04 10:34:37 -08:00
Ali Rizvi-Santiago
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
Megan Marsh
65124985d1
don't set DetectZeroes if it's off, because some versions of QEMU don't support this option
2018-12-03 15:52:13 -08:00
Ali Rizvi-Santiago
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
Ali Rizvi-Santiago
e0d3861e81
Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
27b16cee0a
Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.
2018-12-03 17:47:45 -06:00
Christopher Boumenot
c7d8f4e150
azure: configuration for disk caching
...
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite. This seems the most appropriate value
given Packer. Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
Megan Marsh
c03894c05d
fix bad interpolation exemption for volume_size
2018-11-29 16:39:43 -08:00
Adrien Delorme
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels
...
add snapshot_labels to hcloud builder
2018-11-29 13:48:57 +01:00
Megan Marsh
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation
...
move region validation to run so that we don't break validation when no creds are set
2018-11-28 15:02:18 -08:00
Megan Marsh
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
PORTE Loïc
bf97557abf
Backport VNC log from vmware to qemu
2018-11-28 19:13:29 +01:00
bozhi.ch
a485bcfdf3
delete copied image and snapshots if corresponding options are specified
2018-11-28 21:34:21 +08:00
Megan Marsh
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
Megan Marsh
89fb8f0d3e
fix defaulting/lack thereof for cpu count and memory in vmware template
2018-11-27 15:43:48 -08:00
Nathan A. Ferch
fccd7d0692
add snapshot_labels to hcloud builder
2018-11-27 14:41:32 -05:00
Megan Marsh
6728244480
simplify for loop logic
2018-11-27 09:33:29 -08:00
Andrew Pennebaker
c05ac784d3
fix tests
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5ada3376b8
fix test
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
2c989157e4
gofmt
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5b6cbeed1d
expose `--iso` option down in `VBoxManage export --iso` up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled.
2018-11-27 09:31:01 -08:00
Megan Marsh
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode
...
[Hetzner Cloud] Support for builds using rescue mode
2018-11-26 11:39:34 -08:00
bozhi.ch
7704ff2f24
apply tags to relevant snapshots
2018-11-26 16:58:32 +08:00