Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
.
2018-09-10 16:48:42 -07:00
Adrien Delorme
32cacad273
remove comment that is not true anymore
2018-09-06 16:50:47 +02:00
Adrien Delorme
bb59a70e8f
progressbar: use int64 instead of uint64
...
* it's what's used for file sizes and used lib
2018-09-06 16:49:15 +02:00
Adrien Delorme
f9c58e2b1f
download: defer progress bar Finish
2018-09-06 16:38:28 +02:00
Adrien Delorme
3842f85eb4
download: remove close calls that are already defered
2018-09-06 16:30:35 +02:00
Adrien Delorme
23762a1810
fix tests for common/download_test.go
2018-09-06 15:53:59 +02:00
Adrien Delorme
7f50228080
remove old/unused progress code
2018-09-06 15:53:59 +02:00
Adrien Delorme
059e14fe42
put back usefull debug
2018-09-06 15:53:59 +02:00
Adrien Delorme
a11f985e3c
revert unecessary check
2018-09-06 15:53:59 +02:00
Adrien Delorme
a9d302def8
removed debug logs
2018-09-06 15:53:59 +02:00
Adrien Delorme
541c68aed5
add StackableProgressBar struct that will refresh/show dl status for multiple files
...
* simplified the downloader interface, and removed the total/current values from them
* downloaders use a proxy reader that will add all read bytes to progress
* removed unused const mtu
* DownloadClient doesn't need a downloader, so I removed it too
2018-09-06 15:53:59 +02:00
Adrien Delorme
fd7cb47adc
use proxy reader for download progress & stop storing total/current in downloaders
2018-09-06 15:53:59 +02:00
Adrien Delorme
ddd96c513b
first draft at self refreshing loading bar centralized/controlled by Ui
2018-09-06 15:53:59 +02:00
Adrien Delorme
5a8af5500b
random: optimize allocation & simplify loop
2018-09-05 10:27:02 +02:00
Adrien Delorme
4682b3a9d2
refactor possible random strings into common/random
2018-09-05 10:26:52 +02:00
Adrien Delorme
170b2f3383
builder/azure/common.RandomString-> common/random.String
...
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
Adrien Delorme
9cefd69f0d
change progress bar display rate to 5s to reduce 'spamminess' ( #6640 )
...
#6625
2018-08-30 16:00:30 +02:00
Megan Marsh
8309f36176
Merge pull request #6626 from hashicorp/fix_6620
...
make reasonable tempfile default on windows
2018-08-27 09:43:04 -07:00
Matthew Hooker
7519037562
Merge pull request #6629 from hashicorp/travisbuild
...
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
Matthew Hooker
8a604114ef
remove unused code
2018-08-24 20:43:51 -07:00
Matthew Hooker
3f1a9766f4
formatting verb fixes for go 1.11
2018-08-24 16:18:21 -07:00
Megan Marsh
c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
...
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Megan Marsh
f5355a0693
make reasonable tempfile default on windows
2018-08-24 09:44:50 -07:00
Megan Marsh
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
Megan Marsh
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
...
Filter logs
2018-08-23 13:30:21 -07:00
Megan Marsh
31d4f8af45
use a time.Duration instead of a hardcoded ms
2018-08-23 13:16:01 -07:00
Megan Marsh
918db58604
added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
2018-08-22 11:37:56 -07:00
Adrien Delorme
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
Ali Rizvi-Santiago
cf9bbe3ecf
Incorporated the hack demonstrated by @SwampDragons in order to deal with packer.rpc.Ui not exporting any information about what it's doing to anybody.
2018-08-20 21:55:18 -05:00
Ali Rizvi-Santiago
5726927cba
Moved the progress bar out of packer.Ui and unlinked it out of all the packer.Ui implementations. Split up the terminal-related functions into a separate terminal.go and calculate the progress bar width by traversing through packer.Ui to avoid the issue with github.com/ugorji/go/codec serializing private members (or unsafe pointers) of structs. Shuffled some arguments around in getConsoleScreenBufferInfo in common/terminal_windows.go so that the interface forces the user to correctly declare a _CONSOLE_SCREEN_BUFFER_INFO type.
2018-08-20 21:55:18 -05:00
Ali Rizvi-Santiago
0f10032b3d
Moved the progress bar from common to the packer.UI interface and refactored it so that the terminal width is calculated based on each interface which returns a custom progressbar specific to its ui.
2018-08-20 21:55:18 -05:00
Ali Rizvi-Santiago
fd2fef8738
Added support for the progress bar to automatically determine its width using the minimum length from a packer.UI and the terminal dimensions via kernel32.GetConsoleScreenBufferInfo or an ioctl (TIOCGWINSZ) to "/dev/tty".
2018-08-20 21:55:18 -05:00
Ali Rizvi-Santiago
16ecb3ad9a
Reverted removal of progress-bar that was done by commit 5d97b105a8
and added some missing arguments that were missed during the rebase. Modified the default progress bar's width to 80 as a result of the conversation on PR #5851 .
2018-08-20 21:55:18 -05:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Adrien Delorme
a5587e30ec
log wether the file was transfered or is just being inplace referenced
2018-08-20 11:45:57 +02:00
Adrien Delorme
6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them"
2018-08-20 10:48:06 +02:00
Adrien Delorme
c744e8b2bb
make download messages less redudant and more simple
2018-08-17 09:29:39 +02:00
Adrien Delorme
d7d4aed51c
be even more precise
2018-08-16 18:56:28 +02:00
Adrien Delorme
2b3ea29970
show more precise error download/copy/referencing messages
2018-08-16 18:41:44 +02:00
Adrien Delorme
fae3db4e58
test inplace linking
2018-08-15 17:09:39 +02:00
Adrien Delorme
17f2949e36
remove stuttering; ISOConfig.InplaceISO -> Inplace
2018-08-15 15:51:25 +02:00
Adrien Delorme
863222b1e2
Also use the terminology Inplace in DownloadConfig for clarity/consistency
...
* swapped boolean checks
* swapped in tests too
2018-08-15 15:26:31 +02:00
Adrien Delorme
82e480a285
allow to use ISO images inplace v.s. copying them
2018-08-15 14:37:38 +02:00
Ali Rizvi-Santiago
71e43d0b7f
Updated common/download.go to handle when a connection error happens (response is nil), and reformatted the error that's returned when an HTTP error occurs.
2018-07-28 19:09:29 -05:00
Megan Marsh
5ef8b55559
need log import
2018-07-23 10:34:05 -07:00
Megan Marsh
a2f5fbadf6
don't fail if you can't find abs or relative path.
2018-07-23 09:54:25 -07:00
DanHam
da21c25791
Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts
...
grep -rli --exclude-dir={vendor,bin\*,\*vmware\*,\*pkg\*} vmxc . | \
xargs sed -i 's/\(vm\)\(x\)\(c\)/\1\3\2/ig'
2018-07-20 02:12:47 +01:00
DanHam
674bad0ab4
Break very long lines for readability
2018-07-20 02:12:47 +01:00
DanHam
d2390f464d
Actually implement the function for the driver
2018-07-20 02:12:45 +01:00