Commit Graph

3018 Commits

Author SHA1 Message Date
Matthew Hooker 8510f072a9
Merge pull request #5841 from hashicorp/fix5447
Add volume and run tags if in us-gov/china
2018-02-05 17:29:12 -08:00
Matthew Hooker 21812fa17f
Add volume and run tags if in us-gov/china
We can't tag on instance creation when we're in "restricted" regions,
so let's add the tags after the resources have been created.

Adds methods to AccessConfig to detect if we're in China or US Gov
regions (i.e. "restricted").

Also turns tag:tag maps into a type, and moves methods around validating
and converting them to ec2Tags to methods of the type.
2018-02-05 16:39:20 -08:00
Matthew Hooker ff64ccda55
Merge pull request #5426 from hashicorp/fix_4915
Fix 4915
2018-02-05 14:54:27 -08:00
SwampDragons 7d5d62d748
Merge pull request #2906 from arizvisa/GH-2377
Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme
2018-02-05 09:53:47 -08:00
Petr Hosek eaef2961cb Support specifying licenses for Google Compute images
This is needed to enable features such as the nested virtualization:
https://cloud.google.com/compute/docs/instances/enable-nested-virtualization-vm-instances
2018-02-03 14:15:16 -06:00
Ali Rizvi-Santiago fa2dddd26d Fixed some things mucked up during rebase. 2018-02-02 19:45:18 -06:00
Ali Rizvi-Santiago aefe41a44a Fixed an issue with the previous commit so that when the user does not specify the cdrom_adapter_type to fallback to the original decision made by the disk adapter type selection. 2018-02-02 19:18:50 -06:00
Ali Rizvi-Santiago eb0445ca96 Added support for specifying both the network adapter type and cdrom adapter type as requested by @night199uk. Also included the respective documentation for these new options. 2018-02-02 19:18:50 -06:00
Ali Rizvi-Santiago 74946071d2 Added support for specifying the disk adapter type to the vmware builders. This was squashed from the vmware-diskAdapterType branch (#2968) as submitted by Rami Abughazaleh <icnocop@users.noreply.github.com>. This closes #5671 and possibly #4885.
arizvisa: Updated icnocop's documentation to include the possible disk adapter types that one can specify.
arizvisa: Tweaked icnocop's support for the `disk_adapter_type` option to the VMWare builder that caused conflicts due to version skew.
icnocop: Updated links to the Virtual Disk Manager User's Guide PDF to open in a new window and also added the Adobe PDF icon
icnocop: Added support for vmware to specify the disk adapter type, ide or scsi (lsilogic or buslogic)
2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago 594ed950c7 Fixed a race condition in builder/vmware/common/driver_parser.go due to a misunderstanding how channels work when you close them. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago 737e951685 Added missing root path to path-finders for the VMware Fusion implementation in the vmware builder as mentioned by @SwampDragons. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago b2fec18b1e Added parser for VMware Fusion's networking file. Replaced VmwareDriver's NetmapConfPath with a NetworkMapperInterface in order to handle the differences between VMware Fusion and the rest of the VMware suite. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago 069d00f70b Added the paths suggested by @phekmat and @SwampDragons for VMware Fusion... Although parser for the new mapper format is likely to be needed still. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago 8cc0776f3a Fixed oversight in VMware builder's mock-driver that neglected to initialize 'HostAddressResult'. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago 029c357d8c Modified some tests to require the PACKER_ACC environment variable to be set before executing them. This turns them into acceptance tests as per CONTRIBUTING.md. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago 58ebc5c9a5 When specifying NONE for serial or parallel in the VMware builder, disable the serial and parallel port devices entirely. 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago 258804106b Added missing GetVmwareDriver() method to VMware Builder's DriverMock. 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago 6423525a33 Updated imports of github.com/mitchellh/packer to new naming scheme github.com/hashicorp/packer 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago 75fbfa0763 Replaced a hacky type assertion in the VMware builder with a call to Driver.GetVmwareDriver() that returns the driver-specific structure for ip and addressing information. Also implemented the addressing functions for the ESXi driver interface.
This fixes an issue where a driver might not have defined a VmwareDriver by forcing a developer to implement it via the standard Driver interface.
2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago 898b27c16d Added support for the NONE option to be specified for parallel and serial ports in the vmware iso builder. 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago 884af69da1 go fmt on builder/vmware/* 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago 0d6cf7fac4 Added support for auto-detection to the serial and parallel port types.
Included the yield option to all the serial port types.
Added the ability for the network type to fallback to a custom network if the
    specified network name is not found in netmap.conf.
Promoted the scope for both Read{Dhcp,Netmap}Config inside vmwcommon.driver.
Updated the documentation for the VMware builder.
2018-02-02 19:14:29 -06:00
Ali Rizvi-Santiago b52e2d3f45 Added the ability for the vmware-builder to fallback and determine the network device-name using the .vmx configuration in case of a guest using the "custom" connection type. 2018-02-02 19:13:02 -06:00
Ali Rizvi-Santiago e389d30a1b Implemented the unit-tests for builder/vmware/iso/step_create_vmx.go 2018-02-02 19:13:02 -06:00
Ali Rizvi-Santiago 15cb6a833a Ugh..missing argument in VMware builder's driver_esx5 unit-test due to api change for .HostIP(). Fixed. 2018-02-02 19:11:41 -06:00
Ali Rizvi-Santiago 9b95ce0bc6 Completely forgot to support the unix paths in each of the drivers for the VMware builder. Fixed. 2018-02-02 19:11:41 -06:00
Ali Rizvi-Santiago 4225b3568e Fixed bad ORs and a bad fmtstring. 2018-02-02 19:11:41 -06:00
Ali Rizvi-Santiago 75d3ea7cee Added support for sound, serial ports, parallel ports, usb, and specifying a default network to the vmware builder.
builder/vmware/{iso,vmx}:
    Added the specific configuration options that get parsed.
    Normalize paths when pulling them from the json template so that they'll work on Windows too.
    Added some improved error checking when parsing these options.
    Stash the vm's network connection type so that other steps can figure out addressing information
    Modified the esx5 driver to support the new addressing logic.
    Modified the template in step_create_vmx to include the new options.

builder/vmware/common:
    Implemented a parser for vmware's configuration files to the vmware builder.
    Modified the driver's interface to include support for resolving both guest/host hw and ip addresses
    Implemented a base structure with some methods that implement these features.
    Rewrote all ip and mac address dependent code to utilize these new methods.
    Removed host_ip and guest_ip due to their logic being moved directly into a
        base-structure used by each driver. The code was explicitly checking runtime.GOOS
        instead of portably using net.Interfaces() anyways.
    Updated driver_mock to support the new addressing methods
2018-02-02 19:11:41 -06:00
SwampDragons 8ae8f31a52
Merge pull request #5681 from mcandre/super-key
add super key (vmware builder)
2018-02-02 13:33:11 -08:00
SwampDragons caea770af1
Merge pull request #5819 from hashicorp/oracle-oci-builder
Oracle oci builder
2018-02-02 11:56:18 -08:00
Ben Phegan 3c88e787df
Merge branch 'master' into hyperv_mac_address 2018-02-02 09:26:52 +11:00
SwampDragons 6d14eb6ea4
Merge pull request #5631 from vijayinvites/diffdisks
[Hyper-V] Use differential disks and Inline disk creation to improve build time (a lot) and to reduce disk usage(a lot)
2018-01-31 16:51:27 -08:00
Megan Marsh 383ac13e2a update default of image list after adding new entry. 2018-01-31 16:37:55 -08:00
Megan Marsh 8f7937f492 fix machine image name to include prepended / 2018-01-31 15:22:09 -08:00
Megan Marsh 3180dc327c remove copypasta comment 2018-01-31 15:02:19 -08:00
Matthew Hooker 8bdd3b45c7
use helper functions for reading vmx files 2018-01-31 13:19:31 -08:00
Megan Marsh 66cd85828e rename dest_image_list_description to image_description 2018-01-31 12:48:40 -08:00
Matthew Hooker baf8d30ad2
Merge pull request #5738 from testworksau/intel-haxm-support
Add Intel HAXM support to QEMU builder
2018-01-31 12:41:15 -08:00
Megan Marsh af26b312cd fix logline 2018-01-31 11:35:34 -08:00
Megan Marsh 871ead371a Clean up based on Oracle comments 2018-01-31 10:47:19 -08:00
유성덕 f39c3458f7 fix Run method arguments for testing 2018-01-30 10:20:02 +09:00
Megan Marsh 705459c260 add snapshotted machine image to image lists, then delete the snapshot. 2018-01-29 16:50:53 -08:00
유성덕 e68a742bca make fmt 2018-01-29 22:44:24 +09:00
유성덕 175dd2730f Use 'github.com/hashicorp/packer/helper/multistep' 2018-01-29 22:41:22 +09:00
유성덕 5714108ef9 Merge branch 'master' into support_ncloud 2018-01-29 22:10:18 +09:00
유성덕 6b40c726e0 Use `PublicIp` for communicator 2018-01-29 22:07:32 +09:00
유성덕 e57a8161e0 remove delete step of `login key` and `public ip instance`. 2018-01-29 21:47:58 +09:00
유성덕 2a3a35334a Logging root password 2018-01-29 20:42:22 +09:00
유성덕 30f8fee402 use comment with english 2018-01-29 19:08:53 +09:00
유성덕 3820f97a0b use state storage to save `feeSystemTypeCode` 2018-01-29 18:35:43 +09:00
유성덕 2152ad7609 Add UserDataFile 2018-01-29 18:09:14 +09:00
유성덕 da78ebbf83 - Remove plugin version
- remove `os_type`. use `communicator` instead of this.
2018-01-29 17:29:26 +09:00
Matthew Hooker 76b2ce8604
log which vmware driver we decide on 2018-01-26 16:12:43 -08:00
Matthew Hooker 07421b4433
test vmware workstation version checking 2018-01-26 15:58:17 -08:00
Megan Marsh 56c6fed42a ui.say vs ui.message 2018-01-26 15:20:12 -08:00
Megan Marsh 3ee1aa3ed6 clean up ip reservations 2018-01-26 15:18:33 -08:00
Megan Marsh 565b660b19 comments 2018-01-26 14:28:27 -08:00
Megan Marsh 98857c42cf add tests; fix a couple issues caught by said tests 2018-01-26 14:27:31 -08:00
Matthew Hooker 9edd98f7b0
Use more uuids and make messaging consistent. 2018-01-26 13:43:19 -08:00
Matthew Hooker c6b43ce6e9
remove errouneous double prep 2018-01-26 13:13:13 -08:00
Matthew Hooker 71acccc1ed
add UI output with resource names 2018-01-26 13:12:35 -08:00
Matthew Hooker 18ffde4ecf
remove unused file 2018-01-26 12:59:46 -08:00
Matthew Hooker fad4d5c272
update tests for mapstructure behavior changes 2018-01-26 12:40:34 -08:00
Megan Marsh 0e5be59947 wrap error message for clarity 2018-01-26 09:55:31 -08:00
Megan Marsh ff9fef5ed2 switch to using a UUID for packer-generated keys, and clean them up at end of build 2018-01-26 09:51:16 -08:00
Megan Marsh b6d21ecd63 validate that required fields are present 2018-01-26 08:53:24 -08:00
Megan Marsh 25bc1da8fe remove unsused access config 2018-01-26 08:48:23 -08:00
Megan Marsh de2e5edf2e remove errant change in amazon builder 2018-01-26 08:43:51 -08:00
Matthew Hooker 4622bb4585
return no artifact if no snapshot was created 2018-01-25 16:32:37 -08:00
Matthew Hooker 77277ebc98
add logging behind "PACKER_OCI_CLASSIC_LOGGING" env var 2018-01-25 16:32:34 -08:00
Matthew Hooker 0fad49e897
simplify 2018-01-25 15:05:36 -08:00
Matthew Hooker 4dc42942f5
fix multistep path 2018-01-25 14:46:02 -08:00
Matthew Hooker 6dc0bd759a
import context 2018-01-25 14:43:55 -08:00
Matthew Hooker dd2384483b
add context to steps 2018-01-25 14:42:39 -08:00
Megan Marsh 00db189c9c
add docs page 2018-01-25 14:34:03 -08:00
Megan Marsh 1fffbacdd3
fix ordering of deleting security rules and lists 2018-01-25 14:34:03 -08:00
Matthew Hooker 76ea73c5b2
I don't think we need to delete this artifact right now 2018-01-25 14:34:03 -08:00
Matthew Hooker 603881d990
add oci/classic artifact 2018-01-25 14:34:03 -08:00
Matthew Hooker 44befb0857
rename 2018-01-25 14:34:02 -08:00
Matthew Hooker b9a90b9261
Check for error when creating ip reso 2018-01-25 14:34:02 -08:00
Megan Marsh 7d23cfae0a
allow user to add a security list for SSH access; add cleanup for packer-generated rules and lists 2018-01-25 14:34:02 -08:00
Megan Marsh 531cb2244d
add separated out steps 2018-01-25 14:34:02 -08:00
Megan Marsh 53ff257cf0
it LLIIIIIIIIIVES 2018-01-25 14:34:02 -08:00
Megan Marsh 89159f3a87
fix bugs in cleanup 2018-01-25 14:34:02 -08:00
Megan Marsh f6c60aac78
clean up instance 2018-01-25 14:34:01 -08:00
Megan Marsh 256382547b
snapshot step works 2018-01-25 14:34:01 -08:00
Megan Marsh 69ba710c2a
PROGRESS! Now it only fails on the snapshot step 2018-01-25 14:34:01 -08:00
Megan Marsh f208a071a4
fix communicator 2018-01-25 14:34:01 -08:00
Megan Marsh 6556a851dc
fix ssh key handling 2018-01-25 14:34:01 -08:00
Megan Marsh a8a0072049
oops need to add this moved file to git 2018-01-25 14:34:01 -08:00
Megan Marsh 8b420944c5
debugs 2018-01-25 14:34:00 -08:00
Megan Marsh 46c3113613
it compiles :) 2018-01-25 14:34:00 -08:00
Megan Marsh 8aa716cd4c
stub out step_snapshot 2018-01-25 14:33:43 -08:00
Megan Marsh 007e8f7c14
finish stubbing out step_create_IP_reservation 2018-01-25 14:33:43 -08:00
Megan Marsh 7d72870179
add buffer to read template into 2018-01-25 14:33:42 -08:00
Megan Marsh 0117f53721
add error message 2018-01-25 14:33:42 -08:00
Megan Marsh a66dfe1972
fleshing out step_create_instance 2018-01-25 14:33:42 -08:00
Megan Marsh 4fe89be32a
fleshing out steps 2018-01-25 14:33:42 -08:00
Megan Marsh 75ee66f934
add stubbed out steps 2018-01-25 14:33:42 -08:00
Matthew Hooker 3bf431a423
construct OCI client 2018-01-25 14:33:41 -08:00