11933 Commits

Author SHA1 Message Date
Megan Marsh
542cb1d872
Cut version 1.3.5 v1.3.5 2019-02-28 14:58:54 -08:00
Megan Marsh
58f0b8c22e remove vet which seems to have been broken in golang v1.12 2019-02-28 14:51:29 -08:00
Megan Marsh
09df6a733d cut release 1.3.5 2019-02-28 14:49:36 -08:00
Megan Marsh
64d5ef8709 update changelog date 2019-02-28 14:39:05 -08:00
Stephen Fox
61a8968b22 Use 'os.OpenFile' to atomically create debug key file.
Per code review feedback.
2019-02-28 17:23:33 -05:00
Stephen Fox
094c87e395 Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead.
Per code review feedback, the Go template library supports
encoding variables in URL query format. Instead of exposing
two different public key formats (unmodified string and a
URL encoded string), just have the user apply the 'urlquery'
modifier to their template.
2019-02-28 17:06:51 -05:00
Eric Mowry
e74a81e27b Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process. 2019-02-28 16:47:46 -05:00
Eric Mowry
1127096beb Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted. 2019-02-28 16:43:47 -05:00
Megan Marsh
49a6436c18 fix wording in changelog 2019-02-28 13:02:19 -08:00
Megan Marsh
7dbd42c7f3 update changelog 2019-02-28 11:50:39 -08:00
Megan Marsh
1e47421ba1
Merge pull request #7351 from hashicorp/move_pause_before_connection
move pause to after connection can be established.
2019-02-28 10:56:11 -08:00
Stephen Fox
56c17941fe Added comment to authorized_keys 'sed' calls per review. 2019-02-28 10:54:14 -05:00
Stephen Fox
856810e82e Coalesce private key type switch cases per review feedback. 2019-02-28 09:56:11 -05:00
Stephen Fox
672b22bd13 Move 'CreateKeyPairConfig' closer to callers.
Per review feedback.
2019-02-28 09:44:25 -05:00
Stephen Fox
302828905d Move 'FromPrivateKeyConfig' closer to caller.
Per review feedback.
2019-02-28 09:42:20 -05:00
Stephen Fox
ed06656613 Update 'authorizedKeysLine' doc per review feedback. 2019-02-28 09:40:00 -05:00
Stephen Fox
415ef26768 Removed TODO about key pair description per review feedback. 2019-02-28 09:30:30 -05:00
Adrien Delorme
22df491c67 mock tty using interfaces to test more easily 2019-02-28 14:40:55 +01:00
Chris Marget
0f1bde760c
Merge pull request #4 from stephen-fox/refactor-ssh-key-pair-logic
Initial take on code review feedback from @azr.
2019-02-27 17:05:44 -05:00
Brendan Devenney
328cbf4e42
Merge branch 'master' into feature/7322 2019-02-27 19:29:18 +00:00
Adrien Delorme
7f5c794e5f add go-tty vendor 2019-02-27 17:01:02 +01:00
Adrien Delorme
239a0c633f use go-tty in ui.Ask to fix #7299 2019-02-27 16:59:59 +01:00
Adrien Delorme
c588a8a24d Revert "cheggaaa.pb: try to not open tty at init to see if it causes #7299"
This reverts commit 4e55278839a44da5057903d69f50dd6ab2862566.
2019-02-27 16:52:55 +01:00
Adrien Delorme
f535464097 up a test 2019-02-27 11:17:56 +01:00
Adrien Delorme
f03cbd8a10 aws: allow to pass nil bool as encryption parameter
to retain current encryption settings

this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted

This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
2019-02-27 11:17:56 +01:00
Adrien Delorme
ce8532e94b aws: document ValidateRegion better 2019-02-27 11:17:08 +01:00
Adrien Delorme
6af621c37a aws: StepAMIRegionCopy call waitgroup.add only once 2019-02-27 11:17:08 +01:00
Adrien Delorme
0e8afa37d5
Merge pull request #7347 from amphied/master
Fix support for aws-us-gov
2019-02-27 10:57:53 +01:00
Michael F
01a0b0c766 kmsArnStartPattern - fix support for aws-us-gov
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html

Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
2019-02-26 16:54:54 -08:00
Megan Marsh
9db844a807 move pause to after connection can be established. 2019-02-26 12:24:45 -08:00
Megan Marsh
b8510f35fc
Merge pull request #7330 from hashicorp/except_post_processor_tests
name a post-processor to it's type when it is not named
2019-02-26 09:26:17 -08:00
Adrien Delorme
cc2e30826b
Merge pull request #7344 from ad-m/patch-1
Add hyperone builder to CHANGELOG.md
2019-02-26 16:16:59 +01:00
Adrien Delorme
4e55278839 cheggaaa.pb: try to not open tty at init to see if it causes #7299 2019-02-26 11:55:39 +01:00
Adrien Delorme
b32449cdcc
Merge pull request #7336 from dkuntz2/make-private-ip-fixer-error-more-clearly
Make the amazon-private-ip fixer errors more visible
2019-02-26 09:47:31 +01:00
Megan Marsh
674ff489a9
Merge pull request #7343 from hashicorp/fix_6369
move snapshot deletion to cleanup; this allows people with tag-specif…
2019-02-25 17:50:14 -08:00
Megan Marsh
026e543b24 move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation 2019-02-25 17:01:19 -08:00
Stephen Fox
2ef6b9247d Initial take on code review feedback from @azr.
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00
Megan Marsh
134cf3a141 update gemfile to fix vulnerability in bootstrap-saas dependency 2019-02-25 12:58:35 -08:00
Don Kuntz
279fb7a632 gofix 2019-02-25 14:41:26 -06:00
Adam Dobrawy
419a8c3324
Add hyperone builder to CHANGELOG.md 2019-02-25 21:31:22 +01:00
Don Kuntz
b0589c9643 Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip 2019-02-25 14:20:14 -06:00
Don Kuntz
04de86d211 Add test for non-boolean values in ssh_private_ip for FixerAmazonPrivateIP 2019-02-25 14:19:13 -06:00
Megan Marsh
3b726e66c1 swap region copy and encryption steps 2019-02-25 11:03:03 -08:00
Sargun Dhillon
142a84ef43 amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour
There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
2019-02-25 10:45:23 -08:00
Megan Marsh
1c3bc70b12
Merge pull request #7338 from chhaj5236/feature/update_aliyun_sdk
alicloud: update aliyun sdk to support eu-west-1 region
2019-02-25 09:32:02 -08:00
Megan Marsh
3f7c4f7406
Merge pull request #7341 from hashicorp/fix_7325
openstack WaitForImage: pass context for cancellation
2019-02-25 09:30:36 -08:00
Megan Marsh
05897c8653
Merge pull request #7294 from hyperonecom/hyperone
Add HyperOne builder
2019-02-25 08:30:04 -08:00
Megan Marsh
f7ba933809
Merge pull request #7332 from joellopes03/fix_7301
Use IMDS to get subscription for Azure MSI
2019-02-25 08:25:12 -08:00
Adrien Delorme
b9411712eb builder/openstack/step_create_image.go: pass context for cancellation
fix #7325
2019-02-25 15:03:11 +01:00
Adrien Delorme
3cda840504
Merge pull request #7329 from lrxcy/fix_190220
add Endpoints Description
2019-02-25 09:02:32 +01:00