DanHam
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
.
2018-05-16 13:52:00 +01:00
DanHam
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
.
2018-05-16 12:55:59 +01:00
Hariharan Jayaraman
784c7973c2
minor updates to docs
2018-05-15 11:45:24 -07:00
Hariharan Jayaraman
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
Christopher Boumenot
0d785cca75
Merge pull request #6270 from jamielennox/doc-capture-container-name
...
[Azure] Don't mention capture_container_name in required
2018-05-15 09:32:13 -07:00
DanHam
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
DanHam
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
DanHam
a9aa9908cd
Document use of T2 Unlimited for enabled Amazon builders
2018-05-15 12:25:06 +01:00
DanHam
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
DanHam
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
DanHam
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
DanHam
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00
DanHam
2c339b99d2
Sort run config options alphabetically
2018-05-15 12:25:06 +01:00
Jamie Lennox
436065c02b
[Azure] Don't mention capture_container_name in required
...
capture_container_name is only a required variable if you are outputting
to VHD format. It is mentioned below as required when building a VHD so
having it here as well is confusing.
2018-05-15 18:35:14 +10:00
Hariharan Jayaraman
c8c9bbb22a
Async delete Resource Group
2018-05-14 20:06:23 -07:00
Unknown
5710c0aca1
Making log output clearer for hyper-v gui connection
2018-05-14 20:53:51 +10:00
Unknown
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
Unknown
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
Christopher Boumenot
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
...
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
Hariharan Jayaraman
b3882e0cae
Updates to review comments
2018-05-11 10:00:31 -07:00
M. Marsh
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
...
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
Matthew Hooker
524d3da72e
Merge pull request #6263 from hashicorp/fix_6212
...
remove kms_key_id from ami_block_device_mappings and from launch_bloc…
2018-05-10 16:52:32 -07:00
Megan Marsh
0f985d5e25
remove kms_key_id from ami_block_device_mappings and from launch_block_device_mappings
2018-05-10 14:56:09 -07:00
Hariharan Jayaraman
13c0b0b370
Added warning for VHD creation and updated samples
2018-05-10 13:15:35 -07:00
M. Marsh
3cabf43625
Merge pull request #5883 from synax/master
...
Adds config option to specify hyper-v secure boot template
2018-05-10 11:20:53 -07:00
Stefan Henseler
6f00596053
Adds config option to specify hyper-v secure boot template
2018-05-10 19:00:35 +02:00
DanHam
aeadd039b7
Fix #6240 by way of an update to github.com/masterzen/winrm (& winrm/soap)
...
$ govendor fetch -v github.com/masterzen/winrm
$ govendor fetch -v github.com/masterzen/winrm/soap
* In #6240 users reported problems that could be traced to the use of
RunWithString in communicator/winrm/communicator.go.
* https://github.com/masterzen/winrm/pull/78 apparently fixed a
race condition in RunWithString that only materialises with Go <= 1.10;
This is possibly why we are only seeing this with recent releases.
Additionally, the intermittent nature of the errors and error messages
seen are indicative of this type of problem... so here's hoping this
fixes things...
2018-05-10 15:09:15 +01:00
Matthew Hooker
6189d66e77
Merge pull request #6256 from DanHam/rm-tmp-test-file
...
Remove tmp file created by common/ test
2018-05-09 14:41:04 -07:00
DanHam
d9d8b93c14
Remove tmp file created by common/ test. Avoid possible race condition.
2018-05-09 22:09:05 +01:00
M. Marsh
3944088d7b
Merge pull request #6258 from hashicorp/do_6257
...
add documentation to ansible provisioner warning against running Pack…
2018-05-09 14:02:53 -07:00
Matthew Hooker
5f47a220fc
Merge pull request #6259 from jkohrman/master
...
Add link to privacy policy in website footer
2018-05-09 11:26:37 -07:00
Jeff Kohrman
2cf0533221
Add link to privacy policy in website footer
...
Added link to updated privacy policy in footer of `layout.erb` for the OSS website.
2018-05-09 12:15:11 -06:00
Megan Marsh
c1cb31a8a9
add documentation to ansible provisioner warning against running Packer as root
2018-05-09 09:59:54 -07:00
M. Marsh
7c46e3d89c
Merge pull request #6207 from gtirloni/issue-6203
...
[WIP] Handle HTTP download errors
2018-05-08 15:56:06 -07:00
Matthew Hooker
73e8c293ae
update changelog
2018-05-08 15:32:56 -07:00
Matthew Hooker
a10172c37c
Merge pull request #6253 from hashicorp/fix6252
...
show error message when -on-error=[ask|abort]
2018-05-08 15:31:10 -07:00
Matthew Hooker
5e6e12cacd
Use fmt to convert whatever's in error to a string.
...
This way we don't crash if someone sticks something else in the error
key in the state bag (which a quick glance at the code tells me we're
already doing.
Perhaps in the future we can add an error attribute to the state bag
but for now this will have to suffice.
2018-05-08 15:22:02 -07:00
M. Marsh
84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
...
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
M. Marsh
abb70bfa80
Merge pull request #6215 from tb3088/delay-extraArgs-4462_clean
...
Delay evaluation of ExtraArguments and standardize puppet-server and puppet-masterless
2018-05-08 15:03:55 -07:00
Christopher Boumenot
b5efda4577
Merge pull request #6105 from boumenot/pr-azure-device-login-usgov
...
azure: device login for US Gov
2018-05-08 11:59:54 -07:00
Matthew Patton
d22fb6d60b
reformat via gofmt
2018-05-08 12:44:15 -04:00
Matthew Patton
f510a8667b
standardize documentation between provisioners.
2018-05-08 12:29:13 -04:00
Matthew Patton
5c7d5fac75
expose OS-specific ModulePathJoiner
2018-05-08 12:21:04 -04:00
Matthew Patton
399edbe5e7
revert false economy WRT .ExtraArguments
2018-05-08 10:12:22 -04:00
Matthew Patton
b505cecd98
sync docs to code
2018-05-08 09:53:18 -04:00
DanHam
a866232ac9
Use regex based approach to detect attached disks
2018-05-08 12:52:39 +01:00
Matthew Hooker
0a1842140b
Display build error when on-error=ask|abort
2018-05-08 04:06:03 -07:00
Matthew Hooker
44012b29ec
Remove redundant error message.
2018-05-08 03:25:39 -07:00