Adrien Delorme
d2f036ec44
Revert "Revert "Merge pull request #7391 from carlpett/proxmox-builder""
...
This reverts commit 032527ecfe
.
2019-04-12 12:26:34 +02:00
Adrien Delorme
63f5bbbc73
use our own copy of iochan.LineReader
2019-04-11 14:25:24 +02:00
Adrien Delorme
032527ecfe
Revert "Merge pull request #7391 from carlpett/proxmox-builder"
...
This reverts commit b7d62b2ae0
, reversing
changes made to c36eaf16f7
.
2019-04-11 14:19:25 +02:00
Adrien Delorme
aee73d745d
update code after go mod update
2019-04-11 14:19:24 +02:00
Adrien Delorme
6ff392d713
Update windows_container_communicator.go
...
after merge
2019-04-09 17:46:38 +02:00
Adrien Delorme
d72040f4fa
move retry code into the common/retry pkg and make retry context aware
2019-04-09 17:46:38 +02:00
Adrien Delorme
06941a86a3
make the file builder run provisioners for testing purposes
2019-04-08 20:09:21 +02:00
Adrien Delorme
f555e7a9f2
allow a provisioner to timeout
...
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
2019-04-08 20:09:21 +02:00
Adrien Delorme
a81abd297b
Merge remote-tracking branch 'origin/master' into context_provisioner
2019-04-08 20:09:01 +02:00
Megan Marsh
b7d62b2ae0
Merge pull request #7391 from carlpett/proxmox-builder
...
Implement Proxmox builder
2019-04-08 09:54:11 -07:00
Calle Pettersson
65cd5bbd29
Change disk size config parameter name
2019-04-06 08:10:28 +02:00
Megan Marsh
3e72e65a6c
Merge pull request #7456 from hashicorp/do_5770
...
introduce the clean_resource_name to clean image/var names
2019-04-05 09:12:20 -07:00
Megan Marsh
04b57b3e32
fix tests; clean up ip file after build
2019-04-04 22:33:24 -07:00
Calle Pettersson
e9d5a1d272
Update to builder interface change
2019-04-04 15:20:46 -07:00
Calle Pettersson
2f754c38f8
Add validation of interface implementation for both proxmox.Client and mocks
2019-04-04 15:20:46 -07:00
Calle Pettersson
c4ce295f67
Add tests for step_start_vm cleanup
2019-04-04 15:20:46 -07:00
Calle Pettersson
4c1fbfdd61
Shifted special runes are already handled, simplify SendKey
2019-04-04 15:20:46 -07:00
Calle Pettersson
0765bc2283
Add tests for step_type_boot_command, fix found bug (shifted chars were not lower cased)
2019-04-04 15:20:46 -07:00
Calle Pettersson
28ca0f71b5
Add tests for step_convert_to_template
2019-04-04 15:20:46 -07:00
Calle Pettersson
3d5f433b22
Add more finalizetemplate tests, fix found bug
2019-04-04 15:20:46 -07:00
Calle Pettersson
5eb600bf88
Add draft of step test
2019-04-04 15:20:46 -07:00
Calle Pettersson
2e3086be5a
Initial tests
2019-04-04 15:20:46 -07:00
Calle Pettersson
9f8fc37fde
Implement Proxmox builder
2019-04-04 15:20:46 -07:00
Megan Marsh
196028a7ed
Merge pull request #7444 from hashicorp/docker_windows
...
Docker windows
2019-04-04 09:30:43 -07:00
Paul Meyer
7fc8901d8f
Merge pull request #7464 from paulmey/fix-snapshots
...
[azure] Fix: Power off before taking snapshot (windows)
2019-04-03 16:38:04 -07:00
Adrien Delorme
c4f3dccc14
rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts
2019-04-03 15:56:15 +02:00
Adrien Delorme
a4bf94dd3c
change Builder to be passed a context for cancellation
...
we have to to give it to our hook
2019-04-03 15:55:55 +02:00
Adrien Delorme
9836dad0c9
introduce the clean_resource_name to clean image names and deprecate the old ones
2019-04-03 11:25:51 +02:00
Megan Marsh
17c14770a7
Merge pull request #7450 from AkshatM/rename_security_group_cidr_to_security_group_cidrs
...
Rename and change `temporary_security_group_source_cidr` to accept a list of strings (for Amazon builders).
2019-04-02 10:54:31 -07:00
Paul Meyer
eb274c4e87
Power off before shapshotting
2019-04-01 18:40:50 +00:00
Megan Marsh
874a4ff8c7
Merge pull request #7451 from bh9/master
...
Allow both ports and networks in openstack builder
2019-04-01 09:30:39 -07:00
Adrien Delorme
225f4bab1f
Merge pull request #7446 from hashicorp/do_6928
...
remove default ssh_username from oracle classic builder, but add note…
2019-04-01 17:24:36 +02:00
bh9
cbbbc451b5
Allow both ports and networks in openstack builder
...
Current code would throw an index out of range exception when trying to access `s.Networks[len(s.Networks)]` when `len(s.Ports)>0` and would ignore the first `len(s.Ports)` entries of `s.Networks`, fix by shifting access to `s.Networks` back by `len(s.Ports)` so that the final read is `networks[len(s.Networks)+len(s.Ports)-1].UUID=s.Networks[len(s.Networks)+len(s.Ports)-1-len(s.Ports)]` which is necessarily the last member of `s.Networks`
2019-04-01 11:43:21 +01:00
Akshat Mahajan
f07e4214cc
Addresses issues #5384 , #5494 : Rename and change `temporary_security_group_source_cidr`
...
to accept a list of strings (for Amazon builders).
Per this change, `temporary_security_group_source_cidr` in the configuration:
1. Will be renamed to `temporary_security_group_source_cidrs`.
2. Will accept a list of CIDRs.
3. Will have its documentation updated to reflect this change.
4. Will have a fixer attached for newer templates to avail of.
2019-03-30 15:47:03 -07:00
Megan Marsh
b3c6dd0baa
fix tests
2019-03-29 15:52:41 -07:00
Megan Marsh
bcacd331c3
change cpu to cpus and ram_size to memory in order to bring hyper v into line with other builder defaults
2019-03-29 15:12:51 -07:00
Megan Marsh
b764b1d7e1
fix tests
2019-03-29 15:05:51 -07:00
Megan Marsh
a84fc6bde9
remove default ssh_username from oracle classic builder, but add note in docs.
2019-03-29 14:24:12 -07:00
Megan Marsh
af06334114
fix tests
2019-03-29 11:37:23 -07:00
Megan Marsh
6407a579f0
Document why we need windows communicator in code
2019-03-29 11:21:07 -07:00
Megan Marsh
12b9004c76
reduce duplicated code
2019-03-29 11:14:01 -07:00
Megan Marsh
0860edeed8
fix mocks
2019-03-28 16:55:35 -07:00
Megan Marsh
70150ffa0f
set powershell entrypoint for windows containers
2019-03-28 16:46:07 -07:00
Megan Marsh
36f2634352
can't use docker cp so call powershell to do this natively. Fix implementation for upload, uploadDir, and download in windows container communicator
2019-03-28 16:20:05 -07:00
Megan Marsh
af01860fa9
remove old docker-toolbox limitation.
2019-03-27 15:29:22 -07:00
Megan Marsh
3b87f2a519
stop container before committing if windows
2019-03-27 15:25:51 -07:00
Megan Marsh
8f3313d81e
Create new docker communicator for windows containers
2019-03-27 15:25:32 -07:00
Megan Marsh
9f1a4e0fed
Merge pull request #7423 from hashicorp/lock_ports
...
Lock packer ports using a lock file
2019-03-26 10:35:18 -06:00
Adrien Delorme
ac92916b01
StepConfigureVNC: close listener only once
2019-03-26 10:58:51 +01:00
Megan Marsh
e97f864016
Merge pull request #7395 from josepand/openstack_force_delete
...
Expose force_delete for openstack builder
2019-03-25 17:34:00 -06:00