Megan Marsh
3b726e66c1
swap region copy and encryption steps
2019-02-25 11:03:03 -08:00
Sargun Dhillon
142a84ef43
amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour
...
There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
2019-02-25 10:45:23 -08:00
Megan Marsh
3f7c4f7406
Merge pull request #7341 from hashicorp/fix_7325
...
openstack WaitForImage: pass context for cancellation
2019-02-25 09:30:36 -08:00
Megan Marsh
05897c8653
Merge pull request #7294 from hyperonecom/hyperone
...
Add HyperOne builder
2019-02-25 08:30:04 -08:00
Adrien Delorme
b9411712eb
builder/openstack/step_create_image.go: pass context for cancellation
...
fix #7325
2019-02-25 15:03:11 +01:00
Miłosz Smółka
94a7a07c87
Merge branch 'master' into hyperone
2019-02-24 15:16:21 +01:00
Miłosz Smółka
0673bb2c57
Add cleanup for stepCreateImage
2019-02-23 14:57:19 +01:00
Sargun Dhillon
d3c65ee77d
builder/amazon/chroot: Fix building PV images with mount_partition
...
Right now, if we have a source image that's PV, and try to build an
image with mount_partition set to not 0, it does not get picked up.
This is because under PV we only had a filesystem, not partitions,
but you can convert a PV image to an HVM image during build time.
2019-02-22 18:21:01 -08:00
Joel Lopes
c8a60c77d1
Add comments
2019-02-21 18:12:57 -08:00
Joel Lopes
1c030cb54b
Use IMDS to get subscription for Azure MSI
2019-02-21 09:35:14 -08:00
Megan Marsh
5cc442872e
Merge pull request #7314 from hashicorp/fix_7234
...
add noSSLVerify to ovftool args
2019-02-19 16:54:48 -08:00
Manuel Riezebosch
d79b54e46a
feat(arm-builder): print warning on zone resiliency for currently not supported locations
2019-02-15 19:27:53 +01:00
Manuel Riezebosch
f31031f6b1
feat(arm-builder): zone resilient from config
2019-02-15 19:27:32 +01:00
Megan Marsh
75f574bd4b
Merge pull request #7221 from hashicorp/vagrant_builder
...
Vagrant builder
2019-02-15 10:05:44 -08:00
Megan Marsh
cb5c896c01
Merge pull request #7310 from hashicorp/fix_7286
...
also strip \r to work around windows file ending strangeness
2019-02-15 09:19:33 -08:00
Megan Marsh
9f702af6d9
we lost the skip_add step somewhere
2019-02-14 14:46:14 -08:00
Megan Marsh
bbc52f9a7d
add noSSLVerify to ovftool args
2019-02-14 12:10:58 -08:00
Megan Marsh
be21850e32
Merge pull request #7060 from andrewsomething/do-post-processor
...
Add digitalocean-import post-processor.
2019-02-14 11:58:00 -08:00
Megan Marsh
bd3339f1f9
also strip \r to work around windows file ending strangeness
2019-02-13 15:41:37 -08:00
Megan Marsh
c7278e871c
Merge pull request #7038 from kmbulebu/openstack_deprecated_api
...
Replaced compute/v2/images with imageservice/v2/images.
2019-02-11 15:05:45 -08:00
Megan Marsh
f2439625bf
Merge pull request #7298 from hashicorp/fix_7256
...
Fix 7256
2019-02-11 14:24:01 -08:00
Megan Marsh
22e3f09db3
Merge pull request #7282 from hashicorp/do_6994
...
Allow amazon builders to read credentials from Vault.
2019-02-11 12:49:23 -08:00
Megan Marsh
2a613dd6e9
fix up the github suggestion
2019-02-11 11:49:17 -08:00
Adrien Delorme
3ae5a912d4
Update builder/amazon/common/step_pre_validate.go
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2019-02-11 11:41:58 -08:00
Kevin Bulebush
cd1f1165ed
Support reading app creds from packer config
2019-02-09 22:52:02 -05:00
Kevin Bulebush
2edf3d8b8e
Openstack: Added application credential config
2019-02-09 22:52:02 -05:00
Megan Marsh
3fd589fa72
typos
2019-02-08 09:31:30 -08:00
Megan Marsh
e2d8c0bfd7
docs
2019-02-08 09:28:10 -08:00
Megan Marsh
07c0c599e0
attach guest additions via SATA when necessasry
2019-02-08 09:15:15 -08:00
Megan Marsh
5057220ad2
use VAGRANT_CWD rather than changing packer run directories
2019-02-07 14:35:01 -08:00
Megan Marsh
dc848ea5d7
just make vagrantfile instead of calling init
2019-02-07 12:39:56 -08:00
Miłosz Smółka
228829139b
Merge branch 'master' into hyperone
2019-02-07 14:12:13 +01:00
Miłosz Smółka
1ee4517370
Update source_image names in tests
2019-02-07 09:22:30 +01:00
stephen-fox
b7719650ae
Merge pull request #1 from stephen-fox/parse-user-supplied-keypair
...
Parse user supplied keypair
2019-02-06 15:07:04 -05:00
chris marget
53c0376dfd
don't print keypair to the user's screen
2019-02-06 13:54:05 -05:00
chris marget
13cc73d600
keypair parsing and testing
2019-02-06 13:46:55 -05:00
Miłosz Smółka
fdf028c463
Search SCSI device in /sys/bus due to issues with by-path
2019-02-06 12:30:14 +01:00
Megan Marsh
e56d7f7234
fix tests
2019-02-05 15:34:59 -08:00
Megan Marsh
608b7cb7a3
review comments
2019-02-05 15:16:47 -08:00
Megan Marsh
3704a053d0
move region validation and credential wait into step pre validate
2019-02-05 14:07:04 -08:00
Stephen Fox
354fcc5cc6
Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'.
2019-02-05 16:16:51 -05:00
Stephen Fox
f9d24ccda0
Allow user to get public key straight up, or URL encoded.
2019-02-05 11:59:13 -05:00
Miłosz Smółka
0d8e9f50bf
Add proper SCSI search
2019-02-05 16:20:42 +01:00
Paul Meyer
68516fc05c
Fix Azure interactive authentication
...
Builder looks up tenant ID before asking for token. Client config did
not allow that. Also found that token provider was not properly
initialized.
Fixes 7267
2019-02-05 02:35:12 +00:00
Megan Marsh
a7d9d62996
fix tests on windows
2019-02-04 16:11:25 -08:00
Megan Marsh
8add176ab7
finish first pass at vault code; needs testing and cleanup of error messages
2019-02-04 15:54:14 -08:00
Megan Marsh
7a78b47e83
make vault engine stuff into a little struct for easier management
2019-02-04 15:29:45 -08:00
Megan Marsh
af7131b169
tests, logic cleanup, docs for vagrant builder
2019-02-04 14:08:43 -08:00
Megan Marsh
52892699ca
make it work with a local vagrant box
2019-02-04 14:08:43 -08:00
Megan Marsh
ad21367b21
vagrant builder
2019-02-04 14:08:43 -08:00
Stephen Fox
f2c11b55be
Renamed authorized_keys public key function.
2019-02-04 14:27:14 -05:00
Stephen Fox
ea2a7c3fe9
Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'.
2019-02-04 12:47:42 -05:00
Stephen Fox
01c98f3d82
Tweaked debug SSH private key file name for vbox.
2019-02-04 12:47:18 -05:00
Stephen Fox
c6ae8654d9
Moved SSH key pair code into 'helper/ssh'.
2019-02-04 12:21:58 -05:00
Stephen Fox
25775886a8
Properly set SSH key pair name.
2019-02-04 12:12:18 -05:00
Stephen Fox
be081944b1
Moved new key pair funcs closer to builder funcs.
2019-02-04 12:09:23 -05:00
Stephen Fox
b1b67ecffa
Added support for setting a name in SSH key pair.
...
Also refactored how new SSH key pairs are created, and how the
tests are structured.
2019-02-04 12:07:32 -05:00
Stephen Fox
5893134c61
Updated comment for 'PrivateKeyPemBlock()'.
2019-02-04 10:02:07 -05:00
Stephen Fox
cd4ae03324
Create / use SSH key pairs in vbox builders.
...
This follows the business logic for creating / using SSH key pairs
in the cloud-type builders (e.g., Amazon EC2).
2019-02-03 12:20:52 -05:00
Stephen Fox
72d1501551
Made SSH public key available in vbox boot command.
...
The SSH public key (in authorized_keys format) can be retreived in
the build template by specifying '{{ .SSHPublicKey }}'. The key is
URL encoded to escape spaces.
2019-02-03 12:20:42 -05:00
Stephen Fox
459bd1ea7a
Added vbox step for SSH key pair business logic.
2019-02-03 12:07:57 -05:00
Stephen Fox
6824806e6f
Allow caller to specify new line for SSH public key.
...
The default behavior of the various builders that create SSH key
pairs appears to be to add a trailing new line. This will be the
default behavior, but at least it can be customized if desired.
2019-02-03 10:37:32 -05:00
Stephen Fox
ad075ffac3
Added 'Description()' to 'sshKeyPair'.
...
Also cleaned up tests.
2019-02-03 09:17:18 -05:00
Miłosz Smółka
f7de056f23
Add proper cleanup of chroot disk
...
Closes #3
2019-02-03 00:30:56 +01:00
Miłosz Smółka
5e8eade205
Add support for custom API url of compatible service
...
Closes #4
2019-02-02 14:05:06 +01:00
Miłosz Smółka
6921cc93a9
Add acceptance tests for chroot
2019-02-01 18:58:16 +01:00
Miłosz Smółka
4704565869
Rename vm_flavour to vm_type
2019-02-01 18:57:43 +01:00
Miłosz Smółka
e7e84f04e7
Fix timestamp interpolation in mount path
...
Closes #1
2019-02-01 17:46:35 +01:00
Murcurio
60c7d22ffb
Change metadata url to FQDN
...
If instance has a different DNS/search domain then "metadata" alone won't work. The FQDN of "metadata.google.internal" is included in hosts file, and will work regardless of DNS configuration. Alternatively the IP 169.254.169.254 can be used.
2019-02-01 15:36:40 +11:00
Megan Marsh
eef4fc7a01
Merge pull request #7222 from Adezandee/gce-post-processors
...
googlecompute-postprocessors: service account and export configs
2019-01-31 16:58:42 -08:00
Megan Marsh
6ea64bc378
Merge pull request #7191 from arizvisa/GH-7190
...
Adds support to the vmware builders for specifying the number of cores per socket via the `cores` option.
2019-01-31 15:27:52 -08:00
Stephen Fox
f233e54992
Initial SSH key pair helper implementation.
2019-01-30 22:10:27 -05:00
Yaakov
0a08920816
Hyper-V: Fix integer overflows in 32-bit builds
2019-01-31 13:53:01 +11:00
Miłosz Smółka
3d3e933f48
Add host key hash verify
2019-01-29 10:44:23 +01:00
Miłosz Smółka
bd4ce90728
Add chroot disk build
2019-01-28 12:33:25 +01:00
Megan Marsh
035c3506ba
manually set proxyfromenvironment in default http client for ec2 sessions
2019-01-25 12:33:25 -08:00
Megan Marsh
c63b54a1e7
move http with proxy call into a helper function
2019-01-25 12:32:52 -08:00
Megan Marsh
904c4b9adb
Merge pull request #7230 from hashicorp/up-aws-sdk-go
...
Don't try to guess region from metadata if not set + update aws-sdk-go
2019-01-25 10:06:11 -08:00
Adrien Delorme
4a2773f8fa
remove default max retries config of 8, it will now be used from env
...
removing the code that wants to guess region from metadata allows us to change that setting, which can now be taken from environment.
2019-01-25 13:51:02 +01:00
Adrien Delorme
964b149df2
aws: remove now unused AccessConfig.metadataRegion
2019-01-25 13:03:14 +01:00
Adrien Delorme
335f442b51
aws: unwrap AccessConfig.region func
...
* it was used only in the Session() call.
* default region guessing from metadata should happen in the SDK, not 'manually'
2019-01-25 13:02:42 +01:00
Adrien Delorme
54af9951a8
make guard clauses to clearly see success pass
2019-01-25 13:00:21 +01:00
Adrien Delorme
0864b4d07b
name unclear import
2019-01-25 12:59:43 +01:00
Arnaud Dezandee
91d2cb8c83
googlecompute-import: add service accounts
2019-01-25 11:36:18 +01:00
Megan Marsh
a0c238940e
Merge pull request #7223 from hashicorp/fix_7200
...
escape query as suggested in issue #7200
2019-01-24 09:48:38 -08:00
Megan Marsh
e4dca0016c
Merge pull request #7156 from vtolstov/qemu
...
qemu: Add configuration options to specify cpu count and memory size
2019-01-23 15:19:08 -08:00
Megan Marsh
d0e5c67dc3
Merge pull request #7205 from hashicorp/fix_7196
...
fix region stuff
2019-01-23 15:15:27 -08:00
Megan Marsh
ce8f5c31df
escape query as suggested in issue #7200
2019-01-23 11:04:14 -08:00
Miłosz Smółka
3ce05c7c26
Add acceptance tests
2019-01-23 14:59:28 +01:00
Miłosz Smółka
be30415395
Add HyperOne builder
2019-01-23 14:04:05 +01:00
Vasiliy Tolstov
b6ebe00249
provide memory and cpus like other builders does
...
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2019-01-23 13:21:52 +03:00
Adrien Delorme
f57953d4ff
Docker needs a temporary dir that is inside the $HOME dir
2019-01-18 16:42:04 +01:00
Adrien Delorme
f19b7c0300
Revert "aws: test timeout when no credenrtials are set" Revert "aws: set max retries back to 20"
...
This reverts commits b8b3e64cff
and 993af36f2e
.
2019-01-18 12:40:02 +01:00
Adrien Delorme
b8b3e64cff
aws: test timeout when no credenrtials are set
2019-01-18 11:43:52 +01:00
Adrien Delorme
993af36f2e
aws: set max retries back to 20
2019-01-18 11:43:26 +01:00
Ali Rizvi-Santiago
9d2f98394e
Revert "Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`."
...
This reverts commit 0c37a3c68f
and avoids bikeshedding from other committers.
2019-01-17 14:49:07 -06:00
Ali Rizvi-Santiago
0c37a3c68f
Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`.
2019-01-17 10:39:19 -06:00
Ali Rizvi-Santiago
4894873971
Added logic to the vmware-iso builder that appends the number of cores per socket to the vmx in `stepCreateVmx`.
2019-01-17 10:39:19 -06:00
Ali Rizvi-Santiago
062c62eed8
Added support for specifying the number of cores as `cores` to vmware-common.
2019-01-17 10:39:19 -06:00
Megan Marsh
e0543246fa
remove commented code
2019-01-16 11:05:11 -08:00
Megan Marsh
783ed32e7e
fix region stuff
2019-01-16 11:02:58 -08:00
Paul Meyer
e189db97d4
[azure] deallocate instead of just power-off
...
1. allegedly prevents error where fails because VM still appears running
2. prevents left-behind VM's after failures from accumulating charges
2019-01-16 00:31:23 +00:00
Paul Meyer
aa29facdae
Allow certificate bearer JWT client authentication
...
This allows certificate based authentication, both by just referencing
the certificate file as well as by providing a bearer JWT. This last
option allows authentication without exposing the private key to packer
using an expiring JWT containting the thumbprint (and sometimes the
whole certificate for subject/issuer based auth), signed using the
certificate private key.
2019-01-15 17:29:28 +00:00
Paul Meyer
7e34579b7e
Factor out Azure client credential config
2019-01-15 17:23:57 +00:00
Adrien Delorme
9ddec470a0
Merge pull request #7188 from hashicorp/dedupe_step_output_dir
...
deduplicate step_output_dir and move to common folder
2019-01-15 17:28:21 +01:00
Megan Marsh
126ca2a877
Merge pull request #7158 from rickard-von-essen/fix-7155
...
WIP: parallels: Fix attaching prl tools
2019-01-11 15:30:37 -08:00
Megan Marsh
97a791389a
deduplicate step_output_dir and move to common folder
2019-01-11 15:06:36 -08:00
Adrien Delorme
c8a39e939a
Merge pull request #7178 from edwardmlyte/simplify-version-check
...
Simplify version check for port count argument
2019-01-10 16:07:00 +01:00
Ed Maxwell-Lyte
e8e92fe6c6
rename clashing import
2019-01-09 16:30:54 +00:00
Ed Maxwell-Lyte
4437f8d8ba
Use go-version for comparison
2019-01-09 16:22:33 +00:00
Ed Maxwell-Lyte
346f5d9bba
Simplify version check for port count argument
...
Might be personal preference, but I think this reads more clearly
2019-01-09 09:46:24 +00:00
Adrien Delorme
9f7b4ffc17
Merge branch 'master' into pr/6950
2019-01-09 10:11:18 +01:00
Adrien Delorme
19cbb9cb24
Merge pull request #7136 from hashicorp/fix_5984
...
Add "version" option to hyperv calls
2019-01-09 10:06:49 +01:00
Adrien Delorme
1b84019a45
Merge pull request #7174 from edwardmlyte/reverse-default-vbox-portcount-arg
...
Make portcount default argument for storagectl
2019-01-08 17:35:43 +01:00
Ed Maxwell-Lyte
4fc02ea406
Assign to existing var
2019-01-08 16:19:11 +00:00
Adrien Delorme
f91b668617
Create portCountArg in the if statement
...
You can't assign to something that doesn't exist
Co-Authored-By: edwardmlyte <edwardmlyte@gmail.com>
2019-01-08 16:15:24 +00:00
Ed Maxwell-Lyte
a9eed311a6
Run gofmt on driver_4_2.go
2019-01-08 15:58:12 +00:00
Rickard von Essen
c8fab8c7a3
Merge pull request #7037 from kmbulebu/openstack_tags
...
openstack: `image_tags` - Adds support for tagging new images.
2019-01-08 16:53:21 +01:00
Ed Maxwell-Lyte
e5b1e0f4d9
Add version 0.x to the rule
2019-01-08 15:35:45 +00:00
Ed Maxwell-Lyte
e40c90423f
Reverse default port count virtualbox argument
...
As we know the exact versions that used the old `sataportcount` option, it's safe to assume we want to use the newer `portcount` option for everything else.
Reversed the option check and use the `portcount` option by default. Prevents needing to update this for future major versions of VirtualBox.
2019-01-08 14:14:26 +00:00
Rickard von Essen
e3f82d3725
Merge pull request #6933 from cb-oath/openstack-v2-network-optional
...
openstack: Make the config.networkV2Client conditional in StepAllocateIp
2019-01-07 08:48:38 +01:00
Megan Marsh
16149844a7
Merge pull request #7151 from nelsonjchen/qemu-whpx-option
...
Add support for whpx accelerator to qemu builder
2019-01-04 12:37:03 -08:00
Megan Marsh
c789a68d89
Merge pull request #7154 from ladar/fix-hyperv-ssh-host-bug
...
Fix ssh_host bug in hyper-v builders.
2019-01-04 12:14:13 -08:00
Nelson Chen
b39f398fda
Add support for whpx accelerator to qemu builder
...
Windows Hypervisor Platform (WHPX) is the Windows counterpart to HVF and
KVM. It's an operating system provided component that provides
virtualization acceleration support.
This is kind of the missing counterpart to https://github.com/hashicorp/packer/pull/6193 .
QEMU 2.12 also added support for WHPX.
There's no support for libvirt on Windows so nothing was added in those
areas.
The popular QEMU for Windows distribution does not have WHPX support
built-in for legal reasons as the maintainer does not wish to use or
obtain any part of Microsoft's SDK to compile the distribution.
2019-01-03 15:20:37 -08:00
Adrien Delorme
7132037faa
Merge pull request #7137 from YuSungDuk/fix_to_get_ssh_password
...
Fix to get ssh password
2019-01-03 11:22:14 +01:00
Rickard von Essen
21a7a0a614
parallels: Fix attaching prl tools
...
Closes #7155
2019-01-02 21:33:58 +01:00
Ladar Levison
217028b902
Added comment regarding use of host param.
2018-12-27 03:34:08 -06:00
Ladar Levison
8a9962882c
Use Printf not Println. D'oh.
2018-12-27 03:15:44 -06:00
Ladar Levison
35aaf44fa5
A properly formatted hyperv ssh.go file.
2018-12-27 02:55:14 -06:00
Ladar Levison
cb0011d665
Fix ssh_host bug in hyper-v builders.
2018-12-27 02:33:58 -06:00
유성덕
38c4e21563
Fix to get ssh password
2018-12-21 17:53:52 +09:00
Megan Marsh
141f3b29f3
Merge pull request #7127 from ladar/master
...
Added change support to docker-import post processor.
2018-12-20 14:44:05 -08:00
Adrien Delorme
7655d2efb2
Add tencent cloud builder ( #7135 & #6839 )
2018-12-20 17:09:44 +01:00
Megan Marsh
006682a09c
add version option and also refactor powershell script to use golang templates for ease of testing and variable passing.
2018-12-19 16:30:57 -08:00
Adrien Delorme
e666b60d16
Merge pull request #7126 from hashicorp/fix_7125
...
fix packer crash that occurs when image is nil
2018-12-19 09:25:28 +01:00
Megan Marsh
56d722f779
Merge pull request #7130 from jo/openstack-add-volume-size-option
...
Openstack add volume size option
2018-12-18 16:35:25 -08:00
Megan Marsh
d288f94073
Merge pull request #7128 from ladar/hyperv-legacy-network-adapter
...
Updated support for legacy network adapters on Hyper-V.
2018-12-18 15:32:35 -08:00
Johannes J. Schmidt
a545caa24a
use openstack volume_size option on creation
...
if present. Otherwise fallback to to source image min disk value (if
set) or calculated from the source image bytes size.
Note that in some cases this needs to be specified, if
`use_blockstorage_volume` is true. See #6957 for the discussion.
2018-12-18 23:59:54 +01:00
Johannes J. Schmidt
336c11c54a
add openstack volume_size option
...
Adds an option to OpenStack, `volume_size` (int), which is the size of
the Block Storage service volume in GB.
2018-12-18 23:58:27 +01:00
Christopher Boumenot
acacf6e59c
Merge pull request #7111 from hashicorp/pr-7077-azure-regression
...
azure: fix snapshot regression
2018-12-18 09:53:52 -08:00
Ladar Levison
bdcbf61ade
Fixed replace variable name.
2018-12-18 06:18:51 -06:00
Ladar Levison
fa154f5298
Fixed driver mock up formatting.
2018-12-18 06:14:38 -06:00
Ladar Levison
31d03fb48e
Added legacy network adapter driver mock up.
2018-12-18 06:12:05 -06:00
Ladar Levison
da8b140bca
Fix Hyper-V builder formatting.
2018-12-18 05:50:16 -06:00
Ladar Levison
348c267054
Updated support for legacy network adapters on Hyper-V.
2018-12-18 04:59:00 -06:00
Ladar Levison
6ac5971288
Fixed cmd order for docker driver. Added config to post proc.
2018-12-17 22:59:41 -06:00
Ladar Levison
10095678c8
Adding driver changes.
2018-12-17 22:37:32 -06:00
Ladar Levison
21fdbadf04
Adding changes to import prototype.
2018-12-17 22:35:59 -06:00
Ladar Levison
050f809a1c
Add changes var to docker driver import func.
2018-12-17 22:04:43 -06:00
Megan Marsh
19144111dd
fix packer crash that occurs when image is nil
2018-12-17 14:54:27 -08:00
wizurijyq
8184fcb99a
Make sure sshkey is not nil
2018-12-14 22:30:26 +01:00
DanHam
0821653256
Fix 'nil' dir in VMware artifact when building locally
2018-12-14 13:21:41 +00:00
Megan Marsh
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting
...
Revert hddorder setting
2018-12-13 16:27:31 -08:00
Christopher Boumenot
f9230aeb95
azure: fix snapshot regression
2018-12-13 13:58:18 -08:00
Megan Marsh
7d5ea43f41
revert the hddorder being added to the vmx template, since it's breaking things for some of our users.
2018-12-13 09:58:24 -08:00
Megan Marsh
b95123f457
add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work.
2018-12-13 09:12:23 -08:00
Adrien Delorme
2718a5ed62
Revert "revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release"
...
This reverts commit 2a79d64ae0
.
2018-12-13 10:23:46 +01:00
Adrien Delorme
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes
...
revert changes to docker entrypoint; since this is a backwards-breaki…
2018-12-13 10:23:18 +01:00
Megan Marsh
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
...
Move logging about aws waiters to the access config prepare() so that…
2018-12-12 15:42:37 -08:00
Megan Marsh
2a79d64ae0
revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release
2018-12-12 15:30:24 -08:00
Megan Marsh
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id
...
Check that the KMS key ID is valid
2018-12-12 10:04:22 -08:00
Adrien Delorme
b7222d1f56
Add tmp package that offers Dir & File funcs
...
this regroups the calls of tmp func calls into one package.
the tmp pkg allows to store tmp files under a common directory for easier managment
Squashed commit of the following:
commit 74b674c01560c6b547e9cab5e8afb486f0fe7d6c
Merge: fc94b5714 66001525d
Author: Matthew Patton <mpatton@enquizit.com>
Date: Fri Nov 2 02:02:38 2018 -0400
Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs
commit fc94b571428447aaf2e5171967c95cdf9e5c73ff
Author: Matthew Patton <mpatton@enquizit.com>
Date: Fri Nov 2 01:42:38 2018 -0400
update tests to honor configured temporary directory
commit 5a562359f4937af506607dd96ed1c46426093f52
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 18:52:38 2018 -0400
sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.
commit 9d5a4a0935bfd049e2f8f50ad73e4455b42c9410
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 15:39:46 2018 -0400
insert URL to GoLang API for os.TempDir()
commit fbae4c2e051898aecd8705e9d8a20353430ede23
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:41:29 2018 -0400
revise documentation to match code
commit 3590fae8bd0afa92a161a49ed794ee32e357d583
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:21:59 2018 -0400
refacter config_file. replace all hard-coded os.TempDir with wrapper
commit d5c5306a97b648ded06a8eb76ce728f07c9924f0
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 20:11:36 2018 -0400
close massive file overwrite hole with TempDir
commit 0a72297da86089fbd07e4f7d9472a92fa4d1c733
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 01:06:00 2018 -0400
adjust var declaration scope
commit 20f68228b6c372d984ea5b055cfc8bda9b110ac5
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 00:54:35 2018 -0400
use mktemp() equivalent to create temporary directory
commit c73ebe3d8321664a2685a0baa8e441dd895b0db4
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 20:40:58 2018 -0400
remove extraneous variable declaration, fix FOR loop
commit 63549b8bd745a0090b15ed0b0ebf644162db27db
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:30:44 2018 -0400
match styistic convension with rest of docs
commit 976101074942db36f10d3a686d6d29ddb7c01926
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:08:39 2018 -0400
revert dangling config file change
commit 95159afbc05eac96ed11c3183af5fb0abe2f2d5c
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Fri Dec 29 23:53:43 2017 -0500
replace invalid TMPDIR variable wth PACKER_TMP_DIR.
update ConfigTmpDir() to try common temporary paths first and
only write to configDir() as a last resort.
commit 66001525d72de56a4cf9339b900c46f59bc6e91a
Author: Matthew Patton <mpatton@enquizit.com>
Date: Fri Nov 2 01:42:38 2018 -0400
update tests to honor configured temporary directory
commit e9b6adefeae8c65eb8aa47fef38cbf0aa424338c
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 18:52:38 2018 -0400
sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.
commit 852113ed076e2d14e5dca6815ea680da1e2896bb
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 15:39:46 2018 -0400
insert URL to GoLang API for os.TempDir()
commit 54add38d1d1c6e283cd444b367ed8bd49a5f3699
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:41:29 2018 -0400
revise documentation to match code
commit 6b5b8f6d4edad0e187ca13d64ac4118f34eee643
Author: Matthew Patton <mpatton@enquizit.com>
Date: Thu Nov 1 07:21:59 2018 -0400
refacter config_file. replace all hard-coded os.TempDir with wrapper
commit c22092c601c33484327674f322c7379fa41506d7
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 20:11:36 2018 -0400
close massive file overwrite hole with TempDir
commit 7a730450916bf8e5dbc2a741ec233a49466ab7cc
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 01:06:00 2018 -0400
adjust var declaration scope
commit 0f2933adb6f6922dfeab78a95371a444ec8918ab
Author: Matthew Patton <mpatton@enquizit.com>
Date: Wed Oct 31 00:54:35 2018 -0400
use mktemp() equivalent to create temporary directory
commit d74839ede05dacf712b55a7bb48aec19fe6b007f
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 20:40:58 2018 -0400
remove extraneous variable declaration, fix FOR loop
commit eb65416619437e4a3dec90277770803dd5b2281c
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:30:44 2018 -0400
match styistic convension with rest of docs
commit acaa2b31ed463219c4ef099f351eec72406e2989
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 19:08:39 2018 -0400
revert dangling config file change
commit e573fde668dcb418561e61535c1d68b2888f5b0f
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Fri Dec 29 23:53:43 2017 -0500
replace invalid TMPDIR variable wth PACKER_TMP_DIR.
update ConfigTmpDir() to try common temporary paths first and
only write to configDir() as a last resort.
commit 39a9874afc9dea71b36753375fb7feb61ffecf69
Merge: 8a413cfe8 3315812c2
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Oct 30 18:19:26 2018 -0400
Merge branch 'master' of https://github.com/hashicorp/packer into prestine
commit 8a413cfe83b0a70dbd99c32d936334ca5788ca9b
Merge: e07491de5 4e14710a6
Author: Matthew Patton <mpatton@enquizit.com>
Date: Mon Oct 1 20:18:10 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit e07491de59cead0b337a7f57f4a6c625e1f560ab
Merge: 42610a35d a1fa35dff
Author: Matthew Patton <mpatton@enquizit.com>
Date: Tue Aug 21 13:26:19 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 42610a35d5ef65af8844a58ad70e2ec75262da6a
Merge: 5298142da 0d63cf7bc
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Tue Jun 19 22:45:05 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 5298142da6da95354844f201deeeef3c599e48b2
Merge: 7bb110bc7 9d9736552
Author: Matthew Patton <mpatton@enquizit.com>
Date: Mon Jun 11 15:10:09 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 7bb110bc744c9797fcaec25a265d9b85a22d6d6b
Merge: a61c869ca 6189d66e7
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Wed May 9 23:41:22 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit a61c869ca7268acf0e3b1e1fa7a8ee7feea65984
Merge: 098101dd9 4be5f072c
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Fri May 4 10:13:04 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 098101dd99f08b0ca110d33eff6904537c6d21de
Merge: fefaf0fa6
554b2b4a5
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date: Tue May 1 20:52:30 2018 -0400
Merge branch 'EOL-handling' into prestine
Co-Authored-By: Matthew Patton <pattonme@yahoo.com>
2018-12-12 16:35:57 +01:00
Tom Elliff
12bf7fc4d6
Check that the KMS key ID is valid
...
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.
Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
2018-12-12 11:41:58 +00:00
Adrien Delorme
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087
...
fix virtualbox 6.0 beta command options
2018-12-11 11:54:56 +01:00
Adrien Delorme
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code
...
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-11 11:53:26 +01:00
Megan Marsh
a819217c93
fix virtualbox 6.0 beta command options
2018-12-10 15:18:21 -08:00
Ali Rizvi-Santiago
1a36458e9e
Tiny fix to replace some duplicate code with usage of the `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-10 16:24:27 -06:00
Megan Marsh
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
...
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
Ali Rizvi-Santiago
a6af04417e
Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument.
2018-12-10 15:09:56 -06:00
Megan Marsh
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
...
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
chhaj5236
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied
...
alicloud: delete copied image and snapshots if corresponding options are specified
2018-12-09 19:39:14 +08:00
Adrien Delorme
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965
...
Fix 6965
2018-12-07 13:35:00 +01:00
Megan Marsh
ce71932f95
Merge pull request #7061 from boumenot/pr-6773-caching-type
...
azure: configuration for disk caching
2018-12-06 15:06:21 -08:00
Megan Marsh
042e9ad14b
Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder.
2018-12-06 14:37:31 -08:00
Megan Marsh
dbfc1b5aff
fix tests
2018-12-06 09:36:16 -08:00
Megan Marsh
0058422a5c
also for vmx
2018-12-05 15:58:44 -08:00
Megan Marsh
0fe4d79bbf
add validation to prevent users from being confused about format functionality
2018-12-05 15:57:45 -08:00
Ali Rizvi-Santiago
2e977019e4
Modified the docker builder's default run_command to specify the shell via the entrypoint command line argument as suggested by @vrubiolo in #6920 .
2018-12-04 23:52:17 -06:00
bozhi.ch
0174a502eb
support -force option and update docs
2018-12-05 11:50:35 +08:00
Ali Rizvi-Santiago
310ea6c006
Updated docker's default config to use regular bourne shell instead of bourne again. Closes #6920 .
2018-12-04 18:28:48 -06:00
Ali Rizvi-Santiago
040a33567e
Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser..
2018-12-04 16:54:47 -06:00
Ali Rizvi-Santiago
79b68fb89c
Replaced the previous incorrect logic with an re-implementation of common.ExpandUser.
2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
e04986659a
Changed the logic for when to actually prefix a path with a u.HomeDir so that it's only done when a non-absolute path is specified.
2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
1a3c3f2ffc
Replaced all instances of mitchellh/go-homedir with an implementation based on os/user.
2018-12-04 16:53:33 -06:00
Megan Marsh
152f6fed8f
Merge pull request #7066 from arizvisa/vmware-temporary-devices
...
Add a "temporaryDevices" key to the statebag for the VMware builder
2018-12-04 10:34:37 -08:00
Ali Rizvi-Santiago
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
Megan Marsh
65124985d1
don't set DetectZeroes if it's off, because some versions of QEMU don't support this option
2018-12-03 15:52:13 -08:00
Ali Rizvi-Santiago
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
Ali Rizvi-Santiago
e0d3861e81
Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
27b16cee0a
Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.
2018-12-03 17:47:45 -06:00
Christopher Boumenot
c7d8f4e150
azure: configuration for disk caching
...
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite. This seems the most appropriate value
given Packer. Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
Andrew Starr-Bochicchio
c0c5c6afac
Add DigitalOcean post-processor.
2018-11-29 21:00:57 -05:00
Megan Marsh
c03894c05d
fix bad interpolation exemption for volume_size
2018-11-29 16:39:43 -08:00
Adrien Delorme
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels
...
add snapshot_labels to hcloud builder
2018-11-29 13:48:57 +01:00
Megan Marsh
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation
...
move region validation to run so that we don't break validation when no creds are set
2018-11-28 15:02:18 -08:00
Megan Marsh
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
PORTE Loïc
bf97557abf
Backport VNC log from vmware to qemu
2018-11-28 19:13:29 +01:00
bozhi.ch
a485bcfdf3
delete copied image and snapshots if corresponding options are specified
2018-11-28 21:34:21 +08:00
Megan Marsh
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
Megan Marsh
89fb8f0d3e
fix defaulting/lack thereof for cpu count and memory in vmware template
2018-11-27 15:43:48 -08:00
Nathan A. Ferch
fccd7d0692
add snapshot_labels to hcloud builder
2018-11-27 14:41:32 -05:00
Megan Marsh
6728244480
simplify for loop logic
2018-11-27 09:33:29 -08:00
Andrew Pennebaker
c05ac784d3
fix tests
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5ada3376b8
fix test
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
2c989157e4
gofmt
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5b6cbeed1d
expose `--iso` option down in `VBoxManage export --iso` up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled.
2018-11-27 09:31:01 -08:00
Megan Marsh
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode
...
[Hetzner Cloud] Support for builds using rescue mode
2018-11-26 11:39:34 -08:00
bozhi.ch
7704ff2f24
apply tags to relevant snapshots
2018-11-26 16:58:32 +08:00
dedene
1aaa998b02
Revert back to reset server
2018-11-26 09:49:45 +01:00
dedene
6589bfaaab
Small code improvements and fixes
2018-11-26 09:10:17 +01:00
zhuzhih2017
53bfe7179f
Merge pull request #7022 from chhaj5236/feature/image_without_datadisks
...
alicloud: support creating image without data disks
2018-11-26 13:13:51 +08:00
Kevin Bulebush
76d1bf567e
Replaced compute/v2/images with imageservice/v2/images.
...
Removed usage of a deprecated API.
Standardized clientService naming.
2018-11-25 14:30:31 -05:00
bozhi.ch
3c1395eb04
support wait_snapshot_ready_timeout for much bigger disk
2018-11-25 16:05:26 +08:00
dedene
0f3bfbf8e6
Fix timing issues by updating to hcloud-go v1.11.0
2018-11-24 17:56:09 +01:00
Kevin Bulebush
802e7d467d
openstack: Add support for tagging new images.
2018-11-23 20:22:10 -05:00
dedene
064e6c7e08
Add support for builds using rescue mode
2018-11-23 20:35:32 +01:00
Adrien Delorme
e539133d8c
Merge pull request #7019 from arizvisa/vmware.cpu-memory
...
Add configuration options to vmware builder to specify cpu count and memory size
2018-11-23 10:53:46 +01:00
Adrien Delorme
24510907be
Merge pull request #7018 from arizvisa/parallels.cpu-memory
...
Add configuration options to parallels builder to specify cpu count and memory size
2018-11-23 10:50:01 +01:00
Adrien Delorme
174c811c1e
Merge pull request #7017 from arizvisa/virtualbox.cpu-memory
...
Add configuration options to virtualbox builder to specify cpu count and memory size
2018-11-23 10:27:14 +01:00
Ali Rizvi-Santiago
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
Ali Rizvi-Santiago
0f019407d6
Updated things related to the general hw config in the virtualbox builders to correspond to @azr's suggestions.
2018-11-22 20:48:00 -06:00
Ali Rizvi-Santiago
784535a4e3
Updated things related to the parallels-iso builder to correspond to @azr's suggestions.
2018-11-22 20:19:00 -06:00
Ali Rizvi-Santiago
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
Megan Marsh
da6e350949
fix tests
2018-11-20 15:20:01 -08:00
Megan Marsh
fbb3d526e3
move region validation to run so that we don't break validation when we don't have aws creds set
2018-11-20 15:01:28 -08:00
Nathan A. Ferch
849a6ed353
add ssh_keys config to hcloud builder
2018-11-20 13:58:17 -05:00
bozhi.ch
3c2c13a021
support creating image without data disks
2018-11-19 15:25:12 +08:00
Ali Rizvi-Santiago
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
Ali Rizvi-Santiago
eca26f43f2
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:34:22 -06:00
Ali Rizvi-Santiago
24140131c7
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:32:11 -06:00
Ali Rizvi-Santiago
51948daf92
Added options for the cpu count, memory, audio, and usb to the virtualbox builder.
2018-11-17 06:19:54 -06:00
Ali Rizvi-Santiago
71d15d05c0
Added support for the cpu_count, memory_size, sound, and usb options to the parallels builder.
2018-11-17 06:13:59 -06:00
Ali Rizvi-Santiago
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
Rickard von Essen
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
Ali Rizvi-Santiago
4e73c85e22
Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized.
2018-11-16 22:20:00 -06:00
Christopher Boumenot
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot
...
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
2018-11-16 15:51:52 -08:00
Amrita Dutta
b8def0b3fb
Added test to check for missing OS disk snapshot name and data disk snapshot prefix
2018-11-15 22:01:16 +00:00
Amrita Dutta
67342750a3
Addressed PR comments
2018-11-14 01:47:48 +00:00
Megan Marsh
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
Megan Marsh
3b413d2e5e
fix rebase conflicts
2018-11-12 13:24:03 -08:00
Megan Marsh
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
Megan Marsh
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
Megan Marsh
7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161
...
azure builder: allow to auth with managed identities ( MSI )
2018-11-12 09:03:41 -08:00
Megan Marsh
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
Adrien Delorme
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
Adrien Delorme
78ac943679
Merge pull request #6987 from hashicorp/6624
...
6624
2018-11-12 15:31:36 +01:00
Adrien Delorme
175b6a7971
add test for MSI configuration
2018-11-12 12:04:57 +01:00
Adrien Delorme
1958ef6e81
remove unecessary check
2018-11-12 11:32:49 +01:00
Adrien Delorme
08e8b1850e
remove unnecessary parenthesis
2018-11-12 10:49:39 +01:00