d1e31c0f23
use if/else to clarify code
2018-05-21 15:19:27 -07:00
969201a2d4
handle minor shell-local PR suggestions and corrections
2018-05-21 14:56:44 -07:00
1fdf763d0f
fancier logging
2018-05-21 11:25:51 -07:00
8a3e599cad
Added text to point out two device auth
2018-05-21 11:05:59 -07:00
a54fcc9efe
missed doc fixes to remove referece for object_id, note keeping the command for now for how to get object ID for older releases
2018-05-19 13:16:57 -07:00
da67df6d03
space fix
2018-05-18 21:17:19 -07:00
4992429e8c
Minor comment fixes
2018-05-18 17:34:01 -07:00
00e809cb7e
Refactored the change into a new function
2018-05-18 15:21:49 -07:00
ea9b2a8b5f
review feedback
2018-05-18 12:09:42 -07:00
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
...
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
...
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
3ca4a7208f
Updated Samples and added a windows quick start as well
2018-05-18 08:12:43 -07:00
667113338a
missed formating
2018-05-18 01:41:00 -07:00
7f2277676a
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:34:12 -07:00
77fe1bffe4
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:25:19 -07:00
de1783240f
Updates to remove space changes
2018-05-18 00:53:44 -07:00
91eed4da52
trim right of the keyvault url
2018-05-18 00:44:25 -07:00
df5cc234fc
updates
2018-05-18 00:39:57 -07:00
1f46271a6b
Ensuring device login works for Windows build
2018-05-18 00:32:01 -07:00
2764058eef
Merge pull request #6280 from WaaZaa666/master
...
Fixing #6267 , multiple hyper-v disks
2018-05-17 08:19:25 -07:00
b747877222
Fixing #6267 , multiple hyper-v disks
2018-05-17 14:50:18 +02:00
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
...
Async delete Resource Group
2018-05-16 15:13:09 -07:00
6c7aa724eb
Fix tests after merging with master.
2018-05-16 22:43:30 +02:00
c33ca8ce64
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-16 22:14:12 +02:00
11f2b1ec24
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-16 21:54:39 +02:00
81db142c8a
Unify handling PlaybookFile and PlaybookFiles.
2018-05-16 21:54:19 +02:00
f81492ef9d
Add back last step comment
2018-05-16 15:35:14 -04:00
f793d219b2
Only show Windows Sysprep code with validation
...
The first example completes successfully, but will not let you know that the image is not actually able to be deployed to a VM.
2018-05-16 15:29:54 -04:00
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
2018-05-16 13:52:00 +01:00
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
2018-05-16 12:55:59 +01:00
784c7973c2
minor updates to docs
2018-05-15 11:45:24 -07:00
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
0d785cca75
Merge pull request #6270 from jamielennox/doc-capture-container-name
...
[Azure] Don't mention capture_container_name in required
2018-05-15 09:32:13 -07:00
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
a9aa9908cd
Document use of T2 Unlimited for enabled Amazon builders
2018-05-15 12:25:06 +01:00
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00
2c339b99d2
Sort run config options alphabetically
2018-05-15 12:25:06 +01:00
436065c02b
[Azure] Don't mention capture_container_name in required
...
capture_container_name is only a required variable if you are outputting
to VHD format. It is mentioned below as required when building a VHD so
having it here as well is confusing.
2018-05-15 18:35:14 +10:00
c8c9bbb22a
Async delete Resource Group
2018-05-14 20:06:23 -07:00
5710c0aca1
Making log output clearer for hyper-v gui connection
2018-05-14 20:53:51 +10:00
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
...
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
b3882e0cae
Updates to review comments
2018-05-11 10:00:31 -07:00
Megan Marsh
Hariharan Jayaraman
WaaZaa666
Christopher Boumenot
localghost
David Tesar
DanHam
Jamie Lennox
Unknown