2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
2018-05-16 12:55:59 +01:00
a866232ac9
Use regex based approach to detect attached disks
2018-05-08 12:52:39 +01:00
25dd27a164
Remove tmp directories created by builder/vmware/common tests
2018-04-30 20:38:03 +01:00
c828015bc3
Follow variable varName <-> statebag var_name convention
2018-04-27 20:09:19 +01:00
f342975ff3
Fix test - reporting compaction results requires a tmp file
2018-04-27 16:40:44 +01:00
08f9d619a9
Report the result of the disk compaction step
2018-04-27 16:40:29 +01:00
10d93dffa4
Fix tests for vmware/common
2018-04-27 16:40:23 +01:00
a729ecda87
Fix tests for vmware/vmx builder
2018-04-27 16:40:13 +01:00
c48a7889f9
Simplify handling of disks by collating requirements and unifying ops
2018-04-27 16:39:52 +01:00
67a9c7fb92
we never expect remote cache to be a directory.
2018-04-26 12:40:40 -07:00
de1dac1bdf
don't delete the cache directory.
2018-04-26 12:40:40 -07:00
97cfd60b82
Remove remote cache correctly.
2018-04-26 12:40:35 -07:00
673d4579e4
Ack! Forgot to include the template variable in the definition for vmxTemplateData for commit 0e519d79e0. Now it's added..
2018-04-26 14:22:37 -05:00
0e519d79e0
Modified iso/step_create_vmx.go in the vmware-iso builder to also specify the "bios.hddOrder" field depending on the hdd device that was specified. This might close issue #6197
2018-04-26 14:16:50 -05:00
5d8b476a7f
Fixed the regex in common/step_clean_vmx.go for the VMware builder to also support removal of sata-based cdrom devices. Also added a comment in iso/step_create_vmx.go that links both pieces of related code.
2018-04-26 14:01:58 -05:00
451e3d0554
builder/vmware-esxi: remove floppy files when done
2018-04-26 10:47:33 -07:00
6bbfe7e0bd
remove useless check against format
2018-04-23 10:24:49 -07:00
fdeadfe3f6
builder/vmware: correctly default export format to ovf
2018-04-23 10:17:53 -07:00
bd9e585cb9
Add test for enumeration of vmx network type
2018-04-21 22:49:36 +01:00
94d5a7f2e2
Fix copy/paste error referencing Virtualbox
2018-04-21 22:49:36 +01:00
1aee759f06
Fix tests and reconfigure for support of multi-disk vm
2018-04-21 22:49:36 +01:00
6c9d4efd9f
Fix error on compaction step of vmx build. Support compacting multi-disk vm
2018-04-21 22:49:36 +01:00
c6299972b9
s/boot_command/bootcommand/
2018-04-19 14:26:31 -07:00
408eba88ad
flatten boot command config and implement for vmware
2018-04-19 14:26:30 -07:00
cba4d3235f
cleanup
2018-04-19 14:26:29 -07:00
bf0a320125
Implement new parser for qemu boot command
2018-04-19 14:26:29 -07:00
1c0af28662
Some cleanup and comments.
2018-04-19 14:26:29 -07:00
4e2f14196a
Rely on context to cancel typing boot command.
2018-04-19 14:26:28 -07:00
673245afcf
Replace boot command parser with PEG parser.
2018-04-19 14:26:28 -07:00
83162717ed
Merge pull request #4563 from marema31/vmware-iso-warn-esx
...
builder/vmware-iso: Fail on wrong remote_type value
2018-04-06 16:52:26 -07:00
2c2904c095
Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases..
2018-03-30 18:19:25 -05:00
7e9699675f
Modified device matching logs to look more consistent.
2018-03-30 18:15:46 -05:00
6e176f97a0
Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network.
2018-03-29 13:12:59 -05:00
646523c5f4
Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers.
2018-03-29 13:04:25 -05:00
55702a697a
Ack, forgot to :w in vim. Changed ui.Say in step_clone_vmx.go to use fmt.Sprintf as it originally was a call to log.Printf.
2018-03-25 19:03:46 -05:00
72da7cbfbb
Fixed a case-sensitivity issue when determing the network type during cloning in the vmware-vmx builder and added also some logs that output the different options that were determined from the .vmx. This outputs more accurate debug information and helps out with issue #5925
2018-03-25 18:51:37 -05:00
ef4f3f143b
Merge pull request #5985 from AndiDog/f-5979-vmware-fusion-guestip-lookup-multiple-devices
...
Handle multiple devices per VMware network type
2018-03-21 17:12:36 -07:00
fa36e1d961
spelling: processing
2018-03-14 02:17:22 +00:00
61030c0d85
spelling: output
2018-03-13 08:27:26 +00:00
d987fcefc3
spelling: multiples
2018-03-13 08:12:53 +00:00
ff92fb883d
Handle multiple devices per VMware network type
...
Fixes #5979
2018-03-07 10:59:55 +01:00
ac2e02b938
remove loglines that should not have made it onto master
2018-03-06 14:12:39 -08:00
df6cdcc7f7
Disable the usage of the XHCI bus for USB on the vmware-iso builder.
...
Some platforms with incomplete XHCI implementations (i.e. FreeBSD)
will poll the bus despite there being no usb devices available.
This disables XHCI by default and documents how to enable it using
the vmx_data option.
This closes issue #5961 .
2018-03-05 20:58:43 -06:00
9e8e376d6c
Merge pull request #5932 from hashicorp/add_configurable_snapshot_timeout
...
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:27:20 -08:00
597ddc2192
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:01:53 -08:00
33acdbf3bf
move comments so indentation is more logical
2018-02-21 14:57:58 -08:00
ac2ddbcbf5
Fixes the assumption that all the VMware builder's drivers will implement a network mapper for mapping a network name to it's corresponding device.
...
The ESX5 driver doesn't have a way of mapping the network name to its device name because a .vmx template uses different field names for it and so packer let's ESX handle filling this in. This patch will check to see if the driver that packer determines is missing a NetworkMapper implementation (by checking for nil). If it is, then fall back to using "nat" despite ESX not using the network type at all. This is what packer did prior to exposing the network type to the user back in version 1.1.3.
This closes issue #5916 .
2018-02-20 19:45:55 -06:00
27ed479b0a
Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux.
...
It was reported that on WS14 on Linux, that the path may be different than stated in the documentation. This modifies `workstationDhcpConfPath` and `workstationDhcpLeasesPath` functions to walk through every permutation while attempting to find the correct file.
This reinforces the fix for issue #5882 .
2018-02-14 00:11:17 -06:00
d6e5342ece
Fixed a type-o in the VMWare builder when locating the dhcp configuration file on Linux.
...
Closes issue #5882 .
2018-02-13 17:27:17 -06:00
fa2dddd26d
Fixed some things mucked up during rebase.
2018-02-02 19:45:18 -06:00
aefe41a44a
Fixed an issue with the previous commit so that when the user does not specify the cdrom_adapter_type to fallback to the original decision made by the disk adapter type selection.
2018-02-02 19:18:50 -06:00
eb0445ca96
Added support for specifying both the network adapter type and cdrom adapter type as requested by @night199uk. Also included the respective documentation for these new options.
2018-02-02 19:18:50 -06:00
74946071d2
Added support for specifying the disk adapter type to the vmware builders. This was squashed from the vmware-diskAdapterType branch ( #2968 ) as submitted by Rami Abughazaleh <icnocop@users.noreply.github.com>. This closes #5671 and possibly #4885 .
...
arizvisa: Updated icnocop's documentation to include the possible disk adapter types that one can specify.
arizvisa: Tweaked icnocop's support for the `disk_adapter_type` option to the VMWare builder that caused conflicts due to version skew.
icnocop: Updated links to the Virtual Disk Manager User's Guide PDF to open in a new window and also added the Adobe PDF icon
icnocop: Added support for vmware to specify the disk adapter type, ide or scsi (lsilogic or buslogic)
2018-02-02 19:18:49 -06:00
594ed950c7
Fixed a race condition in builder/vmware/common/driver_parser.go due to a misunderstanding how channels work when you close them.
2018-02-02 19:18:49 -06:00
737e951685
Added missing root path to path-finders for the VMware Fusion implementation in the vmware builder as mentioned by @SwampDragons.
2018-02-02 19:18:49 -06:00
b2fec18b1e
Added parser for VMware Fusion's networking file. Replaced VmwareDriver's NetmapConfPath with a NetworkMapperInterface in order to handle the differences between VMware Fusion and the rest of the VMware suite.
2018-02-02 19:18:49 -06:00
069d00f70b
Added the paths suggested by @phekmat and @SwampDragons for VMware Fusion... Although parser for the new mapper format is likely to be needed still.
2018-02-02 19:18:49 -06:00
8cc0776f3a
Fixed oversight in VMware builder's mock-driver that neglected to initialize 'HostAddressResult'.
2018-02-02 19:18:49 -06:00
029c357d8c
Modified some tests to require the PACKER_ACC environment variable to be set before executing them. This turns them into acceptance tests as per CONTRIBUTING.md.
2018-02-02 19:18:49 -06:00
58ebc5c9a5
When specifying NONE for serial or parallel in the VMware builder, disable the serial and parallel port devices entirely.
2018-02-02 19:18:48 -06:00
258804106b
Added missing GetVmwareDriver() method to VMware Builder's DriverMock.
2018-02-02 19:18:48 -06:00
6423525a33
Updated imports of github.com/mitchellh/packer to new naming scheme github.com/hashicorp/packer
2018-02-02 19:18:48 -06:00
75fbfa0763
Replaced a hacky type assertion in the VMware builder with a call to Driver.GetVmwareDriver() that returns the driver-specific structure for ip and addressing information. Also implemented the addressing functions for the ESXi driver interface.
...
This fixes an issue where a driver might not have defined a VmwareDriver by forcing a developer to implement it via the standard Driver interface.
2018-02-02 19:18:48 -06:00
898b27c16d
Added support for the NONE option to be specified for parallel and serial ports in the vmware iso builder.
2018-02-02 19:18:48 -06:00
884af69da1
go fmt on builder/vmware/*
2018-02-02 19:18:48 -06:00
0d6cf7fac4
Added support for auto-detection to the serial and parallel port types.
...
Included the yield option to all the serial port types.
Added the ability for the network type to fallback to a custom network if the
specified network name is not found in netmap.conf.
Promoted the scope for both Read{Dhcp,Netmap}Config inside vmwcommon.driver.
Updated the documentation for the VMware builder.
2018-02-02 19:14:29 -06:00
b52e2d3f45
Added the ability for the vmware-builder to fallback and determine the network device-name using the .vmx configuration in case of a guest using the "custom" connection type.
2018-02-02 19:13:02 -06:00
e389d30a1b
Implemented the unit-tests for builder/vmware/iso/step_create_vmx.go
2018-02-02 19:13:02 -06:00
15cb6a833a
Ugh..missing argument in VMware builder's driver_esx5 unit-test due to api change for .HostIP(). Fixed.
2018-02-02 19:11:41 -06:00
9b95ce0bc6
Completely forgot to support the unix paths in each of the drivers for the VMware builder. Fixed.
2018-02-02 19:11:41 -06:00
4225b3568e
Fixed bad ORs and a bad fmtstring.
2018-02-02 19:11:41 -06:00
75d3ea7cee
Added support for sound, serial ports, parallel ports, usb, and specifying a default network to the vmware builder.
...
builder/vmware/{iso,vmx}:
Added the specific configuration options that get parsed.
Normalize paths when pulling them from the json template so that they'll work on Windows too.
Added some improved error checking when parsing these options.
Stash the vm's network connection type so that other steps can figure out addressing information
Modified the esx5 driver to support the new addressing logic.
Modified the template in step_create_vmx to include the new options.
builder/vmware/common:
Implemented a parser for vmware's configuration files to the vmware builder.
Modified the driver's interface to include support for resolving both guest/host hw and ip addresses
Implemented a base structure with some methods that implement these features.
Rewrote all ip and mac address dependent code to utilize these new methods.
Removed host_ip and guest_ip due to their logic being moved directly into a
base-structure used by each driver. The code was explicitly checking runtime.GOOS
instead of portably using net.Interfaces() anyways.
Updated driver_mock to support the new addressing methods
2018-02-02 19:11:41 -06:00
8ae8f31a52
Merge pull request #5681 from mcandre/super-key
...
add super key (vmware builder)
2018-02-02 13:33:11 -08:00
8bdd3b45c7
use helper functions for reading vmx files
2018-01-31 13:19:31 -08:00
76b2ce8604
log which vmware driver we decide on
2018-01-26 16:12:43 -08:00
07421b4433
test vmware workstation version checking
2018-01-26 15:58:17 -08:00
8cd403425e
test fixes WIP
2018-01-24 17:09:17 -08:00
7a189a83a1
fix imports
...
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
a831d522be
change run signatures
...
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.
`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
366dc3da0a
move multistep imports to helper.
...
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
d069dc5b7c
handle holding a-z keys, such as for boot options (vmware builder)
2017-12-09 20:51:49 -06:00
4acc98a729
add super key (vmware builder)
2017-12-07 23:15:56 -06:00
8a30b3db80
Merge pull request #5456 from GoSecure/vmware-iso-improved-network-logging
...
vmware-iso builder: Logging on network errors on connection refused
2017-11-30 16:31:30 -08:00
f7b45312f1
Removing skip attribute
2017-11-10 23:58:24 -03:00
be2afccb85
Revamped the process to verify remote cache.
2017-11-10 23:55:26 -03:00
463d87adcd
Merge branch 'master' of https://github.com/hashicorp/packer into esxi-remote-cache
2017-11-10 23:08:09 -03:00
23f4d187e2
validating keep_registered and fixing skip_export issues
2017-11-08 15:57:34 -03:00
4d117bf117
Make vm log output less confusing
2017-11-02 10:45:54 -07:00
820811675d
vmware-iso builder: Logging on network errors on connection refused
2017-10-13 19:00:48 -04:00
07b013945f
more consistent flag name
2017-10-12 16:38:18 -07:00
106408f6be
add new disable_vnc option
2017-10-12 16:34:40 -07:00
6a238a3ef3
add option to skip vnc phase and update docs
2017-10-12 16:28:27 -07:00
2a326b5172
fix nil ptr exception
2017-10-05 16:34:13 -07:00
e93d64e80f
Merge pull request #4592 from jimmythedog/ovfexportpath-localoutputdir
...
Ovfexportpath localoutputdir -- Merging for release with 1.1.0
2017-08-31 09:55:58 -07:00
cd11e4ff33
Merge pull request #5187 from mkuzmin/vmware-artifactid
...
vmware: Publish artifact ID
2017-08-30 13:56:49 -07:00
28894fb418
Merge pull request #5274 from mmerdes/master
...
Fix timestamp interpolation in created file name
2017-08-23 14:08:27 -07:00
cb75796389
Show a message why VM export was skipped while building on VMWare Fusion/Workstation
2017-08-23 12:44:46 -07:00
c8d09b5152
Fix timestamp interpolation in created file name
...
This commit attempts to fix the timestamp-related part of #4885 by using the logic found in the analogous virtualbox implementation. In essence, it applies the solution from commit 93bb0d8
2017-08-23 13:04:42 +02:00
9876a28ea7
vmware: publish vm_name as artifact ID
2017-07-28 11:16:46 +03:00
DanHam
Matthew Hooker
Ali Rizvi-Santiago
M. Marsh
Josh Soref
Andreas Sommer
Andrew Pennebaker
bugbuilder
Olivier Bilodeau
nictrix
Victor Ronin
Matthias Merdes
Michael Kuzmin