44012b29ec
Remove redundant error message.
2018-05-08 03:25:39 -07:00
ee1ff3132d
remove attempt to discover whether destination is a directory from upload function in various communicators
2018-04-10 08:13:06 -07:00
c5e0710a9a
Do nothing if we detect destination is a directory
...
We can't modify the destination path in the communicator because it
breaks assumptions in the provisioners. For example, we try to chmod in
the shell provisioner. The chmod command uses the path as supplied by
the user. If the communicator decides to rewrite the path, the
provisioner doesn't know that, and so tries to chmod the wrong thing.
The best we can do is detect that the destination is a directory and
fail.
Also correctly surface output from sftp uploader.
2018-03-20 16:33:00 -07:00
67c7b9d152
display debug log levels
2018-03-20 16:32:55 -07:00
ccdee2550b
Treat any output directory test command as error.
...
Surfaces any communications from the remote end during file
uploads. For example, we might get notifications if we're logging in
with the wrong user. Rather than swallow these, let's show them to the
user.
2018-03-20 16:32:35 -07:00
e2f9204c11
replace nil ptr exceptions with infinite loops
2018-03-19 15:52:43 -07:00
6c1654d421
spelling: separators
2018-03-14 03:21:38 +00:00
fc99dc25ae
spelling: error
2018-03-13 07:45:13 +00:00
a4123eabe3
prevent 0-value ticker during ssh keepalive
2018-02-12 10:45:53 -08:00
ff64ccda55
Merge pull request #5426 from hashicorp/fix_4915
...
Fix 4915
2018-02-05 14:54:27 -08:00
63f1673909
ssh deadlines
2018-01-31 12:35:25 -08:00
cab52872f4
add session level keep-alives for ssh communicator
2018-01-30 22:00:37 -08:00
a79d5eff4e
implement sftp path
2017-10-05 10:44:18 -07:00
93bddb3e65
implement directory fix for lxc file uploads
2017-10-04 13:35:15 -07:00
b3cc90125d
ssh communicator works
2017-10-03 16:36:27 -07:00
a5e6134819
implement dir check for ssh communicator
2017-10-03 15:55:32 -07:00
4e8303f3b4
Merge pull request #5024 from rickard-von-essen/issue-4941
...
ssh: Renamed ssh_disable_agent to ssh_disable_agent_forwarding
2017-08-28 11:55:26 -07:00
ea76b5a693
Show scp output on error
2017-08-10 11:46:38 -07:00
4f6010aa26
ssh: Renamed ssh_disable_agent to ssh_disable_agent_forwarding
...
Closes : #4941
2017-06-19 16:26:18 +02:00
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
eab4730c29
communicator/ssh: don't return error if we can't close connection.
2017-03-30 02:14:49 -07:00
cc11ec3566
check for a couple errors
2017-03-28 20:36:21 -07:00
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
ce259c126a
communicator/ssh: fix nil ptr error
...
fixes a case where we could return a nil error and nil ssh session.
2017-03-20 14:30:53 -07:00
00ebe9e1d3
various fixes
...
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-11-29 14:55:44 +03:00
d920b3fbf4
run gofmt
2016-11-01 14:08:04 -07:00
892d5e82c9
expect_disconnect option
...
provisioner/shell: Adds option to fail if the remote server disconnects
us.
2016-10-21 11:39:03 -07:00
5747f4e890
prevent panic when ssh reconnect fails
2016-10-14 11:23:35 -07:00
4e93e60313
log unknown error, make ExitMissingError clearer
2016-10-06 11:13:39 -07:00
286b7836fa
remove dead code.
...
continues work from a629f1655b
2016-10-05 18:17:02 -07:00
5ab19ea469
bump ssh library, check for ssh.ExitMissingError
...
should resolve #3920
2016-10-05 18:16:08 -07:00
5919f8d552
continue add support for file-provisioner implement directory download feature.
2016-09-18 20:48:30 +08:00
0cea0e5c24
Swap width and height when allocating a pty
...
RequestPty from crypto/ssh looks like this:
func (s *Session) RequestPty(term string, h, w int, termmodes TerminalModes) error
So arguments 2 and 3 are height and width, respectively. I'm not sure if
the original was just a typo, or if there's an actual reason we want a
40 column terminal. Either way, having a terminal this narrow led me to
a really "fun" bug[0], where `wget` in my shell provisioner scripts
would segfault when trying to display the progress bar.
[0] http://lists.gnu.org/archive/html/bug-wget/2016-02/msg00041.html
2016-04-06 15:40:19 -04:00
feee19e4ed
file provisioner improvements
...
* allow specify source/destination as dir
* allow specify many files as source
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-02-12 11:48:28 -08:00
a59c82d7a6
Add sftp file transfer support
...
Adds a new config option: "ssh_file_transfer_method", which can be set to "scp"
or "sftp" (defaults to "scp")
2015-07-26 23:49:18 +00:00
0ca03f09c1
Fix some style issues and add a doc to ErrHandshakeTimeout
2015-07-02 11:58:51 -07:00
5dd8ae45c7
Cleanup some resources we may have created
2015-07-02 03:55:18 -07:00
03850cafc6
Implemented timeout around the SSH handshake, including a unit test
2015-07-02 03:40:47 -07:00
8657b1e9d8
communicator/ssh: more logging
2015-06-29 11:40:08 -07:00
d8b6c94012
Fix typo: diabled -> disabled
2015-06-26 10:52:21 -07:00
a019575026
helper/communicator: support disabling SSH agent
2015-06-23 14:52:37 -07:00
686d4413ec
communicator/winrm: error if download
2015-06-15 15:08:56 -07:00
8ecca2aa54
implement ssh.Download()
2015-06-15 15:08:18 -07:00
acf31c31a1
communicator/ssh: update logging
2015-06-13 19:00:28 -07:00
b2f8eb68e8
Enable ssh agent forwarding #1066
2015-06-13 17:15:49 -07:00
71d8c6610a
Merge pull request #1968 from bhcleek/master
...
do not request a pty
2015-06-13 16:23:31 -04:00
23a48d6619
go fmt
2015-06-08 21:34:20 -07:00
b1497b951c
code.google.com/p/go.crypto/ssh -> golang.org/x/crypto/ssh
...
code.google.com/p/go.crypto/ssh is now at golang.org/x/crypto/ssh as of
https://code.google.com/p/go/source/detail?spec=svn.crypto.69e2a90ed92d03812364aeb947b7068dc42e561e&repo=crypto&r=8fec09c61d5d66f460d227fd1df3473d7e015bc6
Using the code.google.com import redirects properly, but runs into
issues if you try to use a subpackage of `ssh`, e.g. `agent` which
refers to golang.org/x/crypto/ssh causing conflicts if your types expect
code.google.com/p/go.crypto/ssh.
This is a precursor to a PR for #1066 .
2015-05-28 08:17:49 -07:00
2184892f8a
do not request a pty
...
Change the default behavior from requesting a PTY when executing a
command with the ssh communicator to requesting a PTY only when
configured to do so.
Update the vmware builders to be fully backward compatible with the new
behavior.
2015-02-12 20:18:54 -08:00
0f36a051d5
Create temporary copy of symlink before uploading, fixes #1765
2014-12-16 14:11:28 +11:00
Matthew Hooker
Megan Marsh
Josh Soref
Rickard von Essen
Vasiliy Tolstov
开恒
Alex Brown
Alfonso Acosta
Chris Bednarski
Mitchell Hashimoto
Mark Peek
Alexander Golovko
Mitchell Hashimoto
jszwedko
Billie H. Cleek
Tim Cinel