Megan Marsh
48b448dfd5
Merge pull request #9366 from hashicorp/fix_9248
...
Add ToolSyncTime and ToolUpgradePolicy to vSphere
2020-06-05 13:03:58 -07:00
Megan Marsh
7fcd702b45
Merge pull request #9358 from jhawk28/bug_9349
...
(vsphere-iso) add the ability to check if the IP is within the an IP range
2020-06-05 12:18:51 -07:00
Megan Marsh
093cfcfd9f
Merge pull request #9322 from arizvisa/GH-8528
...
Fix the VMware builders when the guest platform's dhcpcd switches the ip address in-between a build
2020-06-05 10:58:00 -07:00
Ali Rizvi-Santiago
8985ba077c
Re-added the (mistakenly removed) host override to the CommHost for the vmware builders.
2020-06-05 12:39:20 -05:00
Megan Marsh
4cd3429914
add ssh override test
2020-06-05 10:15:11 -07:00
Moss
112638da01
Add ToolSyncTime and ToolUpgradePolicy to vSphere
2020-06-05 17:20:44 +02:00
Sylvia Moss
1422085ede
Validate host and network when looking for network ( #9361 )
2020-06-05 11:01:58 +02:00
Joshua Foster
d87e53b841
return false instead of continue to match logic from govmomi
2020-06-05 00:09:57 -04:00
Joshua Foster
3a6d42e0df
ip check should continue if the ip is NOT in the range
2020-06-04 23:17:02 -04:00
Joshua Foster
90463e5394
make default for wait address to be any ipv4 address. add some better documentation
2020-06-04 23:13:46 -04:00
Ali Rizvi-Santiago
9c5a65263f
Added @SwampDragons' suggestion to the `CommHost()` implementation for the vmware builders which uses the communicator config's `Config.Port()` function to determine the communication port-number independent of the configured protocol.
2020-06-04 19:04:12 -05:00
Megan Marsh
baed65156c
Merge pull request #9319 from arizvisa/GH-8528.refactor
...
This refactors the dhcpd lease parser in the vmware builders and adds unit tests for everything.
2020-06-04 12:18:49 -07:00
Joshua Foster
27a1ceef6d
add example for any ipv4 address
2020-06-04 12:15:53 -04:00
Sylvia Moss
aa52e690ee
Update go-getter and add samba shared files tests to step_download ( #8954 )
2020-06-04 15:00:18 +02:00
Ali Rizvi-Santiago
898321bcfe
Added suggestions from @SwampDragons to the parsers from the vmware builders, included unit-tests and sample file for fusion's networking file, and fixed a few situations where the channel wasn't being closed.
2020-06-04 05:07:18 -05:00
Joshua Foster
1fb22a7b7b
add the ability to check if the IP is within the an IP range
2020-06-04 01:55:25 -04:00
Joshua Foster
d35f342319
add the ability to configure the http bind address. defaults to 0.0.0.0.
2020-06-03 16:40:18 -07:00
Megan Marsh
02590f6c44
Merge pull request #9329 from hashicorp/je.website-maintenance-5-29-20
...
🌷 Website Spring Maintenance
2020-06-03 16:25:23 -07:00
Megan Marsh
f520ced2a8
Merge pull request #9356 from GennadySpb/remove-platform-validation-for-instances-with-gpu
...
Do not require 'gpu-standard-v1' platform_id for any GPU-based config.
2020-06-03 14:52:36 -07:00
Paul Meyer
e260212be3
Merge pull request #9323 [azure-chroot] copy data disks between shared image galleries
...
[azure-chroot] copy data disks between shared image galleries
2020-06-03 12:32:19 -07:00
Gennady Lipenkov
542819c464
Remove test
2020-06-03 21:17:12 +03:00
Gennady Lipenkov
df371b7e25
Do not require 'gpu-standard-v1' platform_id for any GPU-based config.
...
Support use another kind of GPU platforms.
2020-06-03 20:58:39 +03:00
Sylvia Moss
434c9bcae0
Check if task result is nil and return error ( #9354 )
2020-06-03 17:37:30 +02:00
Megan Marsh
df37918467
Merge pull request #9303 from arizvisa/GH-8528.unit-tests
...
Unit tests for the driver_parser.go functionality of the vmware builder
2020-06-02 15:28:13 -07:00
Jeff Escalante
f4d7b5f493
fix some stuff
2020-06-02 17:22:40 -04:00
Wei Cheng
e0cfb404fb
builder/googlecompute: add support to specify storage location for GCP images ( #9326 )
...
* feat: add support to specify storage location for GCP images
Signed-off-by: Wei Cheng <calvinpohwc@gmail.com>
2020-06-02 13:42:33 -04:00
Megan Marsh
e851757e5f
Merge pull request #9342 from jhawk28/bug_9328
...
(vsphere-iso) use the Datacenter's VmFolder
2020-06-02 10:24:48 -07:00
Sylvia Moss
ce45a1990a
Refactor communicator config for Qemu and add SkipNatMapping option ( #9307 )
2020-06-02 11:56:36 +02:00
Joshua Foster
30bff17799
use the Datacenter's VmFolder instead of hand generating it
2020-06-01 19:53:54 -04:00
RedTail72
374f82b978
buidler/vsphere-iso: ISOUrl Fix ( #9321 )
...
* ISOUrl Fix
Added the check for ISOUrls back in addition to a check for RawSingleISOUrl. This should allow both ISOUrls[] or ISOUrl to work while not requiring them all the time.
* Update config.go
Fixed formatting.
2020-06-01 15:27:26 -04:00
Ali Rizvi-Santiago
e5b6d8c37c
Didn't know that WinRM uses a different variable for the port number when trying to determine the communication host in `CommHost`...now it's fixed.
2020-05-30 02:17:21 -05:00
Megan Marsh
5efb1a195e
update docs for configuration_paramaters to explain what it actually is.
2020-05-29 15:07:34 -07:00
Jeff Escalante
9a38fbe2c7
patch source for a couple code block changes
2020-05-29 17:22:16 -04:00
Megan Marsh
184dc6cc44
Merge pull request #9260 from hashicorp/fix_9256
...
make package_include match output_vagrantfile parsing and abspath cal…
2020-05-29 10:41:26 -07:00
Megan Marsh
8a9833f5b1
Merge pull request #9287 from rgl/feature-qemu-add-timeout-wait-for-ip-address
...
builder/qemu: timeout waiting for the guest to become available in the network bridge
2020-05-29 09:47:06 -07:00
Paul Meyer
2288ab3b53
fix typo
2020-05-29 04:15:53 +00:00
Feiyu Shi
1c1991c073
fix a bug
2020-05-28 19:17:22 -07:00
Feiyu Shi
f86f5b958a
Merge remote-tracking branch 'origin/master' into identity
2020-05-28 19:03:44 -07:00
Megan Marsh
03b2c4355e
include Wilken's suggestion
2020-05-28 16:46:33 -07:00
Paul Meyer
53e5137411
[bug] Fix test error message
2020-05-28 23:38:17 +00:00
Paul Meyer
83851bc9aa
[bug] fix diskset type in Artifact creation
2020-05-28 23:38:17 +00:00
Paul Meyer
aa8250bcc8
give temp data disks lun suffix
2020-05-28 23:38:17 +00:00
Paul Meyer
4c96847683
log data disks in images
2020-05-28 23:38:17 +00:00
Paul Meyer
f0cd60b5fa
[bug] provide data disk prefix to disk creation
2020-05-28 23:38:17 +00:00
Paul Meyer
af96cf7881
Generated files
2020-05-28 23:38:14 +00:00
Paul Meyer
ac3d19ee23
Use separate caching/sku for data disks
2020-05-28 23:37:44 +00:00
Paul Meyer
f601f54d0b
Use all disks in managed image
2020-05-28 23:37:43 +00:00
Paul Meyer
de4839b66e
Use all snapshots when creating a shared image
2020-05-28 23:37:43 +00:00
Paul Meyer
c6b995a34d
create snapshots for all disks in a diskset
2020-05-28 23:37:43 +00:00
Paul Meyer
0ee77f8b0e
Add datadisks to disk set when using SIG as source
2020-05-28 23:37:43 +00:00
Paul Meyer
12f746b2b5
Move to using a diskset
...
Need to store lun numbers for data disks as well
2020-05-28 23:37:43 +00:00
Paul Meyer
3a3e6e525b
Shift names to diskset
...
Instead of one disk, we'll be working with a set of disks.
2020-05-28 23:37:43 +00:00
Paul Meyer
c9284d03aa
Add config for data disk/snapshot naming
2020-05-28 23:37:38 +00:00
Ali Rizvi-Santiago
229b5d17ff
Re-worked the vmware builder drivers so that they're able to check multiple ip addresses when trying to connect via the CommHost.
2020-05-28 15:36:45 -05:00
Ali Rizvi-Santiago
0609909f1a
Fixed some lint issues.
2020-05-28 13:53:49 -05:00
Ali Rizvi-Santiago
ad7194c920
Rewrote the GuestIP implementation in the vmware builder to use the new dhcpd lease parsers instead of the old regexp-based logic.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
020b005522
Finished implementing the final dhcpd lease entries parser for the vmware builders and also included its own unit tests.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
cf5332fa20
Updated the dhcpd lease entry parser in the vmware builder to return errors if any are encountered.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
afa4696985
Tightened the regular expressions used by the vmware builder to parse the dhcpd leases, and added support for parsing the weekdays.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
e2a7c317eb
Implemented the dhcpd lease entry decoder and the address decoder for the vmware builder.
2020-05-28 13:22:57 -05:00
Ali Rizvi-Santiago
efb775accb
Added a number of parsing combinators to the vmware builder and some minor tests for them to help with parsing dhcpd leases.
2020-05-28 13:22:57 -05:00
Ali Rizvi-Santiago
f17007d546
Removed the sentinelSignaller chan from the vmware builder parsers and its unit-tests, and also commented all of the goroutines that are used.
2020-05-28 13:22:56 -05:00
Ali Rizvi-Santiago
159ea595df
More lint issues fixed...
2020-05-28 13:12:42 -05:00
Ali Rizvi-Santiago
32b64e0576
Fixed some lint issues in the unit tests for the vmware builder driver parsers.
2020-05-28 13:07:54 -05:00
Adrien Delorme
40947c2bf6
HCL2: generate hcl tags with go-cty tags too ( #9306 )
...
This will allow to generate the config files:
```go
package main
import (
"fmt"
"github.com/hashicorp/hcl/v2/gohcl"
"github.com/hashicorp/hcl/v2/hclwrite"
"github.com/hashicorp/packer/builder/alicloud/ecs"
)
func main() {
name := "name"
app := ecs.FlatConfig{
AlicloudImageName: &name,
ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{
DiskName: &name,
},
}
f := hclwrite.NewEmptyFile()
block := gohcl.EncodeAsBlock(&app, `source "something" "something"`)
f.Body().AppendBlock(block)
fmt.Printf("%s", f.Bytes())
}
```
Will output:
```
source "something" "something" {
packer_user_variables = null
packer_sensitive_variables = null
image_name = "name"
image_share_account = null
image_unshare_account = null
image_copy_regions = null
image_copy_names = null
tags = null
tag = null
system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri
ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_
snapshot_id = null }
image_disk_mappings = null
ssh_remote_tunnels = null
ssh_local_tunnels = null
ssh_public_key = null
ssh_private_key = null
}
```
This is a good first step for #9015 and #9282
fix #9304
2020-05-28 11:19:00 +02:00
Adrien Delorme
0fa60c68fb
Drop the iso_checksum_type & iso_checksum_url fields ( #8437 )
...
* Drop the iso_checksum_type & iso_checksum_url fields
In favor of simply using iso_checksum that will know what to do.
* fix after master merge
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* remove checksum lowercasing tests
* Update builder_test.go
* Update builder_test.go
* better docs
* Update builder_test.go
* even better docs
* Update config.go
* Update builder_test.go
* Update step_create_vmx_test.go
* make generate
* better docs
* fix imports
* up tests
* Update _ISOConfig-required.html.md
* Update builder_test.go
* don't use sha1.Sum("none") as a caching path
* Update builder_test.go
* better docs
* Update iso_config_test.go
remove ISOChecksumType/ISOChecksumURL references
* Update step_download_test.go
* add iso_checksum_url and iso_checksum_type fixers + tests
* add concrete examples of checksum values
* add examples of checksumming from local file
* update go-getter dep
* up deps
* use new go-getter version
* up ESX5Driver.VerifyChecksum: use go-getter's checksumming
* ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum
* Update iso_config.go
* get go-getter from v2 branch
* Update driver_esx5.go
add more comments
* Update driver_esx5.go
* show better error message when the checksum is invalid
* Update builder_test.go
put in a valid checksum to fix tests, checksum is md5("packer")
* Update builder_test.go
test invalid and valid checksum
* more test updating
* fix default md5 string to be a valid md5
* TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming
* Update iso_config_test.go
* Update iso_config_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update go.mod
* Update go.mod
* Update CHANGELOG.md
2020-05-28 11:02:09 +02:00
Joshua Foster
828440d852
rebase and run generate
2020-05-27 15:05:23 -07:00
Joshua Foster
43714049e8
add set_host_for_datastore_uploads flag
2020-05-27 15:00:08 -07:00
Joshua Foster
9895f90451
dont set the host for the datastore upload
2020-05-27 15:00:08 -07:00
Ali Rizvi-Santiago
2a8bc45bc4
Added unit-tests for the netmap parsing components in the vmware builder.
2020-05-26 23:03:30 -05:00
Ali Rizvi-Santiago
7c1ad4adcf
Added unit-tests for the dhcpd configuration components in the vmware builder, and fixed a few discovered race conditions.
2020-05-26 22:59:35 -05:00
Feiyu Shi
fdb0b2ab03
Revert "validate if user assigned identity exists"
...
This reverts commit 9bd19df040
.
2020-05-26 17:17:48 -07:00
Feiyu Shi
c016f3752a
upgrade SIG source api-version to match identity api-version to avoid potential setback for identity
2020-05-26 16:08:00 -07:00
Megan Marsh
01839e272e
Merge pull request #9277 from nitrocode/add-source-ami-creation-date
...
Added SourceAMICreationDate
2020-05-26 12:24:47 -07:00
nitrocode
6d29ec956b
Added SourceAMICreationDate
2020-05-26 15:04:03 -04:00
Rui Lopes
4839b9189d
builder/qemu: timeout waiting for the guest to become available in the network bridge
2020-05-26 07:46:06 +01:00
Feiyu Shi
3fdab998f8
check error
2020-05-25 12:33:33 -07:00
Megan Marsh
5dfd2a763e
send logs about floppy failure directly to UI not just logs ( #9272 )
2020-05-25 12:02:29 +02:00
Feiyu Shi
9bd19df040
validate if user assigned identity exists
2020-05-24 19:05:46 -07:00
Feiyu Shi
b334458b91
use empty struct for UserAssignedIdentities map value; omitempty
2020-05-24 19:05:45 -07:00
Feiyu Shi
c5e2eff847
change to []*Resource
2020-05-24 19:05:45 -07:00
Feiyu Shi
3e3fdaa24e
make generate
2020-05-24 19:05:45 -07:00
Feiyu Shi
76a7ab25e2
add SetIdentity test
2020-05-24 19:05:45 -07:00
Feiyu Shi
764f99ec7b
add correct api-version
2020-05-24 19:05:45 -07:00
Feiyu Shi
f7f033a7fd
add config validation test
2020-05-24 19:05:45 -07:00
Feiyu Shi
10b0a4548f
add identity resource id validation
2020-05-24 19:05:45 -07:00
Feiyu Shi
7c1a62dfed
set identity field in the template
2020-05-24 19:05:45 -07:00
Feiyu Shi
d9c9bfbae8
add identity field to the template
2020-05-24 19:05:45 -07:00
Feiyu Shi
b5b2982772
add user_assigned_managed_identities to the config
2020-05-24 19:05:45 -07:00
Megan Marsh
082d806b1f
fix httpip acquisition
2020-05-21 09:39:54 -07:00
Rui Lopes
06fad6cc4f
qemu: add support for using a network bridge
2020-05-20 16:46:32 -07:00
Megan Marsh
266bba279b
linting
2020-05-19 16:45:14 -07:00
Megan Marsh
aadd95497a
fix tests
2020-05-19 16:39:17 -07:00
Megan Marsh
a892d13d56
make package_include match output_vagrantfile parsing and abspath calculation
2020-05-19 16:32:54 -07:00
Megan Marsh
58b32ebefa
Merge pull request #9251 from hashicorp/fix_9249
...
builder/azure-arm: Update runtime constants with a valid DataDiskName
2020-05-19 11:00:44 -07:00
jhawk28
820f353573
(vsphere-iso) remove deprecated network and disk fields ( #9149 )
...
* remove deprecated network and disk fields
2020-05-19 10:06:12 -04:00
Sylvia Moss
1c30a71d09
Replace file shared state by statebag ( #9238 )
2020-05-19 11:49:48 +02:00
Wilken Rivera
c954831bb2
builder/azure-arm: Update runtime constants with a valid DataDiskName
...
This change fixes an issue where using the `disk_additional_size` configuration option would cause builds to fail.
Build results before the change
```
==> Builds finished but no artifacts were created.
Build 'azure-arm' errored: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details." Details=[{"code":"BadRequest","message":"{\r\n \"error\": {\r\n \"code
\": \"InvalidParameter\",\r\n \"message\": \"The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\\\\W][\\\\w-._]{0,79}(?\u003c![-.])$.\",\r\n \"target\": \"dataDisk.name\"\r\n }\r\n}"}]
```
Build results after change
```
Build 'azure-arm' finished.
==> Builds finished. The artifacts of successful builds are:
--> azure-arm: Azure.ResourceManagement.VMImage:
OSType: Linux
ManagedImageResourceGroupName: test-pkr
ManagedImageName: wilkenPacker9249
```
Closes #9249
2020-05-18 14:57:20 -04:00
Wilken Rivera
f31f5bc61b
docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
...
Closes #9199
2020-05-14 13:31:40 -04:00
Evan Digby
e4eaff6bba
s/Directoty/Directory ( #9221 )
2020-05-14 15:00:27 +02:00