c5df4ed2a3
Merge pull request #8387 from DanHam/fix-validate-aws-vpc-info
...
Only validate the user has provided a subnet_id when vpc_id has been set
2019-11-19 14:56:04 -05:00
afb880c134
test/builder/amazon/common/step_pre_validate: Update DescribeVpcs mock
...
* Update condition to check for a empty VpcId
2019-11-19 14:48:07 -05:00
074be9942d
Only validate the user has provided a subnet_id when vpc_id has been set
2019-11-19 14:09:58 +00:00
3571c585bb
builder/googlecompute: fix dropped error ( #8385 )
2019-11-19 11:41:39 +01:00
ad74a87b5c
Merge pull request #8360 from hashicorp/fix-7167
...
builder/amazon: Add validation for `subnet_id` when specifying `vpc_id`
2019-11-18 16:50:11 -05:00
f9f4726eff
builder/amazon/step_pre_validate: Add check for non-default VPCs
...
Subnet information is only really needed when the specified `vpc_id` is
not the default VPC for the region where the builder is being executed.
This change uses the AWS API to determine if the VPC provided is a
non-default VPC and only validates the existence of a `subnet_id` if a
user has provided a non-default `vpc_id`.
Tests after change
```
> make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc'
...
=== RUN TestStepPreValidate_checkVpc
=== RUN TestStepPreValidate_checkVpc/DefaultVpc
=== RUN TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet
=== RUN TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet
=== RUN TestStepPreValidate_checkVpc/SubnetWithNoVpc
=== RUN TestStepPreValidate_checkVpc/NoVpcInformation
--- PASS: TestStepPreValidate_checkVpc (0.00s)
--- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s)
--- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s)
--- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s)
--- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s)
--- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s)
PASS
...
```
2019-11-18 16:44:09 -05:00
ef137a8f08
Merge pull request #8380 from bennu/qemu-args
...
fix: persist default drive/device
2019-11-18 11:05:45 -08:00
ad34a4551b
provisioner/windows-restart: revert sleep hack now that we've fixed the underlying bug in #8369 ( #8377 )
2019-11-18 10:48:33 +01:00
dfa134cd98
ditch else statement for improved clarity
2019-11-18 10:11:59 +01:00
ce8bca349f
Update builder/amazon/ebs/step_create_ami.go
...
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
2019-11-18 10:11:59 +01:00
a35ac0127e
fix bug in step_region_copy
2019-11-18 10:11:59 +01:00
30ccab472f
fix: persist default drive/device
2019-11-17 04:38:30 -03:00
261331ee2d
Merge pull request #8375 from hashicorp/fix_8373
...
helper/communicator/step_connect_ssh: Update proxy connection settings to use `SSHProxyUsername` and `SSHProxyPassword`
2019-11-15 15:21:40 -08:00
22c754c049
Merge pull request #8369 from hashicorp/eof_dieeee
...
Resolve ntlm nil pointer bug by bumping go-ntlmssp dependency
2019-11-15 15:00:36 -08:00
452ca602ee
update go-ntlmssp dependency to fix upstream bug affecting winrm users
2019-11-15 13:08:38 -08:00
a61fe833ef
helper/communicator/step_connect_ssh: Update proxy connection settings to use `SSHProxyUsername` and `SSHProxyPassword`
2019-11-15 15:08:05 -05:00
2e7ba19d8c
post-processor/vagrant-cloud: fix dropped test errors
2019-11-15 11:44:33 +01:00
437983343a
Merge pull request #8371 from stephentawn/master
...
Fix error message when ovftool is missing
2019-11-14 16:07:12 -08:00
202ba41170
Merge pull request #8370 from alrs/fix-builder-lxc-dropped-error
...
builder/lxc: fix dropped error
2019-11-14 15:46:59 -08:00
c66219084e
Fix error message when ovftool is missing
2019-11-14 23:11:16 +00:00
59472c6aad
builder/lxc: fix dropped error
2019-11-14 13:40:40 -08:00
c09bb52a92
Merge pull request #8357 from hashicorp/fix_8330
...
ask for VM by name to reduce looping.
2019-11-13 14:06:57 -08:00
58a7448c86
Merge pull request #8356 from hashicorp/fix_7879
...
if someone logs a line longer than 64*1024 bytes before it contains a…
2019-11-12 15:08:19 -08:00
fef4b05871
Merge pull request #8365 from hashicorp/td-amazon-helper-awserr-check
...
builder/amazon: Add helper function for checking against AWSError
2019-11-12 15:07:43 -08:00
50e84624b9
Merge pull request #8364 from hashicorp/fix_8222
...
update to newest version of go-tty to fix control flow bug
2019-11-12 13:08:54 -08:00
488e539f63
builder/amazon: Add helper function for checking against AWSError
...
Replace all straight forward occurrences of `if err, ok := err.(awserr.Error)` with the `isAWSErr` helper function
2019-11-12 15:27:47 -05:00
ffc4876812
Merge pull request #8363 from alrs/scripts-plugins-err-before-close
...
scripts: close file after error handling
2019-11-12 10:21:54 -08:00
53bbce4cd7
update to newest version of go-tty to fix control flow bug
2019-11-12 10:17:21 -08:00
3c170522f3
scripts: close file after error handling
2019-11-12 09:52:40 -08:00
9afb7b54cb
Merge pull request #8361 from alrs/fix-ncloud-dropped-error
...
builder/ncloud: fix dropped error
2019-11-12 14:49:22 +09:00
4c9cfed743
builder/ncloud: fix dropped error
2019-11-11 20:56:55 -08:00
60cf4f6014
log errors in scanner and manually close logging pipe if we hit an error in the scanner
2019-11-11 09:20:39 -08:00
ae184fe31d
ask for VM by name to reduce looping.
2019-11-08 16:20:03 -08:00
be0e9f7816
Merge pull request #8354 from alrs/fix-do-ssh-key
...
builder/digitalocean: fix dropped error on RSA key generation
2019-11-08 13:00:00 -08:00
3f11a80c3b
Merge pull request #8355 from hashicorp/fix_8341
...
update docs with note about ssh/winrm
2019-11-08 12:40:24 -08:00
88530a7944
if someone logs a line longer than 65*1024 bytes before it contains a newline, the default ScanLines func in bufio.Scanner can't handle it. Copy that func and add a conditional to clear buffer and continue scanning in this situation.
2019-11-08 12:34:36 -08:00
161be0adcd
update docs with note about ssh/winrm
2019-11-08 11:09:16 -08:00
418152f23a
builder/digitalocean: fix dropped error on RSA key generation
2019-11-08 10:35:48 -08:00
643fce7b8a
builder/hcloud: handle dropped ssh errors
2019-11-08 11:35:58 +01:00
db4f242a24
go generate ./builder/qemu after #7676
2019-11-08 11:27:00 +01:00
6e2456d028
make error messaging around ResourceNotReady better, update docs with other possible issues ( #8349 )
2019-11-08 11:15:24 +01:00
81fb66c857
update changelog.
2019-11-07 16:02:36 -08:00
98c94ab8cb
Merge pull request #7676 from ltrager/master
...
Add display template option for qemu.
2019-11-07 15:41:17 -08:00
e70e82d892
Merge pull request #8342 from cove/retry-runinstances2
...
retry runinstances aws api that wasn't retried
2019-11-07 15:39:02 -08:00
4a3f5318e2
Merge pull request #8347 from rjspiker/rj.font-smooth
...
website - add -moz-osx-font-smoothing for smooth firefox osx fonts
2019-11-07 14:14:48 -08:00
f7cf5bd0c2
Merge pull request #8348 from hashicorp/d-getting-started-updates
...
getting-started/build-image: Remove reference to Redis install
2019-11-07 13:53:31 -08:00
b7561e3915
website - add -moz-osx-font-smoothing for smooth firefox osx fonts
2019-11-07 13:01:05 -07:00
821d6d4f54
getting-started/build-image: Remove reference to Redis install
...
The deleted paragraph seems like a carry over from a previous version of the document as Redis is no longer mentioned as part of the base image template.
2019-11-07 11:48:54 -05:00
f2f544c434
fixed get copy region value ( #8345 )
2019-11-07 11:12:19 +01:00
d5ba530b26
make it clear we expect pem format not some other formate ( #8344 )
2019-11-07 10:30:51 +01:00
Wilken Rivera
DanHam
Lars Lehtonen
Megan Marsh
bugbuilder
Stephen Tawn
Yu SungDuk
Adrien Delorme
RJ Spiker
Li Kexian