Megan Marsh
340009009d
Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890""
...
This reverts commit 0cd3f36d50
.
2018-10-23 09:58:27 -07:00
Megan Marsh
0cd3f36d50
Revert "Merge pull request #6892 from hashicorp/fix_6890"
...
This reverts commit 1c4062c316
, reversing
changes made to 9bc41a23b9
.
2018-10-23 09:34:05 -07:00
Megan Marsh
1c4062c316
Merge pull request #6892 from hashicorp/fix_6890
...
fix template-set credentials
2018-10-22 13:55:48 -07:00
Megan Marsh
0924a316b7
fix template-set credentials
...
update tests with mocked session
2018-10-22 13:53:40 -07:00
Megan Marsh
cdd99564fd
Merge pull request #6891 from hashicorp/fix_6794
...
Fix 6794
2018-10-22 11:10:05 -07:00
Megan Marsh
091efae8bb
Merge branch 'master' into misc
2018-10-22 11:07:30 -07:00
Megan Marsh
fd8a85042d
use strconv.Quote instead of fmt.Sprint
2018-10-22 10:59:47 -07:00
Megan Marsh
18c5e8deb8
fix
2018-10-19 13:46:55 -07:00
Megan Marsh
1e4133cbf9
quote upload path
2018-10-19 13:43:13 -07:00
Megan Marsh
3f591d78f3
quote vmx path in register function
2018-10-19 13:42:40 -07:00
Megan Marsh
8cba32d526
escape all the d.sh calls that contain paths
2018-10-19 13:42:40 -07:00
Megan Marsh
5b9adc0c48
single quotes
2018-10-19 13:42:40 -07:00
Megan Marsh
9573013d3a
Merge pull request #6872 from aspectcapital/disable-ena-support
...
Add support to explicitly disable ENA support
2018-10-19 10:54:38 -07:00
Megan Marsh
9fe27c225b
Merge pull request #6703 from shield-9/wait_volume
...
OpenStack: wait for volume availability when cleaning up
2018-10-19 10:25:51 -07:00
Matt Dainty
feb8067c7d
Convert `ena_support` to a pointer
...
This means it now has three states, `true`, `false`, & `nil`. The
default state is now `nil` which does nothing instead of `false` which
now will explicitly disable ENA support instead of just not enabling it.
2018-10-19 12:40:43 +01:00
Josh Soref
b68168807a
Miscellaneous doc improvements
...
backticks, spaces, commas
In general, a list of items should have a space after each comma.
While there are editorial styles that suggest commas inside quotations,
they're horrible advice when the backticks are describing specific
character for a user to enter.
one off indent filters section
singular
backticks...
word wrap long lines...
spelling: macOS
contributing: clarify closing case
contributing: link to changelog
contributing: point to git remote...
contributing: split commands from descriptions
contributing: grammar
spelling: github
grammar: comma after etc.
spelling: macOS
grammar: i.e.
alicloud: use relative link
alicloud: use backticks
alicloud: bits
alicloud: such as
grammar: comma after etc.
avoid linking periods
grammar: period
amazon-chroot: IOPS
amazon-chroot: use backticks
amazon-chroot: link to section
amazon-chroot: whether-or-not; period
amazon-ebs: period
amazon-ebs: use relative link
amazon-ebs: use backticks
amazon-ebs: comma
amazon-ebs: bold
amazon-ebssurrogate: comma after etc.
amazon-ebssurrogate: this builder
amazon-instance: this builder
amazon-ebssurrogate: set this
amazon-ebssurrogate: whether-or-not
amazon-ebssurrogate: period
amazon-ebssurrogate: bold section reference
amazon-ebssurrogate: backticks...
amazon-ebssurrogate: commas around e.g.
spelling: precedence
spelling: i.e.
amazon-ebssurrogate: backticks...
2018-10-18 19:09:49 -04:00
Megan Marsh
57f87f58b9
Merge pull request #6374 from rickard-von-essen/aws-filters
...
builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter
2018-10-18 14:34:02 -07:00
Megan Marsh
3175dcdf81
Merge pull request #6807 from dev-rowbot/qemu-net-device-6804
...
Fix for #6804 - KVM/QEMU Network "has no peer"
2018-10-18 14:09:22 -07:00
Megan Marsh
c5b6eff691
Merge pull request #6871 from LKaemmerling/master
...
Add hcloud builder
2018-10-18 11:13:16 -07:00
Lukas Kämmerling
e4a670d2a2
Remove Debug Message
2018-10-18 10:29:06 +02:00
Adrien Delorme
29d041ea8a
Merge pull request #6858 from hashicorp/tests_race_detector
...
test with race detection enabled + fix race on progressbar
2018-10-18 09:48:03 +02:00
Lukas Kämmerling
bad1b95a49
Unify steps, fix some typos
2018-10-18 08:03:04 +02:00
Megan Marsh
fd89d4f020
Merge pull request #6827 from skish/qemuDiskZero
...
builder/qemu add drive detect-zeroes option
2018-10-17 19:12:38 -07:00
Megan Marsh
2266514408
Merge pull request #6843 from gmmephisto/pr-master-aws-security-group
...
aws: wait for temporary security group before authorize rules
2018-10-17 14:08:49 -07:00
Megan Marsh
e7d3a30c0e
Merge pull request #6865 from hashicorp/fix_6862
...
Fix 6862
2018-10-17 13:07:29 -07:00
Mikhail Ushanov
00c96fc400
aws: use IpPermissions for authorizing temporary security group
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:25 +03:00
Mikhail Ushanov
b316be51cd
aws: wait for temporary security group before authorizing
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:24 +03:00
Megan Marsh
b0cfecf314
remove unnecessary valid flag
2018-10-17 11:03:31 -07:00
Matt Dainty
9e0fae9db3
Add support to explicitly disable ENA support
...
If `ena_support` is set to false then it previously didn't do anything
whereas now it will explicitly disable ENA support.
Fixes #6852
2018-10-17 14:58:07 +01:00
Adrien Delorme
410bee0666
make TestStepShutdown_shutdownDelay less strict on schedule
2018-10-17 12:49:38 +02:00
Lukas Kämmerling
270110767c
Add hcloud Builder
2018-10-17 12:15:47 +02:00
Adrien Delorme
af3b818de0
TestBuilderPrepare_ISOChecksumType: set config["switch_name"] = "switch" to avoid using builder.detectSwitchName which can lock down in CI mode
2018-10-17 12:09:24 +02:00
Adrien Delorme
0237956e66
builder/virtualbox/common/step_shutdown_test.go: compare durations instead of floats & ouput duration
2018-10-17 11:19:57 +02:00
Adrien Delorme
1ca21499c6
Revert "make builder/hyperv/vmcx/builder_test.go invisible to windows"
...
This reverts commit e692dee2d8
.
2018-10-17 10:21:53 +02:00
Adrien Delorme
b80a0fed42
make builder/parallels/common/output_config_test.go invisible to windows
2018-10-17 09:59:13 +02:00
Adrien Delorme
e692dee2d8
make builder/hyperv/vmcx/builder_test.go invisible to windows
2018-10-17 09:57:42 +02:00
Megan Marsh
d4767845f0
fix tests
2018-10-16 15:01:13 -07:00
Megan Marsh
7c3f0aa3b2
make sure region validation catches authentication errors
2018-10-16 14:17:30 -07:00
Mikhail Ushanov
ee133482b4
aws: add validation for device_name parameter
...
cause it's required in block-device-mapping.
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-16 21:37:48 +03:00
Adrien Delorme
8a6c55dd69
make builder/hyperv/iso/builder_test.go invisible to windows
2018-10-16 19:09:35 +02:00
Matthew Aynalem
28eff7303e
builder/googlecompute: validate startup_script_file exists
2018-10-15 16:09:33 -07:00
Megan Marsh
cdc6c57b31
Merge pull request #6822 from hashicorp/fix_6774
...
Fix 6774
2018-10-10 13:25:58 -07:00
Megan Marsh
f5af2afc06
Merge pull request #6818 from hashicorp/fix_6732
...
default wait time for amazon import to one hour.
2018-10-10 11:27:34 -07:00
Megan Marsh
f331327f24
Merge pull request #6823 from hashicorp/fix_6794
...
fix datastore path that contains spaces
2018-10-10 10:06:15 -07:00
Megan Marsh
53bce398bb
add Managed Image test to azure artifact
2018-10-10 10:04:19 -07:00
Megan Marsh
5dc4ff95da
fix azure artifact so it works with managed images as well as VHDs
2018-10-10 10:04:11 -07:00
Christopher Boumenot
520dea23fd
Merge pull request #6798 from mbearup/mb-sharedgallery
...
Consume images from Azure Shared Image Gallery
2018-10-10 09:53:18 -07:00
mbearup
de8d30d77c
Update tests for Azure Shared Image Gallery
2018-10-10 09:20:34 -07:00
Konstantin Shloma
fe341e2bd0
fix go source formatting
...
add description to documentation page
2018-10-10 16:16:23 +03:00
Konstantin Shloma
1155347b55
add qemu disk detect-zeroes= option
2018-10-10 14:38:59 +03:00
mbearup
c7180413b0
Fix tests for Shared Image Gallery
2018-10-09 16:38:50 -07:00
Megan Marsh
e5e75df033
fix datastore path that contains spaces
2018-10-09 16:36:55 -07:00
mbearup
a3a2a9e970
Fix issue with composite literal in test
2018-10-09 15:35:09 -07:00
mbearup
335feaf89c
Convert shared_image_gallery options to a struct
...
Updates tests and documentation for shared_image_gallery
2018-10-09 13:56:49 -07:00
Megan Marsh
895e7fe111
Merge pull request #6812 from hashicorp/remove_unused_processPrivateKeyFile
...
removed unused processPrivateKeyFile func & tests
2018-10-09 13:14:11 -07:00
Megan Marsh
02bfac118f
default wait time for amazon import to one hour.
2018-10-09 13:08:42 -07:00
Megan Marsh
f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
...
abort if image import fails
2018-10-09 12:56:28 -07:00
Adrien Delorme
b2e2d3b008
removed unused processPrivateKeyFile func & tests
2018-10-09 11:56:43 +02:00
Rowan Potgieter
65db6be6b9
Fix for #6804
...
The user QEMU args may overwrite the default -device.
This results in no network
2018-10-06 14:40:43 +02:00
mbearup
5373b8586d
Update tests for Azure Shared Image Gallery
2018-10-05 16:04:07 -07:00
mbearup
b6bb5d4b4d
Fix format/spacing for config.go
2018-10-05 10:52:02 -07:00
mbearup
c1e0146d33
Dynamically set apiVersion for Shared Image Gallery scenario.
2018-10-03 16:33:28 -07:00
mbearup
d21b13cb85
Modify variable names for Shared Image Gallery.
...
Add checks for Shared Image Gallery options.
2018-10-03 16:10:46 -07:00
Adrien Delorme
f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
...
reset poll delay seconds default to 2 because it can actuall be used …
2018-10-03 11:15:42 +02:00
Adrien Delorme
146db5667a
fix intermitent TestProcessPrivateKeyFile_encrypted failure
...
Because of deficiencies in the encrypted-PEM format, it's not always possible to detect an incorrect
password. In these cases no error will be returned but the decrypted DER bytes will be random noise.
this closes #3337
2018-10-01 10:29:30 +02:00
mbearup
55be0da5da
Initial changes to support Shared Image Gallery
2018-09-30 13:56:44 -07:00
Adrien Delorme
b7b1720a91
Merge pull request #6772 from fflorens/scaleway-add-boottype
...
scaleway: add boottype parameter in config
2018-09-27 16:51:01 +02:00
Florian Florensa
9ea5104b74
scaleway: add boottype parameter in config
2018-09-27 16:37:07 +02:00
Adrien Delorme
37c6f08abe
Revert "Fix bugs"
...
This reverts commit 02139dcb69
that constitutes pr #6701
2018-09-27 16:27:34 +02:00
Adrien Delorme
016b0985a6
builder/openstack: use config as a pointer so values could be set
...
this commit will close #6712
2018-09-27 16:27:34 +02:00
Adrien Delorme
b328d3569d
builer/triton: pass config as a pointer so values could be set
2018-09-27 16:27:34 +02:00
Adrien Delorme
22d3e9b5c4
builder/amazon/ebs: pass config as a pointer so values could be populated by a run
2018-09-27 16:27:34 +02:00
mvaude
7f78eef08d
scaleway: fix builder problems with ssh keys
...
The builder is currently failing with the last packer version.
This commit is fixing:
- the ssh keys and configuration management (the config is passed through a pointer and the ssh keys through the config instead of the runner states)
- the key size for generated ssh key
- the public key added as a tag to the instance<Paste>
fix #6757
2018-09-27 15:40:18 +02:00
Matthew Hooker
9181570bc3
remove stray struct dumps in logs
2018-09-27 00:14:05 -07:00
zhuzhih2017
676b28ecc5
Merge pull request #6764 from chhaj5236/feature/support_disable_stop_instance
...
support disable_stop_instance option for some specific scenarios
2018-09-27 14:52:07 +08:00
zhuzhih2017
f59cde03c4
Merge pull request #6763 from chhaj5236/fix/invalid_type_convert
...
fix type error in step_create_tags
2018-09-27 14:49:52 +08:00
bozhi.ch
bb19cdeb55
support disable_stop_instance option for some specific scenarios
2018-09-25 22:02:05 +08:00
bozhi.ch
1f3a517a19
fix type error in step_create_tags
2018-09-25 20:20:10 +08:00
Rickard von Essen
838d5021f5
openstack: use source_image_name to find UUID
2018-09-21 10:35:15 +02:00
Daisuke Takahashi
3b8aba2d24
OpenStack: wait for volume availability when cleaning up
2018-09-21 10:13:45 +09:00
Megan Marsh
d616f0ba71
abort if image import fails
2018-09-20 13:18:59 -07:00
Daisuke Takahashi
c848f59a55
Check condition for image_disk_format option
2018-09-20 11:02:30 +09:00
Daisuke Takahashi
b7bd3d4b34
OpenStack: Change option name to `image_disk_format`
2018-09-20 10:44:28 +09:00
Daisuke Takahashi
904dd1df63
Add disk_format option for OpenStack builder
2018-09-20 10:44:28 +09:00
Megan Marsh
b0774d155a
Merge pull request #6512 from sharmaanshul2102/5786-use-describe-regions-for-validation-aws
...
Use DescribeRegions for aws region validation
2018-09-19 10:37:42 -07:00
Megan Marsh
79093da6ad
skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock
2018-09-19 10:30:08 -07:00
Adrien Delorme
9ba959598b
Merge pull request #6729 from hashicorp/fix_ssh_digitalocean
...
builder/digitalocean: pass config as a pointer so that ssh configuration is correctly set
2018-09-19 18:26:36 +02:00
zhuzhih2017
9e3e2e83ae
Merge pull request #6720 from chhaj5236/fix/attach_keypair
...
fix attaching keypair error due to missing keypair name
2018-09-19 14:14:55 +08:00
Megan Marsh
93f1155a14
remove test-related special casing
2018-09-18 08:08:36 -07:00
bozhi.ch
3c312eb2a0
change b.config to pointer
2018-09-18 21:40:57 +08:00
Adrien Delorme
5389ab1694
pass config as a pointer so that ssh configuration is correctly set
2018-09-18 11:36:21 +02:00
Anshul Sharma
ef3c10c403
Modify Validate Region for test cases
2018-09-17 14:45:55 -07:00
Anshul Sharma
98f13eaf29
Use DescribeRegions for aws region validation
2018-09-17 14:45:55 -07:00
Megan Marsh
f4e6d06e68
reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides
2018-09-17 11:10:50 -07:00
chhaj5236
43e091de15
Merge branch 'master' into feature/support_tags
2018-09-17 16:50:44 +08:00
zhuzhih2017
31bbe2983b
Merge pull request #6688 from chhaj5236/feature/support_ssh_private_ip
...
support ssh with private ip address
2018-09-17 16:46:38 +08:00
bozhi.ch
b3aae89a53
fix attaching keypair error due to missing keypair name
2018-09-16 18:19:00 +08:00
bozhi.ch
b8a3e3b8f4
support adding tags to image
2018-09-16 18:16:13 +08:00
Adrien Delorme
fc75449e06
Merge pull request #6713 from hashicorp/cleanup_keys
...
new option allowing user to clean up the ephemeral ssh key from the a…
2018-09-14 11:12:33 -07:00
Megan Marsh
38cc525ec7
new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
2018-09-14 11:06:38 -07:00
Daisuke Takahashi
02139dcb69
Fix bugs
2018-09-13 14:39:38 +09:00
Adrien Delorme
770f61e682
spot instance creation, only set blockDurationMinutes when > 0
2018-09-12 10:21:39 -07:00
Adrien Delorme
2e73ed8d46
pass Comm instance to fix Spot instance creation
2018-09-11 18:20:14 -07:00
Matt DeBoer
09797df958
use a UI wrapper to auto-decode error messages
...
update docs to reflect optional config
2018-09-11 16:05:43 -07:00
bozhi.ch
743be8a808
support ssh with private ip address
2018-09-11 16:56:57 +08:00
Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
.
2018-09-10 16:48:42 -07:00
Adrien Delorme
e02d0dacc4
Merge branch 'master' into aws-filters
2018-09-07 16:14:00 +02:00
Sargun Dhillon
63d784023f
Add support to support non-gp2 volume types for building from_scratch
2018-09-06 13:22:09 -07:00
Sargun Dhillon
07ce820c70
Enable setting the volume type when building with the Amazon Chroot builder
2018-09-06 13:22:09 -07:00
Megan Marsh
b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
...
Allow users to build hvm images from pv images to have ena_support
2018-09-06 12:50:46 -07:00
Adrien Delorme
4682b3a9d2
refactor possible random strings into common/random
2018-09-05 10:26:52 +02:00
Adrien Delorme
b80e1d51c6
aws: when building an AMI with 'encrypt_boot: true', randomize the name of the temporary AMI
2018-09-05 10:24:28 +02:00
Adrien Delorme
170b2f3383
builder/azure/common.RandomString-> common/random.String
...
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
Sargun Dhillon
902497d6ce
Allow users to build hvm images from pv images to have ena_support
2018-09-04 18:16:52 -07:00
Megan Marsh
cb35829f80
Merge pull request #6411 from jmartin-r7/esxi_compact
...
add support for disk compaction to esx5 builder
2018-09-04 12:44:32 -07:00
Christopher Boumenot
2e294da82a
Merge pull request #6644 from riezebosch/master
...
[azure-arm] retry cleanup individual resources on error
2018-09-04 11:40:27 -07:00
Megan Marsh
349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
...
Increase retries
2018-09-04 11:39:28 -07:00
Adrien Delorme
819bda50d5
Merge pull request #6648 from hashicorp/fix_6642
...
Update public google cloud image projects
2018-09-03 09:29:31 +02:00
Adrien Delorme
2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
...
Fix 6569
2018-09-03 08:44:07 +02:00
RenaudS
26aab49aaf
aws spot instances: add block_duration_minutes option ( #6638 )
...
* Add block_duration_minutes option
* int64 cannot be nil
* Update doc
* Fix formating
2018-09-03 08:33:58 +02:00
Megan Marsh
4472ecccb0
fix waiters that weren't applying env defaults
2018-08-31 13:30:41 -07:00
Megan Marsh
d00b815c06
Update public google cloud image projects
2018-08-31 13:13:19 -07:00
Manuel Riezebosch
fcfa54fb1d
[azure-arm] retry cleanup individual resources on error
2018-08-31 13:43:38 +02:00
Adrien Delorme
61480f41dc
fix some go vet issues in tests ( composite literal uses unkeyed fields )
2018-08-31 11:54:12 +02:00
Jeffrey Martin
1833b4edaf
validate compaction is skipped when not 'thin'
2018-08-30 16:44:00 -05:00
Jeffrey Martin
b51cd22b21
document ESXi disk compaction & use verbose option
2018-08-30 16:44:00 -05:00
Jeffrey Martin
09c71f3810
add support for disk compaction to esx5 builder
2018-08-30 16:43:53 -05:00
Megan Marsh
9926988ab7
Merge pull request #6621 from hashicorp/ssh_keys_centralised
...
Merge ssh fields usage
2018-08-30 14:13:21 -07:00
Megan Marsh
d606339edc
Merge pull request #6635 from hashicorp/fix_6493
...
fix chroot communicator to properly escape quotes
2018-08-30 09:40:03 -07:00
Megan Marsh
2b9f937c23
increase max retries from 3 to 20
2018-08-30 09:35:06 -07:00
Adrien Delorme
cbbfc6630d
scaleway: stop using config from statebag
2018-08-30 17:58:09 +02:00
Adrien Delorme
d159c0900b
openstack: use config only where needed
2018-08-30 17:52:11 +02:00
Adrien Delorme
df9e756865
pass the Comm instance to the amazon ebs builders steps
2018-08-30 12:50:29 +02:00
Adrien Delorme
157691c710
remove unecessary get/pug config in tests; those are being referenced
2018-08-30 12:07:37 +02:00
Adrien Delorme
94d5bb7a3b
revert test changes of builder/googlecompute/step_create_ssh_key_test.go
2018-08-30 12:04:21 +02:00
Harvey Lowndes
344e7e8b92
Validation for tag configuration
2018-08-29 15:31:05 -07:00
Harvey Lowndes
cc7d4e4a95
Add support for freeform tagging of images
2018-08-29 15:31:05 -07:00
Adrien Delorme
050a98e8bb
googlecompute builder: use config from statebag
2018-08-29 18:15:09 +02:00
Adrien Delorme
b0c09087a2
move SSHInterface/SSHIPVersion fields to communitator.Config struct
2018-08-29 14:51:28 +02:00
Adrien Delorme
cd851f8ac2
use public ssh key & key name from config instead of the statebag
2018-08-29 14:40:33 +02:00
Adrien Delorme
0938b640cc
use key pair name from config
2018-08-29 14:40:33 +02:00
Adrien Delorme
1e71712cc9
builder.alicloud: stop using config from statebag
2018-08-29 14:40:33 +02:00
Adrien Delorme
4fdf5714a6
builder.scaleway: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
0f9eddda3a
builder.oracle: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
92570a2725
builder.openstack: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
4982627dd2
builder.gcp: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
e0e6b0b8f7
builder.cloudstack: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
ef4ca9c48e
builder.amazon: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
dffcbb7a35
builder.alicloud: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
9a9b82715b
config.Comm.SSHKeyPair => SSHKeyPairName
2018-08-29 14:40:33 +02:00
Adrien Delorme
3a4bb26150
builder.aws: use key pair from comm struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
293c485372
builder.aws: use SSHAgentAuth from Comm
2018-08-29 14:40:33 +02:00
Adrien Delorme
ef08c441c9
builder.aws: use Comm field for StepKeyPair & StepGetPassword
2018-08-29 14:40:33 +02:00
Adrien Delorme
7c358eed2f
removed unused builder/azure/common/lin.StepGeneralizeOS struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
3d46fbd4f2
removed unused builder/azure/common/lin.StepCreateCert struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
25de7ad1f2
PrivateKey => PrivateKeyFile
2018-08-29 14:40:33 +02:00
Adrien Delorme
324c46279b
up test
2018-08-29 14:40:33 +02:00
Adrien Delorme
5369c15459
helper: communicator.SSHFileSigner => ssh.FileSigner
...
* had to to avoid circular dependency
* this commit fixes #6631 ( esxi cannot be reached by ssh )
2018-08-29 14:40:33 +02:00
Adrien Delorme
b83c72fd54
more private keys in config
2018-08-29 14:40:32 +02:00
Adrien Delorme
336cac29d4
also use config.SSHPrivateKey for azure-arm builds
2018-08-29 14:40:32 +02:00
Adrien Delorme
d49ad12895
update gcp ssh tests
2018-08-29 14:40:32 +02:00
Adrien Delorme
663c8134ef
GCP: put ssh public/private key in config
2018-08-29 14:40:32 +02:00
Adrien Delorme
51d2aac9f6
SSHPrivateKey => SSHPrivateKeyFile
2018-08-29 14:40:32 +02:00
Megan Marsh
e4f6b6f720
fix chroot communicator to properly escape quotes
2018-08-28 09:16:43 -07:00
Matthew Hooker
7519037562
Merge pull request #6629 from hashicorp/travisbuild
...
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
Matthew Hooker
3f1a9766f4
formatting verb fixes for go 1.11
2018-08-24 16:18:21 -07:00
Matthew Hooker
e41e99954d
go 1.11 format rules
2018-08-24 15:56:44 -07:00
Megan Marsh
c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
...
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
Megan Marsh
bf191d1ef6
Merge pull request #6204 from arizvisa/GH-6197
...
Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.
2018-08-24 15:46:31 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Rickard von Essen
23f62f221e
Only filter SG's on VPC if it's set. Only use VPC's and Subnets that are available
2018-08-24 20:24:48 +02:00
Megan Marsh
fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
...
Increase waiter timeout for AWS WaitUntilImageAvailable command
2018-08-24 09:35:58 -07:00
Adrien Delorme
6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls ( #6622 )
...
* Remove duplicate unused SSHConfig funcs
* call to SSHConfigFunc() for azure/arm builder
* ncloud too
* remove empty ncloud file
2018-08-24 16:00:40 +02:00
Rickard von Essen
533967cb66
builder/amazon: Add suppport for security_group_filter
...
Allow selecting SG's using a filter. Also some cleanup of vpc_filter and
subnet_filter.
2018-08-24 12:42:38 +02:00
Megan Marsh
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
Megan Marsh
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
...
Filter logs
2018-08-23 13:30:21 -07:00
Megan Marsh
7f518cc2d0
Merge pull request #6616 from hashicorp/fix_6496
...
added new template variables to replace PACKER_KEY_INTERVAL with tuna…
2018-08-23 13:21:31 -07:00
Megan Marsh
31d4f8af45
use a time.Duration instead of a hardcoded ms
2018-08-23 13:16:01 -07:00
Rickard von Essen
9840862757
builder/amazon: Add suppport for vpc_filter and subnet_filter
...
First step of adding support for discovering VPC's and Subnets using
filters.
2018-08-23 12:52:03 +02:00
Rickard von Essen
70cfafb75c
Merge pull request #6490 from tcarrio/most-recent-image-openstack
...
OpenStack source image search filter
2018-08-23 12:41:06 +02:00
Tom Carrio
e2fe5cd775
Updated test cases to cover bad filters and empty()
2018-08-22 18:23:12 -04:00
Megan Marsh
bb319fb1e8
Merge pull request #6607 from hashicorp/gcp_min_cpu_platform
...
GCP: min cpu platform
2018-08-22 12:58:34 -07:00
Megan Marsh
918db58604
added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
2018-08-22 11:37:56 -07:00
Adrien Delorme
e5ffa9e5b3
use SSHConfigFunc on right member in builder/parallels/pvm/builder.go
2018-08-22 18:23:23 +02:00
Adrien Delorme
fa44a4546f
use ssh.ParsePrivateKey where we can
2018-08-22 18:23:09 +02:00
Adrien Delorme
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
Rickard von Essen
057a635cab
Merge pull request #6532 from sermilrod/Allowing-fixed-port-in-forwarding-rules
...
Cloudstack builder: adding public_ssh_port flag to use a fixed port in the forwarding rules
2018-08-22 14:27:38 +02:00
Rickard von Essen
3b49caaf40
OpenStack: refactored how source_image_filter is handled to remove reflection
2018-08-22 13:37:43 +02:00
Sergio Millan Rodriguez
befdb59da6
renaming public_ssh_port to public_port
2018-08-22 10:17:46 +01:00
Rickard von Essen
bd1961b927
Correctly fail if no Image matches filter
2018-08-21 12:46:42 +02:00
Adrien Delorme
b038cd10f5
GCP: Allow to set MinCpuPlatform
2018-08-21 10:09:30 +02:00
Adrien Delorme
e37f126cf1
update gcp google.golang.org/api/compute/v1/
2018-08-21 10:09:01 +02:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Matthew Hooker
31fcfe4bc2
PoC for filtering logs
2018-08-20 15:20:21 -07:00
Adrien Delorme
6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them"
2018-08-20 10:48:06 +02:00
Tom Carrio
c5fe1e9e34
Updated to @rickard-von-essen's code review suggestions, including:
...
- filter build and error checking in Prepare stage (multiErr created in the original function will be returned to Prepare and appended, so all errors show).
- source_image overrides source_image_filter.
- Doc edit
2018-08-19 18:47:07 -04:00
Tom Carrio
5ca5c037eb
Updated filter parser to log all invalid values/fields provided by user
2018-08-19 18:45:22 -04:00
Tom Carrio
fc19cd8d28
Updated limit logic, removed limiter, updated test cases and sort field used
2018-08-19 18:45:22 -04:00
Tom Carrio
4147062802
Internally handling most_recent logic.
2018-08-19 18:45:22 -04:00
Tom Carrio
2d5d1890d4
Switching sort method
2018-08-19 18:45:22 -04:00