Adrien Delorme
c744e8b2bb
make download messages less redudant and more simple
2018-08-17 09:29:39 +02:00
Adrien Delorme
d7d4aed51c
be even more precise
2018-08-16 18:56:28 +02:00
Adrien Delorme
2b3ea29970
show more precise error download/copy/referencing messages
2018-08-16 18:41:44 +02:00
Adrien Delorme
fae3db4e58
test inplace linking
2018-08-15 17:09:39 +02:00
Adrien Delorme
17f2949e36
remove stuttering; ISOConfig.InplaceISO -> Inplace
2018-08-15 15:51:25 +02:00
Adrien Delorme
863222b1e2
Also use the terminology Inplace in DownloadConfig for clarity/consistency
...
* swapped boolean checks
* swapped in tests too
2018-08-15 15:26:31 +02:00
Adrien Delorme
82e480a285
allow to use ISO images inplace v.s. copying them
2018-08-15 14:37:38 +02:00
Ali Rizvi-Santiago
71e43d0b7f
Updated common/download.go to handle when a connection error happens (response is nil), and reformatted the error that's returned when an HTTP error occurs.
2018-07-28 19:09:29 -05:00
Megan Marsh
5ef8b55559
need log import
2018-07-23 10:34:05 -07:00
Megan Marsh
a2f5fbadf6
don't fail if you can't find abs or relative path.
2018-07-23 09:54:25 -07:00
DanHam
da21c25791
Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts
...
grep -rli --exclude-dir={vendor,bin\*,\*vmware\*,\*pkg\*} vmxc . | \
xargs sed -i 's/\(vm\)\(x\)\(c\)/\1\3\2/ig'
2018-07-20 02:12:47 +01:00
DanHam
674bad0ab4
Break very long lines for readability
2018-07-20 02:12:47 +01:00
DanHam
d2390f464d
Actually implement the function for the driver
2018-07-20 02:12:45 +01:00
DanHam
c2437ba592
Remove the option to place the VHD files in a separate directory
...
The export process now exports the VM directly from the build directory
into the output directory. There are no intermediate steps or copying of
files involved. This means that there is no longer any benefit in having
a separate directory to house the VHD files - see #5206 for the
reasoning behind the introduction of this feature.
If a user wishes to house the build files on a separate disk from the
output directory (perhaps for performance reasons or due to disk space
limitations) they can still do so through the use of `temp_path`.
2018-07-20 02:12:43 +01:00
DanHam
c6b9d9ce90
Add checks/error reporting to compaction process
...
* Report compaction results
* Failure to find any disks under the supplied path is treated as a
'soft' error and a warning message will be printed in place of the
compaction result. Any other failure will cause the build to fail.
2018-07-20 02:12:42 +01:00
DanHam
534fc4a473
Ensure the export directory structure matches that of previous versions
...
Commit 3fc2defb6
altered the directory structure associated with an
exported VM. The changes mean that the export process now stores the
exported machine files and folders under a folder with name 'vm_name' in
the output directory.
This commit restores the previous behaviour whereby the exported machine
files and folders were stored directly in the output directory. This
allows us to keep the efficiency improvements introduced with 3fc2defb6
while maintaining backward compatibility.
By default the Export-VM command creates three folders in the specified
export directory - 'Virtual Hard Disks', 'Virtual Machines' and
'Snapshots'. When a machine with no associated snapshots is exported the
'Snapshots' directory is empty.
Prior to 3fc2defb6
the Snapshots folder was not copied/incorporated into
the output directory at all. This was a bug.
This commit preserves the legacy behaviour by not including an empty
Snapshots directory in the export. However, if there *are* Snapshots
associated with the VM, they are now moved into the output directory
along with the usual directories containing disks and VM metadata. This
prevents warnings/errors on import due to missing snapshots.
2018-07-20 02:09:57 +01:00
DanHam
dc46848f89
Remove now redundant function to copy exported VM files
2018-07-20 02:09:57 +01:00
DanHam
3fc2defb6d
Refactor the export step for Hyper-V ISO and VMCX builders
...
* Fixes a bug that caused the build to error if users did not
explicitly set `skip_compaction:true` when setting `skip_export:
true`. See #6392 .
* Improves the efficiency of the compaction and export process by
reordering the compaction and export steps.
* Further improves the efficiency of the compacting step through
compacting the vmd* file directly rather than creating and then
operating on a copy.
* The changes mean the export process now stores the exported machine
files and folders under a folder with name 'vm_name' in the output
directory. Previously the exported machine files and folders were
stored directly in the output directory.
2018-07-20 02:09:54 +01:00
Mathieu Tarral
edcc0b3853
shell-local: expose PACKER_HTTP_ADDR env var
2018-07-17 18:49:36 +03:00
Megan Marsh
0df33cd032
fix relative pathing versus iso checksum dir to work even if user has provided a relative path for the iso_url which is relative to the directory where Packer is run.
2018-07-13 09:21:04 -07:00
Megan Marsh
d0f0da6626
allow absolute paths to isos in checksum files
2018-07-13 09:14:59 -07:00
M. Marsh
e5a63a674e
Merge pull request #6422 from DanHam/fix-gh-vmsecureboot
...
Hyper-V: Use Get-Command over Get-Help to check for SecureBootTemplate parameter
2018-06-25 16:48:16 -07:00
M. Marsh
baaca808e8
Merge pull request #6412 from hashicorp/fix_config_validation_bug_windows_shell_local
...
found a config validation bug where packer crashes instead of throwin…
2018-06-25 16:47:23 -07:00
DanHam
297f6b85ec
Use Get-Command over Get-Help to check for SecureBootTemplate parameter
2018-06-25 23:52:01 +01:00
Simon Hulme
475e79a251
Fixed SecureBootTemplate not being passed through to PS cmdlet
...
Added check for SecureBootTemplate parameter for Server 2012 and below
Corrected enableSecureBootString usage
2018-06-25 14:13:43 +01:00
Megan Marsh
4a7953f93a
found a config validation bug where packer crashes instead of throwing a validation error if a windows-style path is provided to a provisioner on linux
2018-06-22 13:49:39 -07:00
Jordan Borean
efa9021974
Check if hyper-v addresses is an array before slicing it
2018-06-18 14:45:33 +10:00
Giovanni Tirloni
28095cf027
Do not return error on initial HEAD request
2018-06-13 20:30:19 -03:00
Giovanni Tirloni
b7ea0b44fc
HTTPDownloader - Fix invalid error handling
2018-06-13 17:42:27 -03:00
M. Marsh
a012f70e71
Merge pull request #6251 from hashicorp/do_winrm_shell_local
...
access automatically generated winrm password from shell-local
2018-05-29 12:09:40 -07:00
Megan Marsh
3afca6905b
remove duplicate assignmnet
2018-05-29 11:47:27 -07:00
Matthew Hooker
6a769f08d8
regenerate boot command code
2018-05-29 11:17:51 -07:00
Matthew Hooker
788418cff2
Add unit test to show that we handle tars safely
2018-05-25 12:13:59 -07:00
Megan Marsh
846f94c964
implement template variable for accessing WinRM password in either environemnt variables or directly in execute_command or inline commands.
2018-05-23 16:00:43 -07:00
M. Marsh
62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
...
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
Megan Marsh
d1e31c0f23
use if/else to clarify code
2018-05-21 15:19:27 -07:00
Megan Marsh
969201a2d4
handle minor shell-local PR suggestions and corrections
2018-05-21 14:56:44 -07:00
Megan Marsh
1fdf763d0f
fancier logging
2018-05-21 11:25:51 -07:00
M. Marsh
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
...
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
WaaZaa666
b747877222
Fixing #6267 , multiple hyper-v disks
2018-05-17 14:50:18 +02:00
Unknown
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
Unknown
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
M. Marsh
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
...
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
Stefan Henseler
6f00596053
Adds config option to specify hyper-v secure boot template
2018-05-10 19:00:35 +02:00
DanHam
d9d8b93c14
Remove tmp file created by common/ test. Avoid possible race condition.
2018-05-09 22:09:05 +01:00
M. Marsh
7c46e3d89c
Merge pull request #6207 from gtirloni/issue-6203
...
[WIP] Handle HTTP download errors
2018-05-08 15:56:06 -07:00
Matthew Hooker
5e6e12cacd
Use fmt to convert whatever's in error to a string.
...
This way we don't crash if someone sticks something else in the error
key in the state bag (which a quick glance at the code tells me we're
already doing.
Perhaps in the future we can add an error attribute to the state bag
but for now this will have to suffice.
2018-05-08 15:22:02 -07:00
Matthew Hooker
0a1842140b
Display build error when on-error=ask|abort
2018-05-08 04:06:03 -07:00
Megan Marsh
1bea658e16
fix command and inline calls on windows
2018-05-07 15:10:10 -07:00
Megan Marsh
fabd1a6517
windows cmd env vars
2018-05-07 15:10:10 -07:00
Megan Marsh
9651432378
preserver BC for people using 'command' option
2018-05-07 15:10:10 -07:00
Megan Marsh
dd183f22d9
update docs and add warnings around WSL limitations
2018-05-07 15:10:10 -07:00
Megan Marsh
51bcc7aa13
add new feature for telling shell-local whether to use linux pathing on windows; update docs with some examples.
2018-05-07 15:10:10 -07:00
Megan Marsh
e983a94a88
fix default windows bash call for shell-local provisioner and move chmod command from the execute_command array into the portion of code where we actually generate inline scripts, sparing users the need to think about this modification which Packer should really handle on its own
...
make bash call work on windows
2018-05-07 15:10:10 -07:00
Megan Marsh
5da4377f21
first pass at docs update
2018-05-07 15:10:10 -07:00
Megan Marsh
854d6fb141
add tests making sure post-processor has backwards compatability
2018-05-07 15:10:10 -07:00
Megan Marsh
f799003b66
tighten up shell-local config validation
2018-05-07 15:10:10 -07:00
Megan Marsh
479d36734d
consolidate shell-local defaulting of InlineShebang and ExecuteCommand to the config validation
2018-05-07 15:10:10 -07:00
Megan Marsh
d304234725
fix tests
2018-05-07 15:10:10 -07:00
Megan Marsh
67739270bb
pull temp file writing into its own function for easier testing
2018-05-07 15:10:10 -07:00
Megan Marsh
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
Megan Marsh
c7c66bedcb
set inline to an empty array, rather than nil
2018-05-07 15:10:09 -07:00
Megan Marsh
926327beba
deduplicate all validation and interpolation of the shell-local config, sharing options between shell-local provisioner and post-processor. Maintain backwards compatibility with shell-local provisioner.
2018-05-07 15:10:09 -07:00
Megan Marsh
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
M. Marsh
bf6dc932d5
Merge pull request #6219 from jborean93/hyper-v-ip
...
Hyper-V: Add support retrieving IP for Server 2008 R2
2018-05-04 12:56:17 -07:00
DanHam
7e478f650e
Remove tmp files created by common/ tests
2018-04-30 18:16:46 +01:00
Jordan Borean
14e41fad7e
Hyper-V: Add support retrieving IP for Server 2008
2018-04-30 15:18:28 +10:00
Giovanni Tirloni
413d13c411
Handle HTTP download errors
2018-04-26 18:59:30 -03:00
Adam Robinson
3aebd5f462
Add use_fixed_vhd_format Hyper-V ISO option
2018-04-26 13:35:19 -04:00
Matthew Hooker
a3bf2c786a
Use expression sequence generator in tests.
2018-04-23 16:32:18 -07:00
M. Marsh
69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
...
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
Matthew Hooker
e4bd30e53d
fix bug with empty boot command.
2018-04-21 11:40:47 -07:00
Matthew Hooker
b5a97e468f
fix test
2018-04-19 17:07:58 -07:00
Matthew Hooker
7e9af8247a
fix 2 byte scancodes for pc-xt VMs.
2018-04-19 17:02:39 -07:00
Matthew Hooker
675eae1e92
flush scancodes when we wait
2018-04-19 16:44:50 -07:00
Matthew Hooker
374d8f089f
better log message
2018-04-19 16:09:38 -07:00
Matthew Hooker
31d04f1945
remove outdated comment
2018-04-19 14:26:31 -07:00
Matthew Hooker
df6224d04e
fix vnc config
2018-04-19 14:26:31 -07:00
Matthew Hooker
aa69bdf74e
Perform validation of boot command.
2018-04-19 14:26:31 -07:00
Matthew Hooker
7d43324359
add menu key.
...
Replaces #5989
2018-04-19 14:26:31 -07:00
Matthew Hooker
e9e27941cc
sort keycode lists
2018-04-19 14:26:31 -07:00
Matthew Hooker
c6299972b9
s/boot_command/bootcommand/
2018-04-19 14:26:31 -07:00
Matthew Hooker
7990966a09
fix boot command config struct name
2018-04-19 14:26:31 -07:00
Matthew Hooker
408eba88ad
flatten boot command config and implement for vmware
2018-04-19 14:26:30 -07:00
Matthew Hooker
9a8acbbcab
negative wait WIP
2018-04-19 14:26:30 -07:00
Matthew Hooker
add7e8acb9
Stop sending boot commands when context canceled.
2018-04-19 14:26:30 -07:00
Matthew Hooker
94129b7fe3
we're using PC-XT (set1) not PC-AT
2018-04-19 14:26:30 -07:00
Matthew Hooker
a46a7afa20
Remove old tests.
2018-04-19 14:26:29 -07:00
Matthew Hooker
e2e7bc65fd
Make special keys case insensitive.
...
add tests
2018-04-19 14:26:29 -07:00
Matthew Hooker
cba4d3235f
cleanup
2018-04-19 14:26:29 -07:00
Matthew Hooker
bdb1eee7d8
Implement new parser for HyperV boot command
2018-04-19 14:26:29 -07:00
Matthew Hooker
f9ad264f4d
Comments
2018-04-19 14:26:29 -07:00
Matthew Hooker
81d127768c
Add key press interval to virtualbox.
2018-04-19 14:26:29 -07:00
Matthew Hooker
59376294ef
Maximize scancode throughput.
...
Let's cache the scancodes and flush them at the end. Also make sure to
send only as many as the driver can send correctly. It's important here
to chunk the scancodes correctly, so that we don't accidentally split them
over successive calls to the driver
2018-04-19 14:26:29 -07:00
Matthew Hooker
9b7704c714
Implement new parser for Parallels boot command
2018-04-19 14:26:29 -07:00
Matthew Hooker
99d61920d0
Abstract vbox driver into PC-AT driver.
2018-04-19 14:26:29 -07:00
Matthew Hooker
e4af71858f
Implement new parser for Virtualbox boot command
...
Remove boot wait for virtualbox run step
2018-04-19 14:26:29 -07:00
Matthew Hooker
1c0af28662
Some cleanup and comments.
2018-04-19 14:26:29 -07:00
Matthew Hooker
673245afcf
Replace boot command parser with PEG parser.
2018-04-19 14:26:28 -07:00
M. Marsh
f5c031baf9
Merge pull request #5941 from synax/hyper-v-disk-block-size
...
Adds Support to configure hyper-v disk block size
2018-04-19 11:27:52 -07:00