a42f8fac4d
Elevated support for puppet-masterless provisioner
...
This should fix #5478 .
2018-12-07 11:08:11 +00:00
2283efff79
Merge pull request #7071 from aspectcapital/ignore-pending-reboots
...
Ignore an already-scheduled reboot
2018-12-07 11:03:55 +01:00
0192289d68
Drop exit code 1717
2018-12-07 09:45:50 +00:00
11be4ffc4b
Attempt at generalising elevated support
...
Refactor puppet-server provisioner to use it.
2018-12-06 18:00:22 +00:00
e69391f28b
save users some bash scripting by exposing IP and port separately as well as together
2018-12-06 09:29:07 -08:00
a7b407eab6
Naive support for elevated support for puppet-server provisioner
...
This commit just lifts the various bits out of the powershell
provisioner.
2018-12-06 15:09:57 +00:00
5fed453047
Ignore an already-scheduled reboot
...
If the previous provisioner already scheduled a reboot don't error we
can't schedule another one.
2018-12-05 15:43:22 +00:00
fa6eb3fdea
reverts 406bf9c4aad7c925c3f5a837fe7f9c71169af098; this was incorrect interpretation of the intent of the inventoryDirectory template option
2018-12-03 16:08:47 -08:00
8a7ec456f1
use error groups so we can return errors
2018-11-30 10:46:40 -08:00
e6477d13fb
fix empty return
2018-11-29 15:22:26 -08:00
a93721c54d
add disable option to breakpoint provisioner
2018-11-29 15:09:14 -08:00
ba25e68fe0
add a new breakpoint provisioner
2018-11-29 14:32:52 -08:00
412119c27e
Fix powershell provisioner tests
2018-11-09 14:26:21 +00:00
3b519acebc
Allow Powershell provisioner to use service accounts
...
Fixes #6104
2018-11-08 11:48:27 +00:00
56fd98552e
removed space
2018-10-24 15:49:49 +02:00
31afd1c2f8
Add PauseAfter option to shell provisioner
...
Closes #6540
2018-10-24 14:04:08 +02:00
7c63c322c7
make provisioner/ansible/provisioner_test.go invisible to windows
2018-10-16 18:40:07 +02:00
1d1729a5ff
fix powershell tests to use new command
2018-10-12 09:54:27 -07:00
a81d18cdab
explicitly use set-variable to work around a bug some users saw where the command invocation would vail
2018-10-12 09:15:12 -07:00
72391f8f4d
Update provisioner.go
...
Remove extra break statement that made it's way into the "reboot pending" loop when some logic was rearranged in 9fa47f5dad (diff-8bb0a16231863cd1487dd9a3d3792565)
2018-10-03 00:54:31 -05:00
7597f609b1
update winrmcp vendor and update error message in file provisioner to aid user who messes up file path name. update file provisioner docs
2018-09-21 14:51:32 -07:00
3f8407d95f
Revert "Merge pull request #6700 from hashicorp/multi_progressbar"
...
This reverts commit 5470c08345c427486bca
2018-09-20 13:14:17 -07:00
dfeca9f0df
split progressbars per object
2018-09-12 16:21:58 -07:00
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
2018-09-10 16:48:42 -07:00
bb59a70e8f
progressbar: use int64 instead of uint64
...
* it's what's used for file sizes and used lib
2018-09-06 16:49:15 +02:00
5b66069da0
tests: remove Ui stubs to use packer.NoopUi to deduplicate code
2018-09-06 15:53:59 +02:00
7efe3cac3d
todos
2018-09-06 15:53:59 +02:00
9b07d7670e
use no ops for ansible ui & MachineReadableUi
2018-09-06 15:53:59 +02:00
fd7cb47adc
use proxy reader for download progress & stop storing total/current in downloaders
2018-09-06 15:53:59 +02:00
ddd96c513b
first draft at self refreshing loading bar centralized/controlled by Ui
2018-09-06 15:53:59 +02:00
61480f41dc
fix some go vet issues in tests ( composite literal uses unkeyed fields )
2018-08-31 11:54:12 +02:00
266a48a73a
minor fixes for shell provisioner docs and logging
2018-08-30 14:36:14 -07:00
ab13c73277
make varfile name unique and make sure to remove it from guest system if cleanup is true.
2018-08-30 11:02:56 -07:00
2c9a205f11
update shell provisioner tests
2018-08-29 11:10:49 -07:00
cce13e3877
shell provisioner: add option to source env vars from a file
2018-08-29 11:10:49 -07:00
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
c51cd751d1
go back to using StartWithUI to prevent weird hangs during windows reboot
2018-08-23 16:15:50 -07:00
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
...
Filter logs
2018-08-23 13:30:21 -07:00
c1b50d365b
Merge pull request #5851 from arizvisa/multi-proto-progressbar
...
Add progress-bar to common/step_download.go
2018-08-21 15:08:22 -07:00
9fa47f5dad
make windows restart provisioner work with ssh communicator
2018-08-21 11:45:18 -07:00
cf9bbe3ecf
Incorporated the hack demonstrated by @SwampDragons in order to deal with packer.rpc.Ui not exporting any information about what it's doing to anybody.
2018-08-20 21:55:18 -05:00
5726927cba
Moved the progress bar out of packer.Ui and unlinked it out of all the packer.Ui implementations. Split up the terminal-related functions into a separate terminal.go and calculate the progress bar width by traversing through packer.Ui to avoid the issue with github.com/ugorji/go/codec serializing private members (or unsafe pointers) of structs. Shuffled some arguments around in getConsoleScreenBufferInfo in common/terminal_windows.go so that the interface forces the user to correctly declare a _CONSOLE_SCREEN_BUFFER_INFO type.
2018-08-20 21:55:18 -05:00
0f10032b3d
Moved the progress bar from common to the packer.UI interface and refactored it so that the terminal width is calculated based on each interface which returns a custom progressbar specific to its ui.
2018-08-20 21:55:18 -05:00
fd2fef8738
Added support for the progress bar to automatically determine its width using the minimum length from a packer.UI and the terminal dimensions via kernel32.GetConsoleScreenBufferInfo or an ioctl (TIOCGWINSZ) to "/dev/tty".
2018-08-20 21:55:18 -05:00
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
eb685b7140
remove duplicate code from chef provisioner
2018-08-07 10:01:06 -07:00
a5a6b1ab58
Merge pull request #6501 from Wenzel/expose_ansible_packer_http_addr
...
Expose ansible packer_http_addr extra var
2018-07-18 17:18:46 -07:00
e146973d08
change implementation to set winrm password in way that matches powershell and shell-local implementations; sanitize logs
2018-07-17 16:39:50 -07:00
3450b6fd6f
ansible: expose packer_http_addr extra var
2018-07-17 19:58:07 +03:00
6646d42490
updated function calls to include buildname and changed variable names
2018-07-14 14:39:38 -04:00
68ec630fde
added function to retreive winrm password from commonhelper
2018-07-14 11:25:04 -04:00
636cec8f2b
added commonhelper import
2018-07-14 11:25:01 -04:00
37fd50995f
added parameter for setting packer password as env variable
2018-07-14 11:25:00 -04:00
485d565e32
Ensure comments are easily readable in a standard terminal
2018-06-15 00:49:15 +01:00
e0bcba4913
Make the upload of env vars retryable in case of restarts
2018-06-15 00:09:50 +01:00
e1a1bb522d
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-26 22:00:50 +02:00
263a3c6910
Include some of the refactoring reverted by previous revert commit.
2018-05-26 21:59:43 +02:00
46a1c5d945
Revert "Unify handling PlaybookFile and PlaybookFiles."
...
This reverts commit 81db142c8a
2018-05-26 21:58:08 +02:00
62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
...
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
6c7aa724eb
Fix tests after merging with master.
2018-05-16 22:43:30 +02:00
c33ca8ce64
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-16 22:14:12 +02:00
11f2b1ec24
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-16 21:54:39 +02:00
81db142c8a
Unify handling PlaybookFile and PlaybookFiles.
2018-05-16 21:54:19 +02:00
abb70bfa80
Merge pull request #6215 from tb3088/delay-extraArgs-4462_clean
...
Delay evaluation of ExtraArguments and standardize puppet-server and puppet-masterless
2018-05-08 15:03:55 -07:00
d22fb6d60b
reformat via gofmt
2018-05-08 12:44:15 -04:00
5c7d5fac75
expose OS-specific ModulePathJoiner
2018-05-08 12:21:04 -04:00
399edbe5e7
revert false economy WRT .ExtraArguments
2018-05-08 10:12:22 -04:00
b505cecd98
sync docs to code
2018-05-08 09:53:18 -04:00
51bcc7aa13
add new feature for telling shell-local whether to use linux pathing on windows; update docs with some examples.
2018-05-07 15:10:10 -07:00
e983a94a88
fix default windows bash call for shell-local provisioner and move chmod command from the execute_command array into the portion of code where we actually generate inline scripts, sparing users the need to think about this modification which Packer should really handle on its own
...
make bash call work on windows
2018-05-07 15:10:10 -07:00
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
926327beba
deduplicate all validation and interpolation of the shell-local config, sharing options between shell-local provisioner and post-processor. Maintain backwards compatibility with shell-local provisioner.
2018-05-07 15:10:09 -07:00
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
23e51d21c2
Merge pull request #4300 from don-code/master
...
Allow skipping Chef Client staging directory cleanup.
2018-05-07 14:25:57 -07:00
fbbcbd772b
remove file stat
2018-05-03 11:08:41 -07:00
735f5273a0
tab/space fixup via gofmt
2018-05-01 17:16:47 -04:00
b2d78339b0
add missing removeDir() to allow StagingDir clean-up post-run
2018-05-01 17:04:40 -04:00
514a597825
alphabetize datastructures
2018-05-01 16:38:01 -04:00
69ac7b56f6
Remove tmp files created by provisioner/windows-shell tests
2018-04-30 20:38:03 +01:00
b738f41efa
Remove tmp files created by provisioner/powershell tests
2018-04-30 20:38:03 +01:00
70ccb8adff
Remove tmp files created by provisioner/puppet-server tests
2018-04-30 20:38:03 +01:00
fd07cfd2b1
Remove tmp files created by provisioner/puppet-masterless tests
2018-04-30 20:38:03 +01:00
b4bec692ed
remove accidental duplicate, initialize WorkingDir for puppet-server
2018-04-28 01:13:23 -04:00
47d46b0c64
use filpath() to make tests portable across Windows and non-Windows
2018-04-28 00:17:27 -04:00
8bb7798ea7
standardize across both puppet-{masterless,server}
...
move comments outside of datastructure
remove duplicated section
fix line-endings
Golang doesn't use C-style comments
run gofmt for alignment and whitespace management
remove danling "options" and fix class reference
syncronize tests to new command structure
2018-04-27 23:47:05 -04:00
edb845b3f4
Allow skipping Chef Client staging directory cleanup ( fixes #3151 ).
2018-04-27 19:35:01 -04:00
5eb497a2c5
reorder terms and define an intermediate variable
...
(cherry picked from commit d0251f9741cf4d7659ecb4496d103f99a0e4184a)
(cherry picked from commit dab1b903ad88af0e3e40168634c1eb227078b4eb)
2018-04-27 18:04:36 -04:00
7cf31060eb
Remove script containing Win-Shell inline commands from local tmp when done
2018-04-26 00:32:52 +01:00
b9ab2c8048
Remove script containing PowerShell inline commands from local tmp when done
2018-04-26 00:32:52 +01:00
ccf687dac6
Fix tests
2018-04-24 11:10:35 +01:00
5419375413
Change to CMD % style path is no longer required
2018-04-24 11:10:35 +01:00
5b652316d9
Dollar's in env vars used in paths may cause problems for ssh
...
* Dollars are interpreted by *nix shells so paths using env vars such as
${env:SYSTEMROOT} will cause issues
2018-04-24 11:10:35 +01:00
4e7feea184
Allow users to specify the location that the env vars file is uploaded to
...
Previously the location the file was uploaded to was set internally and
used ${env:SYSTEMROOT}/Temp as the destination folder.
By default, in order to inject the required environment variables, the file
is 'dot sourced' by the 'execute_command' using the {{ .Vars }} variable.
Unfortunately the inclusion of the dollar in the path caused issues for
users connecting over ssh as the (typically bash) shell running the execute
command would try and interpret the dollar sign.
The change allows users to specify the location the file is uploaded to,
thereby allowing the user to specify a custom 'execute_command' that
escapes any dollar signs that could be present in the path.
If not set the upload path now defaults to using C:/Windows/Temp as the
upload folder.
2018-04-24 11:09:55 +01:00
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
56dd8cdb63
Merge pull request #3891 from nouney/f-generated-files
...
Add "generated" file tag to allow users to upload files created on the fly.
2018-04-05 16:08:38 -07:00
c0719a3590
Allow using a custom inventory file.
2018-04-05 12:56:07 +03:00
406bf9c4aa
override ansible executor inventory to use InventoryDirectory instead of InventoryFile when set
2018-03-26 17:24:58 +01:00
ef4817d644
Fix vertical spacing
2018-03-23 14:01:30 +00:00
34db6c4ab1
Remove temp debugging output
2018-03-23 12:45:49 +00:00
072cd6b745
Merge pull request #5998 from hashicorp/do_5895
...
allow users of AWS to use the dynamically-generated admin password wh…
2018-03-22 16:01:22 -07:00
4e321b2dfa
don't need to use a receiver with this function
2018-03-22 15:55:24 -07:00
732a532d0e
pass file info during shell file upload
2018-03-20 16:32:55 -07:00
ce1ab1f021
fix winrm password
2018-03-15 09:44:22 -07:00
559719020c
use {{.WinRMPassword}} instead of some other weirdness
2018-03-14 17:19:17 -07:00
d689e6b4d3
allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.
2018-03-14 15:58:12 -07:00
414dd80e61
Merge pull request #6013 from jsoref/spelling
...
Spelling
2018-03-14 09:50:27 -07:00
b33d6ce82e
fix salt provisioner on linux
2018-03-13 16:13:23 -07:00
e2f55a50b5
Merge pull request #5702 from brokenbot/salt-masterless-windows
...
Windows Support for salt-masterless provisioner #5432
2018-03-13 14:26:40 -07:00
24b4c36fc9
spelling: function
2018-03-13 07:52:02 +00:00
b545c6f87e
spelling: flattened
2018-03-13 07:50:25 +00:00
04d6bfc696
spelling: environment
2018-03-13 07:41:21 +00:00
684a3f5d8a
spelling: custom
2018-03-13 07:26:33 +00:00
f3a538db46
fix tests
2018-03-09 13:36:47 -08:00
3faf73b5f3
change backslashes to forward slashes in powershell provisioner; was breaking with cygwin
2018-03-09 09:29:29 -08:00
7d9a86becb
Revert "Fix #5335"
2018-02-12 11:03:19 -08:00
2d830d5d43
Auto escape chars special to PowerShell in user supplied data
2018-02-08 12:03:19 +00:00
aaf7102b9a
Tests for escape of chars special to PowerShell in user supplied data
2018-02-08 12:03:18 +00:00
a7b118ed94
Fix tests post changes. Add test for upload func.
2018-02-08 12:03:18 +00:00
478589abec
Extend upload and subsequent 'dot sourcing' of env vars to std PS command
...
* Wrap funcs to flatten and upload env vars with new func prepareEnvVars.
While the wrapped funcs could be combined, keeping them separate
simplifies testing.
* Configure/refactor std and elevated PS to use new funcs to prepare,
upload and dot source env vars.
* Dot sourcing the env vars in this way avoids the need to embed them
directly in the command string. This avoids the need to escape the env
vars to ensure the command string is correctly parsed.
* Characters within the env vars that are special to PS (such as $'s
and backticks) will still need to be escaped to allow them to be
correctly interpreted by PS.
* The std and elevated PS commands now inject env vars into the remote
env via the same mechanism. This ensures consistent behaviour across the
two command types.
Fixes #5471
2018-02-08 12:03:18 +00:00
d3c7d43f20
Small typo correction
2018-02-07 19:47:01 -08:00
5d67f77f43
Fixing 5852
2018-02-07 19:41:01 -08:00
974d9974fe
add workaround for azure bug.
2018-02-07 11:34:18 -08:00
addedbb680
Revert "Merge pull request #5515 from DanHam/dot-source-env-vars"
...
revert so we can use a branch that's had more recent work done
This reverts commit e56849c6056d14eb6ea4
2018-02-02 09:58:39 -08:00
79fe900378
Revert "Merge pull request #5376 from DanHam/ps-escapes"
...
Revert so that we can merge a different branch that's had more recent work instead
This reverts commit ba518637d4e56849c605
2018-02-02 09:57:36 -08:00
7443adf2fd
Simpler escape of chars special to PowerShell in user supplied data
2018-02-01 13:19:07 -08:00
68e13c90b1
Revert "Escape chars special to PowerShell in user supplied data"
...
This reverts commit 53aefe744bcd74ee6ac866f764eafe9e7f507d80.
2018-02-01 13:19:07 -08:00
b67c64fd66
Tests for escape of chars special to PowerShell in user supplied data
2018-02-01 13:19:07 -08:00
f3c326bb3c
Escape chars special to PowerShell in user supplied data
2018-02-01 13:11:05 -08:00
e56849c605
Merge pull request #5515 from DanHam/dot-source-env-vars
...
Extend upload and subsequent dot sourcing of env vars to non-elevated Powershell cmd
2018-02-01 13:06:01 -08:00
9f87213ba4
tests and docs for #5831
2018-01-31 13:08:25 -08:00
3127bfbcfb
Merge pull request #5831 from uShip/chef-client-policyfiles
...
Added Policyfile support to chef-client provisioner
2018-01-31 12:54:27 -08:00
aa76c47019
Merge pull request #5703 from frankdannhauer/5335
...
Fix #5335
2018-01-31 12:53:49 -08:00
5cedfc4557
Fixed go format errors
2018-01-31 11:06:31 -06:00
7354247933
Added policyGroup and policyName to Packer Communicator
2018-01-31 11:01:08 -06:00
fe90f79704
Changed new code to use tabs instead of spaces
2018-01-31 10:54:40 -06:00
1f92aa2c0a
Added Policyfile support to chef-client provisioner
2018-01-31 10:49:04 -06:00
4bccbbba1f
Merge pull request #5790 from GennadySpb/trusted_certs_dir
...
Support 'trusted_certs_dir' chef-client configuration option
2018-01-23 13:11:27 -08:00
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
53aaf84100
Support 'trusted_certs_dir' chef-client configuration option
2018-01-13 01:53:49 +03:00
b894c925d1
make user retrieval for Ansible provisioner more robust
...
Previously, the Ansible provisioner would look for the username from the
`USER` environment variable. Unfortunately, this is not always set -
particularly in Docker containers. It's very confusing to understand why
the error is happening.
Switched to using Go's built-in `os/user` package for retrieving the
current username. @rickard-von-essen had done this in 7369841d59844f795e712b72
2018-01-03 02:52:41 -05:00
6410fd615c
typo
2017-12-18 20:21:26 +00:00
893d0334f1
Fix #5335
...
https://github.com/hashicorp/packer/issues/5335
2017-12-14 14:00:52 +01:00
fc566a3cb4
Added test for new commands and guest os type
2017-12-13 11:16:21 -07:00
bf7a4b3363
remove erroraction on win removedir
2017-12-13 10:49:38 -07:00
284b069003
Fixed stating of files on windows
...
added directory existence check to salt provisioner before directory clean up
2017-12-13 10:20:27 -07:00
57770de36f
revert file stat
2017-12-12 16:01:00 -07:00
a1ba4e5362
Silently continue on removeDir for Windows
...
Fixed parameter type exclusion in movePath command
2017-12-12 15:32:40 -07:00
887b7dc476
Fix mixed case for mv
2017-12-12 15:24:34 -07:00
aee67d3933
Add ability to move files on remote system
...
Fix salt-masterless to use generic MovePath
2017-12-12 15:22:10 -07:00
857e5d04d3
Fix command error for salt install
2017-12-12 15:11:29 -07:00
Matt Dainty
Adrien Delorme
Megan Marsh
Mark Meyer
Adrien Delorme
Poddo
Ali Rizvi-Santiago
Mathieu Tarral
Levi
DanHam
localghost
Matthew Patton
Don Luchini
Matthew Patton
Omer Katz
Joshua C. Randall
Matthew Hooker
Josh Soref
Marc Mercer
Evan Machnic
Gennady Lipenkov
Aidan Feldman
Hunter Morgan
frankdannhauer
Dave Sanderson