e97c56dc72
Merge pull request #9559 from hashicorp/fix_9482
...
builder/azure-arm: Remove duplicate resource deletion steps
2020-08-12 12:43:09 -07:00
55812fe8a5
Handle error of deferred deletion
2020-08-12 11:30:15 -04:00
5700f74c8c
Handle lease not present error
2020-08-12 11:27:07 -04:00
d91839b93e
Update deletion logic for OS disks
...
* Add an ResourceNotFound error check
* Add logic to break temporary disk lease before deleting it
2020-08-12 11:03:51 -04:00
ba6d11d518
Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup
2020-08-12 11:03:03 -04:00
aed97e1a8b
Ensure any active leases are brokend before deleting
2020-08-11 16:41:28 -04:00
920da9d0a4
Fix up code to remove some additional steps
2020-08-11 16:40:51 -04:00
f8bb9008c0
Merge pull request #9697 from backerman/personal/backerman/9695
...
Add FreeBSD support to azure/chroot
2020-08-10 12:47:48 -07:00
7c28d5590c
Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup
2020-08-10 12:57:11 -04:00
23d5432333
Revert inadvertently-changed import.
2020-08-09 14:31:54 -07:00
109b2a0ca9
Build constraints don't seem to work on test.
2020-08-09 14:12:58 -07:00
94c9b87431
Only run on platforms supported by chroot.
2020-08-09 13:53:21 -07:00
33eb8483ba
Get some tests in here.
2020-08-09 13:39:29 -07:00
4964c54f60
update docs to state resource id must be fully qualified
2020-08-06 10:41:18 -07:00
aede34079d
provide more helpful error message than the one returned by the client, without context
2020-08-05 09:52:11 -07:00
fb1a4bd86f
Add placeholder diskattacher for other OSes.
2020-08-01 21:59:43 -07:00
5ce6c8564c
Fix ordering to match master for better diffs.
2020-08-01 21:30:44 -07:00
13a4e47efe
Increase wait time for device to be created.
2020-08-01 21:22:50 -07:00
364c415294
Add FreeBSD support.
2020-08-01 21:22:50 -07:00
a687d6fe12
ci/tech-debt: Fix vmware acceptance tests ( #9636 )
...
* add kex algorithm option to ssh config
* regenerate code
* This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts:
1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed.
2) It modifies logic in reading and defaulting hardware config values, which was crashing.
3) It adds a new acceptance test with a preseed file to test loading from an http directory.
2020-07-23 09:40:57 +02:00
8964367eb5
Merge pull request #9603 from paulmey/disable-password
...
[azure-arm] Disable ssh password authentication unless password is explicitly specified
2020-07-17 09:32:38 -07:00
708ca1c126
Add some error checking
2020-07-16 23:22:24 +00:00
deca28c158
Disable password auth on ssh key Linux builds
2020-07-16 22:26:06 +00:00
5fd68374fe
Optionally disable password authentication for Linux builds
2020-07-16 19:44:01 +00:00
28f8241a05
update generated files
2020-07-10 16:58:06 -07:00
d4a7dd24d9
fix link in deprecation warning ( #9544 )
2020-07-08 11:59:39 +02:00
8ea64c5b35
undocument ssh_keypair_name and ssh_agent_auth
2020-07-02 14:55:58 +02:00
41edd09d3c
undocument temporary_key_pair_name and ssh_private_key_file
2020-07-01 16:33:18 +02:00
8d209caf34
Fix spacing and line endings
2020-06-24 09:20:32 -04:00
f3c33f9a27
remove spaces
2020-06-24 16:08:48 +03:00
c2f352ee6e
Update JSONs to fix tests and make them work with the latest URL changes
2020-06-24 01:35:35 +03:00
d7b8d50acd
Fix data disks URI
...
Fixing bug appeared in 0589f57d4d
2020-06-23 12:58:53 +03:00
4f77bb0c4a
add new ssh_ciphers option
2020-06-17 16:48:23 -07:00
4178625afb
re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.
2020-06-16 10:27:30 -07:00
02590f6c44
Merge pull request #9329 from hashicorp/je.website-maintenance-5-29-20
...
🌷 Website Spring Maintenance
2020-06-03 16:25:23 -07:00
e260212be3
Merge pull request #9323 [azure-chroot] copy data disks between shared image galleries
...
[azure-chroot] copy data disks between shared image galleries
2020-06-03 12:32:19 -07:00
9a38fbe2c7
patch source for a couple code block changes
2020-05-29 17:22:16 -04:00
2288ab3b53
fix typo
2020-05-29 04:15:53 +00:00
1c1991c073
fix a bug
2020-05-28 19:17:22 -07:00
f86f5b958a
Merge remote-tracking branch 'origin/master' into identity
2020-05-28 19:03:44 -07:00
53e5137411
[bug] Fix test error message
2020-05-28 23:38:17 +00:00
83851bc9aa
[bug] fix diskset type in Artifact creation
2020-05-28 23:38:17 +00:00
aa8250bcc8
give temp data disks lun suffix
2020-05-28 23:38:17 +00:00
4c96847683
log data disks in images
2020-05-28 23:38:17 +00:00
f0cd60b5fa
[bug] provide data disk prefix to disk creation
2020-05-28 23:38:17 +00:00
af96cf7881
Generated files
2020-05-28 23:38:14 +00:00
ac3d19ee23
Use separate caching/sku for data disks
2020-05-28 23:37:44 +00:00
f601f54d0b
Use all disks in managed image
2020-05-28 23:37:43 +00:00
de4839b66e
Use all snapshots when creating a shared image
2020-05-28 23:37:43 +00:00
c6b995a34d
create snapshots for all disks in a diskset
2020-05-28 23:37:43 +00:00
0ee77f8b0e
Add datadisks to disk set when using SIG as source
2020-05-28 23:37:43 +00:00
12f746b2b5
Move to using a diskset
...
Need to store lun numbers for data disks as well
2020-05-28 23:37:43 +00:00
3a3e6e525b
Shift names to diskset
...
Instead of one disk, we'll be working with a set of disks.
2020-05-28 23:37:43 +00:00
c9284d03aa
Add config for data disk/snapshot naming
2020-05-28 23:37:38 +00:00
40947c2bf6
HCL2: generate hcl tags with go-cty tags too ( #9306 )
...
This will allow to generate the config files:
```go
package main
import (
"fmt"
"github.com/hashicorp/hcl/v2/gohcl"
"github.com/hashicorp/hcl/v2/hclwrite"
"github.com/hashicorp/packer/builder/alicloud/ecs"
)
func main() {
name := "name"
app := ecs.FlatConfig{
AlicloudImageName: &name,
ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{
DiskName: &name,
},
}
f := hclwrite.NewEmptyFile()
block := gohcl.EncodeAsBlock(&app, `source "something" "something"`)
f.Body().AppendBlock(block)
fmt.Printf("%s", f.Bytes())
}
```
Will output:
```
source "something" "something" {
packer_user_variables = null
packer_sensitive_variables = null
image_name = "name"
image_share_account = null
image_unshare_account = null
image_copy_regions = null
image_copy_names = null
tags = null
tag = null
system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri
ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_
snapshot_id = null }
image_disk_mappings = null
ssh_remote_tunnels = null
ssh_local_tunnels = null
ssh_public_key = null
ssh_private_key = null
}
```
This is a good first step for #9015 and #9282
fix #9304
2020-05-28 11:19:00 +02:00
fdb0b2ab03
Revert "validate if user assigned identity exists"
...
This reverts commit 9bd19df040
2020-05-26 17:17:48 -07:00
c016f3752a
upgrade SIG source api-version to match identity api-version to avoid potential setback for identity
2020-05-26 16:08:00 -07:00
3fdab998f8
check error
2020-05-25 12:33:33 -07:00
9bd19df040
validate if user assigned identity exists
2020-05-24 19:05:46 -07:00
b334458b91
use empty struct for UserAssignedIdentities map value; omitempty
2020-05-24 19:05:45 -07:00
c5e2eff847
change to []*Resource
2020-05-24 19:05:45 -07:00
3e3fdaa24e
make generate
2020-05-24 19:05:45 -07:00
76a7ab25e2
add SetIdentity test
2020-05-24 19:05:45 -07:00
764f99ec7b
add correct api-version
2020-05-24 19:05:45 -07:00
f7f033a7fd
add config validation test
2020-05-24 19:05:45 -07:00
10b0a4548f
add identity resource id validation
2020-05-24 19:05:45 -07:00
7c1a62dfed
set identity field in the template
2020-05-24 19:05:45 -07:00
d9c9bfbae8
add identity field to the template
2020-05-24 19:05:45 -07:00
b5b2982772
add user_assigned_managed_identities to the config
2020-05-24 19:05:45 -07:00
58b32ebefa
Merge pull request #9251 from hashicorp/fix_9249
...
builder/azure-arm: Update runtime constants with a valid DataDiskName
2020-05-19 11:00:44 -07:00
1c30a71d09
Replace file shared state by statebag ( #9238 )
2020-05-19 11:49:48 +02:00
c954831bb2
builder/azure-arm: Update runtime constants with a valid DataDiskName
...
This change fixes an issue where using the `disk_additional_size` configuration option would cause builds to fail.
Build results before the change
```
==> Builds finished but no artifacts were created.
Build 'azure-arm' errored: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details." Details=[{"code":"BadRequest","message":"{\r\n \"error\": {\r\n \"code
\": \"InvalidParameter\",\r\n \"message\": \"The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\\\\W][\\\\w-._]{0,79}(?\u003c![-.])$.\",\r\n \"target\": \"dataDisk.name\"\r\n }\r\n}"}]
```
Build results after change
```
Build 'azure-arm' finished.
==> Builds finished. The artifacts of successful builds are:
--> azure-arm: Azure.ResourceManagement.VMImage:
OSType: Linux
ManagedImageResourceGroupName: test-pkr
ManagedImageName: wilkenPacker9249
```
Closes #9249
2020-05-18 14:57:20 -04:00
f31f5bc61b
docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
...
Closes #9199
2020-05-14 13:31:40 -04:00
e4eaff6bba
s/Directoty/Directory ( #9221 )
2020-05-14 15:00:27 +02:00
7e0cfd8b77
add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs
2020-05-01 10:31:38 -07:00
86ab71f56e
test/azure/arm: Add regression test case for ssh_username overrides ( #9136 )
...
This test is for the regression fixed in #9103
Before fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
--- FAIL: TestConfigUserNameOverride (0.42s)
config_test.go:75: Expected 'c.Comm.SSHPassword' to be set to generated password, but found ""!
config_test.go💯 Expected 'UserName' to be set to 'override_winrm_username', but found "packer"!
FAIL
FAIL github.com/hashicorp/packer/builder/azure/arm 0.425s
FAIL
```
After fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
ok github.com/hashicorp/packer/builder/azure/arm 0.379s
```
* Fix variable names in error messages
2020-04-30 10:49:58 +02:00
e0d2f4fd69
builder/azure-arm: Fix SSH connection for temporary admin users specified in `ssh_username` ( #9103 )
2020-04-23 11:04:49 +02:00
26d768f429
[builder/azure-chroot] Shared image source ( #9070 )
2020-04-23 11:03:17 +02:00
ab119d3270
builder/azure/chroot: fix dropped error ( #9106 )
2020-04-23 10:53:13 +02:00
da4a5224be
HCL2 singular blocks: use key/value or name/value depending on how the service names things ( #9078 )
...
* make sure keyvalue and namevalue filters are using the same naming as the service being used
* make docs a bit more readable for KeyValues too
* Update website/pages/docs/from-1.5/expressions.mdx
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-04-23 10:46:49 +02:00
761abdda4e
Updating documentation for azure-arm builder ( #9097 )
2020-04-21 10:47:48 +02:00
5d2fee04b2
builder/azure: enable boot Diagnostics ( #9053 )
...
* enable boot Diagnostics
2020-04-20 07:29:13 -04:00
89f3aa0bd6
[builder/azure-arm] Use VM/build location for image location ( #9068 )
...
* [builder/azure-arm] Use VM/build location for image locationThe builder was using the location of the containing resource group asthe image location, but the API call can only create images in the samelocation as the source VM that is being captured.
2020-04-17 05:43:03 -04:00
08787ba31f
Merge pull request #9028 from vijayrajah/set_azure_custom_res_names
...
Set Custom Resource Names for Azure-Arm builds
2020-04-16 15:58:41 -07:00
da7382980a
Fix failing test & format code
2020-04-17 00:17:39 +05:30
fff06353b7
Update builder/azure/arm/tempname.go
...
refactor the code.. thanks for the suggestion @sylviamoss
Co-Authored-By: Sylvia Moss <sylviamoss.m@gmail.com>
2020-04-17 00:04:39 +05:30
73242e8de4
make sure keyvalue and namevalue filters are using the same naming as the service being used
2020-04-16 17:22:13 +02:00
840e67f775
HCL2: when we see a map generate an attribute spec instead of a block spec ( #9035 )
...
* mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec
this will alow to do
tags = {
key = "value"
}
instead of
tags {
key = "value"
}
This will also enable using variables directly for those tags
* generate code
* update tests
2020-04-14 16:05:13 +02:00
621bd8ccac
Fix error message grammar
2020-04-09 20:55:10 +00:00
89a8238a07
Fix artifact output
2020-04-09 20:54:50 +00:00
47107e6355
Default polling delay 5 sec
2020-04-09 20:37:23 +00:00
9209826bfe
Update the doc with more info
2020-04-10 00:34:56 +05:30
4ffe5611b8
Add more tests
2020-04-08 21:05:26 +00:00
1e66a1b355
Fix linting & code generation
2020-04-09 00:00:13 +05:30
56bf8bd686
Merge branch 'set_azure_custom_res_names' of github.com:vijayrajah/packer into set_azure_custom_res_names
2020-04-08 23:54:21 +05:30
a3c580f2ac
Merge branch 'master' into set_azure_custom_res_names
2020-04-08 23:51:58 +05:30
53f54000e6
generate spec & fix typo
2020-04-08 23:42:49 +05:30
b12aedcda9
Remove lint
2020-04-07 23:09:42 +00:00
5c89d22fa2
generated & docs
2020-04-07 23:05:09 +00:00
2240ead39c
[azure/chroot] Add shared image output
2020-04-07 22:49:24 +00:00
Megan Marsh
Wilken Rivera
Brad Ackerman
Paul Meyer
Roger Hu
Moss
Arsenii Petrovich
Jeff Escalante
Feiyu Shi
Adrien Delorme
Evan Digby
Lars Lehtonen
Matthew Sanabria
vijayrajah
Adrien Delorme