80ebcea5e1
Mirror cleaner test code back from windows-shell to powershell
2017-01-19 13:33:59 +00:00
2bd9fa6c70
Use counter for index. Sort stray comments.
2017-01-19 12:12:00 +00:00
c33cef9c12
tests for equals in windows-shell
2017-01-18 12:51:14 -08:00
49bc2e353f
Fix to allow equals in value of environment variable. Mirrors #4328
2017-01-18 12:42:25 -08:00
4e6a44f5f1
append will resize
2017-01-17 17:21:14 -08:00
480398c3d2
only set PACKER_HTTP_ADDR if a server is listening
2017-01-17 17:17:36 -08:00
6563eb213c
Document. add to windows-shell and powershell
2017-01-17 17:07:36 -08:00
d2e59e4e92
set PACKER_HTTP_ADDR env var when available.
...
If using a builder that has an http server set up for file transfer,
expose the connection info to the shell provisioner through the environment
variable PACKER_HTTP_ADDR.
Closes #2869
2017-01-16 23:19:52 -08:00
5fc6a2ee70
Merge pull request #4326 from asteris-llc/feature/converge-provisioner
...
New Provisioner: Converge
2017-01-04 10:46:18 -08:00
6d6c7864b4
Merge pull request #4328 from DanHam/gh-3108
...
Allow equals sign in value of environment variable for Powershell provisioner
2017-01-03 12:38:17 -08:00
a617884a16
Add more tests for puppet-masterless provisioner
...
* Add tests for staging_directory config option
* Add tests for working_directory config option
2016-12-28 21:14:17 -06:00
feab6f096e
provisioner(converge): add prevent_bootstrap_sudo
2016-12-28 12:53:22 -06:00
fb6a5c5bbc
provisioner(converge): change skip_bootstrap back to bootstrap
2016-12-28 12:49:40 -06:00
64ebd3af8d
provisioner(converge): remove version validation
2016-12-28 08:49:08 -06:00
18425c45d0
provisioner(converge): change bootstrap to skip_bootstrap
2016-12-28 08:48:02 -06:00
5d935767f0
provisioner(converge): add bootstrap_command
2016-12-28 08:45:19 -06:00
843731d98d
provisioner(converge): add prevent_sudo
2016-12-28 08:19:03 -06:00
c226b19d08
Add additional unit tests for puppet-server provisioner
...
* Add puppet-server test for staging_dir config option
* Add puppet-server test for execute_command config option
2016-12-27 22:35:13 -06:00
0423f91037
Fix to allow equals sign in value of environment variable
2016-12-28 00:33:16 +00:00
be0196492f
Tests for env variables values starting with or containing an equals sign
2016-12-28 00:31:17 +00:00
3311d3a48d
provisioner(converge): interpolate execute_command
2016-12-27 16:48:11 -06:00
fe4b972d32
provisioner(converge): flatten execution fields
2016-12-27 16:32:19 -06:00
3658a0b6b5
provisioner(converge): remove log line
2016-12-27 16:31:12 -06:00
de918ac7a7
provisioner(converge): rename directory to working_directory
2016-12-27 16:07:16 -06:00
e6ba4c1929
provisioner(converge): remove version check
2016-12-27 16:03:35 -06:00
549ff50a3c
provisioner(converge): handle http error
2016-12-27 14:58:41 -06:00
b46a402a18
provisioner(converge): add tests for Prepare
2016-12-27 14:47:13 -06:00
73252b9a9b
provisioner(converge): reverse the meaning of bootstrap
2016-12-27 12:24:06 -06:00
b8849a9c2d
provisioner(converge): add version specification for bootstrapping
2016-12-27 12:22:17 -06:00
eca8690018
provisioner(converge): add actual provisioning step
2016-12-27 12:13:51 -06:00
73d5593242
provisioner(converge): add validate for source and destination
2016-12-27 11:41:52 -06:00
4f0034e574
provisioner(converge): transfer module directories
2016-12-27 11:29:36 -06:00
e2daefab71
provisioner(converge): improve error messages when Converge isn't found
2016-12-27 11:20:20 -06:00
03a8e309ba
provisioner(converge): add bootstrapping
2016-12-27 10:50:33 -06:00
ce43ade973
Add additional unit tests for puppet provisioners
...
* Add puppet-masterless test for packer_build_name default fact
* Add puppet-masterless test for packer_builder_type default fact
* Add puppet-server test for puppet bin directory
2016-12-26 23:11:27 -06:00
7feb8b993c
Add default facts for puppet-server provisioner
2016-12-22 15:53:59 -06:00
335615408a
Run go fmt on files
2016-12-12 22:45:19 +00:00
c88a2ef872
Remove trailing tabs
2016-12-12 22:45:10 +00:00
55353fae89
Fix spelling mistake
...
Fix code type for formatting
Remove empty space
2016-12-12 22:45:09 +00:00
f38d787b0e
Powershell uses UTF16Le for encodedCommand
2016-12-12 22:44:56 +00:00
e36051d394
Pattern for infrastructure changed to quote filename and execute file with ampersand as everything is run in powershell now
...
Handle powershell commands by specifying any extra infrastructure around running scripts inside of ExecuteCommand and ElevatedExecuteCommand
2016-12-12 22:44:55 +00:00
d61513bf77
Encode powershell using utf8
...
Fix a bug in the size of string that was returned when decoding a base64 string
Added tests around encoding and decoding powershell scripts. Used [System.Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes('powershell commands')) | clip to generate what base 64 strings should look like
2016-12-12 22:44:54 +00:00
17597b48e1
Base64 encode powershell to avoid any necessary escaping
2016-12-12 22:44:54 +00:00
5d5809b27e
Make hiding of progress backward compatible with old versions of powershell
2016-12-12 22:44:48 +00:00
e8c2b49be8
Use correct quotation of variables
2016-12-12 22:44:34 +00:00
4b394c8563
Write output will put ouput from function, so we don't want to be getting line from output of function
...
Fix unit tests for not showing progress stream when using powershell
Ensure that progress stream does not get leaked into stdout
Using Write-Output instead of Write-Host since PS v5 now leaks the host stream to stderr
2016-12-12 22:44:33 +00:00
c42cb88ddd
Using Write-Output instead of Write-Host since PS v5 now leaks the host stream to stderr
2016-12-12 22:44:32 +00:00
cd6213eb55
Seems like we do need to escape the double quote
2016-12-12 22:44:25 +00:00
15137310a7
Must escape string formatting for string fmt
2016-12-12 22:44:20 +00:00
5285a819dd
Quoting of powershell commands and associated tests
2016-12-12 22:44:19 +00:00
3051ea6633
Quote powershell so that it does not try to interpret command to be run
...
Get VName out of state. This allows template replacement to be run on vmname
2016-12-12 22:44:10 +00:00
6c3030c73a
Add a little safety around variables that are passed into provisioner.
2016-12-12 22:44:10 +00:00
b49be38d74
Merge pull request #4210 from yoctocloud/fixes
...
various fixes
2016-12-12 12:33:19 -08:00
c510988cbf
Merge pull request #4209 from bhcleek/ansible-winrm
...
provisioner/ansible: assume scp target is file (resolves winrm incompatibility)
2016-12-08 22:37:41 -08:00
5dd7fb11f4
Saltstack bootstrapping: fallback on wget if curl failed for any reason (such as not being installed)
2016-12-02 20:02:22 +01:00
00ebe9e1d3
various fixes
...
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-11-29 14:55:44 +03:00
f5ca0de225
provisioner/ansible: assume scp target is file
...
Assume the scp target is a file instead of a directory. Assuming the scp
target is a file instead of a directory allows uploading files to a node
being provisioned with the ssh communciator using sftp and with the
winrm communicator. It is fully compatible with ansible; ansible
communicators only allow for files (never directories) to be uploaded
(when the copy module is used to upload a directory, ansible walks the
directory and uploads files one at a time).
Update documentation to explain how to provision a Windows image.
Extend tests that use ssh to communicate with the node to include single
files, recursive copies, and content-only recursive copies.
Add test to verify support for the winrm communicator.
Remove the err argument from adapter.scpExec, because it was unused.
Fixes #3911
2016-11-26 14:40:39 -08:00
12176b6afc
provisioner/shell: treat disconnects as retryable.
2016-11-22 15:59:40 -08:00
200aa74e78
Added support for passing arguments to salt-call.
2016-11-11 15:15:16 +01:00
a616c3da3c
provisioner/ansible: Move info messages to log
...
Make the ansible provisioner less noisy by moving most messages to the
log instead of ui print outs.
Closes #4117
2016-11-05 14:25:45 +01:00
d920b3fbf4
run gofmt
2016-11-01 14:08:04 -07:00
f17bd30070
Revert "Removed escaped quotes in non-elevated powershell invocation"
...
This reverts commit 1b186f1613
2016-10-26 21:12:11 +02:00
3b42d28cce
Merge pull request #4014 from mexisme/feature/puppet-bin-dir
...
privisioner/puppet: Add `puppet_bin_dir` option.
2016-10-22 14:48:45 +02:00
3361da82d4
Added trailing slash after puppet_bin_dir.
2016-10-22 14:34:34 +02:00
892d5e82c9
expect_disconnect option
...
provisioner/shell: Adds option to fail if the remote server disconnects
us.
2016-10-21 11:39:03 -07:00
a1ef6398c3
Merge pull request #3371 from simonguest/powershell-envvars-fix
...
Removed escaped quotes in non-elevated powershell invocation
2016-10-19 18:50:39 -07:00
314a4f4bbf
Add Puppet Bin Dir to puppet-server provisioner
2016-10-16 02:50:37 +13:00
6f9294095f
Add Puppet Bin Dir to puppet-masterless provisioner
2016-10-15 22:39:50 +13:00
d8439b0034
Merge pull request #3971 from mitchellh/fix3486
...
change chef-solo provisioner staging directory
2016-10-14 15:51:26 -07:00
3c8dabba9e
Fixed formatting
2016-10-11 23:43:50 +02:00
83131db4b8
Merge pull request #3776 from curiositycasualty/master
...
Add custom_state config to salt provisioner
2016-10-07 17:59:52 -07:00
2ae1b83b15
change chef-solo provisioner staging directory
...
Have the staging directory be called `packer-chef-solo`, which is what
is given in docs. Closes #3486
2016-10-07 17:24:30 -07:00
51a9a51699
Update winrm and winrmcp dependencies
...
Updated winrm and winrmcp dependencies. Relevant unit and acceptance tests passed successfully.
shell.Execute didn't return a Command object.
See f1bcf36a69/winrmcp/cp.go (L167)54ea5d0147/winrm/shell.go (L10-L22)Closes #3763
Original patch by: Philipp Kosel <philipp.kosel@gmail.com>
2016-10-03 13:48:29 -07:00
a8e57d83d2
gofmt project.
...
noticed many unrelated changes being added to patches because of gofmt.
ran `find . -not -path "./vendor/*" -name "*.go" -exec gofmt -w {} \;`
2016-09-29 14:13:06 -07:00
efa594bebe
Merge pull request #3899 from pengkh/f-file-provisioner
...
continue add support for file-provisioner to allow directory downloa…
2016-09-22 18:32:57 -07:00
96a637684b
fix #3897
...
bug fix for file-provisioner download file, including unit-test code.
2016-09-19 10:36:18 +08:00
f760ab2fd8
Make SCP the default for provisioner/ansible
...
Add a new option, `use_sftp` to the ansible provisioner. It's default
value is false; ansible provisioner will use SCP by default.
Refactor to consistently set all configure options for ansible
provisioner in the Prepare step.
Remove incorrect information about `ANSIBLE_HOST_KEY_CHECKING=False`
being set when `ansible_env_vars` is not set in the packer template.
Update BATS tests for the ansible provisioner to actually check that the
fetched directory contains the contents expected. This revealed a
problem with the all_options template that required adding a host to the
hosts list in the test playbook.
2016-09-11 23:58:31 -07:00
e6a0e523e2
refactor sftp subsystem request handling
...
Refactor the sftp subsystem request handling to make it more similar to
an exec request. This simplifies and improves the readability of the
code.
2016-09-11 23:58:31 -07:00
da223b9539
add scp support to ansible provisioner
...
Handle running `scp -t` and `scp -f` exec requests in the
ansible-provisioner's SSH
server to allow Ansible to use SCP so that SFTP doesn't have to be
installed on the node.
Update the BATS tests to test the ansible provisioner.
2016-09-11 23:58:31 -07:00
9963bfcd42
removes unneeded white space
2016-09-01 13:39:44 -06:00
7fdd303641
Installs 64bit chef on windows if available
...
Resolves #3847
- Changes linux install url to new omnitruck.chef.io url.
- Changes powershell install to use omnitruck url instead of hard coded to 32bit msi install.
2016-09-01 13:23:08 -06:00
d1e38052f7
Merge pull request #3350 from JoakimLofgren/add-support-for-ansible-galaxy
...
Add support for ansible-galaxy
2016-09-01 20:51:17 +02:00
023f2edde8
add better logging and error handling to ansible provisioner ( #3477 )
2016-08-24 19:53:39 +02:00
bb2dd6e2b2
add custom_state config to salt provisioner
2016-08-03 12:56:51 -07:00
32cbb515b5
Merge pull request #3692 from mohae/3474-file-mkdir-all
...
3474 file mkdir all
2016-07-07 16:44:15 -07:00
94d158b0b7
remove debug fmt.Print from test
2016-07-07 18:12:54 -05:00
049fb2d9c1
actually check for errors in functional tests
2016-07-07 20:01:23 +01:00
0c81e49f83
Adding a functional test with an Ansible message very long
2016-07-07 01:12:57 +01:00
664e640257
Merge pull request #3392 from msteinhoff/fix-ansible-provisioner-long-lines
...
Fix Scanner buffer too long error in ansible-remote provisioner
2016-07-06 15:27:57 -07:00
999b8b2ed0
file provisioner: download should create all dirs in the destination path
2016-07-06 15:42:26 -05:00
7b3224f3c7
rename KnifeChefTemplate to KnifeTemplate
2016-06-14 13:42:53 -05:00
4847e891b0
Fix knife clean-up run on windows
2016-06-14 13:34:25 -05:00
40aa2b9973
added support for specifying an execute command to the puppet-server provisioner.
2016-06-13 14:12:28 +01:00
49067e732a
append ANSIBLE_HOST_KEY_CHECKING correctly ( #3568 )
...
Append the ANSIBLE_HOST_KEY_CHECKING environment variable correctly
regardless of whether the template specifies some environment variables.
2016-05-24 15:34:51 -07:00
f2b0fabe66
Fixes #3466 - Remote path needs to be set prior to config interpolation ( #3468 )
2016-04-29 19:21:27 -07:00
7e653370b7
Seperate remote_path into remote_folder and remote_script. ( #3462 )
...
Commonly /tmp is set as noexec, as a result packer scripts
fail to run. In order to get around this one can set a
remote_path, whoever, remote path requires full filename
and path.
By making remote_path a combination of
remote_folder/remote_script we can change remote_folder
and keep the default script_nnn.sh
Signed-off-by: Ian Duffy <ian@ianduffy.ie>
2016-04-26 16:04:29 -07:00
b5f6e379f0
Fix Scanner buffer too long error in ansible-remote provisioner
...
Ansible may produce very long lines which Scanner can not handle. This
replaces the Scanner with a Reader and uses the ReadString method to
read an arbitrary large line from the ansible-playbook stdout pipe.
2016-03-28 21:27:42 +02:00
1b186f1613
Removed escaped quotes in non-elevated powershell invocation
2016-03-20 20:28:08 -07:00
1172e670c0
Add support for ansible-galaxy
...
This adds "galaxy_file" to the options
Implement #3301
2016-03-14 18:26:56 +01:00
f3811cb99d
Add ignore_exit_codes param for puppet-masterless provisioner
2016-03-13 23:39:18 -04:00
d59844f0d1
Determine current user without CGO.
2016-03-07 13:35:24 +01:00
7369841e63
Ansible: add the support for specifying ansible_user
...
Closes #3273
2016-03-07 13:35:24 +01:00
d6716f6ee1
Ansible: don't use deprecated ssh options when ver above 2.0
...
Ansible 2.0 deprecated ansible_ssh_user, ansible_ssh_port, ansible_ssh_host
instead use ansible_user, ansible_port, and ansible_host in the
inventory file.
Closes #3275
2016-03-07 13:26:22 +01:00
f823725e53
Ansible: os.Environ() should always be passed to the ansible command.
...
Fixes GH-3271
Regression introduced in GH-3203
2016-02-26 20:49:37 +01:00
4750da3457
Add empty_groups param to ansible provisioner
2016-02-19 23:46:50 +01:00
2791542171
Allow specifying environment variables for ansible provisioner
2016-02-15 13:07:02 +13:00
6dd02e7912
Update ansible test to use the new Downloader interface
2016-02-12 14:53:23 -08:00
feee19e4ed
file provisioner improvements
...
* allow specify source/destination as dir
* allow specify many files as source
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-02-12 11:48:28 -08:00
d8aaf6175f
Merge pull request #2470 from jsoriano/puppet-masterless-clean-staging
...
Puppet masterless provisioner optionally cleans staging directory
2016-02-11 17:39:35 -08:00
3ae867446d
Merge pull request #2660 from mafrosis/saltp
...
Salt provisioner updates
2016-02-11 16:37:06 -08:00
0cd54ed19e
add options to configure host alias and groups
2016-02-10 23:33:14 -08:00
a6552f7c75
Merge pull request #3166 from ephemeralsnow/master
...
Add chmod to chef-solo provisioner
2016-02-10 19:23:47 -08:00
a5ab53bf5e
update ansible tests
...
Update tests to account for changes made in #3149
2016-02-10 14:16:02 -08:00
a23610ef41
cleanup ansible provisioner key generation
...
* Clearly separate host signer and user key generation into separate
functions and data structures.
* Remove inaccurate comment about needing to specify both files if
either one is specified.
* Rename parameters for clarity according to their meaning to the
callee.
* Style the code with gofmt.
2016-02-10 14:16:02 -08:00
3de8561a75
Add chmod to chef-solo provisioner
2016-02-09 20:06:26 +09:00
569e6cc464
go fmt
2016-02-08 17:34:06 -08:00
c95b2b483f
Merge branch ansible-provisioner of https://github.com/dkhenry/packer
2016-02-05 15:40:17 +13:00
114bddfe36
Merge branch 'master' of https://github.com/mitchellh/packer
2016-02-01 13:28:56 -08:00
1f6749096a
Restore missing interpolation after merging ansible remote; fixes #3138
2016-02-01 13:28:49 -08:00
bf3c294326
listen on system chosen port
...
Change the default for LocalPort to "0", so that the listener will be a
system chosen port.
2016-01-28 22:22:12 -08:00
15f99a4aee
Merge branch 'ansible-provisioner' of https://github.com/bhcleek/packer into f-ansible
2016-01-28 15:16:54 -08:00
87532b1b00
Merge branch 'chef-provisioner-windows' of https://github.com/sneal/packer into f-chef-provisioner-windows
2016-01-28 14:55:17 -08:00
33071150c1
Salt provisioner: option to set logging level on Salt highstate run
2016-01-26 13:09:15 +00:00
9ccf298be9
Salt provisioner: option to ignore salt highstate failures fixes #2486
2016-01-26 13:09:15 +00:00
5cd15b52c5
Salt provisioner: dynamic command line args passed onto salt-call fixes #2652
2016-01-26 13:09:15 +00:00
7cb802f8a0
Salt provisioner: improved inputs validation
2016-01-26 13:09:15 +00:00
3eabc6253d
Merge pull request #2653 from evertrue/evertrue/eherot/add_data_bag_secret_to_chef_client
...
Chef-client provisioner: Add encrypted data bag secret path (Fixes #1945 )
2016-01-13 13:59:48 -08:00
77c48678d6
eliminate possible race conditions
...
Eliminate race-y use of the packer.Ui interface by wrapping it in a
concurrency-safe implementation.
2015-12-19 15:15:19 -08:00
d73e75a7cf
fix panic when connection is closed before packer send Shutdown
2015-12-19 12:15:04 -08:00
2668747c71
Rename noclean shell option to skip_clean, per pull feedback
2015-11-19 16:02:45 +13:00
3d23655f2f
Add "noclean" boolean to shell provisioner. This stops the provisioner from
...
attempting to remove helper scripts it creates. As noted on #2803 this can
be useful when deleting the build user from an AMI or other template.
2015-11-16 16:37:09 +13:00
f006a83c95
Fixing the bug found in the tests
2015-11-03 18:19:03 -05:00
6ca02286d4
Test for when the config parameter isn't passed
2015-11-03 18:18:24 -05:00
627a8fe819
Renaming the config parameter from "options"
...
to "extra_arguments"
2015-11-03 17:55:03 -05:00
4ea7e3473d
Testing the new options argument during the actual
...
call to `Provision()`
2015-11-03 15:01:16 -05:00
84e1b387c4
New test for preparing the new config parameter
2015-11-03 14:36:04 -05:00
ebed9e53fb
Adding new "Options" configuration parameter for
...
the puppet-masterless provisioner, to allow for specifying additional
options to pass to the execute command
2015-11-03 12:30:55 -05:00
2dc9e0af3f
fix `go vet` identified issues
2015-10-31 10:39:33 -07:00
5366393f9f
fix tests
2015-10-31 10:39:33 -07:00
cc8ca3098e
add ansible provisioner
2015-10-31 10:39:33 -07:00
43cb854b3e
Merge pull request #2568 from pecigonzalo/f-winrm-reboot
...
Add reboot checks before moving out of the reboot sequence for WinRM
2015-10-26 16:57:13 -07:00
c48548b3bb
go fmt
2015-10-18 11:13:09 -07:00
1aad5cf6d5
provisioner/windows-restart: remove race in test
2015-10-12 13:20:18 -07:00
d87b68efe8
Syncronize cancellation in windows-restart tests
...
Two windows-restart tests would timeout and fail due to the cancellation
thread firing before the cancel object was created. This change syncronizes
the start of the threads to prevent this from occurring.
2015-10-10 14:32:39 -07:00
357e494ee3
Fix failing Windows guest command tests
2015-10-01 10:04:59 -07:00
8014dac742
Add Windows support to Chef provisioners
...
- Add guest os type to change the default Chef-Solo and Chef-Client provisioner behavior. Paths, commands etc.
- Change Chef installation download location to chef.io domain
- Add encrypted data bag secret configuration
2015-10-01 10:04:59 -07:00
affebcda86
Windows Powershell commands need to specify shell
...
The WinRM communicator defaults to the regular Windows cmd shell so we need to tell Packer to use Powershell when running these guest commands.
2015-10-01 10:02:11 -07:00
67f6d6cdb5
Adds provisioner guest commands abstraction
...
Provisioners often needs to perform command line operations on guests that may have different syntax and shells. The GuestCommands type abstracts these away so provisioners can avoid littering branching logic all over the place.
2015-10-01 10:02:10 -07:00
f01f62dc88
Add specific exit codes listed on https://msdn.microsoft.com/en-us/library/windows/desktop/ms681383(v=vs.85).aspx
2015-08-28 09:55:14 +12:00
8bd3e62853
Because the new functionality makes the ```waitForRestart()``` function run commands it modifies the value of ```comm.StartCmd.Command``` that is being checked, we need to implement the same workaround that is being used for the ```waitForCommunicator()``` function. This should make the test work again and retain functionality.
2015-08-28 09:54:59 +12:00
DanHam
Matthew Hooker
Sean Malloy
Brian Hicks
Taliesin Sisson
Taliesin Sisson
Patrick Decat
Vasiliy Tolstov
Billie Cleek
Jasper Siepkes
Rickard von Essen
mexisme
开恒
Spencer Owen
Billie Cleek
Isa
Chris Bednarski
Joel Scoble
Ricard Clau
Jamie Snell
Tom Asquith
Justin Nauman
Ian Duffy
Mario Steinhoff
Simon Guest
Joakim Löfgren
Keyan Pishdadian
Vespian
Marat Bakeev
Billie H. Cleek
ephemeralsnow
Matt Black
David Zanetti
Trevor Suarez
Billie H. Cleek
Mark Peek
Shawn Neal
Gonzalo Peci