* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
Updated winrm and winrmcp dependencies. Relevant unit and acceptance tests passed successfully.
shell.Execute didn't return a Command object.
See f1bcf36a69/winrmcp/cp.go (L167) and 54ea5d0147/winrm/shell.go (L10-L22) respectively.
Closes#3763
Original patch by: Philipp Kosel <philipp.kosel@gmail.com>
WinRM exposes an HTTP transport decorator that can be used for different
authentication schemes. Windows on Azures requires this if one is to use
the out of the box configuration.
Megan Marsh
Adrien Delorme
Mark DeLillo
Paul Nikonowicz
Matthew Hooker
Rickard von Essen
Christopher Boumenot
Vasiliy Tolstov
Chris Bednarski
Ben Goodwin
Mark Peek
Mitchell Hashimoto
Mitchell Hashimoto