7616fbcf3f
skip shell local for now
2019-12-11 15:43:38 -08:00
6f418d0e54
get data sharing to a working state with the powershell provisioner
2019-12-11 15:43:38 -08:00
f4c3501af5
pass struct of generated data into provision() call
2019-12-11 15:43:38 -08:00
096cab9b48
Fix floppy doc markdown typo ( #8458 )
2019-12-06 14:12:11 +01:00
76bfaf9da8
Merge pull request #8394 from hashicorp/fix_iso_target_path
...
Don't cache when TargetPath is non-nil
2019-12-02 16:24:56 -08:00
a8ffa60b46
remove the already-included packer config from top level struct
2019-11-25 11:24:00 -08:00
7d4353864f
use shell struct in shell-local provisioner and post-processor.
2019-11-21 16:47:29 -08:00
cf0130b9ed
pick up dropped error
2019-11-20 16:16:33 -08:00
9fc8ed02ae
Don't cache when TargetPath is non-nil; this messes up use of the iso_target_path iso template option.
2019-11-20 16:05:24 -08:00
ae184fe31d
ask for VM by name to reduce looping.
2019-11-08 16:20:03 -08:00
3522e13b1e
provisioner/shell: Add `env_var_format` support to shell provisioner
...
* Move setting of default EnvVarFormat to the Prepare function
* Add generated hcl2 structure for the updated Shell provisioner config
* Move `EnvVarFormat` field to shared common shell type
* Add description for the `env_var_format` parameter
* Update `env_var_format` when used with `use_env_var_file`
2019-11-06 16:28:56 -05:00
c0db000dc3
Merge pull request #8310 from alrs/resuscitate-common-floppy-tests
...
common: Resuscitate Floppy Tests
2019-11-04 15:50:46 +01:00
5926997a31
common: remove unused test function getDirectory()
2019-11-02 11:37:41 -07:00
9a90aa67e6
common: resuscitate TestStepCreateFloppy_missing()
2019-11-02 10:12:31 -07:00
8e2885e626
common: resuscitate TestStepCreateFloppy_notfound()
2019-11-02 10:10:36 -07:00
819329228a
Change back to make sure all durations are a time.Duration
...
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:
* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
2019-10-31 16:12:07 +01:00
bf3d9841c6
Force durations to be passed a strings
...
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
2019-10-31 11:47:19 +01:00
a783a09ea3
Merge pull request #8269 from paulmey/paulmey/generalize-chroot
...
[amazon/chroot] Move common/generic chroot builder steps to common directory
2019-10-24 14:32:01 -07:00
3be7d81ce2
Move common steps together
2019-10-24 04:21:46 +00:00
e6dfe301ac
Move CommandWrapper & ShellCommand to common
2019-10-24 04:06:29 +00:00
731e0332cf
common: collect dropped error
2019-10-23 13:02:08 -07:00
d15f43e4eb
Merge pull request #8232 from hashicorp/artifact-tree
...
HCL2 configs - part one
2019-10-22 11:54:34 -07:00
e5becfc854
Merge pull request #8248 from marcinbojko/master
...
hyper-v fix for compacting only .vhd|.vhdx files
2019-10-21 11:47:15 -07:00
1b4ffe546f
hyper-v fix for compacting vhdx/vhd only
2019-10-19 12:46:34 +02:00
cf1555bf17
Merge remote-tracking branch 'origin/master' into artifact-tree
2019-10-16 10:22:56 +02:00
d6994df188
Select first adapter attached to host OS's switch
...
If more than one vNic is attached to vmSwitch, use the first one only.
2019-10-15 15:14:22 +02:00
078ba7c8c3
commit old code generation tool
...
for history
2019-10-15 12:56:42 +02:00
7be94f41a6
common.shell-local: unexport Ctx field
...
so that it doesn't temper with hcl2 generation
2019-10-15 12:56:42 +02:00
49e4a2d9ef
Add error check
2019-10-09 15:55:07 +02:00
843986c2d4
missing bracket
2019-10-04 10:41:12 -07:00
59efa0faee
rename option to error-cleanup-privisoner, which I think is clearer
2019-09-25 13:43:29 -07:00
5bd8fee708
Creates a final "cleanup" provisioner to run if an error occurs during a provisioning step, allowing users to perform any custom cleanup tasks that must happen on the VM before the VM is shut down and destroyed.
2019-09-24 16:08:15 -07:00
299544a4c7
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-20 14:47:02 +02:00
a98f2d2170
common: fix dropped errors and warnings in test
2019-09-20 05:06:25 -07:00
3fe9d52e3f
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-20 11:15:44 +02:00
34ba03d3cb
use printf for logging
2019-09-13 01:53:42 +03:00
171c2a9a07
add the floppy label option
2019-09-12 12:25:22 +00:00
597a3e323b
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-10 13:20:07 +02:00
aa9cc919ab
Merge branch 'master' into circle_ci_windows
2019-09-10 12:54:35 +02:00
146b88ba1e
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-10 12:44:46 +02:00
2b6286c31c
Fix powershell formatting. Match style for conditionals
2019-09-09 23:05:40 +01:00
7ba91b7d25
configure_port_test.go: don't panic when error is not what we expected
2019-09-05 17:03:54 +02:00
d4ff29f6c5
hyper-v fix when management interface is not part of virtual switch
...
2
formatting fix
2019-08-22 07:54:50 +02:00
4cb7c30987
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-08-21 16:44:23 +02:00
cd3b39ad17
commit generated code
2019-08-12 15:55:43 -07:00
a6830f8348
Move 'ui' variable closer to invocation.
2019-07-31 14:08:40 -04:00
e362d2f3ee
Use 'log.Printf()' for StepDownload debug instead of 'ui.Say()'.
2019-07-31 14:02:57 -04:00
90c5da40f2
implement abort logic and printing for the askstep implementation as well
2019-07-26 12:24:03 -07:00
54034689ef
On abort, return gracefully rather than exiting so that the subprocess doesn't unexpectedly disconnect from the parent and cause a confusing EOF error in the logs
2019-07-25 16:32:16 -07:00
216afbaa8b
Fixed various typos
...
Just a bunch of nit-picky typo fixes.
2019-07-25 06:49:51 +02:00
e9549d2688
add test for local fs download
2019-07-22 09:17:48 -07:00
197a283b5e
actually check for filepath being present
2019-07-19 10:35:50 -07:00
64f16474f8
fix double slash conundrum
2019-07-19 10:16:40 -07:00
aef77771c0
Correct HTTPIP == FALSE on HyperV builder
2019-07-17 03:41:41 -05:00
d6d4eb2087
fix some tests and some config behavior to prevent null dereference errors and incorrect precedence between iso checksum and iso checksum url
2019-06-28 15:29:39 -07:00
998ef4053f
parse checksum file so that we can use the checksums inside in the vmware-esxi builder stepuploadiso
2019-06-28 14:35:43 -07:00
88d589cc88
enable smb share double backslash pathing too
2019-06-26 13:43:05 -07:00
12471a8b06
use file getter for smb shares
2019-06-26 13:21:49 -07:00
735b34e01f
Document the virtualbox-iso builder using partials
2019-06-19 17:37:22 +02:00
4c1abf828c
Merge branch 'master' into scrape_doc_to_builder_struct_config
2019-06-19 11:21:06 +02:00
8d25cc578f
Merge pull request #7746 from hashicorp/fix_7671
...
Abort hyperv build if there's a name collision
2019-06-14 10:58:22 -07:00
daa9f9d34e
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-06-14 15:17:56 +02:00
425ad1c67e
generate Shutdown command docs from strutc & use in hyperv
2019-06-14 12:43:31 +02:00
c11ef90cb6
use interpolate.NewContext() instead of testConfigTemplate(t)
...
because it's what's happenning there
2019-06-14 12:17:28 +02:00
926c8bbaa6
refactor ShutdownConfig into a single struct
2019-06-14 12:17:28 +02:00
24fad50b00
hyperv-iso: document boot config, http & floppy from partials
2019-06-14 12:17:27 +02:00
3bb8c92902
qemu: document boot command from struct
2019-06-14 12:17:27 +02:00
b48d22b43b
qemu: document FloppyConfig from struct
2019-06-14 11:52:38 +02:00
3b66cac617
document HTTPConfig from struct
2019-06-14 11:52:38 +02:00
2e821da84b
check to make sure a vm-name isn't already in use before trying to launch a vm with said name.
2019-06-13 14:09:45 -07:00
dbfadc0eea
generate struct markdown from common/iso_config.go
2019-06-12 16:02:49 +02:00
20a152d4aa
add comments to common/iso_config.go from docs
2019-06-12 16:02:02 +02:00
ca33f8bc5c
Revert "Backoff.Linear: panic when InitialBackoff > MaxBackoff"
...
This reverts commit 39cfacd5fa
2019-06-11 12:53:06 +02:00
39cfacd5fa
Backoff.Linear: panic when InitialBackoff > MaxBackoff
...
this probably means there's a configuration issue.
Since this struct is mainly set manually from code, I think it is okay to panic here.
2019-06-11 12:41:21 +02:00
36e4eaff99
document retry.Backoff better
2019-06-11 12:20:00 +02:00
8519da6ce9
common/net: Cleanup cache of used port after closing
2019-05-06 22:11:52 +01:00
b329073e54
remove trying port log as retry code will show errors
...
less logs !
2019-05-01 13:04:51 +02:00
38f789eedc
add error types to test for
2019-05-01 13:01:25 +02:00
14f2d1c132
ListenRangeConfig:Listen: use the retry pkg to wait a bit in between opens
2019-05-01 12:27:32 +02:00
e14d1b8b0b
add a timeout trying to open a random port
2019-05-01 12:01:34 +02:00
2fd7adffc4
add tests for ListenRangeConfig.Listen
2019-05-01 11:46:48 +02:00
d9e5145de9
Shadow the flock pkg & add a noop filelock so that at least the solaris binary can be built
...
Without this the following error occurs:
$ GOOS=solaris go build .
# github.com/hashicorp/packer/vendor/github.com/gofrs/flock
vendor/github.com/gofrs/flock/flock_unix.go:28:22: undefined: syscall.LOCK_EX
vendor/github.com/gofrs/flock/flock_unix.go:39:22: undefined: syscall.LOCK_SH
vendor/github.com/gofrs/flock/flock_unix.go:56:12: undefined: syscall.Flock
vendor/github.com/gofrs/flock/flock_unix.go:66:12: undefined: syscall.Flock
vendor/github.com/gofrs/flock/flock_unix.go:96:12: undefined: syscall.Flock
vendor/github.com/gofrs/flock/flock_unix.go:96:42: undefined: syscall.LOCK_UN
vendor/github.com/gofrs/flock/flock_unix.go:118:21: undefined: syscall.LOCK_EX
vendor/github.com/gofrs/flock/flock_unix.go:130:21: undefined: syscall.LOCK_SH
vendor/github.com/gofrs/flock/flock_unix.go:149:9: undefined: syscall.Flock
vendor/github.com/gofrs/flock/flock_unix.go:149:44: undefined: syscall.LOCK_NB
vendor/github.com/gofrs/flock/flock_unix.go:149:44: too many errors
2019-04-30 16:01:23 +02:00
5d9d43c01d
add tests for ListenRangeConfig.Listen
2019-04-30 15:42:59 +02:00
fd63ec9a6c
ListenRangeConfig.Listen: move trying port log after fslock trylock for less logs
2019-04-30 15:35:22 +02:00
79ae62801f
ListenRangeConfig: default network ( protocol ) to tcp
2019-04-30 14:55:38 +02:00
65be2be38b
step_download: force copy of local files only on windows
2019-04-29 09:39:21 +02:00
200e26ea85
Step download: always copy local files
...
instead of symlinking to fix #7534 . The longer term fix for this would be to change the go-getter so that it can leave the source file where it is & tell us where it is.
We will do this when the right time comes.
2019-04-26 10:35:18 +02:00
9f1136db77
retry: encapsulate & return the last seen error in a RetryExhaustedError
2019-04-24 14:19:23 +02:00
e69d95eb37
when retries were exhausted in the retry Run, we were returning nil instead of an error.
2019-04-23 13:48:30 -07:00
5f0259fe89
step download: don't fail when checksum_type is not set
2019-04-16 18:09:54 +02:00
4dc12701d3
step_download: display clearer error messages, also when the checksum is not set
...
Usually the builder validation should error when the checksum is empty, but for the virtualbox-ovf builder this is not validated. Which is something I didn't see when refactoring for go-getter incorporation/refactor.
2019-04-15 14:34:09 +02:00
78cf1405ab
Merge pull request #7480 from BobSilent/fix-hyperv-multiple-hostadapter-same-switch
...
Fixes "Host IP for the HyperV machine: False" if more than one VMNetworkAdapter is found
2019-04-12 14:06:46 -07:00
9ac8d8aed8
step download: ovf files usually point to a file in the same directory, using them in place is the only way
2019-04-12 16:51:57 +02:00
63f5bbbc73
use our own copy of iochan.LineReader
2019-04-11 14:25:24 +02:00
d72040f4fa
move retry code into the common/retry pkg and make retry context aware
2019-04-09 17:46:38 +02:00
5b289f67fe
Update hyperv.go
...
maybe also a fix for issue #5023
at least I got same error like there, incl. VM response
==> hyperv-iso: Host IP for the HyperV machine: False
although #4947 is marked as duplicate but shows different error output
==> hyperv-iso: Error getting host adapter ip address: PowerShell error: Get-VMNetworkAdapter : No network adapter is found with the given input.
2019-04-09 07:36:52 +02:00
f555e7a9f2
allow a provisioner to timeout
...
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
2019-04-08 20:09:21 +02:00
a81abd297b
Merge remote-tracking branch 'origin/master' into context_provisioner
2019-04-08 20:09:01 +02:00
3e72e65a6c
Merge pull request #7456 from hashicorp/do_5770
...
introduce the clean_resource_name to clean image/var names
2019-04-05 09:12:20 -07:00
217a93fc30
fix build_test.go on windows. This code needs to not be run in parallel, or else there can be race conditions with the post-processors all trying to access the same file at once. Additionally, I changed the test template itself so that it is valid code on either bash or cmd. Finally, I found and fixed a small bug in naming the file extensions in shell local inline scripts.
2019-04-04 14:57:56 -07:00
c4f3dccc14
rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts
2019-04-03 15:56:15 +02:00
82c4b76639
[Builder|Build|PostProcessor|Provisioner|Hook]Server: context cancel using a RPC cancel method
2019-04-03 15:55:55 +02:00
14048b1e11
Revert "WIP: go towards context cancelled rpc pkg"
...
This reverts commit e4609b4a6a4ba2ec76a45ad67d50d180f1a914f9.
2019-04-03 15:55:55 +02:00
9e3a179c0d
WIP: go towards context cancelled rpc pkg
2019-04-03 15:55:55 +02:00
829851fc8a
change hooks to be passed a context for cancellation
...
we have to as it is what calls our provisioners
2019-04-03 15:55:54 +02:00
9836dad0c9
introduce the clean_resource_name to clean image names and deprecate the old ones
2019-04-03 11:25:51 +02:00
91cc7e1091
net.ListenRangeConfig.Listen: don't swap ports if max < min
2019-03-26 10:53:52 +01:00
a4a83be2b9
net.ListenRangeConfig.Listen: allow to have a port rage of zero
2019-03-26 10:52:07 +01:00
cd39aa9988
net.ListenRangeConfig.Listen: log tried ports a bit earlier in the process
...
so we know tried ports every time
2019-03-26 10:45:32 +01:00
5a6dffde9a
use port as ints
2019-03-19 15:01:12 +01:00
c214f6735b
make everything a uint
2019-03-19 12:54:15 +01:00
51294287fa
StepHTTPServer: display error if we could not connect
2019-03-19 12:54:15 +01:00
6df4128517
StepHTTPServer: use the common/net pkg
2019-03-19 12:54:12 +01:00
1685a1c4c0
add common/net package that can listen on a random port in a range
2019-03-19 12:53:56 +01:00
6ab28ba89c
Update common/shell/shell.go
...
be more descriptive
2019-03-15 12:21:27 +01:00
b4ec6e2ed2
Create exit_code_test.go
2019-03-14 13:32:46 +01:00
eedf5e4387
Update shell.go
...
remove typo
2019-03-14 12:50:19 +01:00
f0a23bb81d
common shell provisioner: define a ValidExitCode func
2019-03-14 12:46:32 +01:00
30a65c858a
regroup shell provisioner params into a common struct
2019-03-14 11:57:54 +01:00
9f82b75e57
Use the hashicorp/go-getter to download files
...
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
2019-03-13 12:11:58 +01:00
f736e2aba5
Print VerifyChecksum log for the download as ui.Message output
2019-03-11 22:33:46 +02:00
3dc1dafe58
Merge pull request #7287 from stephen-fox/ephemeral-ssh-key-pair-issue-7225
...
virtualbox: create ephemeral SSH key pair for build process
2019-03-04 14:25:04 -08:00
56c17941fe
Added comment to authorized_keys 'sed' calls per review.
2019-02-28 10:54:14 -05:00
2a9f49a5c6
make sure we don't try to load an iso into memory because of a user mistake
2019-02-13 16:21:55 -08:00
36c1e8d838
moved adapter to common package
2019-02-12 07:10:57 +00:00
354fcc5cc6
Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'.
2019-02-05 16:16:51 -05:00
e40aa515f2
Added TODO about public key removal logic.
2019-02-05 12:00:01 -05:00
2d3f84abf0
Merge pull request #7271 from hashicorp/make_generate
...
make generate
2019-02-04 13:11:24 -08:00
4c2851013e
Fixed 'sed' regex to remove public key by magic string.
2019-02-04 12:10:17 -05:00
8621949e01
make generate
2019-02-04 15:16:38 +01:00
482ba644a8
quote variables in powershell script to account for spaces
2019-02-01 13:23:17 -08:00
3602180b45
re-add missing import
2019-01-25 12:33:25 -08:00
c63b54a1e7
move http with proxy call into a helper function
2019-01-25 12:32:52 -08:00
d72fb9bcb3
If checksums for a download don't match, display the checksum that was found
2019-01-17 20:26:16 +00:00
97a791389a
deduplicate step_output_dir and move to common folder
2019-01-11 15:06:36 -08:00
9f2a3bdfbc
Merge pull request #7181 from hashicorp/python_shell_docs
...
add python example to shell-local docs
2019-01-10 10:43:55 +01:00
a2c3de9396
remove outdated logline
2019-01-09 11:16:48 -08:00
9f7b4ffc17
Merge branch 'master' into pr/6950
2019-01-09 10:11:18 +01:00
19cbb9cb24
Merge pull request #7136 from hashicorp/fix_5984
...
Add "version" option to hyperv calls
2019-01-09 10:06:49 +01:00
93053e0488
update comments
2019-01-08 15:15:00 -08:00
9557f3eea7
use script options struct rather than passing all the variables around an extra time
2019-01-08 11:29:38 -08:00
a1b3b63cb9
use golang templating logic
2019-01-08 11:17:19 -08:00
e6de727c25
Fix the Hyper-V gen 1 guest boot order.
2018-12-25 16:54:26 -06:00
f26051a7da
code comments yo
2018-12-20 13:09:32 -08:00
24d2cc34e5
tests
2018-12-20 12:03:14 -08:00
427a35fc7e
tests
2018-12-20 12:03:00 -08:00
d4de89e057
move powershell templating into separate script so we can test it
2018-12-19 16:35:02 -08:00
006682a09c
add version option and also refactor powershell script to use golang templates for ease of testing and variable passing.
2018-12-19 16:30:57 -08:00
348c267054
Updated support for legacy network adapters on Hyper-V.
2018-12-18 04:59:00 -06:00
b95123f457
add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work.
2018-12-13 09:12:23 -08:00
Megan Marsh
Sylvia Moss
nywilken
Adrien Delorme
Lars Lehtonen
Adrien Delorme
Paul Meyer
Marcin Bojko
Vladimír
Davor Kapsa
allinwait
DanHam
Stephen Fox
Christian Muehlhaeuser
WilliamB
Radek Simko
BobSilent
Vadym Haidamaka
xinau
Tom Parker-Shemilt
Ladar Levison
Ladar Levison