packer-cn

Commit Graph

Author	SHA1	Message	Date
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	2019-04-08 20:09:21 +02:00
Megan Marsh	d304234725	fix tests	2018-05-07 15:10:10 -07:00
Megan Marsh	616b41e58f	deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module	2018-05-07 15:10:09 -07:00

Author

SHA1

Message

Date

Adrien Delorme

f555e7a9f2

allow a provisioner to timeout

* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi

2019-04-08 20:09:21 +02:00

Megan Marsh

d304234725

fix tests

2018-05-07 15:10:10 -07:00

Megan Marsh

616b41e58f

deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module

2018-05-07 15:10:09 -07:00

3 Commits