Matthew Hooker
807e88245b
trying to add context to state bag
2018-01-24 17:09:15 -08:00
James Nugent
5967732442
Merge pull request #5795 from stack72/bump-triton-go-deps
...
builder/triton: bump triton-go dependencies
2018-01-23 14:40:03 +00:00
Matthew Hooker
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
stack72
20f9ef3445
builder/triton: bump triton-go dependencies
...
This introduces a new triton-go errors package so we can error handle our code in a better way
2018-01-17 16:55:00 +02:00
Ali Rizvi-Santiago
c17f827e1d
Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols.
2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
3cf448f6ec
Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path.
2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
46a5ca30e5
Removed call to filepath.Rel(...) in builder/vmware/iso/step_create_vmx.go
2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
5d97b105a8
Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist.
2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
d275bacb0f
go fmt builder/vmware/iso/step_create_vmx.go to calm down Travis CI.
2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
e940dc7e42
Fixed a config_test that should've failed but didn't because ftp:// uris work now. HeH!
2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
281dd1258a
Added proper support for downloading via a Windows UNC path or a relative uri.
...
Added proper support for validating a downloadableURL containing a UNC or relative uri.
Removed the workaround for an earlier Go issue that had remained dormant in common/download.go (issue #5927 ).
When building a .vmx file via the vmware-iso builder, transform the path to the correct os-formatted one (using filepath.FromSlash).
2018-01-16 13:36:17 -06:00
Matthew Hooker
cea2ab8c6d
move kms/encrypted validation to block devices
2018-01-12 15:10:51 -08:00
Matthew Hooker
e968f9d6cc
spelling/style fixes
2018-01-12 14:26:56 -08:00
Jason Wieringa
f6772f06be
builder/amazon: Raise error when ebsvolume kms_key_id is without encrypted = true
2018-01-11 20:27:38 -08:00
Jason Wieringa
2ac59b3c27
builder/amazon: Added KmsKeyID to BlockDevice
...
+ Adds kms_key_id to list of options
+ Tests that configuraiton is set along with encrypted
+ Updates documentation on ebsvolume builder
2018-01-11 20:27:38 -08:00
유성덕
b909e9d4e6
remove not used variables
2018-01-12 10:15:40 +09:00
유성덕
26030d750c
update err format
2018-01-12 10:12:47 +09:00
Matthew Hooker
2ce3ca1538
Merge pull request #5773 from hashicorp/fix5705
...
Use SDK's InstanceReady waiter
2018-01-11 12:12:03 -08:00
SwampDragons
fb730cf521
Merge pull request #5761 from hashicorp/fix_5713
...
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-11 11:48:26 -08:00
유성덕
5189d65467
Support Naver Cloud Platform
2018-01-11 18:57:53 +09:00
Megan Marsh
3ace5bb91b
simplify FileExistsLocally
2018-01-10 16:11:17 -08:00
Matthew Hooker
f5ea1e8312
Use WaitUntilInstanceReady waiter
2018-01-10 15:57:31 -08:00
Megan Marsh
216c44b153
fix FileExistsLocally
2018-01-09 15:47:07 -08:00
Matthew Hooker
dfd5f07145
fix ebs acc test
2018-01-08 12:27:10 -08:00
Megan Marsh
e164621bfe
log line to help prevent confusion when guest_additions_url is set from env variable that is empty
2018-01-05 09:19:38 -08:00
SwampDragons
ff3cbbf28c
Merge pull request #5757 from arizvisa/virtualbox-guest_additions_url-interpolation
...
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-04 15:39:29 -08:00
Matthew Hooker
c5bcb97d06
"borrow" access config code from terraform.
...
This gives us a few benefits:
* timeout early if metadata service can't be reached
* report which auth provider we're using
* give much better errors if something goes wrong
2018-01-04 15:04:07 -08:00
Matthew Hooker
98c2a2d1f7
builder/aws: catch static credential errors early.
...
If we're using static credentials, either both the access key and secret key must be set, or neither of them should be.
2018-01-04 11:50:27 -08:00
Megan Marsh
4f3b470804
add helper function to manage validation of filepaths created using DownloadableURL
2018-01-03 16:53:47 -08:00
Ali Rizvi-Santiago
4fcd542d0c
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-02 21:09:41 -06:00
stack72
c3467b686c
builder/triton: Add support for Triton RBAC
...
Fixes : #5737
Triton allows for subusers to be granted access to your account. This PR allows a user to be specified
2017-12-29 21:20:40 +02:00
QuantumGhost
a90376f12a
Attach keypair before starting instance in alicloud builder
...
[Documentation of `AttachKeyPair`](https://goo.gl/gC3srG ) states that
attaching keypair to running instance takes effect after reboot.
So we need to attach keypair before starting instance to avoid an
additional restart.
2017-12-29 10:13:26 +08:00
Glenn McDonald
7250c4f7f0
Add Intel HAXM support to QEMU builder
2017-12-29 11:51:57 +11:00
Rickard von Essen
05fcecb1e7
Merge pull request #5666 from kwilczynski/remove-ecr-credentials-from-logging
...
docker: Remove credentials from being shown in the log.
2017-12-26 08:07:37 +01:00
Matthew Hooker
f3dea272d9
Set session in state bag
...
We can construct connections to arbitrary regions from it
2017-12-19 11:32:33 -08:00
Matthew Hooker
f6c401a143
don't pass in accessconfig
2017-12-19 11:32:32 -08:00
Matthew Hooker
1c352726d7
Merge pull request #5719 from rchenv/issue5606
...
Ensure all AWS connections are configured alike
2017-12-19 11:32:24 -08:00
Rong Chen
3e92b1374e
issue5606: follow the convention to use AccessConfig to create new aws session for step_create_tags etc.
2017-12-19 10:34:12 -08:00
Olivier Bazoud
8bcb469b8b
builder/amazon: Added new region Paris - eu-west-3
2017-12-19 10:00:03 +01:00
Ben Phegan
c338cb79d0
Initial commit of feature to allow MAC address specification for HyperV builders
2017-12-15 13:24:15 +11:00
Arjen Schwarz
c2ecdd98c6
5691: Invalid image URLs make Azure builder crash
2017-12-12 20:12:53 +11:00
Vijaya Bhaskar Reddy Kondreddi
54f059d3d4
Add support for skip export
2017-12-11 11:24:59 +05:30
Krzysztof Wilczynski
567b566c23
docker: Remove AWS credentials and Session Token from being shown in the log.
...
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
2017-12-10 20:55:03 +01:00
Rickard von Essen
63f791570a
Merge pull request #5665 from kwilczynski/remove-sts-token-from-logging
...
amazon: Remove Session Token (STS) from being shown in the log.
2017-12-10 06:50:42 +01:00
Andrew Pennebaker
d069dc5b7c
handle holding a-z keys, such as for boot options (vmware builder)
2017-12-09 20:51:49 -06:00
Matthew Hooker
f216330ba3
spot instance ena/sriov checking for all other builders
2017-12-08 14:56:19 -08:00
Matthew Hooker
4b1d8e3fe8
don't allow enhanced networking flags for spot instances.
2017-12-08 13:38:49 -08:00
Matthew Hooker
73b98b2a04
use waiter to wait for ebs instances to stop
2017-12-08 13:38:48 -08:00
Matthew Hooker
dada63801b
also use waiter code for spot instances
2017-12-08 13:38:48 -08:00
Matthew Hooker
9e61005f7c
Merge pull request #5660 from hashicorp/fix_5625
...
modify validation to allow user to have the original region in the am…
2017-12-08 13:36:10 -08:00