This test is for the regression fixed in #9103
Before fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
--- FAIL: TestConfigUserNameOverride (0.42s)
config_test.go:75: Expected 'c.Comm.SSHPassword' to be set to generated password, but found ""!
config_test.go💯 Expected 'UserName' to be set to 'override_winrm_username', but found "packer"!
FAIL
FAIL github.com/hashicorp/packer/builder/azure/arm 0.425s
FAIL
```
After fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
ok github.com/hashicorp/packer/builder/azure/arm 0.379s
```
* Fix variable names in error messages
* make sure keyvalue and namevalue filters are using the same naming as the service being used
* make docs a bit more readable for KeyValues too
* Update website/pages/docs/from-1.5/expressions.mdx
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
Co-authored-by: Megan Marsh <megan@hashicorp.com>
* [builder/azure-arm] Use VM/build location for image locationThe builder was using the location of the containing resource group asthe image location, but the API call can only create images in the samelocation as the source VM that is being captured.
* mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec
this will alow to do
tags = {
key = "value"
}
instead of
tags {
key = "value"
}
This will also enable using variables directly for those tags
* generate code
* update tests
Results before change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007
builder/alicloud/ecs/image_config.go:208:9: S1007: should use raw string
post-processor/vsphere-template/step_mark_as_template.go:130:8: S1007: shape twice (gosimple)
builder/azure/arm/config.go:58:27: S1007: should use raw string (`...`)
builder/azure/arm/config.go:59:27: S1007: should use raw string (`...`)
builder/qemu/driver.go:192:15: S1007: should use raw string (`...`)
```
Results after change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007
```
* Change generated documentation to indicate what image selection
options are required, and when.
* Refactor the structure of the documentation to highlight required
options for different types of builds
Megan Marsh
Wilken Rivera
Adrien Delorme
Matthew Sanabria
vijayrajah
Paul Meyer
Adrien Delorme
Jeff Escalante
Sylvia Moss
Vijay Rajah
r_takaishi
Mike Brancato