3671 Commits

Author SHA1 Message Date
M. Marsh
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
M. Marsh
cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
Hariharan Jayaraman
667113338a missed formating 2018-05-18 01:41:00 -07:00
Hariharan Jayaraman
7f2277676a Ensure that Device Login tests dont block general acceptance tests 2018-05-18 01:34:12 -07:00
Hariharan Jayaraman
77fe1bffe4 Ensure that Device Login tests dont block general acceptance tests 2018-05-18 01:25:19 -07:00
Hariharan Jayaraman
de1783240f Updates to remove space changes 2018-05-18 00:53:44 -07:00
Hariharan Jayaraman
91eed4da52 trim right of the keyvault url 2018-05-18 00:44:25 -07:00
Hariharan Jayaraman
df5cc234fc updates 2018-05-18 00:39:57 -07:00
Hariharan Jayaraman
1f46271a6b Ensuring device login works for Windows build 2018-05-18 00:32:01 -07:00
Christopher Boumenot
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
Async delete Resource Group
2018-05-16 15:13:09 -07:00
Chris Lundquist
c925a02f82 don't chown to close the security issue 2018-05-16 21:40:22 +00:00
Matt Coleman
3192f5e0da qemu builder: add the 'use_backing_file' setting for QCOW2 images 2018-05-16 10:22:50 -04:00
DanHam
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
This reverts commit f342975ff31e5a59b4534b3fb216250365468b1f.
2018-05-16 13:52:00 +01:00
DanHam
2939cd75ae
Revert "Report the result of the disk compaction step"
Unfortunately this broke the ability to build on remote (ESXi) hosts.

This reverts commit 08f9d619a9299d81495d96cf10160f38cdb2476d.
2018-05-16 12:55:59 +01:00
Hariharan Jayaraman
e1b18d594a Updates based on PR feedback 2018-05-15 11:41:26 -07:00
DanHam
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting 2018-05-15 12:25:06 +01:00
DanHam
99e3487795
Add missing validation and tests for Spot Instance requests 2018-05-15 12:25:06 +01:00
DanHam
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders 2018-05-15 12:25:06 +01:00
DanHam
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance 2018-05-15 12:25:06 +01:00
DanHam
df7fb86984
Add tests for T2 Unlimited configuration 2018-05-15 12:25:06 +01:00
DanHam
be02b3f613
Validate template settings when T2 Unlimited has been enabled
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance 2018-05-15 12:25:06 +01:00
DanHam
2c339b99d2
Sort run config options alphabetically 2018-05-15 12:25:06 +01:00
Hariharan Jayaraman
c8c9bbb22a Async delete Resource Group 2018-05-14 20:06:23 -07:00
Unknown
5710c0aca1 Making log output clearer for hyper-v gui connection 2018-05-14 20:53:51 +10:00
Unknown
29c4b4436d Changes requested in PR #6243
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
Unknown
fc734b6bd9 Using vmconnect to display gui for hyper-v
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
Christopher Boumenot
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
M. Marsh
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
Hariharan Jayaraman
13c0b0b370 Added warning for VHD creation and updated samples 2018-05-10 13:15:35 -07:00
Stefan Henseler
6f00596053 Adds config option to specify hyper-v secure boot template 2018-05-10 19:00:35 +02:00
M. Marsh
84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
DanHam
a866232ac9
Use regex based approach to detect attached disks 2018-05-08 12:52:39 +01:00
Megan Marsh
6dc4b1cbdc move all of the run commands for shell-local provisioner and postprocessor into common library too 2018-05-07 15:10:09 -07:00
Megan Marsh
616b41e58f deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module 2018-05-07 15:10:09 -07:00
Christopher Boumenot
80a096cadd azure: device login for US Gov 2018-05-06 20:59:38 -07:00
Paul Meyer
8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
Update Azure SDK
2018-05-04 09:47:28 -07:00
Rickard von Essen
4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
Paul Meyer
169f9d22e6 Update 'the other place' too 2018-05-04 00:32:15 +00:00
Paul Meyer
80f57308d7 Process review feedback 2018-05-04 00:28:34 +00:00
Christopher Boumenot
420a5842b9
Merge pull request #6231 from cantorek/f-randomize-osdiskname
Randomize osDisk name for Azure Managed Image builds.
2018-05-03 14:55:42 -07:00
Matthew Hooker
0521efa200
correctly log reason waiting for ami failed. 2018-05-03 12:27:09 -07:00
Matthew Hooker
7d5ebd5500
Merge pull request #6217 from alessiot77/5887
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
DanHam
c47e5d19f0
Fix use of auto generated ssh key for scaleway builder 2018-05-03 11:33:28 +01:00
DanHam
585b93cfd6
Follow variable privateKey <-> statebag private_key convention 2018-05-03 00:33:12 +01:00
Oskar Wycislak
78d68880c0 Randomize osDisk name for Azure Managed Image builds.
This fixes #6115
2018-05-02 22:42:08 +02:00
Paul Meyer
07d8c71a2d Create and use context for Builder.Run 2018-05-01 23:40:40 +00:00
M. Marsh
e90c87f885
Merge pull request #6210 from hashicorp/add_windows_sql_cloud_to_defaults
add windows-sql-cloud to the list of projects to check for an image name
2018-05-01 12:57:10 -07:00
Paul Meyer
cf94086b5f Formatting fixes 2018-05-01 19:53:20 +00:00