f681faa296
fix tests
2017-11-07 14:57:10 -08:00
545ee45567
debug region we found
2017-11-07 14:51:20 -08:00
c106e7c26c
Don't set region from metadata if profile is set.
2017-11-07 14:33:26 -08:00
52fc0100eb
this is a critical error
2017-11-07 12:52:03 -08:00
95e4ae251e
WIP
2017-11-02 09:03:44 -07:00
e87b468c6e
Merge pull request #5536 from hashicorp/fix5535
...
add delay option to security group waiter
2017-11-02 08:54:34 -07:00
8ab390a048
Merge pull request #5495 from smaato/master
...
Fix regressions relating to spot instances and EBS volumes
2017-11-02 08:53:27 -07:00
f2413ff138
add delay option to security group waiter
2017-11-02 00:25:54 -07:00
d322fc6c19
Shorten metadata timeout
...
When running in travis, metadata requests will timeout after 5 seconds.
After 24 such timeouts, we'll hit travis' build timeout of two minutes,
and the build will fail. Lowering it to 100 gets us in a safe time
limit. We _may_ need to expose a timeout env var with this logic,
however.
2017-10-30 15:22:15 -07:00
314fc94bd8
clean up
2017-10-30 15:02:39 -07:00
0e4ea7420b
fix tests
2017-10-30 14:34:16 -07:00
c65fa8490d
fix various bugs deregistering AMIs
...
always deregister ami in session region
validate that session region does not appear in ami_regions
2017-10-30 14:17:19 -07:00
6c4fbe8d87
use correct default region when deregistering AMIs.
2017-10-30 13:07:58 -07:00
4c5df79222
Fix regressions introduced in the instance builder
...
Related to #5504
2017-10-24 23:23:18 +02:00
309bf61257
Add missing blockdevices to ebsvolume builder
2017-10-23 22:33:16 +02:00
1cc9b3f1e3
Bring back volume tagging to ebsvolume
...
Related to #5486
2017-10-23 22:09:04 +02:00
7e1646826d
Check if VolumeTags is empty before tagging volumes
...
Related to #5486
2017-10-23 21:10:40 +02:00
f7e269945e
add cidr validation and rename option
2017-10-12 17:05:56 -07:00
c74be87187
Merge pull request #5384 from dave2/sg-source-cidr
...
[WIP] Allow temporary security group to have source CIDR block explicit
2017-10-12 17:05:45 -07:00
512ac214b4
Merge pull request #5417 from smaato/master
...
Add ability to tag volumes on creation
2017-10-12 12:56:25 -07:00
dbb3c76032
Remove redundant step and its usage
...
StepTagEBSVolumes is no longer needed, since this functionality is now
taken over by StepRunSourceInstance and StepRunSpotInstance. So remove
this functionality from the codebase.
2017-10-12 21:40:21 +02:00
ae455bff99
add debugging help if ec2-upload-bundle fails
2017-10-05 17:33:07 -07:00
2661fd7869
Move building of spot instances into its own step
2017-10-04 12:38:21 +02:00
939b44b4fd
Add logic to handle volumes of spot instances
2017-10-03 01:03:21 +02:00
cfd6b6fed5
Change EBS builder to do tag-on-creation
...
The EBS builder will now use the tag-on-creation pattern, so
that it's possible to restrict packer to only create volumes that are
properly tagged by using an AWS policy.
2017-10-03 00:13:02 +02:00
201e8c05a0
add ami name to output
2017-09-26 16:04:40 -07:00
8a8b51be97
Allow temporary security group to have source CIDR block explicitly provided
2017-09-26 00:57:56 +00:00
02cd6bc7f0
Merge pull request #5288 from hashicorp/fix3114
...
add token variable to upload bundle command template
2017-09-25 18:36:28 -05:00
4bc8e7de3d
add token variable to upload bundle command template
2017-09-25 16:35:53 -07:00
42dc1e4795
In Amazon builders, allow tag names to be interpolated like values
2017-09-25 02:24:23 +00:00
1adcce6046
Merge pull request #5284 from hashicorp/fix_5093
...
Allow granular modification of sriov and ena enhanced networking opti…
2017-08-29 14:28:42 -07:00
85ad1f58fb
include ena_support and sriov_support in chroot and instance docs
2017-08-29 09:36:06 -07:00
f19040f3aa
Merge pull request #5196 from cstuntz/aws-add-tags
...
Upgrade aws-sdk-go to 1.10.14, add tags at instance run time
2017-08-28 13:17:29 -07:00
2d4bc70d7b
use ami prefix to make it clear that these variables are amazon specific
...
add fixer, fixer tests
2017-08-28 11:21:27 -07:00
9e2e467b31
Allow granular modification of sriov and ena enhanced networking options in amazon amis. Maintain old functionality.
2017-08-25 14:49:53 -07:00
7da52e1f77
Merge pull request #5250 from hashicorp/repro_3399
...
make force_deregister work in all regions, not just original region.
2017-08-24 14:41:02 -07:00
8703937cde
Natural order of AMI artifacts
2017-08-24 20:57:12 +02:00
14b2d04332
make force_deregister work in all regions, not just original region.
2017-08-14 12:31:58 -07:00
cd84b17923
Fix building packer on GOOS=solaris
...
Update to golang/x/sys/unix is coming in the subsequent commit.
2017-08-14 10:34:06 -07:00
754c80d217
create default tags as well
2017-08-11 12:31:05 -07:00
db7f860d91
Adding tagging back to spot instances, after they're created
2017-08-11 10:43:05 -07:00
a924db9a79
Merge pull request #5228 from hashicorp/4653_dont_delete_snapshots
...
continue, not break
2017-08-08 15:07:01 -07:00
ef0a091720
continue, not break
2017-08-08 14:53:56 -07:00
968eb94b80
Merge pull request #5211 from hashicorp/4653_dont_delete_snapshots
...
use block device mappings to know whether a snapshot existed before p…
2017-08-08 14:31:38 -07:00
2d6028eb9a
use named loops instead of doDelete flag
2017-08-08 14:28:01 -07:00
e9ec705497
use block device mappings to know whether a snapshot existed before packer's current run. If yes, don't delete the unencrypted snapshot.
2017-08-08 13:59:55 -07:00
c760e1323f
don't panic if the communicator is none and the port is 0
2017-08-03 13:54:57 -07:00
c717765154
Removing tagging post instance launch
2017-08-02 09:29:47 -07:00
42444e58e6
Updating step_run_source_instance to add tags at instance start instead of adding them to running instance
2017-07-31 11:38:30 -07:00
12d43c98f7
test the deduplication code
2017-06-27 16:12:22 -07:00
5f92de6a39
fix panic that occurs when ami_block_device_mappings and does not explicitly contain the root volume
2017-06-27 13:17:45 -07:00
ac15b33d2b
Merge pull request #5029 from hashicorp/5007_instance_stop
...
add exponential backoff retry for stopping instance in amazon
2017-06-20 12:08:52 -07:00
f7a703dfb2
add pending to allowable states while waiting for ebs instance to stop
2017-06-20 10:55:23 -07:00
d706147423
add exponential backoff retry for stopping instance in amazon
...
retry only if the error is instancenotfound
2017-06-20 10:50:57 -07:00
febc65aa7c
try again to get region from metadata
2017-06-14 16:30:18 -07:00
8dae6b60c1
Merge pull request #4996 from hashicorp/mwhooker/4613
...
builder/amazon: Support Assume Role with MFA and ECS Task Roles
2017-06-13 17:40:09 -07:00
350e8bfe0d
we don't need to look for region in metadata.
...
Closes #4615'
2017-06-13 17:35:48 -07:00
94d7a4ce8d
post-processor/vagrant-cloud: try upload once
...
* fixes multiple uploads mentioned in #4973
* removed unused token code
2017-06-12 17:34:32 -07:00
4860d7179d
remove redundant log line
2017-06-09 13:00:08 -07:00
ae03dab920
Print in the output the security group name too.
2017-06-09 20:05:59 +01:00
a619759bf7
add support for profile
2017-06-09 11:24:30 -07:00
3fb4162660
remove code from bad merge
2017-06-09 11:07:29 -07:00
624aaa2067
bugfix
2017-06-09 11:01:27 -07:00
3ed7572525
remove cli_config
2017-06-09 10:59:50 -07:00
f637878822
with wrapping
2017-06-09 10:46:01 -07:00
23084fe171
dedupe
2017-06-09 10:41:58 -07:00
58e386827a
fix typo
2017-06-09 10:40:50 -07:00
15f80dc5ab
aws: Drop undocumented option `profile`
...
This was added in 883acb18fa
2017-06-09 10:37:54 -07:00
56c513088b
I think this was the intention
2017-06-09 10:34:49 -07:00
94854a26d9
fix go vet issue
2017-06-09 10:30:07 -07:00
d7e39b72b2
remove dead code
2017-06-09 10:30:07 -07:00
f106e60a7e
builder/amazon: Added MFA support
2017-06-09 10:28:31 -07:00
f55c3b9d34
builder/amazon: Support assume role with assume_role_arn
...
This supports assuming a role when using profile or static credentials.
2017-06-09 10:27:56 -07:00
3833d34829
builder/amazon: Cleaned up credential handeling
...
This properly handles:
- Preference between types of credential
- Assume role via ECS Task Role
2017-06-09 10:26:22 -07:00
769ff28e03
builder/ebssurrogate: Use correct devices for AMI.
2017-06-06 12:33:08 -07:00
11ba986abc
Merge pull request #4930 from hashicorp/fix4925
...
builder/amazon: don't try to delete extra volumes during clean up
2017-06-02 14:08:49 -07:00
1f4b532ed5
Merge pull request #4948 from hashicorp/kms_key_regions
...
Kms key regions
2017-06-01 13:30:31 -07:00
b8c2a5fd43
fix step initializer everywhere StepAMIRegionCopy is called
2017-06-01 09:28:17 -07:00
875745ab9b
one more test
2017-05-31 14:16:02 -07:00
1944f38985
update docs and clean up
2017-05-31 13:41:32 -07:00
5b35d199da
golang has different style than python
2017-05-31 12:27:45 -07:00
f9d7292566
builder/amazon regional KMS keys
2017-05-31 11:23:18 -07:00
cc309c0e5f
spelling fix
2017-05-26 01:03:11 -04:00
0e3469e913
spell fix
2017-05-25 18:49:45 -07:00
7174a7a3d5
New map: region_kms_key_ids, allowing custom encryption keys on a per-region basis. Also new tests.
2017-05-25 14:42:03 -07:00
77b4d47409
only delete snapshots which exist
2017-05-25 14:16:20 -07:00
c0b27dfa6f
don't try to delete extra volumes during clean up
2017-05-25 13:48:32 -07:00
1cf4754d80
correct ami_name error reporting
2017-05-25 13:02:36 -07:00
4abb541468
fix logging to clarify that encrypt_boot needs to be set, not encrypt, and fix typo
2017-05-24 16:39:36 -07:00
4137660b7a
fix ami name validation
2017-05-19 02:11:43 -07:00
ee5d13611f
update ssh client usage for new crypto/ssh version
2017-05-18 12:01:44 -07:00
45143bb6f4
add an option custom_endpoint_ec2 for amazon builder, add a condition if vpc_id is empty don't add the parameter to the aws call
2017-05-17 18:45:20 +02:00
0be5a28080
Fix issue 4693 - Derive vpc_id from subnet_id
...
In AWS we can derive the `VpcId` and AZ from the `SubnetId`, so now we do. In the config you can now only specify the `SubnetId`.
This fixes issue #4693 .
2017-05-15 13:46:05 -07:00
6f63881020
fixes a typo introduced in a previous change
2017-05-11 13:34:48 -07:00
a269bbc6fa
Fix issue 4875 - use retry logic when creating instance tags
2017-05-11 16:25:28 +01:00
80d6cd91fd
remove unneeded keypair var
2017-05-01 10:17:21 -07:00
602fd64c5d
builder/amazon: set flag to delete temporary keypair
2017-04-30 14:24:22 -07:00
da8c4004f0
builder/amazon: numbers are valid in ami name
2017-04-05 12:39:16 -07:00
3f6b5165f2
add affirmative test case for #4762
2017-04-04 22:08:09 -07:00
d9041bda0c
Improved the test for special character so that it doesn't get halted by less than 3 character check
2017-04-05 11:06:59 +10:00
7911cfa94b
Formatting as per make fmt
2017-04-05 11:02:23 +10:00
fdae6858c8
conforming to the standard for imports
2017-04-05 10:53:58 +10:00
df6337e8ab
Added AMIName validation (issue 4761)
2017-04-05 10:46:44 +10:00
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
cc11ec3566
check for a couple errors
2017-03-28 20:36:21 -07:00
35578d9ed1
remove unnecessary type conversions
2017-03-28 20:36:21 -07:00
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
0149f679de
Print instead of Printf with no dynamic first variable.
2017-03-28 20:36:20 -07:00
d1b20b3d9c
remove a bunch of dead code.
...
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
e4aa2a34ca
builder/amazon-chroot: nullable copy_files
...
Allow users to specify that they don't want any
files copied into the chroot by setting an empty
copy_files list
2017-03-24 13:51:47 -07:00
74c8c585f5
builder/amazon: report tag creation
2017-03-23 16:12:59 -07:00
bd76b7bb6f
builder/amazon: validate ssh key name/file
...
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.
When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
2017-03-13 13:14:18 -07:00
50d9546658
builder/amazon: set force_deregister to true on -force
2017-03-09 14:24:49 -08:00
2300b102b7
amazon: Step Region Copy crashing on device mapping
...
Closes #4635
2017-03-08 18:12:37 +01:00
9c027aa70b
Merge pull request #4601 from mitchellh/ebssurrogate-copy-ami
...
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
2017-02-27 10:47:34 -08:00
e856339309
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
...
As pointed out in the initial code review of #4351 , some of the steps
from the standard EBS builder were (intetionally) omitted. It turns out
that these actually are useful, and the original rationale for the
omission was wrong. Consequently, this commit adds in the following
steps:
- `StepPrevalidate`
- `StepTagEBSVolumes`
- `StepDeregisterAMI`
- `StepCreateEncryptedAMICopy`
- `StepAMIRegionCopy`
- `StepModifyAMIAttribute`
- `StepCreateTags`
We also fix the interpolation filter and documentation to reflect these
additions, though the majority were already documented and just not
functional.
2017-02-27 09:05:39 -06:00
1eec5bf058
builder/amazon-ebssurrogate: Exclude duplicate root volume
...
This commit removes the root volume from the list of launch block device
mappings passed to the image, since it is already passed in the form of
a snapshot (which is then configured to be the root device). Without
this commit, AMIs created using this builder have two root volumes
attached on launch.
2017-02-27 06:57:35 -06:00
fd1b00a0d1
use aws helper method
2017-02-26 19:33:34 -08:00
61976dfd86
Merge pull request #4578 from life360/enable_ena
...
Always set both SRIOV and ENA when Enhanced Networking is enabled
2017-02-26 19:31:22 -08:00
6a7c37beb6
builder/amazon-chroot: support encrypted boot volume
2017-02-26 17:48:13 -08:00
2cb9b32acf
don't attempt to delete non-existant key when using agent auth
2017-02-26 17:38:22 -08:00
f95514c120
fix ssh agent authentication
...
treat key name to empty string if it's not been set
by prior step.
2017-02-26 17:17:49 -08:00
1cc3cdf7b5
Always set both SRIOV and ENA when Enhanced Networking is enabled
...
Set SriovNetSupport to "simple". As of February 2017, this applies to C3, C4,
D2, I2, R3, and M4 (excluding m4.16xlarge).
Set EnaSupport to true. As of February 2017, this applies to C5, I3, P2, R4,
X1, and m4.16xlarge.
2017-02-25 07:16:35 -08:00
33a4c2e13b
Change EC2 WindowsPasswordTimeout to 20 minutes
...
10 minutes is often exceeded when using a custom source AMI
which has been sysprepped.
2017-02-24 11:08:17 +00:00
635aeb765b
amazon/ebssurrogate: Add New Builder
...
This commit adds a new type of builder which builds an AMI based on a
snapshot of an EBS volume which is provisioned on a "surrogate"
instance. This can be used to build operating system images from
scratch, but unlike the `chroot` builder does not require running from
an AWS EC2 instance.
2017-02-21 18:38:19 -06:00
c9259d116f
builder/amazon-ebsvolume: Fix interpolation of block_device
2017-01-26 21:27:36 +01:00
de7388fa0a
builder/amazon-ebsvolume: Fixed interpolation of tags
2017-01-25 19:40:43 +01:00
6e891cf682
Fixed botched merge and review comments
2017-01-22 21:57:23 +01:00
ba9cae5078
builder/amazon: Add SourceAMI and BuildRegion template
...
Added {{ .SourceAMI }} and {{ .BuildRegion }} template values availible
in `ami_description`, `run_tags`, `run_volume_tags`, `tags`, and
`snapshot_tags`.
2017-01-21 20:39:58 +01:00
fc30f6cc0a
log tag creation.
...
closes #4427
2017-01-19 12:00:41 -08:00
56b5e97bf4
verify given security group
2017-01-18 15:25:31 -08:00
b265d2614f
builder/amazon: fix when using security_group_id
...
If `security_group_id` was specified with a group that didn't exist, packer
would go into an infinite loop waiting for it. We shouldn't make assumptions
about the status of explicitely set security groups, so let's just error out
right away if we can't find it.
2017-01-18 15:11:52 -08:00
f5bf588393
tag all volumes
2017-01-18 11:34:46 -08:00
800351b7ca
fix panic and don't print each tag we add.
2017-01-18 11:34:36 -08:00
d9186dc8cf
add proper error handling for tagging source instance
2017-01-18 14:02:10 +01:00
ae016a1f25
simplify code flow: skip the step if no run_volume_tags provided
2017-01-18 13:03:05 +01:00
a65af51a4b
apply source instance default "Name" tag only if it's not provided in run_tags
2017-01-18 12:55:18 +01:00
36d8a1df1d
use common.ConvertToEC2Tags to apply tags to source EBS volumes, change Say message
2017-01-18 12:52:59 +01:00
aa70c82ec8
use ConvertToEC2Tags to apply tags to source instance, add Say message
2017-01-18 12:50:20 +01:00
c1f5545986
compress pr #4395
2017-01-13 11:42:20 -08:00
9435fa62e3
Output error causing ebs volume deletion failure
...
When an ebs volume fails to delete, Packer reports that there
was an error deleting the volume and the volume id. But it doesn't
give you the details of what that error is. This commit adds the
error reported back to the standard output.
2017-01-13 15:33:47 +00:00
26fe9cf339
builder/amazon: Fix crash in amazon-instance
...
Closes #4360
2017-01-06 15:17:02 +01:00
377f451a9e
it's InvalidGroup
2017-01-05 16:56:49 -08:00
e54605c120
Properly wait for security group to exist.
...
Adds check for `InvalidGroupID.NotFound` in addition to
`InvalidSecurityGroupID.NotFound`.
Uses aws's `waiter` for clarity.
2017-01-05 15:20:28 -08:00
aef6e0e93f
Merge pull request #4304 from dave2/gh-4277
...
Querying EC2 security groups should report unexpected errors
2017-01-04 10:53:28 -08:00
e31d75eca8
Quick fix for issue #4340
2016-12-29 09:16:52 -07:00
4b1e014be8
builder/amazon: Crashes when multiple EBS vols are used
...
If you use a new EBS vol (which hasn't any snapshot) Packer crashes when
creating the AMI.
Closes #4303
2016-12-21 15:37:08 +01:00
ae5730c5a5
Querying EC2 security groups should report unexpected errors
...
As noted in #4277 , we don't report any errors from the loop waiting for
a security group to exist. Instead, we should accept 'errors' which result
from the group not yet existing, and report errors which are actual issues
the user needs to resolve (eg, IAM permissions are incorrect).
Closes #4277
2016-12-21 11:45:12 +13:00
e4f6eaae9b
Merge pull request #4231 from artburkart/force-delete-snapshot-patch
...
Fixes acceptance test for PR #4223
2016-12-17 11:43:26 -08:00
Matthew Hooker
Mark Meyer
SwampDragons
Mark Meyer
Zanetti, David
Łukasz Kostka
Sean Chittenden
cstuntz
Constantin Bugneac
Rickard von Essen
Jason Ramey
Rémi Jouannet
Paul Thrasher
Ben Fagin
luis-silva
Craig Barr
James Nugent
Aaron Stone
Richard Owen
Roman Zhuzha
Richard Moore
Travis Harrington