Megan Marsh
e670eed315
Add new option, nvme_device_path, so that we can properly mount nvme block devices.
2018-05-23 09:16:40 -07:00
Paul Meyer
97652b62e5
Update CHANGELOG.md
2018-05-22 11:28:00 -07:00
Paul Meyer
3dd6bf5781
Merge pull request #6285 from harijayms/devicelogin
...
Devicelogin Support for Windows and not requiring object ID
2018-05-22 11:26:47 -07:00
James Nugent
d142055ab1
build: Remove old versions of Go on Travis CI
...
There is no real value in continuing to build against versions of Go
which are not the latest (1.10.2 right now). This can easily be
expressed in the `.travis.yml` file as `1.x`, to mean the latest version
in the Go 1 series, which is (presumably) what is being used for
releases.
Keeping older versions around is causing spurious CI failures, and
increases the cycle time to feedback for pull requests: see
hashicorp/packer#6265 for an example of this.
2018-05-22 11:16:25 +04:00
Hariharan Jayaraman
a13a2511f9
Added additional error message if we failed to parse token
2018-05-21 22:20:36 -07:00
Hariharan Jayaraman
1bd7aa534e
Addressed PR feedback
2018-05-21 21:38:41 -07:00
M. Marsh
a8b6a04dda
Merge pull request #6194 from hashicorp/fix_6176
...
allow user to mount entire block device in chroot builder
2018-05-21 15:28:18 -07:00
Megan Marsh
7e9a653da7
use testify instead of homegrown string compare
2018-05-21 15:26:57 -07:00
Megan Marsh
d1e31c0f23
use if/else to clarify code
2018-05-21 15:19:27 -07:00
Megan Marsh
969201a2d4
handle minor shell-local PR suggestions and corrections
2018-05-21 14:56:44 -07:00
Megan Marsh
1fdf763d0f
fancier logging
2018-05-21 11:25:51 -07:00
Hariharan Jayaraman
8a3e599cad
Added text to point out two device auth
2018-05-21 11:05:59 -07:00
Hariharan Jayaraman
a54fcc9efe
missed doc fixes to remove referece for object_id, note keeping the command for now for how to get object ID for older releases
2018-05-19 13:16:57 -07:00
Hariharan Jayaraman
da67df6d03
space fix
2018-05-18 21:17:19 -07:00
Hariharan Jayaraman
4992429e8c
Minor comment fixes
2018-05-18 17:34:01 -07:00
Hariharan Jayaraman
00e809cb7e
Refactored the change into a new function
2018-05-18 15:21:49 -07:00
Hariharan Jayaraman
ea9b2a8b5f
review feedback
2018-05-18 12:09:42 -07:00
M. Marsh
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
...
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
M. Marsh
cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
...
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
Hariharan Jayaraman
3ca4a7208f
Updated Samples and added a windows quick start as well
2018-05-18 08:12:43 -07:00
Hariharan Jayaraman
667113338a
missed formating
2018-05-18 01:41:00 -07:00
Hariharan Jayaraman
7f2277676a
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:34:12 -07:00
Hariharan Jayaraman
77fe1bffe4
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:25:19 -07:00
Hariharan Jayaraman
de1783240f
Updates to remove space changes
2018-05-18 00:53:44 -07:00
Hariharan Jayaraman
91eed4da52
trim right of the keyvault url
2018-05-18 00:44:25 -07:00
Hariharan Jayaraman
df5cc234fc
updates
2018-05-18 00:39:57 -07:00
Hariharan Jayaraman
1f46271a6b
Ensuring device login works for Windows build
2018-05-18 00:32:01 -07:00
M. Marsh
2764058eef
Merge pull request #6280 from WaaZaa666/master
...
Fixing #6267 , multiple hyper-v disks
2018-05-17 08:19:25 -07:00
WaaZaa666
b747877222
Fixing #6267 , multiple hyper-v disks
2018-05-17 14:50:18 +02:00
Christopher Boumenot
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
...
Async delete Resource Group
2018-05-16 15:13:09 -07:00
localghost
6c7aa724eb
Fix tests after merging with master.
2018-05-16 22:43:30 +02:00
localghost
c33ca8ce64
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-16 22:14:12 +02:00
localghost
11f2b1ec24
Merge remote-tracking branch 'origin/master' into ansible_local_playbook_files_update
2018-05-16 21:54:39 +02:00
localghost
81db142c8a
Unify handling PlaybookFile and PlaybookFiles.
2018-05-16 21:54:19 +02:00
David Tesar
f81492ef9d
Add back last step comment
2018-05-16 15:35:14 -04:00
David Tesar
f793d219b2
Only show Windows Sysprep code with validation
...
The first example completes successfully, but will not let you know that the image is not actually able to be deployed to a VM.
2018-05-16 15:29:54 -04:00
DanHam
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
.
2018-05-16 13:52:00 +01:00
DanHam
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
.
2018-05-16 12:55:59 +01:00
Hariharan Jayaraman
784c7973c2
minor updates to docs
2018-05-15 11:45:24 -07:00
Hariharan Jayaraman
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
Christopher Boumenot
0d785cca75
Merge pull request #6270 from jamielennox/doc-capture-container-name
...
[Azure] Don't mention capture_container_name in required
2018-05-15 09:32:13 -07:00
DanHam
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
DanHam
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
DanHam
a9aa9908cd
Document use of T2 Unlimited for enabled Amazon builders
2018-05-15 12:25:06 +01:00
DanHam
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
DanHam
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
DanHam
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
DanHam
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00