6004 Commits

Author SHA1 Message Date
Megan Marsh
b54b778572 major refactor of the step_run. Splits step into two major parts:
- generating defaults
- overriding defaults with user args

The default generation has been shuffled around some, in order to
make sure that any changes to a specific arg happen in one place
to make it easier to reason about those args. Related args have
been moved close to one another.

The deviceArgs and driveArgs were overly complex after several
layers of copy/paste modifications. Careful pruning reduced the
layers of logic and repeated code, to help make it easier to reason
about.
2020-10-07 15:09:45 -07:00
Patrik
d4d78feed2
feat(scaleway): get image by label if not an UUID ()
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-10-07 16:04:00 +02:00
abarbare
a478bf6f37
fix: update scaleway website documentation () 2020-10-07 12:02:08 +02:00
Ricardo Rosales
809f38be3a
[azure-chroot] Updating parameter exlude_from_latest to exclude_from_latest () 2020-10-07 11:08:33 +02:00
Jeff Wong
cd3bdc9e38
REFACTOR: do not pass comm ref through statebag 2020-10-06 22:45:19 -07:00
Jeff Wong
fdda18e392
Use Trilean for boolean value, and allow for missing values for defaults 2020-10-06 17:24:45 -07:00
Jeff Wong
977022fb35
Go format 2020-10-06 16:53:29 -07:00
Jeff Wong
a26e3e6887
[Proxmox] FIX: tests, add required iso_file to basic iso config tests 2020-10-06 16:04:18 -07:00
Megan Marsh
61c6085651
final fix to make service account impersonation work with iap tunnels () 2020-10-06 15:34:06 -04:00
Megan Marsh
7ee9a4b638
Merge pull request from upodroid/google-impersonation
GCP: add service account impersonation
2020-10-06 11:32:03 -07:00
Adrien Delorme
f6d362d392 skip Ctx 2020-10-06 11:54:04 +02:00
Adrien Delorme
25d7e7ce17 fix tests 2020-10-06 11:48:24 +02:00
Adrien Delorme
5b3ff89cb0 proxmox: move iso.storageConfig to common.storageConfig 2020-10-06 11:42:49 +02:00
Adrien Delorme
1260e123aa proxmox.Config: remove mapstructure:",squash" tag 2020-10-06 11:14:09 +02:00
Adrien Delorme
b2be255057 Merge remote-tracking branch 'origin/master' into pr/featheredtoast/9626-1 2020-10-06 11:11:04 +02:00
Megan Marsh
deb08409f1
Merge pull request from OblateSpheroid/GH6844
Feat (oracle/oci): allow specifying image compartment
2020-10-05 15:02:23 -07:00
Megan Marsh
721cbac645
Merge pull request from hashicorp/fix_9995
Make shell-local post-processor return copy of previous artifact
2020-10-05 13:00:51 -07:00
js-g
c892f0582b GH#6844: allow image compartment to be specified 2020-10-02 22:30:52 -04:00
Megan Marsh
157b5cdc28
Merge pull request from kostasns/oci_boot_volume
Allow to specify boot volume size in OCI builder
2020-10-02 11:04:05 -07:00
upodroid
b1c74f9df0 Merge branch 'master' of github.com:hashicorp/packer into google-impersonation 2020-10-01 23:19:15 +01:00
upodroid
f13099edfb rebase the branch 2020-10-01 20:39:06 +01:00
Kostas
8c07e21be8 update hcl2spec 2020-10-01 09:06:22 +03:00
Kostas
18c4f271ac rename variable; add docs 2020-10-01 09:01:51 +03:00
Marin Salinas
49e4d83cd7 refactor: remove oapi references in bsusurrogate builder 2020-09-30 10:39:24 -05:00
Marin Salinas
aa3ec3fd0f refactor: change chroot builder to new SDK 2020-09-30 10:38:31 -05:00
Marin Salinas
c0c0f003f9 refactor: fix bsu builder to accept proxy 2020-09-30 10:37:41 -05:00
Marin Salinas
d813c3647d refactor: change bsuvolume builder to new SDK 2020-09-30 10:37:09 -05:00
Braunson
b2047bd938
Put the correct AzureTags type in StateBag ()
Azure expects the tags format to use a pointer to the string for the map value.
The configuration from the builder is not a pointer so when storing in the state bag for
reference in later execution we convert it when creating the StateBag.

Fixes  and .

* Use the MapToAzureTags helper and error check in resource group creation

* Added test case for tag values not using a pointer

* test/azure/arm: Add test to verify tags stored in state

* test/azure/arm: Add azure_tags to existing acceptance test for Linux

Test Before Fix
```
--- FAIL: TestBuilderAcc_ManagedDisk_Linux (1.81s)
panic: interface conversion: interface {} is map[string]string, not map[string]*string [recovered]
        panic: interface conversion: interface {} is map[string]string, not map[string]*string
FAIL    github.com/hashicorp/packer/builder/azure/arm   1.822s

```

Test After Fix
```
2020/09/29 17:23:03 ui: ==> test: Resource group has been deleted.
--- PASS: TestBuilderAcc_ManagedDisk_Linux (517.41s)
    PASS
    ok      github.com/hashicorp/packer/builder/azure/arm   517.426s
```

Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-09-30 09:55:46 -04:00
Kostas
72166febee allow to specify boot volume size 2020-09-30 13:31:37 +03:00
Megan Marsh
4c0ac6917e switch to using aws base config, which means we're using code tested and maitnained by the terraform crowd. 2020-09-29 14:26:38 -07:00
sylviamoss
c8874c9382 improve docker_tag cast to avoid failures 2020-09-29 14:41:43 +02:00
Lik
bdb1c47532
Pass QemuImgArgs to stepConvertDisk () 2020-09-28 11:43:20 +02:00
sylviamoss
aa9c162c60 improve docker_tags artifact state read 2020-09-28 10:52:28 +02:00
sylviamoss
e758891878 make shell-local post-processor return copy of previous artifact 2020-09-25 16:53:59 +02:00
Roman Tomjak
b6ff793496
builder/proxmox: add support for io threads () 2020-09-25 14:59:54 +02:00
Niels Pardon
a2ceb54b1a
Add support for external source image url ()
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
2020-09-25 14:59:00 +02:00
Niels Pardon
29d23c13d0
Add additional debugging for OpenStack ()
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
2020-09-25 13:16:53 +02:00
Sylvia Moss
96e3def294
Add pause_before_ssm config to pause before establishing the Session Manager session () 2020-09-25 10:19:19 +02:00
Megan Marsh
108455a7dc
Merge pull request from hashicorp/tools_upload_path
allow user to set tools upload path
2020-09-24 10:41:08 -07:00
Megan Marsh
d66b358100
Merge pull request from hashicorp/b-amazon-ssm-infinite-loop
amazon/ssm_driver: Update log polling logic
2020-09-24 09:55:39 -07:00
Megan Marsh
8d0058dad6 allow user to set tools source path 2020-09-24 09:51:01 -07:00
Wilken Rivera
2f2b5683a2 amazon/ssm_driver: Update log polling logic
This change checks for closed iochans related to the log polling
function and will break out of the loop when both channels are closed.
Which is an indicator that the SSM session has been terminated by some
external process. This fixes an issue where Packer hangs, due to the
infinite loop, when an SSM session is killed outside of Packer.

Related to 
2020-09-24 10:19:37 -04:00
Adrien Delorme
654fade0a9
azure arm: make map[string]*string => map[string]string to simplify things ()
* azure arm: make map[string]*string => map[string]string to simplify things
* go generate ./builder/azure/...
* tests !

fix 
2020-09-24 12:19:26 +02:00
Megan Marsh
e41100290e
Merge pull request from hashicorp/assume_role
Implement assume_role for Packer.
2020-09-23 13:44:45 -07:00
Megan Marsh
429d431365 Implement assume_role for Packer. This functionality is copied shamelessly
from the Terraform AWS provider
2020-09-23 13:18:26 -07:00
Megan Marsh
9170204a93
Merge pull request from hashicorp/implement_9868
Add floppy_files, cd_files, and iso_paths to vsphere-clone
2020-09-23 11:37:17 -07:00
sylviamoss
75d649e051 add step_remove_cdrom tests 2020-09-23 12:09:33 +02:00
sylviamoss
2de3f2755a add step_remove_floppy tests 2020-09-23 12:00:28 +02:00
sylviamoss
7cd6ee2b3b add FindDatastore driver test 2020-09-22 17:42:35 +02:00
sylviamoss
b881a59bc8 refactor vcenter simulator setup 2020-09-22 16:48:53 +02:00