Commit Graph

561 Commits

Author SHA1 Message Date
Megan Marsh 5055fa66aa
Merge pull request #5987 from mcandre/multibyte-scancodes
send multibyte scancodes accurately to virtualbox
2018-03-12 16:23:41 -07:00
Megan Marsh 2a88672cd9 add test for modifyer keypress commands 2018-03-12 15:08:30 -07:00
Andrew Pennebaker 1d48812b34 fix later commands overwriting earlier commands 2018-03-09 20:17:43 -06:00
Andrew Pennebaker f305a2f4c2 send multibyte scancodes accurately to virtualbox 2018-03-07 10:59:02 -06:00
SwampDragons 7d5d62d748
Merge pull request #2906 from arizvisa/GH-2377
Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme
2018-02-05 09:53:47 -08:00
Matthew Hooker 8cd403425e
test fixes WIP 2018-01-24 17:09:17 -08:00
Matthew Hooker 5d48d658b4
Wire context through misc steps
Some steps actually need to pass the context around, so let's create
a ctx variable and pass it.
2018-01-24 17:09:17 -08:00
Matthew Hooker 7a189a83a1
fix imports
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker a831d522be
change run signatures
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.

`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker 366dc3da0a
move multistep imports to helper.
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
Matthew Hooker ebe995c0ff
run goimports 2018-01-22 17:21:10 -08:00
Ali Rizvi-Santiago c17f827e1d Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols. 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago 3cf448f6ec Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path. 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago 5d97b105a8 Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist. 2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago e940dc7e42 Fixed a config_test that should've failed but didn't because ftp:// uris work now. HeH! 2018-01-16 13:37:31 -06:00
SwampDragons fb730cf521
Merge pull request #5761 from hashicorp/fix_5713
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-11 11:48:26 -08:00
Megan Marsh 3ace5bb91b simplify FileExistsLocally 2018-01-10 16:11:17 -08:00
Megan Marsh 216c44b153 fix FileExistsLocally 2018-01-09 15:47:07 -08:00
Megan Marsh e164621bfe log line to help prevent confusion when guest_additions_url is set from env variable that is empty 2018-01-05 09:19:38 -08:00
Megan Marsh 4f3b470804 add helper function to manage validation of filepaths created using DownloadableURL 2018-01-03 16:53:47 -08:00
Ali Rizvi-Santiago 4fcd542d0c Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables. 2018-01-02 21:09:41 -06:00
Megan Marsh 6756df9510 use url library instead of parsing string naiively 2017-11-13 12:57:53 -08:00
Megan Marsh 771349e58c fix error message 2017-11-13 12:52:47 -08:00
Megan Marsh 764be03876 didn't mean for this error message to get changed 2017-11-13 12:42:57 -08:00
Megan Marsh 0d18de2942 do validation in vmx config stage 2017-11-13 12:42:57 -08:00
Matthew Hooker fb098d045d
builder/virtualbox-ovf retry removing VM.
moves behavior from builder/virtualbox-iso into the driver
so it is automatically available to callers.
2017-10-25 10:27:33 -07:00
SLAZ666 f6bb79784f Add option keep_registered to virtualbox-ovf builder 2017-09-13 15:37:26 +02:00
Matthew Hooker 94d7a4ce8d
post-processor/vagrant-cloud: try upload once
* fixes multiple uploads mentioned in #4973
* removed unused token code
2017-06-12 17:34:32 -07:00
Matthew Hooker ab81b3ef7d Merge pull request #4699 from BenPhegan/virtualbox_sata_port_count
Add configuration to virtualbox-iso to allow sata port count configuration
2017-06-05 15:21:12 -07:00
Matthew Hooker 0c116981ab Merge pull request #4960 from rickard-von-essen/issue-4959
virtualbox: Don't add portforwarding if comm = none
2017-06-02 13:15:43 -07:00
Rickard von Essen 31b93a3026 virtualbox: Don't add portforwarding if comm = none
Closes: #4959
2017-06-02 21:58:34 +02:00
JD Friedrikson a0052fdb68
Specify InsecureIgnoreHostKey for HostKeyCallback
[A recent breaking change upstream in Golang's crypto
library](e4e2799dd7)
has broken SSH connectivity for a few builders:

```
==> qemu: Waiting for SSH to become available...
2017/05/20 16:23:58 ui: ==> qemu: Waiting for SSH to become available...
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 [INFO] Attempting SSH connection...
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 reconnecting to TCP connection for SSH
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 handshaking with SSH
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 handshake error: ssh: must specify HostKeyCallback
2017/05/20 16:23:58 packer: 2017/05/20 16:23:58 [DEBUG] SSH handshake err: ssh: must specify HostKeyCallback
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 [INFO] Attempting SSH connection...
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 reconnecting to TCP connection for SSH
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 handshaking with SSH
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 handshake error: ssh: must specify HostKeyCallback
2017/05/20 16:24:05 packer: 2017/05/20 16:24:05 [DEBUG] SSH handshake err: ssh: must specify HostKeyCallback
```

Specifying HostKeyCallback as insecure should make things work again
and would make sense for packer's use case.
2017-05-20 16:17:04 -04:00
Ben Phegan c4b8e8e5df Merge branch 'master' into virtualbox_sata_port_count 2017-05-01 09:23:05 +10:00
Matthew Hooker 81522dced0
move packer to hashicorp 2017-04-04 13:39:01 -07:00
Matthew Hooker 4fcbf75da9
s/non existent/nonexistent/ 2017-03-29 12:38:33 -07:00
Matthew Hooker 35578d9ed1
remove unnecessary type conversions 2017-03-28 20:36:21 -07:00
Matthew Hooker 79287d7e47
simplify some code 2017-03-28 20:36:20 -07:00
Matthew Hooker 230079f73a
spell fixes 2017-03-28 20:36:19 -07:00
Matthew Hooker 35480e21b2
fix typo 2017-03-24 11:56:49 -07:00
Matthew Hooker 0ad6b169bc
builder/virtualbox: retry removing floppy controller 2017-03-23 23:58:23 -07:00
Ben Phegan 0c777a1d63 Fix for DriverMock not implementing Driver 2017-03-23 12:11:19 +11:00
Ben Phegan 67eb600c08 Add sata_port_count so that a SATA controller can be created with more than 1 port. The default of prevents additional drives being added. Default preserved if not overridden. 2017-03-22 23:09:25 +11:00
Matthew Hooker 68e2b150cd
builder/virtualbox: allow skipping upload of version file 2017-03-16 18:14:11 -07:00
Matthew Hooker 84fc62f6b2 Merge pull request #4496 from mitchellh/vmrmguest2
builder/virtualbox: remove guest additions
2017-02-03 23:14:35 -08:00
Matthew Hooker 70af3d8148 Merge pull request #4497 from mitchellh/f-clickable-links
Make rdp and vnc links clickable by adding the protocol
2017-02-02 12:41:59 -08:00
Chris Bednarski facf27ceeb Make rdp and vnc links clickable by adding the protocol 2017-02-02 01:55:28 -08:00
Matthew Hooker e9e3215c38
builder/virtualbox: remove guest additions 2017-02-02 00:47:56 -08:00
Matthew Hooker 228bc9cfd3
use driver delete method 2017-02-01 23:57:45 -08:00
Matthew Hooker 22d1322bd9
always check for an error first when walking a path 2017-01-26 16:32:21 -08:00
Matthew Hooker d2e59e4e92
set PACKER_HTTP_ADDR env var when available.
If using a builder that has an http server set up for file transfer,
expose the connection info to the shell provisioner through the environment
variable PACKER_HTTP_ADDR.

Closes #2869
2017-01-16 23:19:52 -08:00
Matthew Hooker a3da92dc97 Merge pull request #4339 from DanHam/gh-4131
Add option to skip export of installed VM for vbox ISO & OVF builders
2017-01-10 15:08:15 -08:00
Rickard von Essen 85cf00069f Merge pull request #4294 from legal90/iso-target-extension
Add "iso_target_extension" option for all local *-iso builders
2017-01-04 13:48:28 +01:00
DanHam ac769be49a
Pause between each boot command element rather than each char with -debug
Fixes #4332
2016-12-31 11:57:11 +00:00
DanHam 0ac071b6e7
Add option to skip export of installed VM for Virtualbox ISO & OVF builders
Closes #4131
2016-12-29 13:19:59 +00:00
DanHam 686ec1866e
vbox builders now need to explicitly set WinRMPort for StepConnect
Aligns vbox builders with changes to helper/communicator/step_connect.go
introduced by PR #2576

Fixes #4310
2016-12-23 15:55:10 +00:00
Matthew Hooker 2e358ae4a1 Revert "builder/virtualbox: group keyboard codes" 2016-12-21 15:12:17 -08:00
Matthew Hooker ee86dc87fd
fix broken test 2016-12-20 18:10:58 -08:00
Matthew Hooker aa177de54b
add test for #4247 2016-12-20 17:51:47 -08:00
Mikhail Zholobov 57d07f227a
Add "iso_target_extension" option for all local *-iso builders
This option allows to set the extension of the ISO file after download.
Defaults to "iso". It makes sense for building Mac OS X guests, where the
bootable image is actually a DMG, not an ISO.
In particular, it is important for "parallels-iso" builder to set the right extension.
2016-12-17 12:50:30 +02:00
Brian Ruff 038787ed48 Refactored to gather scan codes into groups to be sent to VirtualBox's console. 2016-12-04 11:28:18 -07:00
Arthur Burkart 337856811e Implements OVA downloads w/local checksum support
Presumably, it is convention to store a manifest file with checksums
inside the OVA, so remote checksum support was not implemented.
2016-11-28 15:01:37 -05:00
Rickard von Essen 96e9a8e6e9 Removed default value for ssh_username 2016-11-17 22:30:34 +01:00
Matthew Hooker d920b3fbf4 run gofmt 2016-11-01 14:08:04 -07:00
Arthur Burkart 4a00ffeea2 Closes #3999 - Support VirtualBox Trim/Discard
Adds a couple options to enable/disable the `--nonrotational` and
`--discard` flags during `VBoxManage storageattach` command execution
2016-10-17 08:52:28 -04:00
Rickard von Essen 3c8dabba9e Fixed formatting 2016-10-11 23:43:50 +02:00
Rickard von Essen 5e96709ee9 Merge pull request #2919 from arizvisa/floppy-recurse
Added an option for copying entire subdirectories via floppy_dirs (supplants floppy_files)
2016-10-08 16:51:16 +02:00
Matthew Hooker b7e14c4354 Merge pull request #3952 from MikeStankavich/f-virtualbox-post-shutdown-delay
Add VirtualBox post shutdown delay to address floppy controller delet…
2016-10-03 16:23:02 -07:00
Matthew Hooker 127142215a Merge pull request #3954 from emo3/f-keepreq-vb
added functionality like vm
2016-10-03 12:55:34 -07:00
Ed Overton 1adb0a5fc3 added functionality like vm 2016-10-03 15:11:21 -04:00
Mike Stankavich a187b1cf92 Add VirtualBox post shutdown delay to address floppy controller delete error per issue #2401 2016-10-02 13:12:40 -05:00
Rickard von Essen 3ad7f067ab Merge pull request #2784 from orivej/fix-ssh-port-max
Make ssh_host_port_max an inclusive bound to agree with documentation
2016-10-02 00:12:37 +02:00
Rickard von Essen 29ae078326 Added missing virtualbox floppy_dirs 2016-10-01 09:05:10 +02:00
Rickard von Essen 06e3539ffa Merge pull request #3767 from taliesins/ExtendScanCodes
Add support for ctrl, shift and alt keys and using them as key modifier.
2016-09-20 21:36:46 +02:00
Orivej Desh 6762965696 Add -on-error command line argument to allow preserving artifacts on builder errors
Resolves #409
2016-09-16 12:15:00 +00:00
Rickard von Essen 5cbc36103e Merge pull request #3756 from ricardclau/floppy_check
Test floppy disks actually exist
2016-09-12 08:05:16 +02:00
Lamoni Finlayson d02b106a16 Fix for issue #2972 - Implemented ssh_host for virtualbox builders (#3617) 2016-08-24 18:30:26 +02:00
Taliesin Sisson a87ad05866 Add support for ctrl, shift and alt keys.
Add support for using ctrl, shift and alt as key modifiers. So you can now achieve ctrl+c by using "<leftCtrlOn>c<leftCtrlOff>".

Updated documentation for new key stroke tokens.
2016-07-31 19:05:10 +01:00
Ricard Clau acededfc6e tests actually test the floppies 2016-07-27 21:59:21 +01:00
Ian Duffy 9ec319e296 Allow configurable VNC bind IP for VirtualBox builders
Signed-off-by: Ian Duffy <ian@ianduffy.ie>
2016-05-23 14:24:16 +01:00
Sean Chittenden 3ca4782b56
Pause between boot_commands when debugging a Virtualbox build
When debugging a build (or maintaining an existing packer file), teach `packer build -debug` how to step through individual `boot_command`s in order to triage the packer file.
2016-05-17 04:03:45 -04:00
James Bishopp bd8fb014c4 Removed ssh_key_path
- removed backwards compatibility code
- ensured key usage came from SSHPrivateKey configuration
- changed tests to use private_key
2016-02-12 17:24:42 -08:00
Chris Bednarski 4458de4ea0 Reformat 2016-02-11 23:53:40 -08:00
Ian Duffy c4b64eb2c7 Closes #2637 - VRDP support for the virtualbox plugin
Signed-off-by: Ian Duffy <ian@ianduffy.ie>
2016-02-11 14:38:24 -08:00
Chris Bednarski 24dc798cfb Revert "Prevalidate Hardware Specs on Linux"
This reverts commit eda84cb2d3.
2016-02-02 12:41:43 -08:00
Chris Bednarski ffb85f6ea5 Merge pull request #3096 from grubernaut/f-resource-limits
Prevalidate Hardware Specs on Linux
2016-01-25 21:06:14 -08:00
Jake Champlin eda84cb2d3 Prevalidate Hardware Specs on Linux
Prevalidates hardware resources on Linux platforms for Virtualbox and
VMware builders. This is currently only available on Linux, as enabling
for both Darwin and Windows platforms, relies on cgo bindings that would
prevent effective cross-compilation.

Packer will now fail to build and validate templates if the template is
requesting that the VM to be created would allocate more system
resources than the host system has available.

This _however_ doesn't catch parallel builds that overflow the hosts
resources, will probably still need a better error message for VM's
failing to boot in that case.

Example Outputs:

```
$ $GOPATH/bin/packer build -debug ./vmware-iso.json
Debug mode enabled. Builds will not be parallelized.
vmware-iso output will be in this color.

2 error(s) occurred:

* Unavailable Resources: RAM - Requested - 204800000MB - Available 21721MB
* Unavailable Resources: Disk - Requested - 4000000000MB - Available 76701MB
```

```
$ $GOPATH/bin/packer build -debug ./vbox-iso.json
Debug mode enabled. Builds will not be parallelized.
virtualbox-iso output will be in this color.

2 error(s) occurred:

* Unavailable Resources: RAM - Requested - 10240000MB - Available 21721MB
* Unavailable Resources: Disk - Requested - 1000000000MB - Available 76701MB
```
2016-01-21 18:19:11 -05:00
Chris Bednarski db0e098800 Merge pull request #2750 from rickard-von-essen/issue-2743
Fixes #2743: Change log messages for step_forward_ssh
2016-01-21 13:28:44 -08:00
Mark Peek 7f149e595d Refactor http server config into common 2015-11-01 14:45:47 -08:00
Mark Peek cdcffecc2d Refactor builder ISO options
The ISO builders (parallels, qemu, virtualbox, and vmware) had too
much common code which needed to be maintained separately. This change
moves that code to a common ISO configuration.
2015-10-20 16:27:47 -07:00
Mark Peek e9657e6a9f Merge pull request #2642 from oliviertremblay/master
Make TargetPath customizable
2015-10-20 12:11:13 -07:00
Mark Peek e5a713ff01 Alternative fix for #2641: make random script name actually random 2015-10-11 13:31:09 -07:00
Orivej Desh 46d687d5ad Make ssh_host_port_max an inclusive bound to agree with documentation 2015-09-29 03:09:38 +00:00
Rickard von Essen e4dc543cae Fixes #2743: Change log messages for step_forward_ssh
Changed the log messages and changed the m name of the
VirtualBox builder NAT rule name from packerssh to
packercomm.
2015-09-17 13:43:08 +02:00
Olivier Tremblay f301a6454d Added documentation, renamed config param to iso_target_path 2015-08-20 07:37:24 -04:00
Olivier Tremblay 223e35fc65 Makes StepDownload's TargetPath customizable.
I exposed TargetPath as a config file option "target_path". I don't like
the name, but it follows the naming convention. The purpose of TargetPath
stands unmodified, and it enables a fair amount of customization.
2015-07-28 07:45:02 -04:00
Lorenzo Villani 7e64e90670 Use --portcount on VirtualBox 5.x 2015-07-13 20:32:45 +02:00
Mitchell Hashimoto 93bb0d86af builder/virtualbox: fix default names 2015-06-22 09:25:15 -07:00
Mitchell Hashimoto 84189f7a28 builder/*: properly save interpolation context 2015-06-22 09:22:42 -07:00
Mitchell Hashimoto d600456487 builder/virtualbox: fix interpolation weirdness 2015-06-22 09:17:09 -07:00
Mitchell Hashimoto 54e081d5af builder/virtualbox: only remove output dir after check 2015-06-22 09:09:12 -07:00
Mitchell Hashimoto 9c6d0dfc8b builder/virtualbox: fix type casting
/cc @pearkes - This fixes that crash
2015-06-21 19:56:55 -07:00
Mitchell Hashimoto d9fceaf39d update CHANGELOG 2015-06-18 10:19:46 +02:00
Mitchell Hashimoto ba2cf18460 Merge branch 'master' of https://github.com/ldx/packer into ldx-master 2015-06-18 10:18:17 +02:00
Mitchell Hashimoto 70af21615e Merge pull request #2233 from mitchellh/b-output-dir
builder/virtualbox,vmware: validate output dir in step
2015-06-15 09:40:36 -07:00
Mitchell Hashimoto 7fc69828c5 builder/virtualbox: fix forwarding to work with WinRM 2015-06-14 21:47:53 -07:00
Mitchell Hashimoto 115d583cff helper/communicator: make host more generic 2015-06-13 19:23:33 -04:00
Mitchell Hashimoto d5166a8e6c builder/virtualbox: use new communicator abstraction 2015-06-13 18:08:12 -04:00
Mitchell Hashimoto 3976a34d29 builder/virtualbox: validate output dir in step, no in config 2015-06-13 16:58:37 -04:00
Mark Peek 16320372d6 Make some builder config usage more consistent with other builders 2015-06-12 14:02:09 -07:00
Mitchell Hashimoto bd04b52b32 virtualbox/common: style 2015-06-10 10:50:08 -07:00
Mitchell Hashimoto 8d6a99457a Merge pull request #1078 from pleschev/skip_nat_port
Adding the ability to skip nat port forwarding for ssh connectivity
2015-06-10 10:47:03 -07:00
Mitchell Hashimoto f6f9cca7ce Merge pull request #2189 from mitchellh/b-download-extension
common: StepDownload can force an extension
2015-06-09 20:56:43 -07:00
Mitchell Hashimoto 23a48d6619 go fmt 2015-06-08 21:34:20 -07:00
Mitchell Hashimoto 20504da796 Merge pull request #2190 from mitchellh/b-http-addr
virtualbox,vmware: http server should listen on IPv4
2015-06-08 21:23:49 -07:00
Mitchell Hashimoto 9f0b8b71db virtualbox,vmware: http server should listen on IPv4 2015-06-08 20:47:47 -07:00
Mitchell Hashimoto 9ea34d4ea8 virtualbox/iso: force iso extension for downloads 2015-06-08 20:42:16 -07:00
Mitchell Hashimoto 35246ba986 virtualbox/common: fix test 2015-06-08 20:31:53 -07:00
Mitchell Hashimoto b441348ba4 virtualbox/common: remove devices should delete floppy controller
GH-1879
2015-06-08 20:25:21 -07:00
Mitchell Hashimoto 0885e03bbf virtualbox/iso: acceptance test 2015-06-08 20:24:49 -07:00
jszwedko b1497b951c code.google.com/p/go.crypto/ssh -> golang.org/x/crypto/ssh
code.google.com/p/go.crypto/ssh is now at golang.org/x/crypto/ssh as of
https://code.google.com/p/go/source/detail?spec=svn.crypto.69e2a90ed92d03812364aeb947b7068dc42e561e&repo=crypto&r=8fec09c61d5d66f460d227fd1df3473d7e015bc6

Using the code.google.com import redirects properly, but runs into
issues if you try to use a subpackage of `ssh`, e.g. `agent` which
refers to golang.org/x/crypto/ssh causing conflicts if your types expect
code.google.com/p/go.crypto/ssh.

This is a precursor to a PR for #1066.
2015-05-28 08:17:49 -07:00
Mitchell Hashimoto 4bb16ac223 fix failing tests 2015-05-27 14:30:59 -07:00
Mitchell Hashimoto 0dc4226810 builder/virtualbox/ovf: new interpolation 2015-05-27 14:03:56 -07:00
Mitchell Hashimoto d15bc90453 builder/virtualbox/iso: new interpolation 2015-05-27 14:01:08 -07:00
Vilmos Nebehaj 956b9ded0a Try another ssh port if the current one is taken. 2015-04-10 17:55:51 -07:00
Emil Hessman 96b62af551 builder/virtualbox/iso: fix incorrect printf verb type
Fixes the following vet report:

builder/virtualbox/iso/builder_test.go:86: arg b.config.DiskSize for printf verb %s of wrong type: uint
2015-02-25 05:43:17 +01:00
Danny Lockard 7d1b95c907 Formatting fix :) 2015-01-16 10:34:12 -06:00
Danny Lockard 84d6d856f6 Add the ability to create a SCSI Device as the main HD controller for
virtualbox.
2015-01-15 19:53:01 -06:00
pleschev 431647997c Merge pull request #2 from mitchellh/master
Update skip_nat_port to latest master.
2014-11-26 07:52:42 +11:00
Mitchell Hashimoto 0db6cd3533 Merge pull request #1330 from qur/qemu-vagrant
Qemu vagrant
2014-10-28 08:42:17 -07:00
Mitchell Hashimoto 83772fc5b8 Merge pull request #1509 from kamazee/fix_detecting_guest_additions_when_sysprop_empty
Fix detecting guest additions URL
2014-10-27 17:04:03 -07:00
Konstantinos Koukopoulos a8b8658245 figure out VirtualBox version on FreeBSD 2014-10-09 11:45:03 +03:00
Julian Phillips 90a57c411f Expand Artifact API to expose build state
In order that something consuming an artifact can have access to extra
builder specific data add the State method which allows the caller to
ask for arbitary values by name.
2014-09-22 11:15:47 +01:00
Alexander Kurilo 3592d67093 Fix detecting guest additions URL
When system property exists with empty value, packer treats that
empty value as a URL. The issue has been spotted on Arch
with Virtualbox 4.3.16.
2014-09-18 10:53:13 -04:00
Mitchell Hashimoto 75395af12d Merge branch '1064-fix-upload-file-permissions' of github.com:rasa/packer into rasa-1064-fix-upload-file-permissions
Conflicts:
	builder/parallels/common/step_upload_parallels_tools.go
	builder/vmware/common/step_upload_tools.go
	provisioner/chef-client/provisioner.go
	provisioner/chef-solo/provisioner.go
2014-09-08 13:20:46 -07:00
Mitchell Hashimoto bfdc6ea6b7 builder/virtualbox: support http server for ovf [GH-1169] 2014-09-05 11:52:55 -07:00
Mitchell Hashimoto c74f0c7cfe Merge branch '1082-add-boot-commands-to-vmx-and-ovf-builders' of github.com:rasa/packer into rasa-1082-add-boot-commands-to-vmx-and-ovf-builders
Conflicts:
	builder/virtualbox/ovf/config.go
	builder/vmware/vmx/config.go
2014-09-05 11:42:01 -07:00
Mitchell Hashimoto 9b2039121f builder/virtualbox-ovf: import_flags [GH-1383] 2014-09-05 10:23:37 -07:00
Mitchell Hashimoto 863e06a614 builder/virtualbox: comment 2014-09-05 09:59:39 -07:00
Mitchell Hashimoto f54f09d7a3 builder/virtualbox: detect vboxmanage errors with zero code [GH-1119] 2014-09-05 09:57:30 -07:00
Mitchell Hashimoto 77bd024079 builder/*: fix flaky tests, get tests passing 2014-09-04 18:11:05 -07:00
Mitchell Hashimoto c0f9dbde41 builder/virtualbox: search VBOX_MSI_INSTALL_PATH [GH-1337] 2014-09-03 21:08:57 -07:00
Mitchell Hashimoto 749baa19c4 builder/virtualbox/iso: append timestamp to name [GH-1365] 2014-09-03 20:54:02 -07:00
Mitchell Hashimoto 28de122579 builder/virtualbox: fix typo 2014-09-03 20:33:22 -07:00
Mitchell Hashimoto 94f385ecf9 builder/virtualbox: error if guest additions URL can't be read [GH-1439] 2014-09-03 20:30:16 -07:00
Mitchell Hashimoto 76a8221636 builder/*: extract key path to ssh.Signer 2014-09-03 20:23:39 -07:00
Mitchell Hashimoto c185fa42f3 Merge pull request #1200 from zigg/feature/virtualbox-iso-sata
builder/virtualbox: implement `iso_interface` setting
2014-09-02 10:56:57 -07:00
Mitchell Hashimoto 4ef3874467 builder/virtualbox-*: seed RNG [GH-1386] 2014-09-02 09:35:59 -07:00
Hiroaki Nakamura 7549735bd3 Accept VirtualBox release candidate version (ex. 4.3.14_RC1 from 4.3.14_RC1r94870) 2014-07-12 19:08:10 +09:00
Matt Behrens 9eb32e5dcd implement `iso_interface` setting
Adds a new configuration option, `iso_interface`, that can be set to
`sata` to mount the ISO on the SATA controller.  Required for OS X.
2014-05-23 21:14:24 -04:00
Ross Smith II e93697ab4e builder/virtualbox-ovf,vmware-vmx: add `boot_command` support
Fixes #1082
2014-05-12 21:19:24 -07:00
Ross Smith II d92179847d provisioner/file: set file/directory permissions
fixes #1064
2014-05-09 21:03:35 -07:00
Ross Smith II 58fd5aec61 virtualbox: use local VBoxGuestAdditions.iso by default
fixes #1123
2014-05-06 16:15:55 -07:00
Jakob A. Dam 40150c376d Fix http_files typo in comments 2014-05-06 17:13:15 +02:00
Rickard von Essen c2013bf680 virtualbox-ovf support for guest_additions_mode
Fixes #1035 "virtualbox-ovf" builder doesn't support "guest_additions_mode" option
2014-05-04 18:48:41 +02:00
Jacob Helwig 38e880a187 Add ability to run vboxmanage commands just before exporting [GH-664] 2014-04-29 11:58:11 -07:00
Peter Leschev eef3223f6c Adding the ability to skip nat port forwarding for ssh connectivity 2014-04-29 08:27:23 +10:00
Mitchell Hashimoto 83add3969f builder/virtualbox: fix deps 2014-04-26 12:27:30 -07:00
Mitchell Hashimoto 5fac6c79c4 fmt 2014-04-26 11:12:43 -07:00
Mitchell Hashimoto e84e5e4f2c Merge branch 'update-ssh-package' of github.com:higebu/packer into higebu-update-ssh-package
Conflicts:
	builder/amazon/common/ssh.go
	builder/digitalocean/ssh.go
	builder/googlecompute/ssh.go
	builder/openstack/ssh.go
	communicator/ssh/communicator_test.go
	communicator/ssh/keychain.go
	communicator/ssh/keychain_test.go
2014-04-26 11:12:06 -07:00
Ross Smith II 850b066408 Merge pull request #945 from benlangfeld:feature/vb_output_opts (manually) 2014-04-21 08:38:48 -07:00
higebu f087ce16dc Fix the build problem by updating ssh package 2014-04-15 10:17:26 +09:00
Ross Smith II 27491f93f8 use old ssh code until higebu's branch is ready, see #1019 2014-04-11 08:23:12 -07:00
Ben Langfeld 128f555a2c Formatting 2014-03-14 13:22:49 -03:00
Ben Langfeld 5b07e2604c Fix export opts tests 2014-03-14 13:22:44 -03:00
Ben Langfeld 8cf0e53b19 Properly apply templates to export opts 2014-03-14 13:22:32 -03:00
Ben Langfeld 2cee7a5c10 Log export command being executed 2014-03-14 00:26:26 -03:00
Ben Langfeld bfd6755859 Move to an array of strings for a deterministic option separation 2014-03-14 00:12:50 -03:00
Ben Langfeld d1b41f2f14 Pass export_options individually to VBoxManage export 2014-03-13 23:33:35 -03:00
Ben Langfeld 0332901f63 builder/virtualbox: Add an `export_opts` option
Allows arbitrary arguments to VBoxManage export, such as product info (--product, --vendor, etc).
2014-03-12 10:12:20 -03:00
Mitchell Hashimoto 239aabb554 builder/virtualbox: retry unregister a few times [GH-915] 2014-03-01 16:20:02 +01:00
Brian Johnson ac2c4203a2 Add import_opts to the virtualbox-ovf builder. My use case is that I
have existing virtualbox virtual machines where I need to keep the mac
addresses so that the network interfaces come up when packer boots them.
Otherwise I just get SSH timeout and I'm unable to configure the machines.
2014-02-18 16:44:27 -08:00
Mitchell Hashimoto 430963f400 fmt 2014-01-19 19:30:11 -08:00
Myles Steinhauser 28286d2821 Fix tabs vs spaces 2014-01-13 00:03:10 -05:00
Myles Steinhauser e4cfcb2a8a Add more special scancodes 2014-01-10 12:40:43 -05:00
Mitchell Hashimoto 12938fe36b builder/virtualbox,vmware: checksum not required if checksum type is
none
2014-01-04 11:10:13 -08:00
Greg Lu 6d2e50e598 builder/virtualbox/ovf: fix shutdown_timeout handling
The shutdown_timeout config parameter was being ignored
(for both the user setting and the "5m" default) on the
virtualbox-ovf builder. As a result, packer complained
of timeouts on graceful shutdowns, and the build process
would error out. This fixes that along with some newly
created tests.
2013-12-31 18:28:33 -05:00
Mitchell Hashimoto 2b801a7b12 builder/vmware,virtualbox: checksum_type can be "none" [GH-471] 2013-12-28 09:59:47 -07:00
Mitchell Hashimoto 437dc12de3 builder/virtualbox/iso: load shutdown config [GH-754] 2013-12-26 23:28:15 -07:00
Mitchell Hashimoto eeeaec3562 builder/vmware/vmx: StepCloneVMX 2013-12-26 08:34:27 -07:00
Mitchell Hashimoto 39d0600085 builder/virtualbox: fmt 2013-12-23 14:21:28 -08:00
Mitchell Hashimoto c7bf38b63b builder/virtualbox/common: only remove ISO if it was attached 2013-12-22 17:08:07 -08:00
Mitchell Hashimoto 473fe8a950 builder/virtualbox/ovf: instantiate the driver 2013-12-22 17:04:26 -08:00
Mitchell Hashimoto c2b3fa732a builder/virtualbox/ovf: validate source_path 2013-12-22 17:02:22 -08:00
Mitchell Hashimoto e69bb1858c builder/virtualbox/ovf: specify name for import 2013-12-22 15:24:24 -08:00
Mitchell Hashimoto 5b223f0798 builder/virtualbox/ovf: re-order some steps 2013-12-22 15:20:49 -08:00
Mitchell Hashimoto dd767c9d54 builder/virtualbox/ovf: StepImport to import an OVF 2013-12-22 15:19:19 -08:00
Mitchell Hashimoto 0de7bb33cd builder/virtualbox: set Tpl on VBoxManage 2013-12-22 11:57:05 -08:00
Mitchell Hashimoto e51dde13ce builder/virtualbox: tests for StepUploadVerison 2013-12-22 11:55:01 -08:00
Mitchell Hashimoto 5f1c597269 builder/virtualbox: StepUploadVersion 2013-12-22 11:50:29 -08:00
Mitchell Hashimoto 5feb7bce18 builder/virtualbox/common: Export 2013-12-22 10:40:39 -08:00
Mitchell Hashimoto 026bcd33fe builder/virtualbox: StepRun common 2013-12-22 10:30:12 -08:00
Mitchell Hashimoto fbd20dffcb builder/virtualbox/common: StepRemoveDevices 2013-12-22 09:54:00 -08:00
Mitchell Hashimoto b65559d888 builder/virtualbox: StepShutdown tests 2013-12-22 09:47:44 -08:00
Mitchell Hashimoto 67a87ce3e4 builder/virtualbox: StepShutdown 2013-12-22 09:37:27 -08:00
Mitchell Hashimoto 4bd2aa6106 builder/virtualbox: StepVBoxmanage 2013-12-22 09:24:29 -08:00
Mitchell Hashimoto 7a4ff3f2b1 builder/virtualbox: generic SSHConfig 2013-12-22 09:08:09 -08:00
Mitchell Hashimoto 79c0c6b545 builder/virtualbox: step attach floppy 2013-12-22 08:10:11 -08:00
Mitchell Hashimoto d731dcd8f7 builder/virtualbox: floppy files config 2013-12-22 07:58:07 -08:00
Mitchell Hashimoto 598822d46b builder/virtualbox/common: move outputdir config to common 2013-12-21 17:38:06 -08:00
Mitchell Hashimoto 886c0d3ad5 builder/virtualbox/common: StepSuppressMessages 2013-12-21 16:05:34 -08:00
Mitchell Hashimoto db167c5a3d builder/virtualbox/common: StepOutputDir 2013-12-21 15:20:15 -08:00
Mitchell Hashimoto cdc02db96d builder/virtualbox/common: Move Driver here 2013-12-21 15:00:48 -08:00
Mitchell Hashimoto 14eede264f builder/virtualbox: add common package, common Artifact 2013-12-21 14:51:38 -08:00
Mitchell Hashimoto afd67ea104 builder/virtualbox/iso: rename package 2013-12-21 14:27:00 -08:00
Mitchell Hashimoto 01c7bbf8c4 builder/virtualbox: move to iso/ folder 2013-12-21 14:25:22 -08:00
Mitchell Hashimoto ac36b33f98 builder/virtualbox: fix compilation 2013-12-19 08:49:50 -08:00
Mitchell Hashimoto 3c5c9a6ea3 builder/virtualbox: sleep when stopping forcefully to allow session
unlock
2013-12-19 08:49:23 -08:00
Mitchell Hashimoto dcae79e67f builder/virtualbox: remove devices in separate step 2013-12-19 08:47:37 -08:00
Mitchell Hashimoto c264ef0a29 builer/virtualbox: avoid crash since guest additions path not set 2013-12-18 11:27:25 -08:00
Mitchell Hashimoto 675f7a43ba builder/virtualbox: don't download guest additions if disable [GH-731] 2013-12-18 11:22:02 -08:00
Mitchell Hashimoto 2920239e6e builder/virtualbox: verify output dir is writable 2013-12-18 08:40:35 -08:00
Mitchell Hashimoto d9c3aed479 builder/virtualbox: use VBOX_INSTALL_PATH to find VBoxManage 2013-11-19 12:32:10 -08:00
Mitchell Hashimoto c1bd7468d5 builder/virtualbox: ctrl-c works during wait for boot 2013-11-12 16:19:38 +00:00
Mitchell Hashimoto 6c19ba621f builder/virtualbox: no panic if ssh host port min/max is same [GH-594] 2013-11-04 14:20:26 -08:00
Mitchell Hashimoto 9acaa97a32 builder/virtualbox,vmware: warning if shutdown_command is not specified 2013-11-02 23:17:21 -05:00
Mitchell Hashimoto a6150e6596 builder/all: update to warnings 2013-11-02 23:03:59 -05:00
Mitchell Hashimoto aa95caa261 builder/virtualbox: allow disabling guest addition uploading 2013-11-02 11:34:54 +01:00
Matthew Hooker 6620b9cc9b Merge pull request #572 from ktruong7/format-issues1
Spelling mistake in comments
2013-10-28 06:52:57 -07:00
ktruong7 1f31ac1737 spelling mistake in comments 2013-10-24 14:46:54 -04:00
Fabian Grutschus 5e440fa4c1 Arguments Prefix (--) was missing for (data)portconfig 2013-10-23 15:05:00 +02:00
Mitchell Hashimoto 5e3c8c4fe6 builder/virtualbox,vmware: support user templates in SSH key path
[GH-539]
2013-10-20 15:58:39 -07:00
Mitchell Hashimoto 30be4927d6 builder/virtualbox: use proper SATA port arg [GH-547] 2013-10-20 15:55:31 -07:00
Lyndon Washington bb241af7b3 Formatted contributions 2013-10-09 13:14:09 -04:00
Lyndon Washington 88e65ef59b Moved the 1 sec timeout to the export step 2013-10-09 12:59:47 -04:00
Mitchell Hashimoto 8821ef4def builder/virtualbox: detect vboxdrv issues [GH-488] 2013-10-02 17:13:22 -07:00
Mitchell Hashimoto c19fcafc01 builder/virtualbox: error if version can't be detected [GH-488] 2013-10-02 17:11:42 -07:00
Mitchell Hashimoto 865f197503 builder/virtualbox: support attaching guest additions [GH-405] 2013-09-18 18:15:46 -07:00
Mitchell Hashimoto 692278965f builder/virtualbox: fix scan codes 2013-09-15 23:41:08 -07:00
Mitchell Hashimoto 9f52b78602 fmt 2013-09-15 23:29:29 -07:00
Charlie Sharpsteen efa401e4d2 Fix scancode comment concerning key release
According to the scancode reference, the release key code is generated by
adding `0x80` to the key press code, not `0x81`.
2013-09-15 23:18:55 -07:00
Charlie Sharpsteen 4952737ddb Fix VirtualBox scancodes
Support for the backspace, delete and F1-F12 keys was added in commit 6028a3c.
However, that commit seems to have copied character codes from the vmware
builder into the VirtualBox builder. Character codes are appropriate for VMware
which communicates through a VNC. However, VirtualBox communicates through
simulating raw keyboard input and therefore needs scancodes which are key
press/key release sequences.

This patch converts backspace, delete and F1-F10 to scancodes. F11 and F12 are
not listed in the [scancode reference][scancodes] so they have been omitted.

[scancodes]: http://www.win.tue.nl/~aeb/linux/kbd/scancodes-1.html
2013-09-15 21:45:11 -07:00
Sean Mackrory 2a04f49bca Using the vm_name parameter to name OVA/OVF files and their attachments 2013-09-06 23:38:31 -07:00
Mitchell Hashimoto e732d86142 builder/virtualbox: process hdd interface as template, validate 2013-09-05 12:07:58 -07:00
Justin Bronn dbc24d9357 Enable customization of VirtualBox disk controller with `hard_drive_interface` option (SATA only). 2013-09-05 11:00:08 -07:00
Mitchell Hashimoto 1a3620d77a builder/virtualbox: new multistep API 2013-08-31 12:44:58 -07:00
Mitchell Hashimoto a6735b1d65 builder/virtualbox: support ssh keys as auth mechanism [GH-70] 2013-08-27 22:55:13 -07:00
Mitchell Hashimoto 7647b12eab builder/virtualbox: fmt 2013-08-19 16:24:29 -07:00
Mitchell Hashimoto 1fdaadb08c website: document formats feature 2013-08-19 16:10:49 -07:00
Johan Siebens a19bd564d3 builder/virtualbox: export to ovf or ova (default ovf) 2013-08-19 20:21:36 +02:00
Mitchell Hashimoto 64d87bfaf3 *: switch to packer ConfigTemplate 2013-08-15 19:17:23 -07:00
Mitchell Hashimoto c0265d108a builder/virtualbox: iso_urls for multiple ISO urls [GH-110] 2013-08-15 17:46:41 -07:00
Mitchell Hashimoto 0d152f541f builder/virtualbox: remove unused function 2013-08-15 17:46:40 -07:00
Mitchell Hashimoto 562ea28a79 builder/virtualbox: switch download guest additions to use new common 2013-08-15 17:46:40 -07:00
Mitchell Hashimoto bb352e5011 common: Add new StepDownload to DRY up downloads 2013-08-15 17:46:40 -07:00
Mitchell Hashimoto 71664cb34e common: return -1 download percent if download hasn't started [GH-288] 2013-08-14 11:15:47 -04:00
Mitchell Hashimoto 0ba17a1a50 builder/virtualbox: Don't validate guest additions URL so early because it requires template 2013-08-14 09:59:09 -04:00
Mitchell Hashimoto 171ecaefa6 builder/virtualbox: guest-additions_url can use Version var [GH-272] 2013-08-13 22:11:15 -04:00
Mitchell Hashimoto 2d2eefcf33 builder/virtualbox: instantiate driver in Run method 2013-08-13 08:55:33 -07:00
Mitchell Hashimoto 332bdf6edc builder/*, provisioner/*: set user vars 2013-08-09 15:57:08 -07:00
Mitchell Hashimoto 191520bc0b builder/virtualbox: use new template processing stuff 2013-08-08 17:25:25 -07:00