9592211bcf
Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'.
...
The 'ssh.KeyPairFromPrivateKey()' function in the 'ssh' helper
library was not honoring the value of the 'Comment' field in the
'FromPrivateKeyConfig' struct. This commit fixes the issue, and
updates unit tests to catch the issue if it happens again.
2019-07-27 15:52:13 -04:00
d51e300fcd
Clarified comment for 'defaultRsaBits' constant.
...
That *is* a lot of bits.
2019-03-01 12:17:13 -05:00
7e1cbc6d89
Rename references to key pair name to comment.
...
Per the OpenSSH manual, the field is for a comment.
2019-03-01 10:00:29 -05:00
856810e82e
Coalesce private key type switch cases per review feedback.
2019-02-28 09:56:11 -05:00
672b22bd13
Move 'CreateKeyPairConfig' closer to callers.
...
Per review feedback.
2019-02-28 09:44:25 -05:00
302828905d
Move 'FromPrivateKeyConfig' closer to caller.
...
Per review feedback.
2019-02-28 09:42:20 -05:00
ed06656613
Update 'authorizedKeysLine' doc per review feedback.
2019-02-28 09:40:00 -05:00
415ef26768
Removed TODO about key pair description per review feedback.
2019-02-28 09:30:30 -05:00
2ef6b9247d
Initial take on code review feedback from @azr.
...
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00
2ab2ea6ef1
Fixed interface documentation typo.
2019-02-12 10:29:43 -05:00
ed1d224b97
Remove defaultKeyPair type. Be more specific in errors.
2019-02-07 11:09:53 -05:00
97268b3041
.
2019-02-06 15:05:56 -05:00
be01ca70f4
on error return empty defaultKeyPair{} rather than nil
2019-02-06 14:02:26 -05:00
484aa4768f
Remove unused keyheader data type
2019-02-06 13:58:26 -05:00
13cc73d600
keypair parsing and testing
2019-02-06 13:46:55 -05:00
72b7d63a6a
Restructured the SSH key pair's description.
...
Now include the key pair name (if any), and make it more "readable".
2019-02-05 13:37:09 -05:00
4b649f7ce4
Use individual key pair implementations.
...
This allows us to store more information about the key pair.
In particular, we can query the private key for its bits of
entropy - avoiding the possibility of hardcoding the wrong value.
2019-02-05 11:53:12 -05:00
d7510ecdf7
Tweaked 'PublicKeyAuthorizedKeysLine()' comment.
2019-02-05 09:54:38 -05:00
58c692a587
Get bits from private key rather than user input.
2019-02-05 09:52:46 -05:00
f3128143fa
Simplified building of authorized_keys public key.
2019-02-04 14:27:59 -05:00
f2c11b55be
Renamed authorized_keys public key function.
2019-02-04 14:27:14 -05:00
d465231e63
Fixed bad curve ecdsa curve bug.
2019-02-04 14:25:37 -05:00
9328c9f9e0
Renamed "new*" SSH key pair methods.
2019-02-04 14:12:18 -05:00
f8db84334d
Alias 'golang.org/x/crypto/ssh' as 'gossh'.
2019-02-04 12:29:47 -05:00
9a9bc18fab
Renamed SSH key pair source files per pattern.
...
There appears to be a pattern of naming SSH key pair related
source files "*_key_pair*".
2019-02-04 12:25:00 -05:00
Stephen Fox
chris marget