1f46271a6b
Ensuring device login works for Windows build
2018-05-18 00:32:01 -07:00
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
...
Async delete Resource Group
2018-05-16 15:13:09 -07:00
c925a02f82
don't chown to close the security issue
2018-05-16 21:40:22 +00:00
3192f5e0da
qemu builder: add the 'use_backing_file' setting for QCOW2 images
2018-05-16 10:22:50 -04:00
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
2018-05-16 13:52:00 +01:00
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
2018-05-16 12:55:59 +01:00
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00
2c339b99d2
Sort run config options alphabetically
2018-05-15 12:25:06 +01:00
c8c9bbb22a
Async delete Resource Group
2018-05-14 20:06:23 -07:00
5710c0aca1
Making log output clearer for hyper-v gui connection
2018-05-14 20:53:51 +10:00
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
...
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
...
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
13c0b0b370
Added warning for VHD creation and updated samples
2018-05-10 13:15:35 -07:00
6f00596053
Adds config option to specify hyper-v secure boot template
2018-05-10 19:00:35 +02:00
84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
...
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
a866232ac9
Use regex based approach to detect attached disks
2018-05-08 12:52:39 +01:00
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
80a096cadd
azure: device login for US Gov
2018-05-06 20:59:38 -07:00
8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
...
Update Azure SDK
2018-05-04 09:47:28 -07:00
4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
...
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
169f9d22e6
Update 'the other place' too
2018-05-04 00:32:15 +00:00
80f57308d7
Process review feedback
2018-05-04 00:28:34 +00:00
420a5842b9
Merge pull request #6231 from cantorek/f-randomize-osdiskname
...
Randomize osDisk name for Azure Managed Image builds.
2018-05-03 14:55:42 -07:00
0521efa200
correctly log reason waiting for ami failed.
2018-05-03 12:27:09 -07:00
7d5ebd5500
Merge pull request #6217 from alessiot77/5887
...
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
c47e5d19f0
Fix use of auto generated ssh key for scaleway builder
2018-05-03 11:33:28 +01:00
585b93cfd6
Follow variable privateKey <-> statebag private_key convention
2018-05-03 00:33:12 +01:00
78d68880c0
Randomize osDisk name for Azure Managed Image builds.
...
This fixes #6115
2018-05-02 22:42:08 +02:00
07d8c71a2d
Create and use context for Builder.Run
2018-05-01 23:40:40 +00:00
e90c87f885
Merge pull request #6210 from hashicorp/add_windows_sql_cloud_to_defaults
...
add windows-sql-cloud to the list of projects to check for an image name
2018-05-01 12:57:10 -07:00
cf94086b5f
Formatting fixes
2018-05-01 19:53:20 +00:00
6260151034
Merge pull request #6226 from hashicorp/fix6225
...
builder/qemu: properly prepare boot command.
2018-05-01 12:41:11 -07:00
4f1395e0f6
builder/qemu: properly prepare boot command.
2018-05-01 12:40:00 -07:00
c13965c0ce
Add acceptance tests
2018-05-01 15:39:50 +00:00
a3fb24639a
make tests pass again
2018-05-01 15:39:50 +00:00
09ce3c9803
Make it compile again
2018-05-01 15:39:50 +00:00
3d4c7d0df1
Feature Request: Log reason why AMI creation failed
2018-04-30 20:59:13 +01:00
25dd27a164
Remove tmp directories created by builder/vmware/common tests
2018-04-30 20:38:03 +01:00
13b7078cb0
Remove tmp directories created by builder/virtualbox/common tests
2018-04-30 20:38:03 +01:00
475b3978d2
Remove tmp directories created by builder/parallels/common tests
2018-04-30 20:38:03 +01:00
5642f8cb01
Remove tmp files created by builder/googlecompute tests
2018-04-30 20:38:03 +01:00
9b6fc5a58d
Remove tmp files created by builder/amazon/instance tests
2018-04-30 18:16:46 +01:00
54e9690dff
Remove tmp files created by builder/amazon/common tests
2018-04-30 18:16:46 +01:00
96adb4a9d1
Remove tmp files created by builder/alicloud/ecs tests
2018-04-30 18:16:46 +01:00
373226e9c5
Extract state reason for failure
2018-04-28 12:40:48 +01:00
09bb21774d
alessio.tomasino@yahoo.co.uk
2018-04-28 11:02:53 +01:00
c27f3e9445
alessio.tomasino@yahoo.co.uk
2018-04-28 11:00:33 +01:00
c828015bc3
Follow variable varName <-> statebag var_name convention
2018-04-27 20:09:19 +01:00
df5c67090e
Merge pull request #6193 from adarobin/hvf
...
add support for hvf accelerator to qemu builder
2018-04-27 11:41:01 -07:00
ed6d999b1f
add windows-sql-cloud to the list of projects to check for an image name
2018-04-27 11:24:08 -07:00
f342975ff3
Fix test - reporting compaction results requires a tmp file
2018-04-27 16:40:44 +01:00
08f9d619a9
Report the result of the disk compaction step
2018-04-27 16:40:29 +01:00
10d93dffa4
Fix tests for vmware/common
2018-04-27 16:40:23 +01:00
a729ecda87
Fix tests for vmware/vmx builder
2018-04-27 16:40:13 +01:00
c48a7889f9
Simplify handling of disks by collating requirements and unifying ops
2018-04-27 16:39:52 +01:00
29b89e63b8
add support for hvf accelerator to qemu builder
2018-04-27 10:11:20 -04:00
879319a76c
Merge pull request #6202 from rickard-von-essen/fix-6184
...
builder/parallels-pvm: Add missing compaction of disks
2018-04-26 15:44:12 -07:00
67a9c7fb92
we never expect remote cache to be a directory.
2018-04-26 12:40:40 -07:00
de1dac1bdf
don't delete the cache directory.
2018-04-26 12:40:40 -07:00
97cfd60b82
Remove remote cache correctly.
2018-04-26 12:40:35 -07:00
673d4579e4
Ack! Forgot to include the template variable in the definition for vmxTemplateData for commit 0e519d79e0. Now it's added..
2018-04-26 14:22:37 -05:00
0e519d79e0
Modified iso/step_create_vmx.go in the vmware-iso builder to also specify the "bios.hddOrder" field depending on the hdd device that was specified. This might close issue #6197
2018-04-26 14:16:50 -05:00
5d8b476a7f
Fixed the regex in common/step_clean_vmx.go for the VMware builder to also support removal of sata-based cdrom devices. Also added a comment in iso/step_create_vmx.go that links both pieces of related code.
2018-04-26 14:01:58 -05:00
451e3d0554
builder/vmware-esxi: remove floppy files when done
2018-04-26 10:47:33 -07:00
3aebd5f462
Add use_fixed_vhd_format Hyper-V ISO option
2018-04-26 13:35:19 -04:00
77d0ba492d
parallels-pvm: Add missing compaction of disks
2018-04-26 14:09:17 +02:00
59e3ec722d
allow user to mount entire block device in chroot builder
2018-04-25 10:47:52 -07:00
ef03e97dc3
pass MacAddress to StepCreateVM
2018-04-24 20:39:42 -04:00
148f7d39e4
Merge pull request #6142 from harveylowndes/use-official-go-sdk
...
builder/oracle: Use official OCI Go SDK
2018-04-24 16:34:38 -07:00
db65c99bf4
update code based on master and update docs
2018-04-24 10:35:27 +01:00
e2e7953fe4
Merge branch 'master' into allow_gcp_winrm_password
2018-04-24 10:25:27 +01:00
cbdf9db832
Use contexts with amazon waiters.
2018-04-23 12:57:15 -07:00
6bbfe7e0bd
remove useless check against format
2018-04-23 10:24:49 -07:00
fdeadfe3f6
builder/vmware: correctly default export format to ovf
2018-04-23 10:17:53 -07:00
0e80d98805
Merge pull request #6166 from hashicorp/parallelsfixes
...
forcefully stop parallels vm.
2018-04-23 10:08:35 -07:00
69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
...
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
e455e7b054
Merge pull request #6074 from DanHam/fix-vmx-compacting-error
...
Fix error with VMware vmx builder at compacting stage
2018-04-23 09:03:36 -07:00
a2a593759e
Merge pull request #6041 from Xeite/f-add-instance-name
...
builder/openstack: Add instance_name config to OpenStack builder
2018-04-23 08:47:50 +02:00
bd9e585cb9
Add test for enumeration of vmx network type
2018-04-21 22:49:36 +01:00
94d5a7f2e2
Fix copy/paste error referencing Virtualbox
2018-04-21 22:49:36 +01:00
1aee759f06
Fix tests and reconfigure for support of multi-disk vm
2018-04-21 22:49:36 +01:00
6c9d4efd9f
Fix error on compaction step of vmx build. Support compacting multi-disk vm
2018-04-21 22:49:36 +01:00
bcbee45bf9
Merge pull request #6039 from stack72/triton-insecure-skip-tls-verify
...
builder/triton: Add support to Skip TLS Verification of Triton Certificate
2018-04-20 13:44:28 -07:00
024fac4b4f
Merge pull request #6129 from hashicorp/bc_replace
...
Replace boot command parser with PEG parser.
2018-04-20 12:21:20 -07:00
5a10e5a038
fix invalid disc_discard setting error message
2018-04-20 13:17:40 +02:00
11de2b9759
remove unnecessary log line.
2018-04-19 16:13:24 -07:00
c920e0a20b
forcefully stop parallels vm.
...
also only output parallels version once.
2018-04-19 16:11:29 -07:00
1d36ef038c
implement boot config struct for hyperv
2018-04-19 14:26:31 -07:00
a0c9ddb9ae
implement boot config struct for virtualbox
2018-04-19 14:26:31 -07:00
c8e76ce298
implement config struct for qemu
2018-04-19 14:26:31 -07:00
c6299972b9
s/boot_command/bootcommand/
2018-04-19 14:26:31 -07:00
7990966a09
fix boot command config struct name
2018-04-19 14:26:31 -07:00
e662927623
Implement boot config struct for parallels
2018-04-19 14:26:30 -07:00
408eba88ad
flatten boot command config and implement for vmware
2018-04-19 14:26:30 -07:00
94129b7fe3
we're using PC-XT (set1) not PC-AT
2018-04-19 14:26:30 -07:00
a46a7afa20
Remove old tests.
2018-04-19 14:26:29 -07:00
cba4d3235f
cleanup
2018-04-19 14:26:29 -07:00
bf0a320125
Implement new parser for qemu boot command
2018-04-19 14:26:29 -07:00
bdb1eee7d8
Implement new parser for HyperV boot command
2018-04-19 14:26:29 -07:00
81d127768c
Add key press interval to virtualbox.
2018-04-19 14:26:29 -07:00
59376294ef
Maximize scancode throughput.
...
Let's cache the scancodes and flush them at the end. Also make sure to
send only as many as the driver can send correctly. It's important here
to chunk the scancodes correctly, so that we don't accidentally split them
over successive calls to the driver
2018-04-19 14:26:29 -07:00
9b7704c714
Implement new parser for Parallels boot command
2018-04-19 14:26:29 -07:00
99d61920d0
Abstract vbox driver into PC-AT driver.
2018-04-19 14:26:29 -07:00
e4af71858f
Implement new parser for Virtualbox boot command
...
Remove boot wait for virtualbox run step
2018-04-19 14:26:29 -07:00
1c0af28662
Some cleanup and comments.
2018-04-19 14:26:29 -07:00
4e2f14196a
Rely on context to cancel typing boot command.
2018-04-19 14:26:28 -07:00
673245afcf
Replace boot command parser with PEG parser.
2018-04-19 14:26:28 -07:00
f5c031baf9
Merge pull request #5941 from synax/hyper-v-disk-block-size
...
Adds Support to configure hyper-v disk block size
2018-04-19 11:27:52 -07:00
c442ba165e
Migrate to official OCI Go SDK
2018-04-17 10:30:42 +01:00
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
ec6f8264bf
fix winrm password access in google compute
2018-04-16 10:56:26 +01:00
ee1ff3132d
remove attempt to discover whether destination is a directory from upload function in various communicators
2018-04-10 08:13:06 -07:00
83162717ed
Merge pull request #4563 from marema31/vmware-iso-warn-esx
...
builder/vmware-iso: Fail on wrong remote_type value
2018-04-06 16:52:26 -07:00
f094b3be85
update changelog
2018-04-05 16:32:03 -07:00
cb90e8b375
Merge pull request #6111 from hashicorp/replace4448
...
Restrict deregistered AMIs to those owned by self.
2018-04-05 16:30:37 -07:00
d70451f82e
Merge pull request #6106 from sethvargo/sethvargo/useragent
...
Add a common package for specifying useragent and adopt that everywhere
2018-04-05 15:38:11 -07:00
d236f26439
allow users to access winrm password in powershell and elevated powershell provisioners
2018-04-05 15:24:54 -07:00
302b1988a5
Restrict deregistered AMIs to those owned by self.
2018-04-05 13:29:36 -07:00
5eeac07b63
Include existing azure user agent
2018-04-05 14:28:51 -04:00
b17b333e29
Add a common package for specifying useragent and adopt that everywhere
...
There were 5 different formats for the Packer useragent string. This
fixes that and unifies it into a helper package.
I did not touch oracle's user-agent, because it looked kinda special.
2018-04-05 14:28:50 -04:00
f2df7a45ba
Merge pull request #6096 from arizvisa/GH-5882
...
Fixes the DHCP lease and configuration pathfinders for VMware Player.
2018-04-02 16:57:20 -07:00
67d2de8de1
Merge pull request #6079 from hashicorp/do_5866
...
add user data and user data file to oracle oci builder
2018-04-02 16:48:48 -07:00
d6e5b01a23
Merge pull request #6095 from hashicorp/OPaniC
...
prevent panics when cleaning up resources that haven't been created.
2018-04-02 16:34:34 -07:00
22608f3efd
Merge pull request #6088 from adongy/master
...
Expose more source ami data in the template
2018-04-02 16:32:16 -07:00
7e13b5c62a
prevent panics when cleaning up resources that haven't been created.
2018-04-02 11:56:11 -07:00
52f69cd91a
Validate image name.
2018-04-02 11:22:15 -07:00
2c2904c095
Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases..
2018-03-30 18:19:25 -05:00
7e9699675f
Modified device matching logs to look more consistent.
2018-03-30 18:15:46 -05:00
0533e1ad9c
Validate destination image name.
2018-03-30 13:01:52 -07:00
04790695e6
Add interpolate_build_info_test tests
2018-03-30 16:46:35 +02:00
507b3619e7
Expose more source ami data in the template
2018-03-30 10:47:11 +02:00
6e176f97a0
Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network.
2018-03-29 13:12:59 -05:00
646523c5f4
Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers.
2018-03-29 13:04:25 -05:00
f2fc064037
Merge pull request #6056 from rjosephwright/snapshots
...
Modify ebssurrogate builder to snapshot all launch devices
2018-03-29 10:15:19 -07:00
541d33a80f
Merge pull request #6067 from mcandre/virtualbox-fixes
...
VirtualBox fixes
2018-03-29 10:13:49 -07:00
56af885212
Avoid warning when using raw format.
...
When using the raw image format and attempting to resize it we get the following error message:
```
WARNING: Image format was not specified for 'test.raw' and probing guessed raw.
Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
Specify the 'raw' format explicitly to remove the restrictions.
```
Specifying the format will remove this warning.
2018-03-29 14:51:02 +03:00
7623c26e4e
Merge pull request #6057 from arizvisa/GH-5925
...
Fixed a case-sensitivity issue when determing the network type during the cloning step in the vmware-vmx builder
2018-03-28 13:54:09 -07:00
16d044b398
add user data and user data file to oracle oci builder
2018-03-28 13:27:41 -07:00
58ecd32289
remove redundant security_protocol code from the winrm implementation of the oracle-classic provisioner
2018-03-28 10:54:06 -07:00
fdc6ac631a
fix vbox scancodes and support critical key combinations during boot-time operations
2018-03-26 18:35:45 -05:00
55702a697a
Ack, forgot to :w in vim. Changed ui.Say in step_clone_vmx.go to use fmt.Sprintf as it originally was a call to log.Printf.
2018-03-25 19:03:46 -05:00
1913517d29
Fix formatting by running `make fmt`
2018-03-25 19:51:49 -04:00
72da7cbfbb
Fixed a case-sensitivity issue when determing the network type during cloning in the vmware-vmx builder and added also some logs that output the different options that were determined from the .vmx. This outputs more accurate debug information and helps out with issue #5925
2018-03-25 18:51:37 -05:00
cb3699a584
Modify ebssurrogate builder to snapshot all launch devices
...
Documentation for ebssurrogate states that all of the devices in
`launch_block_device_mappings` are snapshotted and included in the
image. In fact, only the device that was designated as the root
device was snapshotted. This patch modifies the builder to create
snapshots of all the devices and include them in the image. This
allows creating images with separate filesystems preconfigured,
rather than having to add volumes to `ami_block_device_mappings`
and configure them after boot.
2018-03-25 19:37:44 -04:00
7253d6547b
minor LXD documentation tweaks
2018-03-23 15:46:39 -07:00
088b4ab275
Merge pull request #6038 from ChrisLundquist/clundquist/more-lxd-config
...
[WIP] LXD fixes and feature requests
2018-03-23 15:38:28 -07:00
072cd6b745
Merge pull request #5998 from hashicorp/do_5895
...
allow users of AWS to use the dynamically-generated admin password wh…
2018-03-22 16:01:22 -07:00
95aa7e67bd
Merge pull request #5893 from neumayer/privateip
...
Allow using private ip addresses for oracle oci builder
2018-03-22 09:42:19 -07:00
61432cd257
Update logs to talk about IP instead of public IP
...
When logging we don't know whether we use a private or public ip, just
the ip itself.
2018-03-22 09:08:25 +01:00
1f4212efa7
builder/openstack: Add instance_name config to OpenStack builder
...
RFC952 restricts hostname not to use underline(_) and period(.), so
private cloud with legacy DNS system does not allow just to use
image_name for name of server.
Add instance_name config option for servers which packer creates to
make instance_name configurable. If instance_name is not specified,
by default it works like the past using image_name for instance_name.
2018-03-22 11:20:14 +09:00
ef4f3f143b
Merge pull request #5985 from AndiDog/f-5979-vmware-fusion-guestip-lookup-multiple-devices
...
Handle multiple devices per VMware network type
2018-03-21 17:12:36 -07:00
eb201724c1
azure: unit tests for naming temp resources
2018-03-20 16:20:11 -07:00
c877312a4d
builder/triton: Add support to Skip TLS Verification of Triton URL
...
In order to allow Packer to connect to Private Triton installations
we now expose `insecure_skip_tls_verify` which, if set to true, will
allow the user to make requests to Triton installations that use a
certificate not signed by a trusted root CA
2018-03-20 22:10:12 +02:00
4f5e7fe060
first pass at allowing configurable sleep timeouts, profiles, and launch configs
2018-03-20 19:30:46 +00:00
aa54f908ed
Merge pull request #6019 from hashicorp/fix-aws-credentials
...
Fix aws credentials
2018-03-19 10:13:09 -07:00
49958391b3
better error when source_path doesn't exist.
2018-03-19 09:58:39 -07:00
b16f2ec64b
builder/amazon: Use sdk default cred providers
...
I think we were overcomplicating things. The SDK provides the correct
credential chain by default, so let's use that. This patch does a quick
check for static credentials and uses those if found, then defaults to
the default credential provider chain.
This patch also removes the metadata timeout argument. Current versions
of the SDK have short timeouts by default, so I don't believe this is
needed.
2018-03-15 16:49:47 -07:00
e483087574
builder/amazon: Use service default retries.
...
Each service has its own preconfigured number of times to retry.
Lets use that instead of setting a global number.
2018-03-14 22:26:35 -07:00
d689e6b4d3
allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.
2018-03-14 15:58:12 -07:00
414dd80e61
Merge pull request #6013 from jsoref/spelling
...
Spelling
2018-03-14 09:50:27 -07:00
27dfe92f1c
spelling: virtualization
2018-03-14 03:29:14 +00:00
0171dfc890
spelling: validating
2018-03-14 03:28:19 +00:00
b81672c906
spelling: valid
2018-03-14 03:28:00 +00:00
33f90d7783
spelling: unmarshalling
2018-03-14 03:27:22 +00:00
3b694feabc
spelling: transfer
2018-03-14 03:25:35 +00:00
5a393d4fac
spelling: template
2018-03-14 03:24:51 +00:00
c563ef0797
spelling: structure
2018-03-14 03:23:56 +00:00
007930ec2d
spelling: restricted
2018-03-14 03:20:51 +00:00
aae5b50dab
spelling: response
2018-03-14 02:19:26 +00:00
8294c8bc66
spelling: receive
2018-03-14 02:19:01 +00:00
fa36e1d961
spelling: processing
2018-03-14 02:17:22 +00:00
8c72bba160
spelling: possible
2018-03-14 02:14:18 +00:00
aeb25d2c61
Merge pull request #5991 from evandbrown/google-disable-default-service-account
...
builder/googlecompute: Optionally disable service account
2018-03-13 13:39:08 -07:00
7eda44d28c
builder/googlecompute: disambiguate disable_default_service_account
...
This change requires 'disable_default_service_account=false' in order to
set 'service_account_email'.
This is a guard against an incorrect assumption
that disabling the default service account would mean that no service
account would be used.
2018-03-13 12:39:41 -07:00
2de0652eb4
Merge pull request #6003 from boumenot/pr-azure-support-force
...
azure: respect -force for managed image deletion
2018-03-13 09:47:16 -07:00
18f51e7338
spelling: parameters
2018-03-13 08:29:17 +00:00
61030c0d85
spelling: output
2018-03-13 08:27:26 +00:00
e43b8de3b1
spelling: network
2018-03-13 08:14:30 +00:00
d987fcefc3
spelling: multiples
2018-03-13 08:12:53 +00:00
cab8b6ed68
spelling: maximum
2018-03-13 08:10:20 +00:00
73d3d65b84
spelling: marshal
2018-03-13 08:10:01 +00:00
964d5dd55e
spelling: mapstructure
2018-03-13 08:09:41 +00:00
ae4abedfa2
spelling: mandatory
2018-03-13 08:10:59 +00:00
933ac20e68
spelling: instance
2018-03-13 08:04:50 +00:00
62f59662a3
spelling: installation
2018-03-13 08:04:40 +00:00
1e99dce12b
spelling: inertness
2018-03-13 08:05:14 +00:00
3a31baae4f
spelling: incorrect
2018-03-13 08:00:05 +00:00
57c0e9e4a7
spelling: illegal
2018-03-13 08:02:43 +00:00
210f8e8312
spelling: hyphen
2018-03-13 07:59:00 +00:00
24b4c36fc9
spelling: function
2018-03-13 07:52:02 +00:00
dc942a0d8a
spelling: first
2018-03-13 07:50:00 +00:00
466f0d2be4
spelling: firewall
2018-03-13 07:49:46 +00:00
041a115f65
spelling: existent
2018-03-13 08:15:56 +00:00
33bf6de921
spelling: exceeds
2018-03-13 07:46:49 +00:00
04d6bfc696
spelling: environment
2018-03-13 07:41:21 +00:00
9b9ab4c492
spelling: encrypt
2018-03-13 07:41:47 +00:00
83471c8399
spelling: doesn't
2018-03-13 07:39:58 +00:00
60ef3c3374
spelling: directories
2018-03-13 07:37:32 +00:00
939e7d5587
spelling: delete
2018-03-13 07:36:38 +00:00
efb525f03d
spelling: creating
2018-03-13 07:22:37 +00:00
935c8e9a28
spelling: configuration
2018-03-13 08:19:16 +00:00
47a4bbd9f5
spelling: compaction
2018-03-13 07:22:09 +00:00
5010bfda39
spelling: comes
2018-03-13 07:20:55 +00:00
f362789174
spelling: because
2018-03-13 07:15:08 +00:00
7895051962
spelling: attribute
2018-03-13 07:12:16 +00:00
75a7ceec48
spelling: alicloud
2018-03-13 07:09:12 +00:00
fe98bcc5a1
spelling: address
2018-03-13 07:07:10 +00:00
8481663d4a
Merge pull request #6005 from boumenot/pr-azure-randomize-resource-names
...
azure: support concurrent deployments in the same resource group
2018-03-12 17:00:44 -07:00
5055fa66aa
Merge pull request #5987 from mcandre/multibyte-scancodes
...
send multibyte scancodes accurately to virtualbox
2018-03-12 16:23:41 -07:00
2a88672cd9
add test for modifyer keypress commands
2018-03-12 15:08:30 -07:00
3207ffbd9a
Merge pull request #6002 from mcandre/fix-6001
...
fix later commands overwriting earlier commands
2018-03-12 15:07:43 -07:00
2a21032964
azure: randomize NIC and Public IP names
2018-03-11 20:47:45 -07:00
149ce52079
azure: respect -force for managed image deletion
2018-03-10 10:43:28 -08:00
1d48812b34
fix later commands overwriting earlier commands
2018-03-09 20:17:43 -06:00
b1eaaed6fb
Merge pull request #5970 from boumenot/pr-azure-plan-info
...
azure: support for marketplace plan information
2018-03-09 15:21:03 -08:00
1ef491d4c8
incorporate reviewer feedback
2018-03-08 22:43:26 -08:00
4a2c124ea2
builder/googlecompute: Optionally disable service account
...
The ability to use a service account other than the default was
introduced in #5928 . This change adds to that by introducing the
'disable_default_service_account' config option. If true - and
'service_account_email' is not set - Packer will create a GCE VM
with no service account.
2018-03-07 20:53:26 -08:00
f305a2f4c2
send multibyte scancodes accurately to virtualbox
2018-03-07 10:59:02 -06:00
ff92fb883d
Handle multiple devices per VMware network type
...
Fixes #5979
2018-03-07 10:59:55 +01:00
ac2e02b938
remove loglines that should not have made it onto master
2018-03-06 14:12:39 -08:00
97060d100c
Merge pull request #5928 from kri5/service_account_gce
...
Builder GoogleCompute: Allows to specify GCE service account build VM
2018-03-06 13:41:33 -08:00
d3f1b501c6
Merge pull request #5975 from arizvisa/GH-5961
...
Disable the usage of the XHCI bus for USB on the vmware-iso builder.
2018-03-06 09:48:38 -08:00
df6cdcc7f7
Disable the usage of the XHCI bus for USB on the vmware-iso builder.
...
Some platforms with incomplete XHCI implementations (i.e. FreeBSD)
will poll the bus despite there being no usb devices available.
This disables XHCI by default and documents how to enable it using
the vmx_data option.
This closes issue #5961 .
2018-03-05 20:58:43 -06:00
980c777000
Merge pull request #5960 from LessMo/master
...
builder/amazon: Added new region cn-northwest-1
2018-03-05 17:41:12 -08:00
585e31e47a
Merge pull request #5974 from boumenot/pr-azure-better-error-message
...
azure: better error message
2018-03-05 17:28:50 -08:00
d2e593de37
azure: support for marketplace plan information
2018-03-05 09:05:21 -08:00
8166ba2d8d
azure: better error message
2018-03-04 21:21:02 -08:00
e0ac07f5db
azure: correct function name spelling
2018-03-03 08:53:10 +00:00
686cacb435
builder/amazon: Added new region cn-northwest-1
...
Add new region China Ningxia cn-northwest-1.
2018-03-02 16:34:19 +08:00
675dc06967
Tests for the optional disk_additional_size configuration.
2018-02-26 17:37:46 -08:00
33c3d2885d
Add the additional disk steps to the Linux build
2018-02-26 17:33:40 -08:00
47947bd0f6
Apply gofmt
2018-02-23 18:43:55 -08:00
efcdbfeab9
Add support for optionally building Azure VMs with additional disks.
2018-02-23 15:34:13 -08:00
103186af86
Adds Support to configure hyper-v disk block size
2018-02-23 20:19:26 +01:00
9e8e376d6c
Merge pull request #5932 from hashicorp/add_configurable_snapshot_timeout
...
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:27:20 -08:00
597ddc2192
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:01:53 -08:00
16882c1252
builder/googlecompute: Go code formatting
2018-02-22 17:19:13 +01:00
4befdce47e
builder/googlecompute: Adds ability to specify service account
...
This commit allows user to specify the service account they want
to associate with the virtual machine provisionned by setting
the service_account_email field in the config.
It allows to manage permissions of the instantiated VM properly,
using a service account that can be tied up to IAM roles and
permissions.
2018-02-22 17:19:13 +01:00
33acdbf3bf
move comments so indentation is more logical
2018-02-21 14:57:58 -08:00
3ea7fc9876
Merge pull request #5931 from arizvisa/GH-5916
...
Fixes the assumption that all the VMware builder's drivers will implement a network mapper for mapping a network name to it's corresponding device.
2018-02-21 14:56:53 -08:00
cfede07228
Merge pull request #5929 from hashicorp/oracle_classic_winrm
...
Oracle classic winrm
2018-02-21 13:31:40 -08:00
df45e0916d
Add the winRM communicator to Oracle Classic builder.
...
update oracle classic docs with a minimal working windows example
2018-02-21 13:21:54 -08:00
ac2ddbcbf5
Fixes the assumption that all the VMware builder's drivers will implement a network mapper for mapping a network name to it's corresponding device.
...
The ESX5 driver doesn't have a way of mapping the network name to its device name because a .vmx template uses different field names for it and so packer let's ESX handle filling this in. This patch will check to see if the driver that packer determines is missing a NetworkMapper implementation (by checking for nil). If it is, then fall back to using "nat" despite ESX not using the network type at all. This is what packer did prior to exposing the network type to the user back in version 1.1.3.
This closes issue #5916 .
2018-02-20 19:45:55 -06:00
1b4956aef8
Merge pull request #5900 from arizvisa/GH-5882
...
Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux.
2018-02-20 11:28:32 -08:00
2806523834
Fix issue with assume role credentials
2018-02-15 14:54:01 -08:00
27ed479b0a
Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux.
...
It was reported that on WS14 on Linux, that the path may be different than stated in the documentation. This modifies `workstationDhcpConfPath` and `workstationDhcpLeasesPath` functions to walk through every permutation while attempting to find the correct file.
This reinforces the fix for issue #5882 .
2018-02-14 00:11:17 -06:00
d6e5342ece
Fixed a type-o in the VMWare builder when locating the dhcp configuration file on Linux.
...
Closes issue #5882 .
2018-02-13 17:27:17 -06:00
ff30b3b3f7
Remove unrelated changes
2018-02-13 14:23:19 +01:00
30fa1494d5
Add option to use prive ip for oci builder
2018-02-13 14:20:26 +01:00
7966e202b7
Fix typo
2018-02-13 13:25:48 +01:00
4be86e2e18
Merge pull request #3417 from arizvisa/vmware-iso-extraconfig
...
Added support for sound, serial/parallel/usb ports, and mapping the correct network (via a couple parsers) for the VMware builder.
2018-02-09 13:01:01 -08:00
19a89a101e
builder/amazon: remove ssh_private_ip
...
ssh_private_ip should now be set through ssh_interface.
Adds fixer to automatically fix existing json files
2018-02-08 16:47:43 -08:00
125a9133d4
Merge pull request #5874 from hashicorp/do_5866
...
fail in oracle classic builder if user tries winrm since it doesn't w…
2018-02-08 14:57:35 -08:00
5b64f71702
Merge pull request #5764 from hashicorp/fix5760
...
"borrow" access config code from terraform.
2018-02-08 14:55:43 -08:00
7f631fcb77
unpack attributes in oracle-classic builder earlier so that we error fast if there's an issue
2018-02-08 14:12:39 -08:00
ff717c5784
wrong place for differentiation between ssh and winrm
2018-02-08 13:21:21 -08:00
ad2e5f1f08
fail in oracle classic builder if user tries winrm since it doesn't work yet, and add attributes and attributes_file fields to oracle builder
2018-02-08 12:52:44 -08:00
e752e3a018
use new internal multistep helper
2018-02-08 12:10:11 -08:00
22b12432db
builder/scaleway: support ssh agent authentication
2018-02-08 12:10:11 -08:00
1f7c32db98
builder/scaleway: report to ui scw api startup error
2018-02-08 12:10:11 -08:00
7f8ed28bc6
builder/scaleway: Make use of NewRunnerWithPauseFn
2018-02-08 12:10:11 -08:00
fc7d89eb79
builder/scaleway: support password auth
2018-02-08 12:10:11 -08:00
eb56b1b70e
Fix terminate error
2018-02-08 12:10:10 -08:00
b44798b38d
Raise error in case of create server failure
2018-02-08 12:10:10 -08:00
09805911b4
Fix builder unique id
...
Add new ARM64 commercial types
DOC - Add default value for optional settings
DOC - Fix typo
2018-02-08 12:09:25 -08:00
2de93c5ae6
Add existing SSH key support
...
Update documentation
2018-02-08 12:09:25 -08:00
1fb13cc23e
Add image creation from snapshot
...
Rename organization_id / access_key
Update test / doc
2018-02-08 12:09:25 -08:00
9b611af7e6
Allow token and organization id to be passed via env vars
2018-02-08 12:09:25 -08:00
7e36cfcff1
Add Scaleway builder
2018-02-08 12:09:24 -08:00
6205c71f98
Merge pull request #5791 from YuSungDuk/master
...
Naver Cloud Platform builder
2018-02-08 11:10:18 -08:00
c29e5de381
Remove the deprecated extensions
...
The Nova extension API was deprecated from OpenStack N release.
this parts of code cannot work well with the newest OpenStack version.
This patch is to remove the relative parts:
1. Remove the step_load_extensions.go
2. Remove the step of extension from builder.go
3. Remove the parameter parsing from step_stop_server.go
Resolves : #5581
2018-02-06 17:36:47 -08:00
0ebdad2934
fix communicator type : Windows -> winrm
2018-02-07 10:29:56 +09:00
8510f072a9
Merge pull request #5841 from hashicorp/fix5447
...
Add volume and run tags if in us-gov/china
2018-02-05 17:29:12 -08:00
21812fa17f
Add volume and run tags if in us-gov/china
...
We can't tag on instance creation when we're in "restricted" regions,
so let's add the tags after the resources have been created.
Adds methods to AccessConfig to detect if we're in China or US Gov
regions (i.e. "restricted").
Also turns tag:tag maps into a type, and moves methods around validating
and converting them to ec2Tags to methods of the type.
2018-02-05 16:39:20 -08:00
ff64ccda55
Merge pull request #5426 from hashicorp/fix_4915
...
Fix 4915
2018-02-05 14:54:27 -08:00
7d5d62d748
Merge pull request #2906 from arizvisa/GH-2377
...
Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme
2018-02-05 09:53:47 -08:00
eaef2961cb
Support specifying licenses for Google Compute images
...
This is needed to enable features such as the nested virtualization:
https://cloud.google.com/compute/docs/instances/enable-nested-virtualization-vm-instances
2018-02-03 14:15:16 -06:00
fa2dddd26d
Fixed some things mucked up during rebase.
2018-02-02 19:45:18 -06:00
aefe41a44a
Fixed an issue with the previous commit so that when the user does not specify the cdrom_adapter_type to fallback to the original decision made by the disk adapter type selection.
2018-02-02 19:18:50 -06:00
eb0445ca96
Added support for specifying both the network adapter type and cdrom adapter type as requested by @night199uk. Also included the respective documentation for these new options.
2018-02-02 19:18:50 -06:00
74946071d2
Added support for specifying the disk adapter type to the vmware builders. This was squashed from the vmware-diskAdapterType branch ( #2968 ) as submitted by Rami Abughazaleh <icnocop@users.noreply.github.com>. This closes #5671 and possibly #4885 .
...
arizvisa: Updated icnocop's documentation to include the possible disk adapter types that one can specify.
arizvisa: Tweaked icnocop's support for the `disk_adapter_type` option to the VMWare builder that caused conflicts due to version skew.
icnocop: Updated links to the Virtual Disk Manager User's Guide PDF to open in a new window and also added the Adobe PDF icon
icnocop: Added support for vmware to specify the disk adapter type, ide or scsi (lsilogic or buslogic)
2018-02-02 19:18:49 -06:00
594ed950c7
Fixed a race condition in builder/vmware/common/driver_parser.go due to a misunderstanding how channels work when you close them.
2018-02-02 19:18:49 -06:00
737e951685
Added missing root path to path-finders for the VMware Fusion implementation in the vmware builder as mentioned by @SwampDragons.
2018-02-02 19:18:49 -06:00
b2fec18b1e
Added parser for VMware Fusion's networking file. Replaced VmwareDriver's NetmapConfPath with a NetworkMapperInterface in order to handle the differences between VMware Fusion and the rest of the VMware suite.
2018-02-02 19:18:49 -06:00
069d00f70b
Added the paths suggested by @phekmat and @SwampDragons for VMware Fusion... Although parser for the new mapper format is likely to be needed still.
2018-02-02 19:18:49 -06:00
8cc0776f3a
Fixed oversight in VMware builder's mock-driver that neglected to initialize 'HostAddressResult'.
2018-02-02 19:18:49 -06:00
029c357d8c
Modified some tests to require the PACKER_ACC environment variable to be set before executing them. This turns them into acceptance tests as per CONTRIBUTING.md.
2018-02-02 19:18:49 -06:00
58ebc5c9a5
When specifying NONE for serial or parallel in the VMware builder, disable the serial and parallel port devices entirely.
2018-02-02 19:18:48 -06:00
258804106b
Added missing GetVmwareDriver() method to VMware Builder's DriverMock.
2018-02-02 19:18:48 -06:00
6423525a33
Updated imports of github.com/mitchellh/packer to new naming scheme github.com/hashicorp/packer
2018-02-02 19:18:48 -06:00
75fbfa0763
Replaced a hacky type assertion in the VMware builder with a call to Driver.GetVmwareDriver() that returns the driver-specific structure for ip and addressing information. Also implemented the addressing functions for the ESXi driver interface.
...
This fixes an issue where a driver might not have defined a VmwareDriver by forcing a developer to implement it via the standard Driver interface.
2018-02-02 19:18:48 -06:00
898b27c16d
Added support for the NONE option to be specified for parallel and serial ports in the vmware iso builder.
2018-02-02 19:18:48 -06:00
884af69da1
go fmt on builder/vmware/*
2018-02-02 19:18:48 -06:00
0d6cf7fac4
Added support for auto-detection to the serial and parallel port types.
...
Included the yield option to all the serial port types.
Added the ability for the network type to fallback to a custom network if the
specified network name is not found in netmap.conf.
Promoted the scope for both Read{Dhcp,Netmap}Config inside vmwcommon.driver.
Updated the documentation for the VMware builder.
2018-02-02 19:14:29 -06:00
b52e2d3f45
Added the ability for the vmware-builder to fallback and determine the network device-name using the .vmx configuration in case of a guest using the "custom" connection type.
2018-02-02 19:13:02 -06:00
e389d30a1b
Implemented the unit-tests for builder/vmware/iso/step_create_vmx.go
2018-02-02 19:13:02 -06:00
15cb6a833a
Ugh..missing argument in VMware builder's driver_esx5 unit-test due to api change for .HostIP(). Fixed.
2018-02-02 19:11:41 -06:00
9b95ce0bc6
Completely forgot to support the unix paths in each of the drivers for the VMware builder. Fixed.
2018-02-02 19:11:41 -06:00
4225b3568e
Fixed bad ORs and a bad fmtstring.
2018-02-02 19:11:41 -06:00
75d3ea7cee
Added support for sound, serial ports, parallel ports, usb, and specifying a default network to the vmware builder.
...
builder/vmware/{iso,vmx}:
Added the specific configuration options that get parsed.
Normalize paths when pulling them from the json template so that they'll work on Windows too.
Added some improved error checking when parsing these options.
Stash the vm's network connection type so that other steps can figure out addressing information
Modified the esx5 driver to support the new addressing logic.
Modified the template in step_create_vmx to include the new options.
builder/vmware/common:
Implemented a parser for vmware's configuration files to the vmware builder.
Modified the driver's interface to include support for resolving both guest/host hw and ip addresses
Implemented a base structure with some methods that implement these features.
Rewrote all ip and mac address dependent code to utilize these new methods.
Removed host_ip and guest_ip due to their logic being moved directly into a
base-structure used by each driver. The code was explicitly checking runtime.GOOS
instead of portably using net.Interfaces() anyways.
Updated driver_mock to support the new addressing methods
2018-02-02 19:11:41 -06:00
8ae8f31a52
Merge pull request #5681 from mcandre/super-key
...
add super key (vmware builder)
2018-02-02 13:33:11 -08:00
caea770af1
Merge pull request #5819 from hashicorp/oracle-oci-builder
...
Oracle oci builder
2018-02-02 11:56:18 -08:00
3c88e787df
Merge branch 'master' into hyperv_mac_address
2018-02-02 09:26:52 +11:00
6d14eb6ea4
Merge pull request #5631 from vijayinvites/diffdisks
...
[Hyper-V] Use differential disks and Inline disk creation to improve build time (a lot) and to reduce disk usage(a lot)
2018-01-31 16:51:27 -08:00
383ac13e2a
update default of image list after adding new entry.
2018-01-31 16:37:55 -08:00
8f7937f492
fix machine image name to include prepended /
2018-01-31 15:22:09 -08:00
3180dc327c
remove copypasta comment
2018-01-31 15:02:19 -08:00
8bdd3b45c7
use helper functions for reading vmx files
2018-01-31 13:19:31 -08:00
66cd85828e
rename dest_image_list_description to image_description
2018-01-31 12:48:40 -08:00
baf8d30ad2
Merge pull request #5738 from testworksau/intel-haxm-support
...
Add Intel HAXM support to QEMU builder
2018-01-31 12:41:15 -08:00
af26b312cd
fix logline
2018-01-31 11:35:34 -08:00
871ead371a
Clean up based on Oracle comments
2018-01-31 10:47:19 -08:00
f39c3458f7
fix Run method arguments for testing
2018-01-30 10:20:02 +09:00
705459c260
add snapshotted machine image to image lists, then delete the snapshot.
2018-01-29 16:50:53 -08:00
e68a742bca
make fmt
2018-01-29 22:44:24 +09:00
175dd2730f
Use 'github.com/hashicorp/packer/helper/multistep'
2018-01-29 22:41:22 +09:00
5714108ef9
Merge branch 'master' into support_ncloud
2018-01-29 22:10:18 +09:00
6b40c726e0
Use `PublicIp` for communicator
2018-01-29 22:07:32 +09:00
e57a8161e0
remove delete step of `login key` and `public ip instance`.
2018-01-29 21:47:58 +09:00
2a3a35334a
Logging root password
2018-01-29 20:42:22 +09:00
30f8fee402
use comment with english
2018-01-29 19:08:53 +09:00
3820f97a0b
use state storage to save `feeSystemTypeCode`
2018-01-29 18:35:43 +09:00
2152ad7609
Add UserDataFile
2018-01-29 18:09:14 +09:00
da78ebbf83
- Remove plugin version
...
- remove `os_type`. use `communicator` instead of this.
2018-01-29 17:29:26 +09:00
76b2ce8604
log which vmware driver we decide on
2018-01-26 16:12:43 -08:00
07421b4433
test vmware workstation version checking
2018-01-26 15:58:17 -08:00
56c6fed42a
ui.say vs ui.message
2018-01-26 15:20:12 -08:00
3ee1aa3ed6
clean up ip reservations
2018-01-26 15:18:33 -08:00
565b660b19
comments
2018-01-26 14:28:27 -08:00
98857c42cf
add tests; fix a couple issues caught by said tests
2018-01-26 14:27:31 -08:00
9edd98f7b0
Use more uuids and make messaging consistent.
2018-01-26 13:43:19 -08:00
c6b43ce6e9
remove errouneous double prep
2018-01-26 13:13:13 -08:00
71acccc1ed
add UI output with resource names
2018-01-26 13:12:35 -08:00
18ffde4ecf
remove unused file
2018-01-26 12:59:46 -08:00
fad4d5c272
update tests for mapstructure behavior changes
2018-01-26 12:40:34 -08:00
0e5be59947
wrap error message for clarity
2018-01-26 09:55:31 -08:00
ff9fef5ed2
switch to using a UUID for packer-generated keys, and clean them up at end of build
2018-01-26 09:51:16 -08:00
b6d21ecd63
validate that required fields are present
2018-01-26 08:53:24 -08:00
25bc1da8fe
remove unsused access config
2018-01-26 08:48:23 -08:00
Hariharan Jayaraman
Christopher Boumenot
Chris Lundquist
Matt Coleman
DanHam
Unknown
M. Marsh
Stefan Henseler
Christopher Boumenot
Paul Meyer
Rickard von Essen
Paul Meyer
Matthew Hooker
Oskar Wycislak
AlessioT
Adam Robinson
Ali Rizvi-Santiago
Matthew Donoughe
Richard Nienaber
Evgeni Golov
Harvey Lowndes
Seth Vargo
ADO
Omer Katz
Andrew Pennebaker
Joseph Wright
Robert Neumayer
Yang Youseok
stack72
Josh Soref
Evan Brown
Andreas Sommer
Less Mo
jmajoor
Christophe Courtaut
Loïc Carr
Edouard BONLIEU
Edward
유성덕
Petr Hosek
Ben Phegan