Adrien Delorme
941dc394f0
Update step_run_spot_instance.go
2019-09-27 13:04:52 +02:00
Adrien Delorme
d049284120
Update builder/amazon/common/step_run_spot_instance.go
...
remove unused code that might induce errors
2019-09-27 13:00:53 +02:00
Adrien Delorme
07e97e26de
step_run_source_instance.go: make sure we use the right ShouldRetry error
2019-09-27 12:57:55 +02:00
Megan Marsh
c722009159
we only need one describeInstances call, not 3, and it should be wrapped in a retry
2019-09-26 15:47:01 -07:00
Megan Marsh
e47059aaca
put retry around describeinstances call in amazon
2019-09-26 14:49:28 -07:00
Megan Marsh
31bb1e818f
fix tests
2019-09-26 13:02:11 -07:00
Megan Marsh
0cbd3ff0f3
make sure amazon builders respect ssh_host option
2019-09-26 12:30:04 -07:00
Paul Meyer
698c9c44d4
Merge pull request #8121 from paulmey/clientconfig
...
[azure] Refactor client config
2019-09-26 10:49:13 -07:00
Megan Marsh
72d393c95a
update docs to show a use case for block device mappings
2019-09-25 16:48:04 -07:00
Megan Marsh
0683bc409b
add test for error-cleanup provisioner, and fix tests by fixing null builder to use an actual none communicator instead of skipping communicator generation altogether
2019-09-25 13:39:09 -07:00
Paul Meyer
c72a612b44
Re-added tests for FillParamters
2019-09-25 20:33:38 +00:00
Paul Meyer
094a8840d8
Improve comments for FillParameters
2019-09-25 20:33:38 +00:00
Paul Meyer
feeae1514e
Refactor client config
2019-09-25 20:33:38 +00:00
Megan Marsh
e5e864c624
Merge pull request #8143 from hashicorp/google_vault_oauth
...
Google vault oauth
2019-09-25 10:12:29 -07:00
Gennady Lipenkov
d070b4868a
Wrap values with backticks
...
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
2019-09-25 16:04:45 +03:00
Gennady Lipenkov
00e4e0c7a7
Add description of field in config struct
...
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
2019-09-25 14:31:27 +03:00
Megan Marsh
3c14c50aba
Allow user to real oauth token from properly configured Vault instance
2019-09-23 13:26:03 -07:00
Megan Marsh
2a662b451c
Merge pull request #8142 from yandex-cloud/yandex-add-retries
...
Add retries to Yandex builder
2019-09-23 12:23:47 -07:00
Megan Marsh
c24693372d
Merge pull request #8132 from scienty/support_floppy_vmx_esxi
...
Support floppy_files for vmx on esxi
2019-09-23 12:20:49 -07:00
Gennady Lipenkov
fceaa9ccf9
Add retries to Yandex builder
...
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
2019-09-23 21:03:17 +03:00
Megan Marsh
f0461da1a1
Merge pull request #7724 from hashicorp/scrape_doc_to_builder_struct_config
...
Generate builder documentation markdown from structs.
2019-09-20 16:50:39 -07:00
Adrien Delorme
4fb05e5bc4
fix test
2019-09-20 15:28:43 +02:00
Adrien Delorme
792f61a4ad
fmt
2019-09-20 15:18:48 +02:00
Adrien Delorme
55f1c734d0
fix alicloud docs a little
2019-09-20 15:10:02 +02:00
Adrien Delorme
849de792da
re-apply doc changes of master
2019-09-20 15:04:01 +02:00
Adrien Delorme
299544a4c7
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-20 14:47:02 +02:00
Adrien Delorme
3fe9d52e3f
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-20 11:15:44 +02:00
Prakash Sidaraddi
67be007f45
Support floppy_files for vmx on esxi
2019-09-20 00:23:28 +05:30
Megan Marsh
30f86bb778
fix ssh and package steps to use source syntax.
2019-09-18 13:15:49 -07:00
Megan Marsh
577a34b1c3
Merge pull request #8106 from shapeblue-br/master
...
[cloudstack builder] Detach iso option step
2019-09-17 10:15:09 -07:00
Megan Marsh
35357616e0
Merge pull request #8112 from milescrabill/packer-googlecompute-validate-imagename
...
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s
2019-09-17 10:00:33 -07:00
Adrien Delorme
f779530715
Merge pull request #8102 from hashicorp/fix_8085
...
don't fall for nil pointer dereference in account file
2019-09-17 17:00:52 +02:00
Lars Lehtonen
c6212731ff
builder/vagrant: fix dropped errors in code and tests
2019-09-17 05:39:23 -07:00
Miles Crabill
2bff60bac8
address review feedback
2019-09-16 13:50:43 -07:00
Miles Crabill
328baced05
add some test cases for image names
2019-09-16 10:18:22 -07:00
Miles Crabill
c11a444f77
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s
2019-09-16 10:10:41 -07:00
Lars Lehtonen
6c1ce2bd9a
builder/openstack: Fix dropped error
2019-09-16 06:26:56 -07:00
Adrien Delorme
4d4bd38afa
Merge pull request #8087 from hashicorp/fix_8048
...
add retry wrapper to query so it handles rate limiting
2019-09-16 10:25:12 +02:00
William Bianchini
d022c2194a
[cloudstack builder] Detach iso step
...
Detach iso file after loading image to cache, allowing OS to boot from
volume ater the installation
Add eject iso check and wait timeout
Closes #7235
2019-09-13 21:33:49 -03:00
Megan Marsh
a6e263adb6
don't fall for nil pointer dereference in account file
2019-09-13 16:37:19 -07:00
Megan Marsh
fc6a4fd5d8
Merge pull request #8021 from hashicorp/fix_7959
...
[WIP] implement custom data type "trilean" (tri-state-boolean) to track boo…
2019-09-13 14:42:27 -07:00
Megan Marsh
9503802814
adding ctx makes the cancel channel redundant
2019-09-13 14:32:13 -07:00
Megan Marsh
4b497006b3
add retry wrapper to query so it handles rate limiting
2019-09-13 14:32:13 -07:00
allinwait
171c2a9a07
add the floppy label option
2019-09-12 12:25:22 +00:00
Adrien Delorme
2e58b807de
Merge pull request #8096 from onematchfox/virtualbox-snapshot
...
fix(virtualbox-vm) LoadSnapshots should succeed even if machine has no snapshots
2019-09-12 13:18:46 +02:00
Adrien Delorme
1d0cf1db98
Merge pull request #8092 from milescrabill/fix-vagrant-builder-stepup
...
vagrant builder: use GlobalID where provided, add test for `vagrant up` args generation
2019-09-12 13:13:04 +02:00
Brian Fox
5b6dcb0c94
fix(virtualbox) LoadSnapshots should succeed even if VM has no snapshots
2019-09-12 10:51:12 +02:00
lonegunman
0de807cce0
make ucloud builder's base url configurable
2019-09-12 11:33:57 +08:00
Miles Crabill
e6d2a97e12
s/destory/destroy
2019-09-10 14:31:00 -07:00
Miles Crabill
7850bf8bc5
use GlobalID where provided, add test for `vagrant up` args generation
2019-09-10 10:46:16 -07:00
Gennady Lipenkov
524b822e11
Support GPU instances, allow set source image by name
...
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
2019-09-10 17:52:42 +03:00
Adrien Delorme
597a3e323b
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-10 13:20:07 +02:00
Adrien Delorme
350aa54274
Update step_shutdown_test.go
...
bump test duration
2019-09-10 13:07:30 +02:00
Adrien Delorme
146b88ba1e
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-10 12:44:46 +02:00
Adrien Delorme
de9bb26f62
Merge branch 'master' into fix_7959
2019-09-10 12:21:33 +02:00
Adrien Delorme
e730e9f3ce
Merge pull request #8051 from DanHam/aws-vol-tags
...
Add ability to set `run_volume_tags` for Amazon EBS Volume builder
2019-09-10 12:04:58 +02:00
Calle Pettersson
b467bb22a3
Shorten default boot_key_interval to 5ms from 100ms
2019-09-09 22:33:48 +02:00
Adrien Delorme
dad3ae1535
Merge pull request #8084 from carlpett/check-disk-format-set
...
builder/proxmox: Check that disk format is set when pool type requires it
2019-09-09 10:33:50 +02:00
Adrien Delorme
78bfda582f
Merge pull request #8083 from carlpett/bump-proxmox-api-dep
...
Bump proxmox api dep
2019-09-09 10:33:18 +02:00
Calle Pettersson
10ad38fcbd
Check that disk format is set when pool type requires it
2019-09-08 18:40:29 +02:00
Calle Pettersson
df41b56d9a
Change MonitorCmd/sendkeys to Sendkey
2019-09-07 23:09:16 +02:00
Calle Pettersson
8c2c1a82cb
Bump proxmox-api-go dependency
2019-09-07 23:07:45 +02:00
Adrien Delorme
a5b899770e
Merge pull request #8077 from marinsalinas/master
...
Outscale Builder: Get SSH Host from VM.Nics insead VM's Root
2019-09-05 15:40:23 +02:00
Marin Salinas
640612da92
refactor: get ssh hot from nics instead of root of the vm
2019-09-05 08:21:07 -05:00
Marin Salinas
793b3f1990
chore: remove unused code in omi config
2019-09-05 08:20:27 -05:00
Marin Salinas
7d024b9725
change ui message to private ip in run source vm
2019-09-05 08:19:58 -05:00
Calle Pettersson
0813c5bdb4
Check for StateCancelled
2019-09-04 23:03:25 +02:00
Adrien Delorme
c4c88d3768
debug template id
2019-09-04 14:29:45 +02:00
Adrien Delorme
d113dd12c1
fix panic in proxmox builder
2019-09-04 14:21:52 +02:00
Adrien Delorme
ba9ffcbf73
re-indent HWConfig struct comments
2019-09-03 17:35:29 +02:00
DanHam
bbeb1a3528
Delete any `run_volume_tags` applied to EBS volumes at instance creation
...
* Allows `run_volume_tags` to be set without requiring a major rewrite
of the (common) amazon builder code used to start an instance.
The common start up code tags the instance and *all attached volumes
at creation*. If `run_volume_tags` are set this means that any volumes
specified in `ebs_volumes` will *initially* be tagged with the
`run_volume_tags` rather than the tags set in the `ebs_volumes`
section
* Once the instance is reported to be 'ready' the step to tag the EBS
volumes is run. Once complete all volumes should have the tags
requested by the user:
* Volumes associated with the source instance should be tagged with
the tags set in `run_volume_tags` (if any)
* Each EBS volumes specified in the `ebs_volumes` section of the
template should only be tagged with its associated tags (if any)
2019-08-30 14:30:25 +01:00
DanHam
61b1605a85
More accurate error description; Add comments; Add output
2019-08-30 14:26:06 +01:00
DanHam
430d41fbf9
Add option to enable tagging of the running instances volumes
...
* Currently this results in *all* volumes attached to the instance
being tagged with the `run_volume_tags`. This includes any `ebs_volumes`
for which the user may have configured other tags.
* This issue will be addressed in a later commit
2019-08-30 14:16:29 +01:00
DanHam
30070ffb30
Sort fields and options alphabetically
2019-08-30 14:16:29 +01:00
Adrien Delorme
a841da960d
Merge branch 'master' of ssh://github.com/hashicorp/packer into scrape_doc_to_builder_struct_config
2019-08-30 15:10:29 +02:00
Adrien Delorme
c475eb57ef
Merge pull request #8047 from hashicorp/avoid_panic_when_token_in_azure_builder
...
azure builder: avoid a panic in getObjectIdFromToken
2019-08-30 11:26:48 +02:00
Adrien Delorme
7d9798f5ee
update AlicloudAccessConfig docs for SECURITY_TOKEN
...
SecurityToken=>SECURITY_TOKEN
2019-08-29 14:39:25 +02:00
Adrien Delorme
9f8e9893b3
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-08-29 14:22:16 +02:00
Lars Lehtonen
b6eadb419a
builder/qemu: Fix dropped error
2019-08-29 05:13:46 -07:00
Adrien Delorme
86cee5cbef
Merge pull request #8034 from cove/retry-describe-instances
...
add AWS API call reties on AMI prevalidation
2019-08-29 10:48:54 +02:00
Adrien Delorme
f11341c0b4
azure builder: avoid a panic in getObjectIdFromToken
2019-08-29 10:34:59 +02:00
cove
87e0a3b5e7
add prevalidating AMI name retries so the build doesn't fail when throttled
2019-08-27 18:00:08 -07:00
Adrien Delorme
9d0bc476d9
add ommited struct interpolation
...
after dcc22df609
2019-08-27 15:17:57 +02:00
Adrien Delorme
b3cdf2ac8f
remove docs typo
2019-08-27 15:16:33 +02:00
Adrien Delorme
94bb33db57
fix triple backtick indentation
2019-08-27 13:37:28 +02:00
Adrien Delorme
d135106171
fix more docs
2019-08-27 09:50:43 +02:00
Adrien Delorme
f66ca58a46
Update azure docs for config.go
...
add missing docs fields
Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
2019-08-27 09:32:03 +02:00
Adrien Delorme
783b02bd15
Update config.go
...
add missing doc fields
Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
2019-08-27 09:28:36 +02:00
Adrien Delorme
239f97471c
fix ebs volume tags doc field
...
Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
2019-08-27 09:21:29 +02:00
Adrien Delorme
5517d41468
make sure all documentation fields are there
...
* add missing `temporary_key_pair_name` field for alicloud
* add missing description to `vpc_filter` for aws
* add missing ssh communicator fields for aws
* add links for aws
* update vmware-vmx docs
* manually describe AMI Configuration section for ebsvolume
* display missing required ami_name field for aws
* add missing fields for docker
* add missing fields for openstack
2019-08-26 17:16:54 +02:00
Adrien Delorme
2db109d55b
Merge branch 'master' into scrape_doc_to_builder_struct_config
2019-08-23 17:37:53 +02:00
Adrien Delorme
2efc94521b
use trilean initializers in test where missing
2019-08-23 11:17:45 +02:00
Megan Marsh
6a895db9be
converte block device encryption to trilean
2019-08-22 14:24:22 -07:00
Megan Marsh
1d9bba6fe3
change AMIEncryptBootVolume to trilean
2019-08-22 14:04:26 -07:00
Megan Marsh
f7c8321a7e
convert alicloud s.IOOptimized into trilean in code
2019-08-22 13:59:38 -07:00
Megan Marsh
ecaec1ac58
swap out alicloud encryption *bools for trileans
2019-08-22 13:52:29 -07:00
Megan Marsh
1a6adadb89
convert EnableAMIENASupport to trilean in code
2019-08-22 13:18:22 -07:00
Megan Marsh
3c3f7f26ce
implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool.
2019-08-22 13:18:15 -07:00
Megan Marsh
04d9888657
Merge pull request #8016 from psinghal20/issue-8009
...
fix: move adding metadata step after waiting for uploading step
2019-08-22 11:24:37 -07:00
Pratyush Singhal
dbb50337bc
fix: out of scope blockStorageClient nil value issue
...
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
2019-08-22 20:50:46 +05:30
Megan Marsh
fcef7e2d85
this timeout regularly flakes on Travis, I suspect because the instances running the tests are brutally underpowered. Increase the fudge factor.
2019-08-21 16:36:42 -07:00
Adrien Delorme
4cb7c30987
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-08-21 16:44:23 +02:00
psinghal20
bbd71136dc
fix: move adding metadata step after waiting for uploading step
...
Signed-off-by: psinghal20 <psinghal20@gmail.com>
2019-08-21 15:45:46 +05:30
Megan Marsh
17d9a85895
Merge pull request #7945 from ahilsend/hcloud-image-filter
...
feat(builder/hcloud): allow selecting image based on filters
2019-08-19 14:37:43 -07:00
Megan Marsh
b6fdccc2af
Merge pull request #7970 from williamb1024/master
...
Decrease the delay between Hyper-V VM startup and hyper-v builder's ability to send keystrokes to the target VM.
2019-08-19 14:37:10 -07:00
Megan Marsh
4aa33306cb
make sure that fleetId exists before trying to stick it into error message
2019-08-19 13:44:39 -07:00
Megan Marsh
8dbd078738
Merge pull request #8011 from tmeckel/vbox-vm-target-snapshot-optional
...
Fix: VirtualBox VM builder, target snapshot optional
2019-08-19 13:29:06 -07:00
Megan Marsh
dd97435d42
Merge pull request #7957 from milescrabill/fix-vagrant-builder-basebox-sourcebox
...
vagrant builder: fix provisioning boxes, define source and output boxes
2019-08-19 13:25:54 -07:00
Thomas Meckel
01edafb49f
Cleaned up golint warnings
2019-08-19 21:36:43 +02:00
Thomas Meckel
92501cd344
target_snapshot is not optional as described in the documentation
2019-08-19 21:36:43 +02:00
William L. Brooks
be4ca4b666
Move hyper-v host ip determination earlier in steps, connect to Hyper-V vm prior to issuing the start operation.
2019-08-19 11:45:41 -07:00
Megan Marsh
06bef2844b
Merge pull request #7996 from hashicorp/fix_7925
...
dont bother with a targetpath for the vbox additions; use a hash like…
2019-08-19 09:45:38 -07:00
Brian Fox
47c027e5c8
Remove check/requirement for target_snapshot
2019-08-19 11:25:17 +02:00
Megan Marsh
316a30b31d
fix spot_tags
2019-08-15 16:06:16 -07:00
Megan Marsh
02399f32f6
dont bother with a targetpath for the vbox additions; use a hash like everything else
2019-08-15 15:10:25 -07:00
Megan Marsh
94d8da60f0
Merge pull request #7940 from jgeorgeson/openstack-winrmpassword-provisioners
...
OpenStack builder store WinRM password for provisioners to use
2019-08-15 12:02:26 -07:00
Megan Marsh
9f6d14c75a
work around spot_tags related regression and bad fleet cleanup in spot instances
2019-08-14 11:08:59 -07:00
Andre Hilsendeger
cb1e30ef69
feat(builder/hcloud): allow selecting image based on filters
2019-08-13 08:40:47 +02:00
Megan Marsh
0eebebaedb
Merge pull request #7939 from hashicorp/fix_7938
...
check container os, not host os, when creating container dir default
2019-08-12 16:45:00 -07:00
xiaohan.liang
f4fc9dd09a
Rewrite all files, remove sensitive information
2019-08-09 15:00:23 +08:00
Miles Crabill
ff157c8a6d
vagrant builder: define source box and output box in Vagrantfile
2019-08-07 10:11:34 -07:00
Justin Georgeson
c0ee859559
OpenStack builder store WinRM password for provisioners to use
2019-08-01 19:02:36 -05:00
Megan Marsh
c0e37e6045
Merge pull request #7780 from tmeckel/own-vbox-snapshot
...
VirtualBox Snapshot Builder
2019-08-01 15:31:15 -07:00
Megan Marsh
1952130030
Merge pull request #7920 from hashicorp/fix_7865
...
[wip] fix polling issues in azure
2019-08-01 12:40:11 -07:00
Megan Marsh
773e76c1ce
remove unused import
2019-08-01 11:35:53 -07:00
Megan Marsh
b6f3742425
check container os, not host os, when creating container dir default
2019-08-01 11:31:21 -07:00
Megan Marsh
6a201211a9
fix polling issues in azure
...
adds a configurable timeout to the shared image gallery publisher
2019-08-01 11:18:03 -07:00
Mason, Elliot
ee484f2dd9
Updated public gcp cloud images
2019-07-31 11:38:35 -05:00
Megan Marsh
f97df6721e
Merge pull request #7927 from hashicorp/fix_googlecompute_crash_7921
...
code changed recently so that sometimes the conf is nil.
2019-07-30 09:55:09 -07:00
Megan Marsh
7c93a5c51e
code changed recently so that sometimes the conf is nil.
2019-07-29 13:19:43 -07:00
Megan Marsh
b42701380c
add test for nil case
2019-07-29 12:11:59 -07:00
DanHam
088151e51d
Type assertion safety - fix panic when key cannot be retrieved from statebag
2019-07-28 10:44:24 +01:00
Thomas Meckel
822b72bd14
Added force_delete_snapshot configuration item and the corresponding checks
2019-07-26 12:34:28 +02:00
Thomas Meckel
e7583de847
StepCreateSnapshot.Run() will stop and create an error if the virtual machine is still running
...
Removed left over code from StepCreateSnapshot.Cleanup()
2019-07-26 12:34:27 +02:00
Thomas Meckel
d9b8623f64
StepShutdown now always waits for the shutdown of the virtual machine to complete, not only if a shutdown command is specified
2019-07-26 12:34:27 +02:00
Thomas Meckel
b873876670
Added test TestSnapshot_EnsureParents
...
No using asserts NotNil and Nil
2019-07-26 12:34:27 +02:00
Thomas Meckel
6fd0b3e83e
Fixed a bug in ParseSnapshotData
...
Added fuction GetSnapshots
2019-07-26 12:34:26 +02:00
Thomas Meckel
225a140055
Applied correct source format (got fmt) to builder\virtualbox\common\driver_mock.go
2019-07-26 12:34:26 +02:00
Thomas Meckel
51e5ae69db
Corrected method signatures in builder\virtualbox\common\driver_mock.go
2019-07-26 12:34:26 +02:00
Thomas Meckel
ab6a163ff2
Added missing newline at end of builder\virtualbox\common\driver_mock.go
2019-07-26 12:34:25 +02:00
Thomas Meckel
e9b5332e99
Added missing functions to builder\virtualbox\common\driver_mock.go
2019-07-26 12:34:25 +02:00
Thomas Meckel
fd5a2db58f
Removed commented (obsolete) code from builder\virtualbox\common\driver_4_2.go
2019-07-26 12:34:25 +02:00
Thomas Meckel
7d3c84e5f9
Changed VirtualBox VM builder according to current builder interface
2019-07-26 12:29:48 +02:00
Thomas Meckel
2ef911f6f0
Fixed bugs in snapshot and builder code
2019-07-26 12:29:47 +02:00
Thomas Meckel
ebd2780e5d
implemented first unit tests for snapshot.go
2019-07-26 12:29:46 +02:00
Thomas Meckel
f1f7c4e10c
* added function ParseSnapshotData to parse a string representation of a VBox snapshot tree
...
* fixed bugs
2019-07-26 12:29:46 +02:00
Thomas Meckel
45e2095ae3
Moved parsing of tree string representation to new function in snapshot.go
2019-07-26 12:29:45 +02:00
Thomas Meckel
092e32fe9e
First version of reworked snapshot implementation
2019-07-26 12:29:45 +02:00
Thomas Meckel
a6074894f1
Defined struct and first function for enhanced snapshot handling
2019-07-26 12:29:45 +02:00
Thomas Meckel
d3202497ae
First working version of virtualbox/vm builder
2019-07-26 12:29:44 +02:00