Remove the redundant StepRemoveDevices and rely on the cleanup to be handled by:
* StepAttachParallelsTools.Cleanup
* StepAttachFloppy.Cleanup
* stepAttachISO.Cleanup
We need to ensure the VMWare process has exited before attempting to run VMX file cleanup steps, otherwise VMWare may overwrite our changes. While Packer does its best to ensure VMWare has exited, there's still a race condition on some OSs between VMWare flushing the VMX and Packer updating it. The workaround is to artifically wait 5 seconds.
When using the VMX builder its possible for the source machine to have a floppy and/or CD-ROM mounted which gets cloned to the new VM Packer spins up, but have no Packer configuration for those devices. With this change we always attempt to remove the mounted devices regardless of the Packer configuration.
Uses the Python API from Parallels Virtualization SDK to write
boot commands.
This eliminates a 3rd party requirement and makes it easier for people
not using homebrew to get started with packer.
Adds logic to ESXi driver VNC Address function to ignore listen
addresses that bind to localhost (127.0.0.1), this allows certain
default ports to be available on ESXi for VNC connections
When using the VMX builder its possible for the source machine to have a floppy configured which gets cloned to the new VM Packer spins up. When the new VM's Packer config doesn't have a floppy_files config entry, the Packer clean VMX step fails to remove the floppy disk from the new VM. This can cause build failures, for example with the vsphere post processor; generating errors like:
* Post-processor failed: Failed: exit status 1
Error: File (/home/teamcity/tmp/buildTmp/packer941120499) could not be found.
Opening the cloned VM's VMX file you can clearly see it has a floppy entry from the source machine's VMX file (exact same path) even though the Packer config contains no floppy_files entry.
By default, go get determines parallelism based on the number of
cores available. Those show up as 32 in the Travis CI environment
but a virtual machine is limited both by the amount of cores it
has allocated and the amount of memory available to it. 32 parallel
build processes are likely to exhaust the memory resources, leading
to killed processes.
This change reduces the number of builds running concurrently to 2,
which should reduce the likelihood of memory exhaustion greatly.
The number could probably be dialed up a little bit, but this should
give a good default reflecting the environment's resources.
Mikhail Zholobov
JessThrysoee
Jack Pearkes
Rickard von Essen
Seth Vargo
Brian Downs
Kent Holloway
Nicolai Fröhlich
amangoel
Jesse Cooke
Ask Holme
Shawn Neal
Jason A. Beranek
Alexander Kurilo
John Deatherage
Hiroyuki Sato
Lance French
Mitchell Hashimoto
Mitchell Hashimoto
Mathias Meyer
Chris Spicer
Ross Smith II