5d17b3de84
fix: config validator output
2018-10-19 19:52:11 -05:00
23ad90f2c4
fix: condensed and simplified os check logic and added validate output
2018-10-19 13:48:30 -05:00
d408c9e69c
fix: moved os check to entry of func
2018-10-19 01:38:51 -05:00
0912adea34
fix: converted onlyon param to only_on and added validation step
2018-10-19 00:51:25 -05:00
25c0b98363
feat: ability to specify runtime OSs where shell-local should run
2018-10-18 15:10:04 -05:00
02ba6ccfab
make common/iso_config_test.go invisible to windows
2018-10-16 18:41:27 +02:00
847a3b0061
provide useful powershell error
2018-10-09 12:13:07 -07:00
3f8407d95f
Revert "Merge pull request #6700 from hashicorp/multi_progressbar"
...
This reverts commit 5470c08345c427486bca
2018-09-20 13:14:17 -07:00
5470c08345
Merge pull request #6700 from hashicorp/multi_progressbar
...
Split progressbars per object
2018-09-19 15:22:14 -07:00
38cc525ec7
new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
2018-09-14 11:06:38 -07:00
dfeca9f0df
split progressbars per object
2018-09-12 16:21:58 -07:00
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
2018-09-10 16:48:42 -07:00
32cacad273
remove comment that is not true anymore
2018-09-06 16:50:47 +02:00
bb59a70e8f
progressbar: use int64 instead of uint64
...
* it's what's used for file sizes and used lib
2018-09-06 16:49:15 +02:00
f9c58e2b1f
download: defer progress bar Finish
2018-09-06 16:38:28 +02:00
3842f85eb4
download: remove close calls that are already defered
2018-09-06 16:30:35 +02:00
23762a1810
fix tests for common/download_test.go
2018-09-06 15:53:59 +02:00
7f50228080
remove old/unused progress code
2018-09-06 15:53:59 +02:00
059e14fe42
put back usefull debug
2018-09-06 15:53:59 +02:00
a11f985e3c
revert unecessary check
2018-09-06 15:53:59 +02:00
a9d302def8
removed debug logs
2018-09-06 15:53:59 +02:00
541c68aed5
add StackableProgressBar struct that will refresh/show dl status for multiple files
...
* simplified the downloader interface, and removed the total/current values from them
* downloaders use a proxy reader that will add all read bytes to progress
* removed unused const mtu
* DownloadClient doesn't need a downloader, so I removed it too
2018-09-06 15:53:59 +02:00
fd7cb47adc
use proxy reader for download progress & stop storing total/current in downloaders
2018-09-06 15:53:59 +02:00
ddd96c513b
first draft at self refreshing loading bar centralized/controlled by Ui
2018-09-06 15:53:59 +02:00
5a8af5500b
random: optimize allocation & simplify loop
2018-09-05 10:27:02 +02:00
4682b3a9d2
refactor possible random strings into common/random
2018-09-05 10:26:52 +02:00
170b2f3383
builder/azure/common.RandomString-> common/random.String
...
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
9cefd69f0d
change progress bar display rate to 5s to reduce 'spamminess' ( #6640 )
...
#6625
2018-08-30 16:00:30 +02:00
8309f36176
Merge pull request #6626 from hashicorp/fix_6620
...
make reasonable tempfile default on windows
2018-08-27 09:43:04 -07:00
7519037562
Merge pull request #6629 from hashicorp/travisbuild
...
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
8a604114ef
remove unused code
2018-08-24 20:43:51 -07:00
3f1a9766f4
formatting verb fixes for go 1.11
2018-08-24 16:18:21 -07:00
c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
...
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
f5355a0693
make reasonable tempfile default on windows
2018-08-24 09:44:50 -07:00
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
...
Filter logs
2018-08-23 13:30:21 -07:00
31d4f8af45
use a time.Duration instead of a hardcoded ms
2018-08-23 13:16:01 -07:00
918db58604
added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
2018-08-22 11:37:56 -07:00
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
cf9bbe3ecf
Incorporated the hack demonstrated by @SwampDragons in order to deal with packer.rpc.Ui not exporting any information about what it's doing to anybody.
2018-08-20 21:55:18 -05:00
5726927cba
Moved the progress bar out of packer.Ui and unlinked it out of all the packer.Ui implementations. Split up the terminal-related functions into a separate terminal.go and calculate the progress bar width by traversing through packer.Ui to avoid the issue with github.com/ugorji/go/codec serializing private members (or unsafe pointers) of structs. Shuffled some arguments around in getConsoleScreenBufferInfo in common/terminal_windows.go so that the interface forces the user to correctly declare a _CONSOLE_SCREEN_BUFFER_INFO type.
2018-08-20 21:55:18 -05:00
0f10032b3d
Moved the progress bar from common to the packer.UI interface and refactored it so that the terminal width is calculated based on each interface which returns a custom progressbar specific to its ui.
2018-08-20 21:55:18 -05:00
fd2fef8738
Added support for the progress bar to automatically determine its width using the minimum length from a packer.UI and the terminal dimensions via kernel32.GetConsoleScreenBufferInfo or an ioctl (TIOCGWINSZ) to "/dev/tty".
2018-08-20 21:55:18 -05:00
16ecb3ad9a
Reverted removal of progress-bar that was done by commit 5d97b105a8 and added some missing arguments that were missed during the rebase. Modified the default progress bar's width to 80 as a result of the conversation on PR #5851 .
2018-08-20 21:55:18 -05:00
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
a5587e30ec
log wether the file was transfered or is just being inplace referenced
2018-08-20 11:45:57 +02:00
6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them"
2018-08-20 10:48:06 +02:00
c744e8b2bb
make download messages less redudant and more simple
2018-08-17 09:29:39 +02:00
d7d4aed51c
be even more precise
2018-08-16 18:56:28 +02:00
2b3ea29970
show more precise error download/copy/referencing messages
2018-08-16 18:41:44 +02:00
fae3db4e58
test inplace linking
2018-08-15 17:09:39 +02:00
17f2949e36
remove stuttering; ISOConfig.InplaceISO -> Inplace
2018-08-15 15:51:25 +02:00
863222b1e2
Also use the terminology Inplace in DownloadConfig for clarity/consistency
...
* swapped boolean checks
* swapped in tests too
2018-08-15 15:26:31 +02:00
82e480a285
allow to use ISO images inplace v.s. copying them
2018-08-15 14:37:38 +02:00
71e43d0b7f
Updated common/download.go to handle when a connection error happens (response is nil), and reformatted the error that's returned when an HTTP error occurs.
2018-07-28 19:09:29 -05:00
5ef8b55559
need log import
2018-07-23 10:34:05 -07:00
a2f5fbadf6
don't fail if you can't find abs or relative path.
2018-07-23 09:54:25 -07:00
da21c25791
Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts
...
grep -rli --exclude-dir={vendor,bin\*,\*vmware\*,\*pkg\*} vmxc . | \
xargs sed -i 's/\(vm\)\(x\)\(c\)/\1\3\2/ig'
2018-07-20 02:12:47 +01:00
674bad0ab4
Break very long lines for readability
2018-07-20 02:12:47 +01:00
d2390f464d
Actually implement the function for the driver
2018-07-20 02:12:45 +01:00
c2437ba592
Remove the option to place the VHD files in a separate directory
...
The export process now exports the VM directly from the build directory
into the output directory. There are no intermediate steps or copying of
files involved. This means that there is no longer any benefit in having
a separate directory to house the VHD files - see #5206 for the
reasoning behind the introduction of this feature.
If a user wishes to house the build files on a separate disk from the
output directory (perhaps for performance reasons or due to disk space
limitations) they can still do so through the use of `temp_path`.
2018-07-20 02:12:43 +01:00
c6b9d9ce90
Add checks/error reporting to compaction process
...
* Report compaction results
* Failure to find any disks under the supplied path is treated as a
'soft' error and a warning message will be printed in place of the
compaction result. Any other failure will cause the build to fail.
2018-07-20 02:12:42 +01:00
534fc4a473
Ensure the export directory structure matches that of previous versions
...
Commit 3fc2defb63fc2defb63fc2defb6
2018-07-20 02:09:57 +01:00
dc46848f89
Remove now redundant function to copy exported VM files
2018-07-20 02:09:57 +01:00
3fc2defb6d
Refactor the export step for Hyper-V ISO and VMCX builders
...
* Fixes a bug that caused the build to error if users did not
explicitly set `skip_compaction:true` when setting `skip_export:
true`. See #6392 .
* Improves the efficiency of the compaction and export process by
reordering the compaction and export steps.
* Further improves the efficiency of the compacting step through
compacting the vmd* file directly rather than creating and then
operating on a copy.
* The changes mean the export process now stores the exported machine
files and folders under a folder with name 'vm_name' in the output
directory. Previously the exported machine files and folders were
stored directly in the output directory.
2018-07-20 02:09:54 +01:00
edcc0b3853
shell-local: expose PACKER_HTTP_ADDR env var
2018-07-17 18:49:36 +03:00
0df33cd032
fix relative pathing versus iso checksum dir to work even if user has provided a relative path for the iso_url which is relative to the directory where Packer is run.
2018-07-13 09:21:04 -07:00
d0f0da6626
allow absolute paths to isos in checksum files
2018-07-13 09:14:59 -07:00
e5a63a674e
Merge pull request #6422 from DanHam/fix-gh-vmsecureboot
...
Hyper-V: Use Get-Command over Get-Help to check for SecureBootTemplate parameter
2018-06-25 16:48:16 -07:00
baaca808e8
Merge pull request #6412 from hashicorp/fix_config_validation_bug_windows_shell_local
...
found a config validation bug where packer crashes instead of throwin…
2018-06-25 16:47:23 -07:00
297f6b85ec
Use Get-Command over Get-Help to check for SecureBootTemplate parameter
2018-06-25 23:52:01 +01:00
475e79a251
Fixed SecureBootTemplate not being passed through to PS cmdlet
...
Added check for SecureBootTemplate parameter for Server 2012 and below
Corrected enableSecureBootString usage
2018-06-25 14:13:43 +01:00
4a7953f93a
found a config validation bug where packer crashes instead of throwing a validation error if a windows-style path is provided to a provisioner on linux
2018-06-22 13:49:39 -07:00
efa9021974
Check if hyper-v addresses is an array before slicing it
2018-06-18 14:45:33 +10:00
28095cf027
Do not return error on initial HEAD request
2018-06-13 20:30:19 -03:00
b7ea0b44fc
HTTPDownloader - Fix invalid error handling
2018-06-13 17:42:27 -03:00
a012f70e71
Merge pull request #6251 from hashicorp/do_winrm_shell_local
...
access automatically generated winrm password from shell-local
2018-05-29 12:09:40 -07:00
3afca6905b
remove duplicate assignmnet
2018-05-29 11:47:27 -07:00
6a769f08d8
regenerate boot command code
2018-05-29 11:17:51 -07:00
788418cff2
Add unit test to show that we handle tars safely
2018-05-25 12:13:59 -07:00
846f94c964
implement template variable for accessing WinRM password in either environemnt variables or directly in execute_command or inline commands.
2018-05-23 16:00:43 -07:00
62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
...
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
d1e31c0f23
use if/else to clarify code
2018-05-21 15:19:27 -07:00
969201a2d4
handle minor shell-local PR suggestions and corrections
2018-05-21 14:56:44 -07:00
1fdf763d0f
fancier logging
2018-05-21 11:25:51 -07:00
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
...
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
b747877222
Fixing #6267 , multiple hyper-v disks
2018-05-17 14:50:18 +02:00
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
...
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
6f00596053
Adds config option to specify hyper-v secure boot template
2018-05-10 19:00:35 +02:00
d9d8b93c14
Remove tmp file created by common/ test. Avoid possible race condition.
2018-05-09 22:09:05 +01:00
7c46e3d89c
Merge pull request #6207 from gtirloni/issue-6203
...
[WIP] Handle HTTP download errors
2018-05-08 15:56:06 -07:00
5e6e12cacd
Use fmt to convert whatever's in error to a string.
...
This way we don't crash if someone sticks something else in the error
key in the state bag (which a quick glance at the code tells me we're
already doing.
Perhaps in the future we can add an error attribute to the state bag
but for now this will have to suffice.
2018-05-08 15:22:02 -07:00
0a1842140b
Display build error when on-error=ask|abort
2018-05-08 04:06:03 -07:00
1bea658e16
fix command and inline calls on windows
2018-05-07 15:10:10 -07:00
fabd1a6517
windows cmd env vars
2018-05-07 15:10:10 -07:00
9651432378
preserver BC for people using 'command' option
2018-05-07 15:10:10 -07:00
dd183f22d9
update docs and add warnings around WSL limitations
2018-05-07 15:10:10 -07:00
51bcc7aa13
add new feature for telling shell-local whether to use linux pathing on windows; update docs with some examples.
2018-05-07 15:10:10 -07:00
e983a94a88
fix default windows bash call for shell-local provisioner and move chmod command from the execute_command array into the portion of code where we actually generate inline scripts, sparing users the need to think about this modification which Packer should really handle on its own
...
make bash call work on windows
2018-05-07 15:10:10 -07:00
5da4377f21
first pass at docs update
2018-05-07 15:10:10 -07:00
854d6fb141
add tests making sure post-processor has backwards compatability
2018-05-07 15:10:10 -07:00
f799003b66
tighten up shell-local config validation
2018-05-07 15:10:10 -07:00
479d36734d
consolidate shell-local defaulting of InlineShebang and ExecuteCommand to the config validation
2018-05-07 15:10:10 -07:00
d304234725
fix tests
2018-05-07 15:10:10 -07:00
67739270bb
pull temp file writing into its own function for easier testing
2018-05-07 15:10:10 -07:00
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
c7c66bedcb
set inline to an empty array, rather than nil
2018-05-07 15:10:09 -07:00
926327beba
deduplicate all validation and interpolation of the shell-local config, sharing options between shell-local provisioner and post-processor. Maintain backwards compatibility with shell-local provisioner.
2018-05-07 15:10:09 -07:00
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
bf6dc932d5
Merge pull request #6219 from jborean93/hyper-v-ip
...
Hyper-V: Add support retrieving IP for Server 2008 R2
2018-05-04 12:56:17 -07:00
7e478f650e
Remove tmp files created by common/ tests
2018-04-30 18:16:46 +01:00
14e41fad7e
Hyper-V: Add support retrieving IP for Server 2008
2018-04-30 15:18:28 +10:00
413d13c411
Handle HTTP download errors
2018-04-26 18:59:30 -03:00
3aebd5f462
Add use_fixed_vhd_format Hyper-V ISO option
2018-04-26 13:35:19 -04:00
a3bf2c786a
Use expression sequence generator in tests.
2018-04-23 16:32:18 -07:00
69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
...
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
e4bd30e53d
fix bug with empty boot command.
2018-04-21 11:40:47 -07:00
b5a97e468f
fix test
2018-04-19 17:07:58 -07:00
7e9af8247a
fix 2 byte scancodes for pc-xt VMs.
2018-04-19 17:02:39 -07:00
675eae1e92
flush scancodes when we wait
2018-04-19 16:44:50 -07:00
374d8f089f
better log message
2018-04-19 16:09:38 -07:00
31d04f1945
remove outdated comment
2018-04-19 14:26:31 -07:00
df6224d04e
fix vnc config
2018-04-19 14:26:31 -07:00
aa69bdf74e
Perform validation of boot command.
2018-04-19 14:26:31 -07:00
7d43324359
add menu key.
...
Replaces #5989
2018-04-19 14:26:31 -07:00
e9e27941cc
sort keycode lists
2018-04-19 14:26:31 -07:00
c6299972b9
s/boot_command/bootcommand/
2018-04-19 14:26:31 -07:00
7990966a09
fix boot command config struct name
2018-04-19 14:26:31 -07:00
408eba88ad
flatten boot command config and implement for vmware
2018-04-19 14:26:30 -07:00
9a8acbbcab
negative wait WIP
2018-04-19 14:26:30 -07:00
add7e8acb9
Stop sending boot commands when context canceled.
2018-04-19 14:26:30 -07:00
94129b7fe3
we're using PC-XT (set1) not PC-AT
2018-04-19 14:26:30 -07:00
a46a7afa20
Remove old tests.
2018-04-19 14:26:29 -07:00
e2e7bc65fd
Make special keys case insensitive.
...
add tests
2018-04-19 14:26:29 -07:00
cba4d3235f
cleanup
2018-04-19 14:26:29 -07:00
bdb1eee7d8
Implement new parser for HyperV boot command
2018-04-19 14:26:29 -07:00
f9ad264f4d
Comments
2018-04-19 14:26:29 -07:00
81d127768c
Add key press interval to virtualbox.
2018-04-19 14:26:29 -07:00
59376294ef
Maximize scancode throughput.
...
Let's cache the scancodes and flush them at the end. Also make sure to
send only as many as the driver can send correctly. It's important here
to chunk the scancodes correctly, so that we don't accidentally split them
over successive calls to the driver
2018-04-19 14:26:29 -07:00
9b7704c714
Implement new parser for Parallels boot command
2018-04-19 14:26:29 -07:00
99d61920d0
Abstract vbox driver into PC-AT driver.
2018-04-19 14:26:29 -07:00
e4af71858f
Implement new parser for Virtualbox boot command
...
Remove boot wait for virtualbox run step
2018-04-19 14:26:29 -07:00
1c0af28662
Some cleanup and comments.
2018-04-19 14:26:29 -07:00
673245afcf
Replace boot command parser with PEG parser.
2018-04-19 14:26:28 -07:00
f5c031baf9
Merge pull request #5941 from synax/hyper-v-disk-block-size
...
Adds Support to configure hyper-v disk block size
2018-04-19 11:27:52 -07:00
b8bf421dc2
Fixes missing diskblocksize parameter for gen1 vms
2018-04-18 22:14:44 +02:00
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
Joel Vasallo
Adrien Delorme
Megan Marsh
Adrien Delorme
Matthew Hooker
Ali Rizvi-Santiago
DanHam
Mathieu Tarral
Simon Hulme
Jordan Borean
Giovanni Tirloni
WaaZaa666
Unknown
Stefan Henseler
Adam Robinson