5fd9651982
We need to ensure the VMWare process has exited before attempting to run VMX file cleanup steps, otherwise VMWare may overwrite our changes. While Packer does its best to ensure VMWare has exited, there's still a race condition on some OSs between VMWare flushing the VMX and Packer updating it. The workaround is to artifically wait 5 seconds. When using the VMX builder its possible for the source machine to have a floppy and/or CD-ROM mounted which gets cloned to the new VM Packer spins up, but have no Packer configuration for those devices. With this change we always attempt to remove the mounted devices regardless of the Packer configuration.
142 lines
2.9 KiB
Go
142 lines
2.9 KiB
Go
package common
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/mitchellh/multistep"
|
|
)
|
|
|
|
func TestStepCleanVMX_impl(t *testing.T) {
|
|
var _ multistep.Step = new(StepCleanVMX)
|
|
}
|
|
|
|
func TestStepCleanVMX(t *testing.T) {
|
|
state := testState(t)
|
|
step := new(StepCleanVMX)
|
|
|
|
vmxPath := testVMXFile(t)
|
|
defer os.Remove(vmxPath)
|
|
state.Put("vmx_path", vmxPath)
|
|
|
|
// Test the run
|
|
if action := step.Run(state); action != multistep.ActionContinue {
|
|
t.Fatalf("bad action: %#v", action)
|
|
}
|
|
if _, ok := state.GetOk("error"); ok {
|
|
t.Fatal("should NOT have error")
|
|
}
|
|
}
|
|
|
|
func TestStepCleanVMX_floppyPath(t *testing.T) {
|
|
state := testState(t)
|
|
step := new(StepCleanVMX)
|
|
|
|
vmxPath := testVMXFile(t)
|
|
defer os.Remove(vmxPath)
|
|
if err := ioutil.WriteFile(vmxPath, []byte(testVMXFloppyPath), 0644); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
state.Put("vmx_path", vmxPath)
|
|
|
|
// Test the run
|
|
if action := step.Run(state); action != multistep.ActionContinue {
|
|
t.Fatalf("bad action: %#v", action)
|
|
}
|
|
if _, ok := state.GetOk("error"); ok {
|
|
t.Fatal("should NOT have error")
|
|
}
|
|
|
|
// Test the resulting data
|
|
vmxContents, err := ioutil.ReadFile(vmxPath)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
vmxData := ParseVMX(string(vmxContents))
|
|
|
|
cases := []struct {
|
|
Key string
|
|
Value string
|
|
}{
|
|
{"floppy0.present", "FALSE"},
|
|
{"floppy0.filetype", ""},
|
|
{"floppy0.filename", ""},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
if tc.Value == "" {
|
|
if _, ok := vmxData[tc.Key]; ok {
|
|
t.Fatalf("should not have key: %s", tc.Key)
|
|
}
|
|
} else {
|
|
if vmxData[tc.Key] != tc.Value {
|
|
t.Fatalf("bad: %s %#v", tc.Key, vmxData[tc.Key])
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestStepCleanVMX_isoPath(t *testing.T) {
|
|
state := testState(t)
|
|
step := new(StepCleanVMX)
|
|
|
|
vmxPath := testVMXFile(t)
|
|
defer os.Remove(vmxPath)
|
|
if err := ioutil.WriteFile(vmxPath, []byte(testVMXISOPath), 0644); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
state.Put("vmx_path", vmxPath)
|
|
|
|
// Test the run
|
|
if action := step.Run(state); action != multistep.ActionContinue {
|
|
t.Fatalf("bad action: %#v", action)
|
|
}
|
|
if _, ok := state.GetOk("error"); ok {
|
|
t.Fatal("should NOT have error")
|
|
}
|
|
|
|
// Test the resulting data
|
|
vmxContents, err := ioutil.ReadFile(vmxPath)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
vmxData := ParseVMX(string(vmxContents))
|
|
|
|
cases := []struct {
|
|
Key string
|
|
Value string
|
|
}{
|
|
{"ide0:0.filename", "auto detect"},
|
|
{"ide0:0.devicetype", "cdrom-raw"},
|
|
{"ide0:1.filename", "bar"},
|
|
{"foo", "bar"},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
if tc.Value == "" {
|
|
if _, ok := vmxData[tc.Key]; ok {
|
|
t.Fatalf("should not have key: %s", tc.Key)
|
|
}
|
|
} else {
|
|
if vmxData[tc.Key] != tc.Value {
|
|
t.Fatalf("bad: %s %#v", tc.Key, vmxData[tc.Key])
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
const testVMXFloppyPath = `
|
|
floppy0.present = "TRUE"
|
|
floppy0.filetype = "file"
|
|
`
|
|
|
|
const testVMXISOPath = `
|
|
ide0:0.devicetype = "cdrom-image"
|
|
ide0:0.filename = "foo"
|
|
ide0:1.filename = "bar"
|
|
foo = "bar"
|
|
`
|