iSharkFly-Docs
/
packer-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
packer-cn/fix
History
Wilken Rivera b9f1b3c8d4
Fix gosimple S1005 linting issue (#8870) 
Results before change
```
⇶  golangci-lint run ./... --disable-all --enable=gosimple | grep 1005
fix/fixer_comm_config.go:48:4: S1005: should write `sshHostPortMinRaw := builders["ssh_host_port_min"]` instead of `sshHostPortMinRaw, _ := builders["ssh_host_port_min"]` (gosimple)
fix/fixer_comm_config.go:64:4: S1005: should write `sshHostPortMaxRaw := builders["ssh_host_port_max"]` instead of `sshHostPortMaxRaw, _ := builders["ssh_host_port_max"]` (gosimple)
fix/fixer_comm_config.go:81:4: S1005: should write `sshSkipNatMappingRaw := builders["ssh_skip_nat_mapping"]` instead of `sshSkipNatMappingRaw, _ := builders["ssh_skip_nat_mapping"]` (gosimple)
packer/artifact_mock.go:47:2: S1005: should write `value := a.StateValues[name]` instead of `value, _ := a.StateValues[name]` (gosimple)
packer/artifact_test.go:31:2: S1005: should write `value := a.state[name]` instead of `value, _ := a.state[name]` (gosimple)
```

Results after change
```
```
 		2020-03-11 10:30:08 +01:00
..
fixer.go Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
fixer_amazon_enhanced_networking.go
…
fixer_amazon_enhanced_networking_test.go
…
fixer_amazon_private_ip.go Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip 2019-02-25 14:20:14 -06:00
fixer_amazon_private_ip_test.go gofix 2019-02-25 14:41:26 -06:00
fixer_amazon_shutdown_behavior.go
…
fixer_amazon_shutdown_behavior_test.go
…
fixer_amazon_spot_price_product.go add a fixer and update docs for spot_price_auto_product 2019-07-01 13:01:41 -07:00
fixer_amazon_temporary_security_group_cidrs.go Add golangci-lint to project (#8686) 2020-02-14 11:42:29 -05:00
fixer_amazon_temporary_security_group_cidrs_test.go Fix typographical errors in the fixers 2019-04-01 23:42:31 -07:00
fixer_clean_image_name.go add a Fixer that replaces the "clean_(image|ami)_name" template calls with "clean_resource_name" 2019-04-05 15:30:41 +02:00
fixer_clean_image_name_test.go add a Fixer that replaces the "clean_(image|ami)_name" template calls with "clean_resource_name" 2019-04-05 15:30:41 +02:00
fixer_comm_config.go Fix gosimple S1005 linting issue (#8870) 2020-03-11 10:30:08 +01:00
fixer_comm_config_test.go Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
fixer_createtime.go
…
fixer_createtime_test.go
…
fixer_docker_email.go bug fix and add test 2018-09-06 12:19:31 -07:00
fixer_galaxy_command.go Fix typo in Synopsis for galaxycommand fixer (#8573) 2020-01-07 11:05:35 +01:00
fixer_galaxy_command_test.go removed escape character check, updated synopsis string, change type to 'ansbile-local' only 2019-11-27 20:27:24 -05:00
fixer_hyperv_cpu_and_ram_naming.go write fixer 2019-03-29 15:30:00 -07:00
fixer_hyperv_deprecations.go Fixer and tests to remove deprecated 'vhd_temp_path' Hyper-V ISO setting 2018-07-20 02:12:47 +01:00
fixer_hyperv_deprecations_test.go Fixer and tests to remove deprecated 'vhd_temp_path' Hyper-V ISO setting 2018-07-20 02:12:47 +01:00
fixer_hyperv_vmxc_typo.go Fixer and tests to convert 'clone_from_vmxc_path' -> 'clone_from_vmcx_path' 2018-07-20 02:12:48 +01:00
fixer_hyperv_vmxc_typo_test.go Fixer and tests to convert 'clone_from_vmxc_path' -> 'clone_from_vmcx_path' 2018-07-20 02:12:48 +01:00
fixer_iso_md5.go
…
fixer_iso_md5_test.go
…
fixer_parallels_deprecations.go Update and futureproof fix command usage 2019-07-24 17:18:07 +01:00
fixer_parallels_deprecations_test.go go 1.11 format rules 2018-08-24 15:56:44 -07:00
fixer_parallels_headless.go
…
fixer_parallels_headless_test.go
…
fixer_powershell_escapes.go
…
fixer_pp_manifest_filename.go bug fix and add test 2018-09-06 12:19:31 -07:00
fixer_pp_manifest_filename_test.go bug fix and add test 2018-09-06 12:19:31 -07:00
fixer_pp_vagrant_override.go bug fix and add test 2018-09-06 12:19:31 -07:00
fixer_pp_vagrant_override_test.go bug fix and add test 2018-09-06 12:19:31 -07:00
fixer_qemu_disk_size.go Implement fixer to convert qemu disk size type to string 2019-11-20 10:41:08 -06:00
fixer_qemu_disk_size_test.go Implement fixer to convert qemu disk size type to string 2019-11-20 10:41:08 -06:00
fixer_scaleway_access_key.go Revert "Revert "Rename attribute api_access_key to organization_id"" 2018-11-09 08:47:22 -08:00
fixer_scaleway_access_key_test.go Revert "Revert "Rename attribute api_access_key to organization_id"" 2018-11-09 08:47:22 -08:00
fixer_ssh_timeout.go Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
fixer_ssh_timeout_test.go Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
fixer_sshdisableagent.go
…
fixer_sshdisableagent_test.go
…
fixer_sshkeypath.go
…
fixer_sshkeypath_test.go
…
fixer_test.go Format code with `gofmt -s -w` 2020-01-28 16:52:50 -05:00
fixer_virtualbox_gaattach.go
…
fixer_virtualbox_gaattach_test.go go 1.11 format rules 2018-08-24 15:56:44 -07:00
fixer_virtualbox_rename.go
…
fixer_virtualbox_rename_test.go
…
fixer_vmware_compaction.go validate compaction is skipped when not 'thin' 2018-08-30 16:44:00 -05:00
fixer_vmware_compaction_test.go validate compaction is skipped when not 'thin' 2018-08-30 16:44:00 -05:00
fixer_vmware_rename.go
…
fixer_vmware_rename_test.go
…
helpers.go bug fix and add test 2018-09-06 12:19:31 -07:00